From a94e1ef35fa38d5204e93882f1d525da53557fba Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 17:30:30 +0100 Subject: Document RPC test --- RPCTests/README.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 RPCTests/README.txt diff --git a/RPCTests/README.txt b/RPCTests/README.txt new file mode 100644 index 000000000..3137d1d0b --- /dev/null +++ b/RPCTests/README.txt @@ -0,0 +1 @@ +See https://github.com/ethereum/cpp-ethereum/blob/7cc43bed7de890a496d7238092837c30c7e90729/scripts/runalltests.sh#L38 for how cpp-ethereum uses this. -- cgit v1.2.3 From 5f5f40768c09ba7ca9777a7157740f4cf97c382f Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 18:08:18 +0100 Subject: Adding common errors --- RPCTests/README.txt | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/RPCTests/README.txt b/RPCTests/README.txt index 3137d1d0b..95426fbe7 100644 --- a/RPCTests/README.txt +++ b/RPCTests/README.txt @@ -1 +1,35 @@ See https://github.com/ethereum/cpp-ethereum/blob/7cc43bed7de890a496d7238092837c30c7e90729/scripts/runalltests.sh#L38 for how cpp-ethereum uses this. + +FAQ +=== + +Cannot find module +------------------ + +I get an error: +``` +$ node main.js $workdir/cpp-ethereum/build/eth/eth +module.js:471 + throw err; + ^ + +Error: Cannot find module '/home/yh/src/tests/RLPTests/main.js' + at Function.Module._resolveFilename (module.js:469:15) + at Function.Module._load (module.js:417:25) + at Module.runMain (module.js:604:10) + at run (bootstrap_node.js:393:7) + at startup (bootstrap_node.js:150:9) + at bootstrap_node.js:508:3 +``` + +Answer: if your `main.js` is in your current directory, use `./main.js` instead of just `main.js`. + + +Cannot find module web3 +----------------------- + +I get an error: +``` +$ node ./main.js ~/src/cpp-ethereum/build/eth/eth +(node:27647) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Cannot find module 'web3' +``` -- cgit v1.2.3 From 0a4f67833ea07712eba5cf17cb22c1231239678a Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 18:08:29 +0100 Subject: Move to README.md --- RPCTests/README.md | 35 +++++++++++++++++++++++++++++++++++ RPCTests/README.txt | 35 ----------------------------------- 2 files changed, 35 insertions(+), 35 deletions(-) create mode 100644 RPCTests/README.md delete mode 100644 RPCTests/README.txt diff --git a/RPCTests/README.md b/RPCTests/README.md new file mode 100644 index 000000000..95426fbe7 --- /dev/null +++ b/RPCTests/README.md @@ -0,0 +1,35 @@ +See https://github.com/ethereum/cpp-ethereum/blob/7cc43bed7de890a496d7238092837c30c7e90729/scripts/runalltests.sh#L38 for how cpp-ethereum uses this. + +FAQ +=== + +Cannot find module +------------------ + +I get an error: +``` +$ node main.js $workdir/cpp-ethereum/build/eth/eth +module.js:471 + throw err; + ^ + +Error: Cannot find module '/home/yh/src/tests/RLPTests/main.js' + at Function.Module._resolveFilename (module.js:469:15) + at Function.Module._load (module.js:417:25) + at Module.runMain (module.js:604:10) + at run (bootstrap_node.js:393:7) + at startup (bootstrap_node.js:150:9) + at bootstrap_node.js:508:3 +``` + +Answer: if your `main.js` is in your current directory, use `./main.js` instead of just `main.js`. + + +Cannot find module web3 +----------------------- + +I get an error: +``` +$ node ./main.js ~/src/cpp-ethereum/build/eth/eth +(node:27647) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Cannot find module 'web3' +``` diff --git a/RPCTests/README.txt b/RPCTests/README.txt deleted file mode 100644 index 95426fbe7..000000000 --- a/RPCTests/README.txt +++ /dev/null @@ -1,35 +0,0 @@ -See https://github.com/ethereum/cpp-ethereum/blob/7cc43bed7de890a496d7238092837c30c7e90729/scripts/runalltests.sh#L38 for how cpp-ethereum uses this. - -FAQ -=== - -Cannot find module ------------------- - -I get an error: -``` -$ node main.js $workdir/cpp-ethereum/build/eth/eth -module.js:471 - throw err; - ^ - -Error: Cannot find module '/home/yh/src/tests/RLPTests/main.js' - at Function.Module._resolveFilename (module.js:469:15) - at Function.Module._load (module.js:417:25) - at Module.runMain (module.js:604:10) - at run (bootstrap_node.js:393:7) - at startup (bootstrap_node.js:150:9) - at bootstrap_node.js:508:3 -``` - -Answer: if your `main.js` is in your current directory, use `./main.js` instead of just `main.js`. - - -Cannot find module web3 ------------------------ - -I get an error: -``` -$ node ./main.js ~/src/cpp-ethereum/build/eth/eth -(node:27647) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Cannot find module 'web3' -``` -- cgit v1.2.3 From 32a7678d26362898b00b7efda3e89ab20b7ea24e Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 18:09:35 +0100 Subject: Add another question --- RPCTests/README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/RPCTests/README.md b/RPCTests/README.md index 95426fbe7..9e0486c7d 100644 --- a/RPCTests/README.md +++ b/RPCTests/README.md @@ -33,3 +33,7 @@ I get an error: $ node ./main.js ~/src/cpp-ethereum/build/eth/eth (node:27647) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Cannot find module 'web3' ``` + + +Has any other clients been tested with this? +-------------------------------------------- -- cgit v1.2.3 From e0e10d4afe390404c1b0700fb2694e7a3a7d5be5 Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 18:12:33 +0100 Subject: How to install web3 --- RPCTests/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RPCTests/README.md b/RPCTests/README.md index 9e0486c7d..6497ddeec 100644 --- a/RPCTests/README.md +++ b/RPCTests/README.md @@ -34,6 +34,8 @@ $ node ./main.js ~/src/cpp-ethereum/build/eth/eth (node:27647) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Cannot find module 'web3' ``` +Answer: `npm install web3` + Has any other clients been tested with this? -------------------------------------------- -- cgit v1.2.3 From 4868f3b5fd23cbfa3e1f9f5a1fd2ddbff4d48f25 Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Wed, 6 Dec 2017 18:14:30 +0100 Subject: Questions about test failures --- RPCTests/README.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/RPCTests/README.md b/RPCTests/README.md index 6497ddeec..bfe33b510 100644 --- a/RPCTests/README.md +++ b/RPCTests/README.md @@ -37,5 +37,30 @@ $ node ./main.js ~/src/cpp-ethereum/build/eth/eth Answer: `npm install web3` +Some tests fail +--------------- + +``` +$ node ./main.js ~/src/cpp-ethereum/build/eth/eth +TEST_newAccount OK +TEST_addPeerOnNode2 OK +TEST_getPeerCountOnNode1 OK +TEST_mineBlockOnNode1 FAILED +TEST_mineBlockOnNode1 FAILED +TEST_getBlockHashOnNode2 OK +TEST_mineBlockOnNode2 FAILED +TEST_mineBlockOnNode2 FAILED +TEST_getBlockHashOnNode1 OK +(node:30406) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Callback was already called. +``` + +Answer: everybody experiences these failures now. + + +Do these failures indicate bugs in cpp-ethereum or in the test? +--------------------------------------------------------------- + + + Has any other clients been tested with this? -------------------------------------------- -- cgit v1.2.3 From 262da2df5f4038790aa857ce61b9694a647de4d5 Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Thu, 7 Dec 2017 12:00:21 +0100 Subject: Answer two more questions in FAQ --- RPCTests/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/RPCTests/README.md b/RPCTests/README.md index bfe33b510..ff3d0883f 100644 --- a/RPCTests/README.md +++ b/RPCTests/README.md @@ -60,7 +60,11 @@ Answer: everybody experiences these failures now. Do these failures indicate bugs in cpp-ethereum or in the test? --------------------------------------------------------------- - +Different opinions exist +* https://github.com/ethereum/tests/pull/376#issuecomment-349799774 +* https://github.com/ethereum/tests/pull/376#issuecomment-349933405 Has any other clients been tested with this? -------------------------------------------- + +No. -- cgit v1.2.3 From ca2adf19b697ef6a44d2bbf093f2d04700acf774 Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Thu, 7 Dec 2017 12:06:14 +0100 Subject: Mention the GitHub issue where the errors are tracked --- RPCTests/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RPCTests/README.md b/RPCTests/README.md index ff3d0883f..f6c25cd6a 100644 --- a/RPCTests/README.md +++ b/RPCTests/README.md @@ -54,7 +54,7 @@ TEST_getBlockHashOnNode1 OK (node:30406) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Callback was already called. ``` -Answer: everybody experiences these failures now. +Answer: everybody experiences these failures now. They are being tracked in [issue 377](https://github.com/ethereum/tests/issues/377). Do these failures indicate bugs in cpp-ethereum or in the test? -- cgit v1.2.3