From 7e5406dd8953cb819c397221fa55e6fa390108ee Mon Sep 17 00:00:00 2001 From: chriseth Date: Fri, 29 Jun 2018 00:06:51 +0200 Subject: Disallow calling base constructors without arguments. --- .../inheritance/disallow_modifier_style_without_parentheses.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test') diff --git a/test/libsolidity/syntaxTests/inheritance/disallow_modifier_style_without_parentheses.sol b/test/libsolidity/syntaxTests/inheritance/disallow_modifier_style_without_parentheses.sol index 6cf68d2a..8f5ceef8 100644 --- a/test/libsolidity/syntaxTests/inheritance/disallow_modifier_style_without_parentheses.sol +++ b/test/libsolidity/syntaxTests/inheritance/disallow_modifier_style_without_parentheses.sol @@ -1,4 +1,4 @@ contract A { constructor() public { } } contract B is A { constructor() A public { } } // ---- -// Warning: (72-73): Modifier-style base constructor call without arguments. +// DeclarationError: (72-73): Modifier-style base constructor call without arguments. -- cgit v1.2.3 From 061ea0cfc6b8a7a0950e9764876733391eac6b81 Mon Sep 17 00:00:00 2001 From: chriseth Date: Fri, 29 Jun 2018 00:18:22 +0200 Subject: Correctly determine whether base constructor is called without parentheses. --- .../syntaxTests/inheritance/modifiers_in_constructor_context.sol | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 test/libsolidity/syntaxTests/inheritance/modifiers_in_constructor_context.sol (limited to 'test') diff --git a/test/libsolidity/syntaxTests/inheritance/modifiers_in_constructor_context.sol b/test/libsolidity/syntaxTests/inheritance/modifiers_in_constructor_context.sol new file mode 100644 index 00000000..d8ce0e48 --- /dev/null +++ b/test/libsolidity/syntaxTests/inheritance/modifiers_in_constructor_context.sol @@ -0,0 +1,9 @@ +// This generated an invalid warning on m1 in some compiler versions. +contract A { + constructor() m1 public { } + modifier m1 { _; } +} +contract B is A { + modifier m2 { _; } + constructor() A() m1 m2 public { } +} -- cgit v1.2.3