From 95ad87267878a168dba98d5eb16e27dc9632465d Mon Sep 17 00:00:00 2001 From: LianaHus Date: Wed, 14 Oct 2015 20:27:30 +0200 Subject: added Error class for all kind of errors Conflicts: libsolidity/Exceptions.h Conflicts: libsolidity/ReferencesResolver.cpp --- libsolidity/ReferencesResolver.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libsolidity/ReferencesResolver.cpp b/libsolidity/ReferencesResolver.cpp index 32c1728f..70bc6572 100644 --- a/libsolidity/ReferencesResolver.cpp +++ b/libsolidity/ReferencesResolver.cpp @@ -57,10 +57,10 @@ bool ReferencesResolver::visit(UserDefinedTypeName const& _typeName) Declaration const* declaration = m_resolver.pathFromCurrentScope(_typeName.namePath()); if (!declaration) BOOST_THROW_EXCEPTION( - DeclarationError() << + Error(Error::Type::DeclarationError) << errinfo_sourceLocation(_typeName.location()) << errinfo_comment("Identifier not found or not unique.") - ); + _typeName.annotation().referencedDeclaration = declaration; return true; } @@ -70,7 +70,7 @@ bool ReferencesResolver::visit(Identifier const& _identifier) auto declarations = m_resolver.nameFromCurrentScope(_identifier.name()); if (declarations.empty()) BOOST_THROW_EXCEPTION( - DeclarationError() << + Error(Error::Type::DeclarationError) << errinfo_sourceLocation(_identifier.location()) << errinfo_comment("Undeclared identifier.") ); -- cgit v1.2.3 From 742e5b259a8c88e69f09ede7312673157cd77a1f Mon Sep 17 00:00:00 2001 From: LianaHus Date: Fri, 2 Oct 2015 14:41:40 +0200 Subject: added Error class for all kind of errors Conflicts: libsolidity/Exceptions.h --- libsolidity/AST.cpp | 4 +- libsolidity/AST.h | 14 ++++--- libsolidity/CompilerStack.cpp | 4 +- libsolidity/CompilerStack.h | 5 ++- libsolidity/Exceptions.h | 52 ++++++++++++++++++++++--- libsolidity/InterfaceHandler.cpp | 16 ++++---- libsolidity/NameAndTypeResolver.cpp | 10 +++-- libsolidity/NameAndTypeResolver.h | 3 +- libsolidity/Parser.cpp | 4 +- libsolidity/Parser.h | 2 +- libsolidity/TypeChecker.cpp | 9 +++-- libsolidity/Types.cpp | 6 +-- solc/CommandLineInterface.cpp | 23 +++-------- solc/jsonCompiler.cpp | 16 +------- test/libsolidity/SolidityExpressionCompiler.cpp | 13 +++++-- test/libsolidity/SolidityParser.cpp | 2 +- 16 files changed, 107 insertions(+), 76 deletions(-) diff --git a/libsolidity/AST.cpp b/libsolidity/AST.cpp index 490ae29a..f184e037 100644 --- a/libsolidity/AST.cpp +++ b/libsolidity/AST.cpp @@ -51,9 +51,9 @@ ASTAnnotation& ASTNode::annotation() const return *m_annotation; } -TypeError ASTNode::createTypeError(string const& _description) const +Error ASTNode::createTypeError(string const& _description) const { - return TypeError() << errinfo_sourceLocation(location()) << errinfo_comment(_description); + return Error(Error::Type::TypeError) << errinfo_sourceLocation(location()) << errinfo_comment(_description); } map, FunctionTypePointer> ContractDefinition::interfaceFunctions() const diff --git a/libsolidity/AST.h b/libsolidity/AST.h index f257dfb2..9dd67cc2 100644 --- a/libsolidity/AST.h +++ b/libsolidity/AST.h @@ -75,7 +75,7 @@ public: /// Creates a @ref TypeError exception and decorates it with the location of the node and /// the given description - TypeError createTypeError(std::string const& _description) const; + Error createTypeError(std::string const& _description) const; ///@todo make this const-safe by providing a different way to access the annotation virtual ASTAnnotation& annotation() const; @@ -660,10 +660,14 @@ class MagicVariableDeclaration: public Declaration public: MagicVariableDeclaration(ASTString const& _name, std::shared_ptr const& _type): Declaration(SourceLocation(), std::make_shared(_name)), m_type(_type) {} - virtual void accept(ASTVisitor&) override { BOOST_THROW_EXCEPTION(InternalCompilerError() - << errinfo_comment("MagicVariableDeclaration used inside real AST.")); } - virtual void accept(ASTConstVisitor&) const override { BOOST_THROW_EXCEPTION(InternalCompilerError() - << errinfo_comment("MagicVariableDeclaration used inside real AST.")); } + virtual void accept(ASTVisitor&) override + { + BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("MagicVariableDeclaration used inside real AST.")); + } + virtual void accept(ASTConstVisitor&) const override + { + BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("MagicVariableDeclaration used inside real AST.")); + } virtual TypePointer type(ContractDefinition const*) const override { return m_type; } diff --git a/libsolidity/CompilerStack.cpp b/libsolidity/CompilerStack.cpp index 8c1cd8cf..519f785b 100644 --- a/libsolidity/CompilerStack.cpp +++ b/libsolidity/CompilerStack.cpp @@ -107,7 +107,7 @@ bool CompilerStack::parse() resolveImports(); m_globalContext = make_shared(); - NameAndTypeResolver resolver(m_globalContext->declarations()); + NameAndTypeResolver resolver(m_globalContext->declarations(), m_errors); for (Source const* source: m_sourceOrder) resolver.registerDeclarations(*source->ast); for (Source const* source: m_sourceOrder) @@ -345,7 +345,7 @@ void CompilerStack::resolveImports() string const& id = import->identifier(); if (!m_sources.count(id)) BOOST_THROW_EXCEPTION( - ParserError() + Error(Error::Type::ParserError) << errinfo_sourceLocation(import->location()) << errinfo_comment("Source not found.") ); diff --git a/libsolidity/CompilerStack.h b/libsolidity/CompilerStack.h index da26148d..5b128868 100644 --- a/libsolidity/CompilerStack.h +++ b/libsolidity/CompilerStack.h @@ -33,6 +33,7 @@ #include #include #include +#include namespace dev { @@ -164,7 +165,7 @@ public: std::tuple positionFromSourceLocation(SourceLocation const& _sourceLocation) const; /// @returns the list of errors that occured during parsing and type checking. - std::vector> const& errors() const { return m_errors; } + ErrorList const& errors() const { return m_errors; } private: /** @@ -212,7 +213,7 @@ private: std::shared_ptr m_globalContext; std::vector m_sourceOrder; std::map m_contracts; - std::vector> m_errors; + ErrorList m_errors; }; } diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 8ab33999..723475c7 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -31,13 +31,51 @@ namespace dev { namespace solidity { -struct Error: virtual Exception {}; -struct ParserError: virtual Error {}; -struct TypeError: virtual Error {}; -struct DeclarationError: virtual Error {}; -struct DocstringParsingError: virtual Error {}; -struct Warning: virtual Error {}; +class Error: virtual public Exception +{ +public: + enum class Type + { + DeclarationError, + DocstringParsingError, + ParserError, + TypeError, + Warning + }; + + Error(Type _type) : m_type(_type) + { + switch(m_type) + { + case Type::DeclarationError: + m_typeName = "Declaration Error"; + break; + case Type::DocstringParsingError: + m_typeName = "Docstring Parsing Error"; + break; + case Type::ParserError: + m_typeName = "Parser Error"; + break; + case Type::TypeError: + m_typeName = "Type Error"; + break; + case Type::Warning: + m_typeName = "Warning"; + break; + default: + m_typeName = "Error"; + break; + } + } + + Type type() { return m_type; } + std::string const& typeName() const { return m_typeName; } + +private: + Type m_type; + std::string m_typeName; +}; struct CompilerError: virtual Exception {}; struct InternalCompilerError: virtual Exception {}; @@ -56,6 +94,8 @@ public: std::vector infos; }; + +using ErrorList = std::vector>; using errinfo_sourceLocation = boost::error_info; using errinfo_secondarySourceLocation = boost::error_info; diff --git a/libsolidity/InterfaceHandler.cpp b/libsolidity/InterfaceHandler.cpp index be15ae58..17ca66b4 100644 --- a/libsolidity/InterfaceHandler.cpp +++ b/libsolidity/InterfaceHandler.cpp @@ -243,7 +243,7 @@ string InterfaceHandler::devDocumentation(ContractDefinition const& _contractDef if (find(paramNames.begin(), paramNames.end(), pair.first) == paramNames.end()) // LTODO: mismatching parameter name, throw some form of warning and not just an exception BOOST_THROW_EXCEPTION( - DocstringParsingError() << + Error(Error::Type::DocstringParsingError) << errinfo_comment("documented parameter \"" + pair.first + "\" not found in the parameter list of the function.") ); params[pair.first] = pair.second; @@ -310,7 +310,7 @@ string::const_iterator InterfaceHandler::parseDocTagParam( // find param name auto currPos = find(_pos, _end, ' '); if (currPos == _end) - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("End of param name not found" + string(_pos, _end))); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("End of param name not found" + string(_pos, _end))); auto paramName = string(_pos, currPos); @@ -369,7 +369,7 @@ string::const_iterator InterfaceHandler::parseDocTag( return parseDocTagLine(_pos, _end, m_author, DocTagType::Author, false); else // LTODO: for now this else makes no sense but later comments will go to more language constructs - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("@author tag is legal only for contracts")); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("@author tag is legal only for contracts")); } else if (_tag == "title") { @@ -377,13 +377,13 @@ string::const_iterator InterfaceHandler::parseDocTag( return parseDocTagLine(_pos, _end, m_title, DocTagType::Title, false); else // LTODO: Unknown tag, throw some form of warning and not just an exception - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("@title tag is legal only for contracts")); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("@title tag is legal only for contracts")); } else if (_tag == "param") return parseDocTagParam(_pos, _end); else // LTODO: Unknown tag, throw some form of warning and not just an exception - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("Unknown tag " + _tag + " encountered")); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("Unknown tag " + _tag + " encountered")); } else return appendDocTag(_pos, _end, _owner); @@ -410,13 +410,13 @@ string::const_iterator InterfaceHandler::appendDocTag( return parseDocTagLine(_pos, _end, m_author, DocTagType::Author, true); else // LTODO: Unknown tag, throw some form of warning and not just an exception - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("@author tag in illegal comment")); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("@author tag in illegal comment")); case DocTagType::Title: if (_owner == CommentOwner::Contract) return parseDocTagLine(_pos, _end, m_title, DocTagType::Title, true); else // LTODO: Unknown tag, throw some form of warning and not just an exception - BOOST_THROW_EXCEPTION(DocstringParsingError() << errinfo_comment("@title tag in illegal comment")); + BOOST_THROW_EXCEPTION(Error(Error::Type::DocstringParsingError) << errinfo_comment("@title tag in illegal comment")); case DocTagType::Param: return appendDocTagParam(_pos, _end); default: @@ -451,7 +451,7 @@ void InterfaceHandler::parseDocString(string const& _string, CommentOwner _owner auto tagNameEndPos = firstSpaceOrNl(tagPos, end); if (tagNameEndPos == end) BOOST_THROW_EXCEPTION( - DocstringParsingError() << + Error(Error::Type::DocstringParsingError) << errinfo_comment("End of tag " + string(tagPos, tagNameEndPos) + "not found")); currPos = parseDocTag(tagNameEndPos + 1, end, string(tagPos + 1, tagNameEndPos), _owner); diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index 0d2c3b02..3591c07a 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -33,8 +33,10 @@ namespace solidity { NameAndTypeResolver::NameAndTypeResolver( - vector const& _globals -) + vector const& _globals, + ErrorList& _errors +) : + m_errors(_errors) { for (Declaration const* declaration: _globals) m_scopes[nullptr].registerDeclaration(*declaration); @@ -163,7 +165,7 @@ vector NameAndTypeResolver::cleanedDeclarations( for (auto parameter: functionType.parameterTypes() + functionType.returnParameterTypes()) if (!parameter) BOOST_THROW_EXCEPTION( - DeclarationError() << + Error(Error::Type::DeclarationError) << errinfo_sourceLocation(_identifier.location()) << errinfo_comment("Function type can not be used in this context") ); @@ -408,7 +410,7 @@ void DeclarationRegistrationHelper::registerDeclaration(Declaration& _declaratio } BOOST_THROW_EXCEPTION( - DeclarationError() << + Error(Error::Type::DeclarationError) << errinfo_sourceLocation(secondDeclarationLocation) << errinfo_comment("Identifier already declared.") << errinfo_secondarySourceLocation( diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index f5f4c6ce..d5afb29a 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -42,7 +42,7 @@ namespace solidity class NameAndTypeResolver: private boost::noncopyable { public: - NameAndTypeResolver(std::vector const& _globals); + NameAndTypeResolver(std::vector const& _globals, ErrorList& _errors); /// Registers all declarations found in the source unit. void registerDeclarations(SourceUnit& _sourceUnit); /// Resolves all names and types referenced from the given contract. @@ -91,6 +91,7 @@ private: std::map m_scopes; DeclarationContainer* m_currentScope = nullptr; + ErrorList& m_errors; }; /** diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index 88a6b030..ce13098e 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -1156,9 +1156,9 @@ ASTPointer Parser::createEmptyParameterList() return nodeFactory.createNode(vector>()); } -ParserError Parser::createParserError(string const& _description) const +Error Parser::createParserError(string const& _description) const { - return ParserError() << + return Error(Error::Type::ParserError) << errinfo_sourceLocation(SourceLocation(position(), position(), sourceName())) << errinfo_comment(_description); } diff --git a/libsolidity/Parser.h b/libsolidity/Parser.h index 043d022b..c9acb47d 100644 --- a/libsolidity/Parser.h +++ b/libsolidity/Parser.h @@ -147,7 +147,7 @@ private: /// Creates a @ref ParserError exception and annotates it with the current position and the /// given @a _description. - ParserError createParserError(std::string const& _description) const; + Error createParserError(std::string const& _description) const; std::shared_ptr m_scanner; /// Flag that signifies whether '_' is parsed as a PlaceholderStatement or a regular identifier. diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index afffe344..658e4874 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -67,6 +67,7 @@ TypePointer const& TypeChecker::type(VariableDeclaration const& _variable) const bool TypeChecker::visit(ContractDefinition const& _contract) { + // We force our own visiting order here. ASTNode::listAccept(_contract.definedStructs(), *this); ASTNode::listAccept(_contract.baseContracts(), *this); @@ -87,7 +88,7 @@ bool TypeChecker::visit(ContractDefinition const& _contract) { if (fallbackFunction) { - auto err = make_shared(); + auto err = make_shared(Error::Type::DeclarationError); *err << errinfo_comment("Only one fallback function is allowed."); m_errors.push_back(err); } @@ -143,7 +144,7 @@ void TypeChecker::checkContractDuplicateFunctions(ContractDefinition const& _con for (; it != functions[_contract.name()].end(); ++it) ssl.append("Another declaration is here:", (*it)->location()); - auto err = make_shared(); + auto err = make_shared(Error(Error::Type::DeclarationError)); *err << errinfo_sourceLocation(functions[_contract.name()].front()->location()) << errinfo_comment("More than one constructor defined.") << @@ -157,7 +158,7 @@ void TypeChecker::checkContractDuplicateFunctions(ContractDefinition const& _con for (size_t j = i + 1; j < overloads.size(); ++j) if (FunctionType(*overloads[i]).hasEqualArgumentTypes(FunctionType(*overloads[j]))) { - auto err = make_shared(); + auto err = make_shared(Error(Error::Type::DeclarationError)); *err << errinfo_sourceLocation(overloads[j]->location()) << errinfo_comment("Function with same name and arguments defined twice.") << @@ -1251,7 +1252,7 @@ void TypeChecker::requireLValue(Expression const& _expression) void TypeChecker::typeError(ASTNode const& _node, string const& _description) { - auto err = make_shared(); + auto err = make_shared(Error(Error::Type::TypeError));; *err << errinfo_sourceLocation(_node.location()) << errinfo_comment(_description); diff --git a/libsolidity/Types.cpp b/libsolidity/Types.cpp index c800e288..3ccaaf5d 100644 --- a/libsolidity/Types.cpp +++ b/libsolidity/Types.cpp @@ -50,7 +50,7 @@ void StorageOffsets::computeOffsets(TypePointers const& _types) byteOffset = 0; } if (slotOffset >= bigint(1) << 256) - BOOST_THROW_EXCEPTION(TypeError() << errinfo_comment("Object too large for storage.")); + BOOST_THROW_EXCEPTION(Error(Error::Type::TypeError) << errinfo_comment("Object too large for storage.")); offsets[i] = make_pair(u256(slotOffset), byteOffset); solAssert(type->storageSize() >= 1, "Invalid storage size."); if (type->storageSize() == 1 && byteOffset + type->storageBytes() <= 32) @@ -64,7 +64,7 @@ void StorageOffsets::computeOffsets(TypePointers const& _types) if (byteOffset > 0) ++slotOffset; if (slotOffset >= bigint(1) << 256) - BOOST_THROW_EXCEPTION(TypeError() << errinfo_comment("Object too large for storage.")); + BOOST_THROW_EXCEPTION(Error(Error::Type::TypeError) << errinfo_comment("Object too large for storage.")); m_storageSize = u256(slotOffset); swap(m_offsets, offsets); } @@ -805,7 +805,7 @@ u256 ArrayType::storageSize() const else size = bigint(length()) * baseType()->storageSize(); if (size >= bigint(1) << 256) - BOOST_THROW_EXCEPTION(TypeError() << errinfo_comment("Array too large for storage.")); + BOOST_THROW_EXCEPTION(Error(Error::Type::TypeError) << errinfo_comment("Array too large for storage.")); return max(1, u256(size)); } diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp index be10faa8..42b65d4c 100644 --- a/solc/CommandLineInterface.cpp +++ b/solc/CommandLineInterface.cpp @@ -502,21 +502,6 @@ bool CommandLineInterface::processInput() return false; m_compiler->link(m_libraries); } - catch (ParserError const& _exception) - { - SourceReferenceFormatter::printExceptionInformation(cerr, _exception, "Parser error", *m_compiler); - return false; - } - catch (DeclarationError const& _exception) - { - SourceReferenceFormatter::printExceptionInformation(cerr, _exception, "Declaration error", *m_compiler); - return false; - } - catch (TypeError const& _exception) - { - SourceReferenceFormatter::printExceptionInformation(cerr, _exception, "Type error", *m_compiler); - return false; - } catch (CompilerError const& _exception) { SourceReferenceFormatter::printExceptionInformation(cerr, _exception, "Compiler error", *m_compiler); @@ -528,9 +513,13 @@ bool CommandLineInterface::processInput() << boost::diagnostic_information(_exception); return false; } - catch (DocstringParsingError const& _exception) + catch (Error const& _error) { - cerr << "Documentation parsing error: " << *boost::get_error_info(_exception) << endl; + if (_error.type() == Error::Type::DocstringParsingError) + cerr << "Documentation parsing error: " << *boost::get_error_info(_error) << endl; + else + SourceReferenceFormatter::printExceptionInformation(cerr, _error, _error.typeName(), *m_compiler); + return false; } catch (Exception const& _exception) diff --git a/solc/jsonCompiler.cpp b/solc/jsonCompiler.cpp index 00fd0370..1cf539e5 100644 --- a/solc/jsonCompiler.cpp +++ b/solc/jsonCompiler.cpp @@ -134,17 +134,9 @@ string compile(string _input, bool _optimize) )); success = succ; // keep success false on exception } - catch (ParserError const& exception) + catch (Error const& error) { - errors.append(formatError(exception, "Parser error", compiler)); - } - catch (DeclarationError const& exception) - { - errors.append(formatError(exception, "Declaration error", compiler)); - } - catch (TypeError const& exception) - { - errors.append(formatError(exception, "Type error", compiler)); + errors.append(formatError(error, error.typeName(), compiler)); } catch (CompilerError const& exception) { @@ -154,10 +146,6 @@ string compile(string _input, bool _optimize) { errors.append(formatError(exception, "Internal compiler error", compiler)); } - catch (DocstringParsingError const& exception) - { - errors.append(formatError(exception, "Documentation parsing error", compiler)); - } catch (Exception const& exception) { errors.append("Exception during compilation: " + boost::diagnostic_information(exception)); diff --git a/test/libsolidity/SolidityExpressionCompiler.cpp b/test/libsolidity/SolidityExpressionCompiler.cpp index 545775ee..8134080e 100644 --- a/test/libsolidity/SolidityExpressionCompiler.cpp +++ b/test/libsolidity/SolidityExpressionCompiler.cpp @@ -85,9 +85,12 @@ Declaration const& resolveDeclaration( return *declaration; } -bytes compileFirstExpression(const string& _sourceCode, vector> _functions = {}, - vector> _localVariables = {}, - vector> _globalDeclarations = {}) +bytes compileFirstExpression( + const string& _sourceCode, + vector> _functions = {}, + vector> _localVariables = {}, + vector> _globalDeclarations = {} +) { Parser parser; ASTPointer sourceUnit; @@ -105,7 +108,9 @@ bytes compileFirstExpression(const string& _sourceCode, vector> _ declarations.reserve(_globalDeclarations.size() + 1); for (ASTPointer const& variable: _globalDeclarations) declarations.push_back(variable.get()); - NameAndTypeResolver resolver(declarations); + /// TODO: + ErrorList errorList; + NameAndTypeResolver resolver(declarations, errorList); resolver.registerDeclarations(*sourceUnit); vector inheritanceHierarchy; diff --git a/test/libsolidity/SolidityParser.cpp b/test/libsolidity/SolidityParser.cpp index 03930479..a90399fc 100644 --- a/test/libsolidity/SolidityParser.cpp +++ b/test/libsolidity/SolidityParser.cpp @@ -76,7 +76,7 @@ BOOST_AUTO_TEST_CASE(missing_variable_name_in_declaration) char const* text = "contract test {\n" " uint256 ;\n" "}\n"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK_THROW(parseText(text), Error); } BOOST_AUTO_TEST_CASE(empty_function) -- cgit v1.2.3 From 8f7f22c5a6b1a71d7baff489b6425670550e8e8b Mon Sep 17 00:00:00 2001 From: LianaHus Date: Mon, 5 Oct 2015 11:06:30 +0200 Subject: some fixes --- libsolidity/Exceptions.h | 3 ++- libsolidity/TypeChecker.cpp | 5 ++++- libsolidity/TypeChecker.h | 4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 723475c7..5a1b827c 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -41,6 +41,7 @@ public: DocstringParsingError, ParserError, TypeError, + Warning }; @@ -69,7 +70,7 @@ public: } } - Type type() { return m_type; } + Type const type() { return m_type; } const std::string const& typeName() const { return m_typeName; } private: diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index 658e4874..e3264429 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -45,11 +45,14 @@ bool TypeChecker::checkTypeRequirements(const ContractDefinition& _contract) } bool success = true; for (auto const& it: m_errors) - if (!dynamic_cast(it.get())) + { + Error const& e = dynamic_cast(it.get()); + if (e.type() != Error::Type::Warning) { success = false; break; } + } return success; } diff --git a/libsolidity/TypeChecker.h b/libsolidity/TypeChecker.h index cb65d5a8..c654c698 100644 --- a/libsolidity/TypeChecker.h +++ b/libsolidity/TypeChecker.h @@ -47,7 +47,7 @@ public: bool checkTypeRequirements(ContractDefinition const& _contract); /// @returns the list of errors and warnings found during type checking. - std::vector> const& errors() const { return m_errors; } + ErrorList const& errors() const { return m_errors; } /// @returns the type of an expression and asserts that it is present. TypePointer const& type(Expression const& _expression) const; @@ -114,7 +114,7 @@ private: /// Runs type checks on @a _expression to infer its type and then checks that it is an LValue. void requireLValue(Expression const& _expression); - std::vector> m_errors; + ErrorList m_errors; }; } -- cgit v1.2.3 From c3491e446964f366101f28e3d51ab59dd9aaa5b2 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Wed, 14 Oct 2015 20:37:41 +0200 Subject: errors instead of exceptions Conflicts: libsolidity/CompilerStack.cpp libsolidity/NameAndTypeResolver.cpp libsolidity/NameAndTypeResolver.h libsolidity/TypeChecker.cpp test/libsolidity/SolidityNameAndTypeResolution.cpp --- libsolidity/CompilerContext.cpp | 2 +- libsolidity/CompilerStack.cpp | 32 ++- libsolidity/CompilerStack.h | 1 + libsolidity/Exceptions.h | 36 ++- libsolidity/NameAndTypeResolver.cpp | 240 ++++++++++++------ libsolidity/NameAndTypeResolver.h | 42 +++- libsolidity/Parser.cpp | 86 ++++--- libsolidity/Parser.h | 13 +- libsolidity/TypeChecker.cpp | 30 +-- libsolidity/TypeChecker.h | 10 +- solc/CommandLineInterface.cpp | 2 +- test/libsolidity/Assembly.cpp | 14 +- test/libsolidity/SolidityABIJSON.cpp | 7 +- test/libsolidity/SolidityEndToEndTest.cpp | 4 +- test/libsolidity/SolidityExpressionCompiler.cpp | 14 +- test/libsolidity/SolidityNameAndTypeResolution.cpp | 280 ++++++++++----------- test/libsolidity/SolidityParser.cpp | 224 ++++++++++------- test/libsolidity/solidityExecutionFramework.h | 20 +- 18 files changed, 651 insertions(+), 406 deletions(-) diff --git a/libsolidity/CompilerContext.cpp b/libsolidity/CompilerContext.cpp index fa7f9c77..0ba7af5b 100644 --- a/libsolidity/CompilerContext.cpp +++ b/libsolidity/CompilerContext.cpp @@ -137,7 +137,7 @@ ModifierDefinition const& CompilerContext::functionModifier(string const& _name) if (modifier->name() == _name) return *modifier.get(); BOOST_THROW_EXCEPTION(InternalCompilerError() - << errinfo_comment("Function modifier " + _name + " not found.")); + << errinfo_comment("Function modifier " + _name + " not found.")); } unsigned CompilerContext::baseStackOffsetOfVariable(Declaration const& _declaration) const diff --git a/libsolidity/CompilerStack.cpp b/libsolidity/CompilerStack.cpp index 519f785b..3887999a 100644 --- a/libsolidity/CompilerStack.cpp +++ b/libsolidity/CompilerStack.cpp @@ -97,30 +97,41 @@ void CompilerStack::setSource(string const& _sourceCode) bool CompilerStack::parse() { + // todo not sure about clear. can contain warnings m_errors.clear(); for (auto& sourcePair: m_sources) { sourcePair.second.scanner->reset(); - sourcePair.second.ast = Parser().parse(sourcePair.second.scanner); + sourcePair.second.ast = Parser(m_errors).parse(sourcePair.second.scanner); // todo check for errors } + if (!Error::containsOnlyWarnings(m_errors)) + // errors while parsing. sould stop before type checking + return false; + resolveImports(); m_globalContext = make_shared(); + bool success = true; NameAndTypeResolver resolver(m_globalContext->declarations(), m_errors); for (Source const* source: m_sourceOrder) - resolver.registerDeclarations(*source->ast); + success = success && resolver.registerDeclarations(*source->ast); for (Source const* source: m_sourceOrder) for (ASTPointer const& node: source->ast->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { m_globalContext->setCurrentContract(*contract); - resolver.updateDeclaration(*m_globalContext->currentThis()); - resolver.updateDeclaration(*m_globalContext->currentSuper()); - resolver.resolveNamesAndTypes(*contract); + success = success && resolver.updateDeclaration(*m_globalContext->currentThis()); + success = success && resolver.updateDeclaration(*m_globalContext->currentSuper()); + success = success && resolver.resolveNamesAndTypes(*contract); m_contracts[contract->name()].contract = contract; } + if (!success) + { + m_parseSuccessful = false; + return m_parseSuccessful; + } InterfaceHandler interfaceHandler; bool typesFine = true; for (Source const* source: m_sourceOrder) @@ -137,6 +148,7 @@ bool CompilerStack::parse() } else typesFine = false; + m_contracts[contract->name()].contract = contract; m_errors += typeChecker.errors(); } @@ -253,9 +265,8 @@ string const& CompilerStack::metadata(string const& _contractName, Documentation if (!m_parseSuccessful) BOOST_THROW_EXCEPTION(CompilerError() << errinfo_comment("Parsing was not successful.")); - Contract const& currentContract = contract(_contractName); - std::unique_ptr* doc; + Contract const& currentContract = contract(_contractName); // checks wheather we already have the documentation switch (_type) @@ -346,9 +357,10 @@ void CompilerStack::resolveImports() if (!m_sources.count(id)) BOOST_THROW_EXCEPTION( Error(Error::Type::ParserError) - << errinfo_sourceLocation(import->location()) - << errinfo_comment("Source not found.") + << errinfo_sourceLocation(import->location()) + << errinfo_comment("Source not found.") ); + toposort(&m_sources[id]); } sourceOrder.push_back(_source); @@ -414,10 +426,12 @@ CompilerStack::Source const& CompilerStack::source(string const& _sourceName) co auto it = m_sources.find(_sourceName); if (it == m_sources.end()) BOOST_THROW_EXCEPTION(CompilerError() << errinfo_comment("Given source file not found.")); + return it->second; } CompilerStack::Contract::Contract(): interfaceHandler(make_shared()) {} + } } diff --git a/libsolidity/CompilerStack.h b/libsolidity/CompilerStack.h index 5b128868..e47f558b 100644 --- a/libsolidity/CompilerStack.h +++ b/libsolidity/CompilerStack.h @@ -167,6 +167,7 @@ public: /// @returns the list of errors that occured during parsing and type checking. ErrorList const& errors() const { return m_errors; } + private: /** * Information pertaining to one source unit, filled gradually during parsing and compilation. diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 5a1b827c..92c009ef 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -26,11 +26,18 @@ #include #include #include +#include namespace dev { namespace solidity { +class Error; +using ErrorList = std::vector>; + +struct CompilerError: virtual Exception {}; +struct InternalCompilerError: virtual Exception {}; +struct fatalError: virtual Exception {}; //todo rename to FatalError class Error: virtual public Exception { @@ -41,7 +48,6 @@ public: DocstringParsingError, ParserError, TypeError, - Warning }; @@ -65,22 +71,39 @@ public: m_typeName = "Warning"; break; default: - m_typeName = "Error"; + solAssert(false, ""); break; } } - Type const type() { return m_type; } const + Type type() const { return m_type; } std::string const& typeName() const { return m_typeName; } + + /// helper functions + static Error const* containsErrorOfType(ErrorList const& _list, Error::Type _type) + { + for (auto e: _list) + { + if(e->type() == _type) + return e.get(); + } + return nullptr; + } + static bool containsOnlyWarnings(ErrorList const& _list) + { + for (auto e: _list) + { + if(e->type() != Type::Warning) + return false; + } + return true; + } private: Type m_type; std::string m_typeName; }; -struct CompilerError: virtual Exception {}; -struct InternalCompilerError: virtual Exception {}; -struct FatalError: virtual Exception {}; using errorSourceLocationInfo = std::pair; @@ -96,7 +119,6 @@ public: }; -using ErrorList = std::vector>; using errinfo_sourceLocation = boost::error_info; using errinfo_secondarySourceLocation = boost::error_info; diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index 3591c07a..934be0e3 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -42,81 +42,105 @@ NameAndTypeResolver::NameAndTypeResolver( m_scopes[nullptr].registerDeclaration(*declaration); } -void NameAndTypeResolver::registerDeclarations(SourceUnit& _sourceUnit) +bool NameAndTypeResolver::registerDeclarations(SourceUnit& _sourceUnit) { // The helper registers all declarations in m_scopes as a side-effect of its construction. - DeclarationRegistrationHelper registrar(m_scopes, _sourceUnit); + try + { + DeclarationRegistrationHelper registrar(m_scopes, _sourceUnit, m_errors); + } + catch (fatalError) + { + return false; + } + return true; } -void NameAndTypeResolver::resolveNamesAndTypes(ContractDefinition& _contract) +bool NameAndTypeResolver::resolveNamesAndTypes(ContractDefinition& _contract) { - m_currentScope = &m_scopes[nullptr]; + try + { + m_currentScope = &m_scopes[nullptr]; - for (ASTPointer const& baseContract: _contract.baseContracts()) - ReferencesResolver resolver(*baseContract, *this, &_contract, nullptr); + for (ASTPointer const& baseContract: _contract.baseContracts()) + ReferencesResolver resolver(*baseContract, *this, &_contract, nullptr); - m_currentScope = &m_scopes[&_contract]; + m_currentScope = &m_scopes[&_contract]; - linearizeBaseContracts(_contract); - std::vector properBases( - ++_contract.annotation().linearizedBaseContracts.begin(), - _contract.annotation().linearizedBaseContracts.end() - ); + linearizeBaseContracts(_contract); + std::vector properBases( + ++_contract.annotation().linearizedBaseContracts.begin(), + _contract.annotation().linearizedBaseContracts.end() + ); - for (ContractDefinition const* base: properBases) - importInheritedScope(*base); + for (ContractDefinition const* base: properBases) + importInheritedScope(*base); - for (ASTPointer const& structDef: _contract.definedStructs()) - ReferencesResolver resolver(*structDef, *this, &_contract, nullptr); - for (ASTPointer const& enumDef: _contract.definedEnums()) - ReferencesResolver resolver(*enumDef, *this, &_contract, nullptr); - for (ASTPointer const& variable: _contract.stateVariables()) - ReferencesResolver resolver(*variable, *this, &_contract, nullptr); - for (ASTPointer const& event: _contract.events()) - ReferencesResolver resolver(*event, *this, &_contract, nullptr); + for (ASTPointer const& structDef: _contract.definedStructs()) + ReferencesResolver resolver(*structDef, *this, &_contract, nullptr); + for (ASTPointer const& enumDef: _contract.definedEnums()) + ReferencesResolver resolver(*enumDef, *this, &_contract, nullptr); + for (ASTPointer const& variable: _contract.stateVariables()) + ReferencesResolver resolver(*variable, *this, &_contract, nullptr); + for (ASTPointer const& event: _contract.events()) + ReferencesResolver resolver(*event, *this, &_contract, nullptr); - // these can contain code, only resolve parameters for now - for (ASTPointer const& modifier: _contract.functionModifiers()) - { - m_currentScope = &m_scopes[modifier.get()]; - ReferencesResolver resolver(*modifier, *this, &_contract, nullptr); - } - for (ASTPointer const& function: _contract.definedFunctions()) - { - m_currentScope = &m_scopes[function.get()]; - ReferencesResolver referencesResolver( - *function, - *this, - &_contract, - function->returnParameterList().get() - ); - } + // these can contain code, only resolve parameters for now + for (ASTPointer const& modifier: _contract.functionModifiers()) + { + m_currentScope = &m_scopes[modifier.get()]; + ReferencesResolver resolver(*modifier, *this, &_contract, nullptr); + } + for (ASTPointer const& function: _contract.definedFunctions()) + { + m_currentScope = &m_scopes[function.get()]; + ReferencesResolver referencesResolver( + *function, + *this, + &_contract, + function->returnParameterList().get() + ); + } - m_currentScope = &m_scopes[&_contract]; + m_currentScope = &m_scopes[&_contract]; - // now resolve references inside the code - for (ASTPointer const& modifier: _contract.functionModifiers()) - { - m_currentScope = &m_scopes[modifier.get()]; - ReferencesResolver resolver(*modifier, *this, &_contract, nullptr, true); + // now resolve references inside the code + for (ASTPointer const& modifier: _contract.functionModifiers()) + { + m_currentScope = &m_scopes[modifier.get()]; + ReferencesResolver resolver(*modifier, *this, &_contract, nullptr, true); + } + for (ASTPointer const& function: _contract.definedFunctions()) + { + m_currentScope = &m_scopes[function.get()]; + ReferencesResolver referencesResolver( + *function, + *this, + &_contract, + function->returnParameterList().get(), + true + ); + } } - for (ASTPointer const& function: _contract.definedFunctions()) + catch (fatalError const& _e) { - m_currentScope = &m_scopes[function.get()]; - ReferencesResolver referencesResolver( - *function, - *this, - &_contract, - function->returnParameterList().get(), - true - ); + return false; } + return true; } -void NameAndTypeResolver::updateDeclaration(Declaration const& _declaration) +bool NameAndTypeResolver::updateDeclaration(Declaration const& _declaration) { - m_scopes[nullptr].registerDeclaration(_declaration, false, true); - solAssert(_declaration.scope() == nullptr, "Updated declaration outside global scope."); + try + { + m_scopes[nullptr].registerDeclaration(_declaration, false, true); + solAssert(_declaration.scope() == nullptr, "Updated declaration outside global scope."); + } + catch(fatalError _error) + { + return false; + } + return true; } vector NameAndTypeResolver::resolveName(ASTString const& _name, Declaration const* _scope) const @@ -164,11 +188,8 @@ vector NameAndTypeResolver::cleanedDeclarations( FunctionType functionType(functionDefinition); for (auto parameter: functionType.parameterTypes() + functionType.returnParameterTypes()) if (!parameter) - BOOST_THROW_EXCEPTION( - Error(Error::Type::DeclarationError) << - errinfo_sourceLocation(_identifier.location()) << - errinfo_comment("Function type can not be used in this context") - ); + reportFatalDeclarationError(_identifier.location(), "Function type can not be used in this context"); + if (uniqueFunctions.end() == find_if( uniqueFunctions.begin(), uniqueFunctions.end(), @@ -194,7 +215,7 @@ void NameAndTypeResolver::importInheritedScope(ContractDefinition const& _base) m_currentScope->registerDeclaration(*declaration); } -void NameAndTypeResolver::linearizeBaseContracts(ContractDefinition& _contract) const +void NameAndTypeResolver::linearizeBaseContracts(ContractDefinition& _contract) { // order in the lists is from derived to base // list of lists to linearize, the last element is the list of direct bases @@ -204,19 +225,19 @@ void NameAndTypeResolver::linearizeBaseContracts(ContractDefinition& _contract) Identifier const& baseName = baseSpecifier->name(); auto base = dynamic_cast(baseName.annotation().referencedDeclaration); if (!base) - BOOST_THROW_EXCEPTION(baseName.createTypeError("Contract expected.")); + reportFatalTypeError(baseName.createTypeError("Contract expected.")); // "push_front" has the effect that bases mentioned later can overwrite members of bases // mentioned earlier input.back().push_front(base); vector const& basesBases = base->annotation().linearizedBaseContracts; if (basesBases.empty()) - BOOST_THROW_EXCEPTION(baseName.createTypeError("Definition of base has to precede definition of derived contract")); + reportFatalTypeError(baseName.createTypeError("Definition of base has to precede definition of derived contract")); input.push_front(list(basesBases.begin(), basesBases.end())); } input.back().push_front(&_contract); vector result = cThreeMerge(input); if (result.empty()) - BOOST_THROW_EXCEPTION(_contract.createTypeError("Linearization of inheritance graph impossible")); + reportFatalTypeError(_contract.createTypeError("Linearization of inheritance graph impossible")); _contract.annotation().linearizedBaseContracts = result; _contract.annotation().contractDependencies.insert(result.begin() + 1, result.end()); } @@ -272,9 +293,53 @@ vector<_T const*> NameAndTypeResolver::cThreeMerge(list>& _toMer return result; } -DeclarationRegistrationHelper::DeclarationRegistrationHelper(map& _scopes, - ASTNode& _astRoot): - m_scopes(_scopes), m_currentScope(nullptr) +void NameAndTypeResolver::reportDeclarationError( + SourceLocation _sourceLoction, + string const& _description, + SourceLocation _secondarySourceLocation = SourceLocation(), + string const& _secondaryDescription = "" +) +{ + auto err = make_shared(Error::Type::DeclarationError); // todo remove Error? + *err << + errinfo_sourceLocation(_sourceLoction) << + errinfo_comment(_description) << + errinfo_secondarySourceLocation( + SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) + ); + + m_errors.push_back(err); +} + +void NameAndTypeResolver::reportFatalDeclarationError( + SourceLocation _sourceLoction, + string _description +) +{ + reportDeclarationError(_sourceLoction, _description); + BOOST_THROW_EXCEPTION(fatalError()); +} + +void NameAndTypeResolver::reportTypeError(Error _e) +{ + m_errors.push_back(make_shared(_e)); +} + +void NameAndTypeResolver::reportFatalTypeError(Error _e) +{ + reportTypeError(_e); + BOOST_THROW_EXCEPTION(fatalError()); +} + + +DeclarationRegistrationHelper::DeclarationRegistrationHelper( + map& _scopes, + ASTNode& _astRoot, + ErrorList& _errors +): + m_scopes(_scopes), + m_currentScope(nullptr), + m_errors(_errors) { _astRoot.accept(*this); } @@ -409,13 +474,11 @@ void DeclarationRegistrationHelper::registerDeclaration(Declaration& _declaratio secondDeclarationLocation = _declaration.location(); } - BOOST_THROW_EXCEPTION( - Error(Error::Type::DeclarationError) << - errinfo_sourceLocation(secondDeclarationLocation) << - errinfo_comment("Identifier already declared.") << - errinfo_secondarySourceLocation( - SecondarySourceLocation().append("The previous declaration is here:", firstDeclarationLocation) - ) + declarationError( + secondDeclarationLocation, + "Identifier already declared.", + firstDeclarationLocation, + "The previous declaration is here:" ); } @@ -440,5 +503,32 @@ string DeclarationRegistrationHelper::currentCanonicalName() const return ret; } +void DeclarationRegistrationHelper::declarationError( + SourceLocation _sourceLoction, + string const& _description, + SourceLocation _secondarySourceLocation = SourceLocation(), + string const& _secondaryDescription = "" +) +{ + auto err = make_shared(Error::Type::DeclarationError); + *err << + errinfo_sourceLocation(_sourceLoction) << + errinfo_comment(_description) << + errinfo_secondarySourceLocation( + SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) + ); + + m_errors.push_back(err); +} + +void DeclarationRegistrationHelper::fatalDeclarationError( + SourceLocation _sourceLoction, + string const& _description +) +{ + declarationError(_sourceLoction, _description); + BOOST_THROW_EXCEPTION(fatalError()); +} + } } diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index d5afb29a..9587fcfe 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -44,12 +44,15 @@ class NameAndTypeResolver: private boost::noncopyable public: NameAndTypeResolver(std::vector const& _globals, ErrorList& _errors); /// Registers all declarations found in the source unit. - void registerDeclarations(SourceUnit& _sourceUnit); + /// @returns false in case of type error. + bool registerDeclarations(SourceUnit& _sourceUnit); /// Resolves all names and types referenced from the given contract. - void resolveNamesAndTypes(ContractDefinition& _contract); + /// @returns false in case of type error. + bool resolveNamesAndTypes(ContractDefinition& _contract); /// Updates the given global declaration (used for "this"). Not to be used with declarations /// that create their own scope. - void updateDeclaration(Declaration const& _declaration); + /// @returns false in case of type error. + bool updateDeclaration(Declaration const& _declaration); /// Resolves the given @a _name inside the scope @a _scope. If @a _scope is omitted, /// the global scope is used (i.e. the one containing only the contract). @@ -66,7 +69,7 @@ public: Declaration const* pathFromCurrentScope(std::vector const& _path, bool _recursive = true) const; /// returns the vector of declarations without repetitions - static std::vector cleanedDeclarations( + std::vector cleanedDeclarations( Identifier const& _identifier, std::vector const& _declarations ); @@ -78,8 +81,8 @@ private: /// into the current scope if they are not present already. void importInheritedScope(ContractDefinition const& _base); - /// Computes "C3-Linearization" of base contracts and stores it inside the contract. - void linearizeBaseContracts(ContractDefinition& _contract) const; + /// Computes "C3-Linearization" of base contracts and stores it inside the contract. Reports errors if any + void linearizeBaseContracts(ContractDefinition& _contract); /// Computes the C3-merge of the given list of lists of bases. /// @returns the linearized vector or an empty vector if linearization is not possible. template @@ -90,6 +93,21 @@ private: /// not contain code. std::map m_scopes; + // creates the Declaration error and adds it in the errors list + void reportDeclarationError( + SourceLocation _sourceLoction, + std::string const& _description, + SourceLocation _secondarySourceLocation, + std::string const& _secondaryDescription + ); + // creates the Declaration error and adds it in the errors list and throws FatalError + void reportFatalDeclarationError(SourceLocation _sourceLoction, std::string _description); + + // creates the Declaration error and adds it in the errors list + void reportTypeError(Error _e); + // creates the Declaration error and adds it in the errors list and throws FatalError + void reportFatalTypeError(Error _e); + DeclarationContainer* m_currentScope = nullptr; ErrorList& m_errors; }; @@ -101,7 +119,7 @@ private: class DeclarationRegistrationHelper: private ASTVisitor { public: - DeclarationRegistrationHelper(std::map& _scopes, ASTNode& _astRoot); + DeclarationRegistrationHelper(std::map& _scopes, ASTNode& _astRoot, ErrorList& _errors); private: bool visit(ContractDefinition& _contract) override; @@ -126,10 +144,20 @@ private: /// @returns the canonical name of the current scope. std::string currentCanonicalName() const; + // creates the Declaration error and adds it in the errors list + void declarationError( + SourceLocation _sourceLoction, + std::string const& _description, + SourceLocation _secondarySourceLocation, + std::string const& _secondaryDescription + ); + // creates the Declaration error and adds it in the errors list and throws FatalError + void fatalDeclarationError(SourceLocation _sourceLoction, std::string const& _description); std::map& m_scopes; Declaration const* m_currentScope; VariableScope* m_currentFunction; + ErrorList& m_errors; }; } diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index ce13098e..491af369 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -66,25 +66,35 @@ private: ASTPointer Parser::parse(shared_ptr const& _scanner) { - m_scanner = _scanner; - ASTNodeFactory nodeFactory(*this); - vector> nodes; - while (m_scanner->currentToken() != Token::EOS) - { - switch (auto token = m_scanner->currentToken()) + try{ + m_scanner = _scanner; + ASTNodeFactory nodeFactory(*this); + vector> nodes; + while (m_scanner->currentToken() != Token::EOS) { - case Token::Import: - nodes.push_back(parseImportDirective()); - break; - case Token::Contract: - case Token::Library: - nodes.push_back(parseContractDefinition(token == Token::Library)); - break; - default: - BOOST_THROW_EXCEPTION(createParserError(std::string("Expected import directive or contract definition."))); + switch (auto token = m_scanner->currentToken()) + { + case Token::Import: + nodes.push_back(parseImportDirective()); + break; + case Token::Contract: + case Token::Library: + nodes.push_back(parseContractDefinition(token == Token::Library)); + break; + default: + fatalParserError(std::string("Expected import directive or contract definition.")); + } } + return nodeFactory.createNode(nodes); + } + catch(fatalError const& _error) + { + return nullptr; + } + catch(Exception const& _e) + { + return nullptr; } - return nodeFactory.createNode(nodes); } std::shared_ptr const& Parser::sourceName() const @@ -107,7 +117,7 @@ ASTPointer Parser::parseImportDirective() ASTNodeFactory nodeFactory(*this); expectToken(Token::Import); if (m_scanner->currentToken() != Token::StringLiteral) - BOOST_THROW_EXCEPTION(createParserError("Expected string literal (URL).")); + fatalParserError(std::string("Expected string literal (URL).")); ASTPointer url = getLiteralAndAdvance(); nodeFactory.markEndPosition(); expectToken(Token::Semicolon); @@ -165,7 +175,7 @@ ASTPointer Parser::parseContractDefinition(bool _isLibrary) else if (currentTokenValue == Token::Event) events.push_back(parseEventDefinition()); else - BOOST_THROW_EXCEPTION(createParserError("Function, variable, struct or modifier declaration expected.")); + fatalParserError(std::string("Function, variable, struct or modifier declaration expected.")); } nodeFactory.markEndPosition(); expectToken(Token::RBrace); @@ -249,7 +259,7 @@ ASTPointer Parser::parseFunctionDefinition(ASTString const* else if (Token::isVisibilitySpecifier(token)) { if (visibility != Declaration::Visibility::Default) - BOOST_THROW_EXCEPTION(createParserError("Multiple visibility specifiers.")); + fatalParserError(std::string("Multiple visibility specifiers.")); visibility = parseVisibilitySpecifier(token); } else @@ -326,7 +336,7 @@ ASTPointer Parser::parseEnumDefinition() break; expectToken(Token::Comma); if (m_scanner->currentToken() != Token::Identifier) - BOOST_THROW_EXCEPTION(createParserError("Expected Identifier after ','")); + fatalParserError(std::string("Expected Identifier after ','")); } nodeFactory.markEndPosition(); @@ -362,7 +372,7 @@ ASTPointer Parser::parseVariableDeclaration( if (_options.isStateVariable && Token::isVariableVisibilitySpecifier(token)) { if (visibility != Declaration::Visibility::Default) - BOOST_THROW_EXCEPTION(createParserError("Visibility already specified.")); + fatalParserError(std::string("Visibility already specified.")); visibility = parseVisibilitySpecifier(token); } else @@ -374,9 +384,9 @@ ASTPointer Parser::parseVariableDeclaration( else if (_options.allowLocationSpecifier && Token::isLocationSpecifier(token)) { if (location != VariableDeclaration::Location::Default) - BOOST_THROW_EXCEPTION(createParserError("Location already specified.")); + fatalParserError(std::string("Location already specified.")); if (!type) - BOOST_THROW_EXCEPTION(createParserError("Location specifier needs explicit type name.")); + fatalParserError(std::string("Location specifier needs explicit type name.")); location = ( token == Token::Memory ? VariableDeclaration::Location::Memory : @@ -513,7 +523,7 @@ ASTPointer Parser::parseTypeName(bool _allowVar) else if (token == Token::Var) { if (!_allowVar) - BOOST_THROW_EXCEPTION(createParserError("Expected explicit type name.")); + fatalParserError(std::string("Expected explicit type name.")); m_scanner->next(); } else if (token == Token::Mapping) @@ -532,7 +542,7 @@ ASTPointer Parser::parseTypeName(bool _allowVar) type = nodeFactory.createNode(identifierPath); } else - BOOST_THROW_EXCEPTION(createParserError("Expected type name")); + fatalParserError(std::string("Expected type name")); if (type) // Parse "[...]" postfixes for arrays. @@ -555,7 +565,7 @@ ASTPointer Parser::parseMapping() expectToken(Token::Mapping); expectToken(Token::LParen); if (!Token::isElementaryTypeName(m_scanner->currentToken())) - BOOST_THROW_EXCEPTION(createParserError("Expected elementary type name for mapping key type")); + fatalParserError(std::string("Expected elementary type name for mapping key type")); ASTPointer keyType; keyType = ASTNodeFactory(*this).createNode(m_scanner->currentToken()); m_scanner->next(); @@ -1011,7 +1021,7 @@ ASTPointer Parser::parsePrimaryExpression() m_scanner->next(); } else - BOOST_THROW_EXCEPTION(createParserError("Expected primary expression.")); + fatalParserError(std::string("Expected primary expression.")); break; } return expression; @@ -1122,7 +1132,7 @@ ASTPointer Parser::expressionFromIndexAccessStructure( void Parser::expectToken(Token::Value _value) { if (m_scanner->currentToken() != _value) - BOOST_THROW_EXCEPTION(createParserError(string("Expected token ") + string(Token::name(_value)))); + fatalParserError(std::string(string("Expected token ") + string(Token::name(_value)))); m_scanner->next(); } @@ -1130,7 +1140,7 @@ Token::Value Parser::expectAssignmentOperator() { Token::Value op = m_scanner->currentToken(); if (!Token::isAssignmentOp(op)) - BOOST_THROW_EXCEPTION(createParserError("Expected assignment operator")); + fatalParserError(std::string("Expected assignment operator")); m_scanner->next(); return op; } @@ -1138,7 +1148,7 @@ Token::Value Parser::expectAssignmentOperator() ASTPointer Parser::expectIdentifierToken() { if (m_scanner->currentToken() != Token::Identifier) - BOOST_THROW_EXCEPTION(createParserError("Expected identifier")); + fatalParserError(std::string("Expected identifier")); return getLiteralAndAdvance(); } @@ -1156,13 +1166,21 @@ ASTPointer Parser::createEmptyParameterList() return nodeFactory.createNode(vector>()); } -Error Parser::createParserError(string const& _description) const +void Parser::parserError(string const& _description) { - return Error(Error::Type::ParserError) << - errinfo_sourceLocation(SourceLocation(position(), position(), sourceName())) << - errinfo_comment(_description); + auto err = make_shared(Error::Type::ParserError); + *err << + errinfo_sourceLocation(SourceLocation(position(), position(), sourceName())) << + errinfo_comment(_description); + + m_errors.push_back(err); } +void Parser::fatalParserError(string const& _description) +{ + parserError(_description); + BOOST_THROW_EXCEPTION(fatalError()); +} } } diff --git a/libsolidity/Parser.h b/libsolidity/Parser.h index c9acb47d..3fc3768e 100644 --- a/libsolidity/Parser.h +++ b/libsolidity/Parser.h @@ -34,7 +34,8 @@ class Scanner; class Parser { public: - Parser() {} + Parser(ErrorList& errors): + m_errors(errors){}; ASTPointer parse(std::shared_ptr const& _scanner); std::shared_ptr const& sourceName() const; @@ -145,13 +146,19 @@ private: /// Creates an empty ParameterList at the current location (used if parameters can be omitted). ASTPointer createEmptyParameterList(); - /// Creates a @ref ParserError exception and annotates it with the current position and the + /// Creates a @ref ParserError and annotates it with the current position and the /// given @a _description. - Error createParserError(std::string const& _description) const; + void parserError(std::string const& _description); + + /// Creates a @ref ParserError and annotates it with the current position and the + /// given @a _description. Throws the FatalError. + void fatalParserError(std::string const& _description); std::shared_ptr m_scanner; /// Flag that signifies whether '_' is parsed as a PlaceholderStatement or a regular identifier. bool m_insideModifier = false; + /// The reference to the list of errors and warning to add errors/warnings during parsing + ErrorList& m_errors; }; } diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index e3264429..cc7ad2f3 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -36,24 +36,26 @@ bool TypeChecker::checkTypeRequirements(const ContractDefinition& _contract) { visit(_contract); } - catch (FatalError const&) + catch (fatalError const&) { // We got a fatal error which required to stop further type checking, but we can // continue normally from here. if (m_errors.empty()) throw; // Something is weird here, rather throw again. } - bool success = true; - for (auto const& it: m_errors) - { - Error const& e = dynamic_cast(it.get()); - if (e.type() != Error::Type::Warning) - { - success = false; - break; - } - } - return success; + +return Error::containsOnlyWarnings(m_errors); +// bool success = true; +// for (auto const& it: m_errors) +// { +// auto e = dynamic_cast(it.get()); +// if (e->type() != Error::Type::Warning) +// { +// success = false; +// break; +// } +// } +// return success; } TypePointer const& TypeChecker::type(Expression const& _expression) const @@ -1255,7 +1257,7 @@ void TypeChecker::requireLValue(Expression const& _expression) void TypeChecker::typeError(ASTNode const& _node, string const& _description) { - auto err = make_shared(Error(Error::Type::TypeError));; + auto err = make_shared(Error::Type::TypeError); *err << errinfo_sourceLocation(_node.location()) << errinfo_comment(_description); @@ -1266,5 +1268,5 @@ void TypeChecker::typeError(ASTNode const& _node, string const& _description) void TypeChecker::fatalTypeError(ASTNode const& _node, string const& _description) { typeError(_node, _description); - BOOST_THROW_EXCEPTION(FatalError()); + BOOST_THROW_EXCEPTION(fatalError()); } diff --git a/libsolidity/TypeChecker.h b/libsolidity/TypeChecker.h index c654c698..de095e3b 100644 --- a/libsolidity/TypeChecker.h +++ b/libsolidity/TypeChecker.h @@ -42,26 +42,26 @@ namespace solidity class TypeChecker: private ASTConstVisitor { public: + /// @_errors the reference to the list of errors and warnings to add them found during type checking. + TypeChecker(ErrorList& _errors): m_errors(_errors) {} + /// Performs type checking on the given contract and all of its sub-nodes. /// @returns true iff all checks passed. Note even if all checks passed, errors() can still contain warnings bool checkTypeRequirements(ContractDefinition const& _contract); - /// @returns the list of errors and warnings found during type checking. - ErrorList const& errors() const { return m_errors; } - /// @returns the type of an expression and asserts that it is present. TypePointer const& type(Expression const& _expression) const; /// @returns the type of the given variable and throws if the type is not present /// (this can happen for variables with non-explicit types before their types are resolved) TypePointer const& type(VariableDeclaration const& _variable) const; +private: /// Adds a new error to the list of errors. void typeError(ASTNode const& _node, std::string const& _description); /// Adds a new error to the list of errors and throws to abort type checking. void fatalTypeError(ASTNode const& _node, std::string const& _description); -private: virtual bool visit(ContractDefinition const& _contract) override; /// Checks that two functions defined in this contract with the same name have different /// arguments and that there is at most one constructor. @@ -114,7 +114,7 @@ private: /// Runs type checks on @a _expression to infer its type and then checks that it is an LValue. void requireLValue(Expression const& _expression); - ErrorList m_errors; + ErrorList& m_errors; }; } diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp index 42b65d4c..deae5928 100644 --- a/solc/CommandLineInterface.cpp +++ b/solc/CommandLineInterface.cpp @@ -496,7 +496,7 @@ bool CommandLineInterface::processInput() SourceReferenceFormatter::printExceptionInformation( cerr, *error, - (dynamic_pointer_cast(error)) ? "Warning" : "Error", *m_compiler + (error->type() == Error::Type::Warning) ? "Warning" : "Error", *m_compiler ); if (!successful) return false; diff --git a/test/libsolidity/Assembly.cpp b/test/libsolidity/Assembly.cpp index ca1e8980..f69ae680 100644 --- a/test/libsolidity/Assembly.cpp +++ b/test/libsolidity/Assembly.cpp @@ -48,21 +48,29 @@ namespace eth::AssemblyItems compileContract(const string& _sourceCode) { - Parser parser; + ErrorList errors; + Parser parser(errors); ASTPointer sourceUnit; BOOST_REQUIRE_NO_THROW(sourceUnit = parser.parse(make_shared(CharStream(_sourceCode)))); - NameAndTypeResolver resolver({}); + BOOST_CHECK(!!sourceUnit); + + NameAndTypeResolver resolver({}, errors); + solAssert(Error::containsOnlyWarnings(errors), ""); resolver.registerDeclarations(*sourceUnit); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { BOOST_REQUIRE_NO_THROW(resolver.resolveNamesAndTypes(*contract)); + if (!Error::containsOnlyWarnings(errors)) + return AssemblyItems(); } for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { - TypeChecker checker; + TypeChecker checker(errors); BOOST_REQUIRE_NO_THROW(checker.checkTypeRequirements(*contract)); + if (!Error::containsOnlyWarnings(errors)) + return AssemblyItems(); } for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) diff --git a/test/libsolidity/SolidityABIJSON.cpp b/test/libsolidity/SolidityABIJSON.cpp index f3004b5f..68f5a64a 100644 --- a/test/libsolidity/SolidityABIJSON.cpp +++ b/test/libsolidity/SolidityABIJSON.cpp @@ -45,9 +45,10 @@ public: m_reader.parse(generatedInterfaceString, generatedInterface); Json::Value expectedInterface; m_reader.parse(_expectedInterfaceString, expectedInterface); - BOOST_CHECK_MESSAGE(expectedInterface == generatedInterface, - "Expected:\n" << expectedInterface.toStyledString() << - "\n but got:\n" << generatedInterface.toStyledString()); + BOOST_CHECK_MESSAGE( + expectedInterface == generatedInterface, + "Expected:\n" << expectedInterface.toStyledString() << "\n but got:\n" << generatedInterface.toStyledString() + ); } private: diff --git a/test/libsolidity/SolidityEndToEndTest.cpp b/test/libsolidity/SolidityEndToEndTest.cpp index 08f62963..cccca0ba 100644 --- a/test/libsolidity/SolidityEndToEndTest.cpp +++ b/test/libsolidity/SolidityEndToEndTest.cpp @@ -4705,7 +4705,7 @@ BOOST_AUTO_TEST_CASE(dev_title_at_function_error) " function mul(uint a, uint second) returns(uint d) { return a * 7 + second; }\n" "}\n"; - compileRequireThrow(sourceCode); + compileRequireError(sourceCode, Error::Type::DocstringParsingError); } BOOST_AUTO_TEST_CASE(dev_documenting_nonexistant_param) @@ -4717,7 +4717,7 @@ BOOST_AUTO_TEST_CASE(dev_documenting_nonexistant_param) " function mul(uint a, uint second) returns(uint d) { return a * 7 + second; }\n" "}\n"; - compileRequireThrow(sourceCode); + compileRequireError(sourceCode, Error::Type::DocstringParsingError); } diff --git a/test/libsolidity/SolidityExpressionCompiler.cpp b/test/libsolidity/SolidityExpressionCompiler.cpp index 8134080e..4013581d 100644 --- a/test/libsolidity/SolidityExpressionCompiler.cpp +++ b/test/libsolidity/SolidityExpressionCompiler.cpp @@ -92,11 +92,13 @@ bytes compileFirstExpression( vector> _globalDeclarations = {} ) { - Parser parser; ASTPointer sourceUnit; try { - sourceUnit = parser.parse(make_shared(CharStream(_sourceCode))); + ErrorList errors; + sourceUnit = Parser(errors).parse(make_shared(CharStream(_sourceCode))); + if (!sourceUnit) + return bytes(); } catch(boost::exception const& _e) { @@ -108,9 +110,9 @@ bytes compileFirstExpression( declarations.reserve(_globalDeclarations.size() + 1); for (ASTPointer const& variable: _globalDeclarations) declarations.push_back(variable.get()); - /// TODO: - ErrorList errorList; - NameAndTypeResolver resolver(declarations, errorList); + + ErrorList errors; + NameAndTypeResolver resolver(declarations, errors); resolver.registerDeclarations(*sourceUnit); vector inheritanceHierarchy; @@ -123,7 +125,7 @@ bytes compileFirstExpression( for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { - TypeChecker typeChecker; + TypeChecker typeChecker(errors); BOOST_REQUIRE(typeChecker.checkTypeRequirements(*contract)); } for (ASTPointer const& node: sourceUnit->nodes()) diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index cc990c1e..905b5ce1 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -44,16 +44,23 @@ namespace test namespace { -pair, shared_ptr> +pair, std::shared_ptr> parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) { - Parser parser; + ErrorList errors; + Parser parser(errors); ASTPointer sourceUnit; - shared_ptr err; // catch exceptions for a transition period try { sourceUnit = parser.parse(std::make_shared(CharStream(_source))); + if(!sourceUnit) + return make_pair(sourceUnit, nullptr); + + NameAndTypeResolver resolver({}, errors); + solAssert(Error::containsOnlyWarnings(errors), ""); + resolver.registerDeclarations(*sourceUnit); + std::shared_ptr globalContext = make_shared(); NameAndTypeResolver resolver(globalContext->declarations()); resolver.registerDeclarations(*sourceUnit); @@ -71,51 +78,45 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) { globalContext->setCurrentContract(*contract); resolver.updateDeclaration(*globalContext->currentThis()); - TypeChecker typeChecker; + + TypeChecker typeChecker(errors); bool success = typeChecker.checkTypeRequirements(*contract); BOOST_CHECK(success || !typeChecker.errors().empty()); - for (auto const& firstError: typeChecker.errors()) + + for (auto const& currentError: errors) { - if (_reportWarnings || !dynamic_pointer_cast(firstError)) - { - err = firstError; - break; - } - else if (_reportWarnings) - { - err = firstError; - break; - } + if ( + (_reportWarnings && currentError->type() == Error::Type::Warning) || + (!_reportWarnings && currentError->type() != Error::Type::Warning) + ) + return make_pair(sourceUnit, std::make_shared(currentError->type())); } } } - catch (ParserError const& _exception) - { - return make_pair(sourceUnit, make_shared(_exception)); - } - catch (DeclarationError const& _exception) + catch(Error const& _e) { - return make_pair(sourceUnit, make_shared(_exception)); + return make_pair(sourceUnit, std::make_shared(_e.type())); } - catch (TypeError const& _exception) + catch (Exception const& _exception) { - return make_pair(sourceUnit, make_shared(_exception)); + return make_pair(sourceUnit, nullptr); } - return make_pair(sourceUnit, err); + return make_pair(sourceUnit, nullptr); } ASTPointer parseAndAnalyse(string const& _source) { auto sourceAndError = parseAnalyseAndReturnError(_source); - BOOST_REQUIRE(!sourceAndError.second); + BOOST_REQUIRE(!!sourceAndError.first); return sourceAndError.first; } -shared_ptr parseAndAnalyseReturnError(std::string const& _source, bool _warning = false) +Error::Type parseAndAnalyseReturnErrorType(std::string const& _source, bool _warning = false) { auto sourceAndError = parseAnalyseAndReturnError(_source, _warning); BOOST_REQUIRE(!!sourceAndError.second); - return sourceAndError.second; + BOOST_REQUIRE(!!sourceAndError.first); + return *sourceAndError.second; } static ContractDefinition const* retrieveContract(ASTPointer _source, unsigned index) @@ -140,10 +141,6 @@ static FunctionTypePointer const& retrieveFunctionBySignature( } -#define SOLIDITY_CHECK_ERROR_TYPE(_statement, _ErrorType) \ - BOOST_CHECK(!!dynamic_cast<_ErrorType const*>(_statement.get())) - - BOOST_AUTO_TEST_SUITE(SolidityNameAndTypeResolution) BOOST_AUTO_TEST_CASE(smoke_test) @@ -161,7 +158,7 @@ BOOST_AUTO_TEST_CASE(double_stateVariable_declaration) " uint256 variable;\n" " uint128 variable;\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(double_function_declaration) @@ -170,7 +167,7 @@ BOOST_AUTO_TEST_CASE(double_function_declaration) " function fun() { uint x; }\n" " function fun() { uint x; }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(double_variable_declaration) @@ -178,7 +175,7 @@ BOOST_AUTO_TEST_CASE(double_variable_declaration) char const* text = "contract test {\n" " function f() { uint256 x; if (true) { uint256 x; } }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(name_shadowing) @@ -205,7 +202,7 @@ BOOST_AUTO_TEST_CASE(undeclared_name) " uint256 variable;\n" " function f(uint256 arg) { f(notfound); }" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(reference_to_later_declaration) @@ -225,7 +222,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_directly_recursive) " MyStructName x;\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_definition_indirectly_recursive) @@ -240,7 +237,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_indirectly_recursive) " MyStructName1 x;\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_definition_not_really_recursive) @@ -287,7 +284,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return_wrong_number) char const* text = "contract test {\n" " function f() returns (bool r1, bool r2) { return 1 >= 2; }" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_checking_return_wrong_type) @@ -295,7 +292,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return_wrong_type) char const* text = "contract test {\n" " function f() returns (uint256 r) { return 1 >= 2; }" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_checking_function_call) @@ -320,7 +317,7 @@ BOOST_AUTO_TEST_CASE(type_conversion_for_comparison_invalid) char const* text = "contract test {\n" " function f() { int32(2) == uint64(2); }" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_inference_explicit_conversion) @@ -356,7 +353,7 @@ BOOST_AUTO_TEST_CASE(balance_invalid) " address(0).balance = 7;\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_to_mapping) @@ -371,7 +368,7 @@ BOOST_AUTO_TEST_CASE(assignment_to_mapping) " data.map = a;\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_to_struct) @@ -395,7 +392,7 @@ BOOST_AUTO_TEST_CASE(returns_in_constructor) " function test() returns (uint a) {\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(forward_function_reference) @@ -483,7 +480,7 @@ BOOST_AUTO_TEST_CASE(create_abstract_contract) function foo() { b = new base();} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_optional) @@ -527,7 +524,7 @@ BOOST_AUTO_TEST_CASE(redeclare_implemented_abstract_function_as_abstract) contract derived is base { function foo() {} } contract wrong is derived { function foo(); } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_canonical_signature) @@ -636,7 +633,7 @@ BOOST_AUTO_TEST_CASE(function_external_call_not_allowed_conversion) } function g (C c) external {} })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_internal_allowed_conversion) @@ -668,7 +665,7 @@ BOOST_AUTO_TEST_CASE(function_internal_not_allowed_conversion) g(a); } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(hash_collision_in_interface) @@ -679,7 +676,7 @@ BOOST_AUTO_TEST_CASE(hash_collision_in_interface) " function tgeo() {\n" " }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(inheritance_basic) @@ -713,7 +710,7 @@ BOOST_AUTO_TEST_CASE(cyclic_inheritance) contract A is B { } contract B is A { } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(legal_override_direct) @@ -741,7 +738,7 @@ BOOST_AUTO_TEST_CASE(illegal_override_visibility) contract B { function f() internal {} } contract C is B { function f() public {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(illegal_override_constness) @@ -750,7 +747,7 @@ BOOST_AUTO_TEST_CASE(illegal_override_constness) contract B { function f() constant {} } contract C is B { function f() {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(complex_inheritance) @@ -820,7 +817,7 @@ BOOST_AUTO_TEST_CASE(implicit_base_to_derived_conversion) function f() { B b = A(1); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_modifier_invocation) @@ -843,7 +840,7 @@ BOOST_AUTO_TEST_CASE(invalid_function_modifier_type) modifier mod1(uint a) { if (a > 0) _ } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_modifier_invocation_parameters) @@ -884,7 +881,7 @@ BOOST_AUTO_TEST_CASE(illegal_modifier_override) contract A { modifier mod(uint a) {} } contract B is A { modifier mod(uint8 a) {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(modifier_overrides_function) @@ -893,7 +890,7 @@ BOOST_AUTO_TEST_CASE(modifier_overrides_function) contract A { modifier mod(uint a) {} } contract B is A { function mod(uint a) {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_overrides_modifier) @@ -902,7 +899,7 @@ BOOST_AUTO_TEST_CASE(function_overrides_modifier) contract A { function mod(uint a) {} } contract B is A { modifier mod(uint a) {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(modifier_returns_value) @@ -913,7 +910,7 @@ BOOST_AUTO_TEST_CASE(modifier_returns_value) modifier mod(uint a) { return 7; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(state_variable_accessors) @@ -964,7 +961,7 @@ BOOST_AUTO_TEST_CASE(function_clash_with_state_variable_accessor) "uint256 foo;\n" " function foo() {}\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_state_variable) @@ -1022,7 +1019,7 @@ BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class1) "contract Child is Parent2{\n" " function foo() returns (uint256) { return Parent2.m_aMember1; }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class2) @@ -1037,7 +1034,7 @@ BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class2) " function foo() returns (uint256) { return Child.m_aMember2; }\n" " uint256 public m_aMember3;\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(fallback_function) @@ -1059,7 +1056,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_with_arguments) function(uint a) { x = 2; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(fallback_function_twice) @@ -1071,7 +1068,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_twice) function() { x = 3; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(fallback_function_inheritance) @@ -1104,7 +1101,7 @@ BOOST_AUTO_TEST_CASE(event_too_many_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d); })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(anonymous_event_four_indexed) @@ -1178,7 +1175,7 @@ BOOST_AUTO_TEST_CASE(access_to_internal_function) contract d { function g() { c(0).f(); } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(access_to_default_state_variable_visibility) @@ -1190,7 +1187,7 @@ BOOST_AUTO_TEST_CASE(access_to_default_state_variable_visibility) contract d { function g() { c(0).a(); } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(access_to_internal_state_variable) @@ -1211,7 +1208,7 @@ BOOST_AUTO_TEST_CASE(error_count_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1}); }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(empty_in_named_args) @@ -1220,7 +1217,7 @@ BOOST_AUTO_TEST_CASE(empty_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({}); }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(duplicate_parameter_names_in_named_args) @@ -1229,7 +1226,7 @@ BOOST_AUTO_TEST_CASE(duplicate_parameter_names_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1, a: 2}); }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(invalid_parameter_names_in_named_args) @@ -1238,7 +1235,7 @@ BOOST_AUTO_TEST_CASE(invalid_parameter_names_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1, c: 2}); }\n" "}\n"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(empty_name_input_parameter) @@ -1280,13 +1277,18 @@ BOOST_AUTO_TEST_CASE(empty_name_return_parameter_with_named_one) return 5; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(disallow_declaration_of_void_type) { +<<<<<<< HEAD char const* sourceCode = "contract c { function f() { var (x) = f(); } }"; SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); +======= + char const* sourceCode = "contract c { function f() { var x = f(); } }"; + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); +>>>>>>> 2cd6509... errors instead of exceptions } BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) @@ -1309,7 +1311,7 @@ BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) } uint256 a; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(exp_operator_negative_exponent) @@ -1318,7 +1320,7 @@ BOOST_AUTO_TEST_CASE(exp_operator_negative_exponent) contract test { function f() returns(uint d) { return 2 ** -3; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(exp_operator_exponent_too_big) @@ -1327,7 +1329,7 @@ BOOST_AUTO_TEST_CASE(exp_operator_exponent_too_big) contract test { function f() returns(uint d) { return 2 ** 10000000000; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_member_access) @@ -1357,7 +1359,7 @@ BOOST_AUTO_TEST_CASE(enum_invalid_member_access) ActionChoices choices; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_explicit_conversion_is_okay) @@ -1408,7 +1410,7 @@ BOOST_AUTO_TEST_CASE(enum_implicit_conversion_is_not_okay) uint64 b; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_duplicate_values) @@ -1418,7 +1420,7 @@ BOOST_AUTO_TEST_CASE(enum_duplicate_values) enum ActionChoices { GoLeft, GoRight, GoLeft, Sit } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_visibility) @@ -1431,7 +1433,7 @@ BOOST_AUTO_TEST_CASE(private_visibility) function g() { f(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_visibility_via_explicit_base_access) @@ -1444,7 +1446,7 @@ BOOST_AUTO_TEST_CASE(private_visibility_via_explicit_base_access) function g() { base.f(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_visibility) @@ -1455,7 +1457,7 @@ BOOST_AUTO_TEST_CASE(external_visibility) function g() { f(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(external_base_visibility) @@ -1468,7 +1470,7 @@ BOOST_AUTO_TEST_CASE(external_base_visibility) function g() { base.f(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_assign) @@ -1478,7 +1480,7 @@ BOOST_AUTO_TEST_CASE(external_argument_assign) function f(uint a) external { a = 1; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_increment) @@ -1488,7 +1490,7 @@ BOOST_AUTO_TEST_CASE(external_argument_increment) function f(uint a) external { a++; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_delete) @@ -1498,7 +1500,7 @@ BOOST_AUTO_TEST_CASE(external_argument_delete) function f(uint a) external { delete a; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(test_for_bug_override_function_with_bytearray_type) @@ -1520,7 +1522,7 @@ BOOST_AUTO_TEST_CASE(array_with_nonconstant_length) contract c { function f(uint a) { uint8[a] x; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types1) @@ -1531,7 +1533,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types1) uint[] b; function f() { b = a; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types2) @@ -1542,7 +1544,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types2) uint8[] b; function f() { b = a; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_conversion_possible) @@ -1575,7 +1577,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_dynamic_static) uint[80] b; function f() { b = a; } })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_int) @@ -1584,7 +1586,7 @@ BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_int) contract c { uint8 a = 1000; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_string) @@ -1593,7 +1595,7 @@ BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_string) contract c { uint a = "abc"; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(test_fromElementaryTypeName) @@ -1718,7 +1720,7 @@ BOOST_AUTO_TEST_CASE(assigning_value_to_const_variable) function changeIt() { x = 9; } uint constant x = 56; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(complex_const_variable) @@ -1728,7 +1730,7 @@ BOOST_AUTO_TEST_CASE(complex_const_variable) contract Foo { mapping(uint => bool) constant mapVar; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(uninitialized_const_variable) @@ -1737,20 +1739,7 @@ BOOST_AUTO_TEST_CASE(uninitialized_const_variable) contract Foo { uint constant y; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); -} - -BOOST_AUTO_TEST_CASE(local_const_variable) -{ - char const* text = R"( - contract Foo { - function localConst() returns (uint ret) - { - uint constant local = 4; - return local; - } - })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), ParserError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overloaded_function_cannot_resolve) @@ -1762,7 +1751,7 @@ BOOST_AUTO_TEST_CASE(overloaded_function_cannot_resolve) function g() returns(uint) { return f(3, 5); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(ambiguous_overloaded_function) @@ -1775,7 +1764,7 @@ BOOST_AUTO_TEST_CASE(ambiguous_overloaded_function) function g() returns(uint) { return f(1); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_of_nonoverloaded_function) @@ -1798,7 +1787,7 @@ BOOST_AUTO_TEST_CASE(assignment_of_overloaded_function) function g() returns(uint) { var x = f; return x(7); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_types_clash) @@ -1812,7 +1801,7 @@ BOOST_AUTO_TEST_CASE(external_types_clash) function f(uint8 a) { } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(override_changes_return_types) @@ -1825,7 +1814,7 @@ BOOST_AUTO_TEST_CASE(override_changes_return_types) function f(uint a) returns (uint8) { } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multiple_constructors) @@ -1836,7 +1825,7 @@ BOOST_AUTO_TEST_CASE(multiple_constructors) function test() {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(equal_overload) @@ -1847,7 +1836,7 @@ BOOST_AUTO_TEST_CASE(equal_overload) function test(uint a) external {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), DeclarationError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(uninitialized_var) @@ -1857,7 +1846,7 @@ BOOST_AUTO_TEST_CASE(uninitialized_var) function f() returns (uint) { var x; return 2; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string) @@ -1879,7 +1868,7 @@ BOOST_AUTO_TEST_CASE(string_index) function f() { var a = s[2]; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string_length) @@ -1890,7 +1879,7 @@ BOOST_AUTO_TEST_CASE(string_length) function f() { var a = s.length; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(negative_integers_to_signed_out_of_bound) @@ -1900,7 +1889,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_signed_out_of_bound) int8 public i = -129; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(negative_integers_to_signed_min) @@ -1920,7 +1909,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound) int8 public j = 128; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound_max) @@ -1940,7 +1929,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_unsigned) uint8 public x = -1; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(positive_integers_to_unsigned_out_of_bound) @@ -1950,7 +1939,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_unsigned_out_of_bound) uint8 public x = 700; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(integer_boolean_operators) @@ -1958,15 +1947,15 @@ BOOST_AUTO_TEST_CASE(integer_boolean_operators) char const* sourceCode1 = R"( contract test { function() { uint x = 1; uint y = 2; x || y; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode1), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode1) == Error::Type::TypeError); char const* sourceCode2 = R"( contract test { function() { uint x = 1; uint y = 2; x && y; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode2), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode2) == Error::Type::TypeError); char const* sourceCode3 = R"( contract test { function() { uint x = 1; !x; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode3), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode3) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(reference_compare_operators) @@ -1974,11 +1963,11 @@ BOOST_AUTO_TEST_CASE(reference_compare_operators) char const* sourceCode1 = R"( contract test { bytes a; bytes b; function() { a == b; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode1), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode1) == Error::Type::TypeError); char const* sourceCode2 = R"( contract test { struct s {uint a;} s x; s y; function() { x == y; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode2), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode2) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overwrite_memory_location_external) @@ -1988,7 +1977,7 @@ BOOST_AUTO_TEST_CASE(overwrite_memory_location_external) function f(uint[] memory a) external {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overwrite_storage_location_external) @@ -1998,7 +1987,7 @@ BOOST_AUTO_TEST_CASE(overwrite_storage_location_external) function f(uint[] storage a) external {} } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_location_local_variables) @@ -2024,7 +2013,7 @@ BOOST_AUTO_TEST_CASE(no_mappings_in_memory_array) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_mem_to_local_storage_variable) @@ -2038,7 +2027,7 @@ BOOST_AUTO_TEST_CASE(assignment_mem_to_local_storage_variable) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_assign_to_different_local_variable) @@ -2055,7 +2044,7 @@ BOOST_AUTO_TEST_CASE(storage_assign_to_different_local_variable) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(no_delete_on_storage_pointers) @@ -2069,7 +2058,7 @@ BOOST_AUTO_TEST_CASE(no_delete_on_storage_pointers) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_mem_storage_variable_directly) @@ -2096,7 +2085,7 @@ BOOST_AUTO_TEST_CASE(function_argument_mem_to_storage) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_argument_storage_to_mem) @@ -2125,7 +2114,7 @@ BOOST_AUTO_TEST_CASE(mem_array_assignment_changes_base_type) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(dynamic_return_types_not_possible) @@ -2138,7 +2127,7 @@ BOOST_AUTO_TEST_CASE(dynamic_return_types_not_possible) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(memory_arrays_not_resizeable) @@ -2151,7 +2140,7 @@ BOOST_AUTO_TEST_CASE(memory_arrays_not_resizeable) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_constructor) @@ -2217,7 +2206,7 @@ BOOST_AUTO_TEST_CASE(invalid_integer_literal_fraction) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(invalid_integer_literal_exp) @@ -2229,7 +2218,7 @@ BOOST_AUTO_TEST_CASE(invalid_integer_literal_exp) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(memory_structs_with_mappings) @@ -2244,7 +2233,7 @@ BOOST_AUTO_TEST_CASE(memory_structs_with_mappings) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string_bytes_conversion) @@ -2270,7 +2259,7 @@ BOOST_AUTO_TEST_CASE(inheriting_from_library) library Lib {} contract Test is Lib {} )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(inheriting_library) @@ -2279,7 +2268,7 @@ BOOST_AUTO_TEST_CASE(inheriting_library) contract Test {} library Lib is Test {} )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(library_having_variables) @@ -2287,7 +2276,7 @@ BOOST_AUTO_TEST_CASE(library_having_variables) char const* text = R"( library Lib { uint x; } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(valid_library) @@ -2321,7 +2310,7 @@ BOOST_AUTO_TEST_CASE(creating_contract_within_the_contract) function f() { var x = new Test(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_out_of_bound_access) @@ -2335,7 +2324,7 @@ BOOST_AUTO_TEST_CASE(array_out_of_bound_access) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(literal_string_to_storage_pointer) @@ -2345,7 +2334,7 @@ BOOST_AUTO_TEST_CASE(literal_string_to_storage_pointer) function f() { string x = "abc"; } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(non_initialized_references) @@ -2363,7 +2352,10 @@ BOOST_AUTO_TEST_CASE(non_initialized_references) } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text, true), Warning); + + auto b = parseAndAnalyseReturnErrorType(text, true); + (void)b; + BOOST_CHECK(parseAndAnalyseReturnErrorType(text, true) == Error::Type::Warning); } BOOST_AUTO_TEST_CASE(sha3_with_large_integer_constant) diff --git a/test/libsolidity/SolidityParser.cpp b/test/libsolidity/SolidityParser.cpp index a90399fc..0bc4d4ee 100644 --- a/test/libsolidity/SolidityParser.cpp +++ b/test/libsolidity/SolidityParser.cpp @@ -39,10 +39,11 @@ namespace test namespace { -ASTPointer parseText(std::string const& _source) +ASTPointer parseText(std::string const& _source, ErrorList& _errors) { - Parser parser; - ASTPointer sourceUnit = parser.parse(std::make_shared(CharStream(_source))); + ASTPointer sourceUnit = Parser(_errors).parse(std::make_shared(CharStream(_source))); + if(!sourceUnit) + return ASTPointer(); for (ASTPointer const& node: sourceUnit->nodes()) if (ASTPointer contract = dynamic_pointer_cast(node)) return contract; @@ -50,8 +51,30 @@ ASTPointer parseText(std::string const& _source) return ASTPointer(); } -static void checkFunctionNatspec(ASTPointer _function, - std::string const& _expectedDoc) +bool successParse(std::string const& _source) +{ + ErrorList errors; + try + { + auto sourceUnit = parseText(_source, errors); + if(!sourceUnit) + return false; + } + catch (fatalError const& _exception) + { + if (Error::containsErrorOfType(errors, Error::Type::ParserError)) + return false; + } + if (Error::containsErrorOfType(errors, Error::Type::ParserError)) + return false; + + return true; +} + +void checkFunctionNatspec( + ASTPointer _function, + std::string const& _expectedDoc +) { auto doc = _function->documentation(); BOOST_CHECK_MESSAGE(doc != nullptr, "Function does not have Natspec Doc as expected"); @@ -68,7 +91,7 @@ BOOST_AUTO_TEST_CASE(smoke_test) char const* text = "contract test {\n" " uint256 stateVariable1;\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed."); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(missing_variable_name_in_declaration) @@ -76,7 +99,7 @@ BOOST_AUTO_TEST_CASE(missing_variable_name_in_declaration) char const* text = "contract test {\n" " uint256 ;\n" "}\n"; - BOOST_CHECK_THROW(parseText(text), Error); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(empty_function) @@ -87,7 +110,7 @@ BOOST_AUTO_TEST_CASE(empty_function) " returns (int id)\n" " { }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed."); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(no_function_params) @@ -96,7 +119,7 @@ BOOST_AUTO_TEST_CASE(no_function_params) " uint256 stateVar;\n" " function functionName() {}\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed."); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(single_function_param) @@ -105,7 +128,7 @@ BOOST_AUTO_TEST_CASE(single_function_param) " uint256 stateVar;\n" " function functionName(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed."); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(function_no_body) @@ -113,7 +136,7 @@ BOOST_AUTO_TEST_CASE(function_no_body) char const* text = "contract test {\n" " function functionName(bytes32 input) returns (bytes32 out);\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed."); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(missing_parameter_name_in_named_args) @@ -122,7 +145,7 @@ BOOST_AUTO_TEST_CASE(missing_parameter_name_in_named_args) " function a(uint a, uint b, uint c) returns (uint r) { r = a * 100 + b * 10 + c * 1; }\n" " function b() returns (uint r) { r = a({: 1, : 2, : 3}); }\n" "}\n"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(missing_argument_in_named_args) @@ -131,7 +154,7 @@ BOOST_AUTO_TEST_CASE(missing_argument_in_named_args) " function a(uint a, uint b, uint c) returns (uint r) { r = a * 100 + b * 10 + c * 1; }\n" " function b() returns (uint r) { r = a({a: , b: , c: }); }\n" "}\n"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(two_exact_functions) @@ -145,7 +168,8 @@ BOOST_AUTO_TEST_CASE(two_exact_functions) // with support of overloaded functions, during parsing, // we can't determine whether they match exactly, however // it will throw DeclarationError in following stage. - BOOST_CHECK_NO_THROW(parseText(text)); + // TODO add test to the SolidityNameAndTypeDeclaration + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(overloaded_functions) @@ -156,20 +180,23 @@ BOOST_AUTO_TEST_CASE(overloaded_functions) function fun(uint a, uint b) returns(uint r) { return a + b; } } )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(function_natspec_documentation) { - ASTPointer contract; - ASTPointer function; char const* text = "contract test {\n" " uint256 stateVar;\n" " /// This is a test function\n" " function functionName(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList e; + ASTPointer contract = parseText(text, e); + ASTPointer function; + + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); checkFunctionNatspec(function, "This is a test function"); } @@ -183,8 +210,9 @@ BOOST_AUTO_TEST_CASE(function_normal_comments) " // We won't see this comment\n" " function functionName(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); BOOST_CHECK_MESSAGE(function->documentation() == nullptr, "Should not have gotten a Natspecc comment for this function"); @@ -205,8 +233,9 @@ BOOST_AUTO_TEST_CASE(multiple_functions_natspec_documentation) " /// This is test function 4\n" " function functionName4(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); checkFunctionNatspec(function, "This is test function 1"); @@ -232,9 +261,9 @@ BOOST_AUTO_TEST_CASE(multiline_function_documentation) " /// and it has 2 lines\n" " function functionName1(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); - + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); checkFunctionNatspec(function, "This is a test function\n" " and it has 2 lines"); @@ -257,8 +286,9 @@ BOOST_AUTO_TEST_CASE(natspec_comment_in_function_body) " /// and it has 2 lines\n" " function fun(bytes32 input) returns (bytes32 out) {}\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); checkFunctionNatspec(function, "fun1 description"); @@ -283,8 +313,9 @@ BOOST_AUTO_TEST_CASE(natspec_docstring_between_keyword_and_signature) " bytes7 name = \"Solidity\";" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); BOOST_CHECK_MESSAGE(!function->documentation(), @@ -306,8 +337,9 @@ BOOST_AUTO_TEST_CASE(natspec_docstring_after_signature) " bytes7 name = \"Solidity\";" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(contract = parseText(text), "Parsing failed"); - auto functions = contract->definedFunctions(); + BOOST_CHECK(successParse(text)); + ErrorList errors; + auto functions = parseText(text, errors)->definedFunctions(); ETH_TEST_REQUIRE_NO_THROW(function = functions.at(0), "Failed to retrieve function"); BOOST_CHECK_MESSAGE(!function->documentation(), @@ -323,7 +355,7 @@ BOOST_AUTO_TEST_CASE(struct_definition) " uint256 count;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(mapping) @@ -331,7 +363,7 @@ BOOST_AUTO_TEST_CASE(mapping) char const* text = "contract test {\n" " mapping(address => bytes32) names;\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(mapping_in_struct) @@ -343,7 +375,7 @@ BOOST_AUTO_TEST_CASE(mapping_in_struct) " mapping(bytes32 => test_struct) self_reference;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(mapping_to_mapping_in_struct) @@ -354,7 +386,7 @@ BOOST_AUTO_TEST_CASE(mapping_to_mapping_in_struct) " mapping (uint64 => mapping (bytes32 => uint)) complex_mapping;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(variable_definition) @@ -367,7 +399,7 @@ BOOST_AUTO_TEST_CASE(variable_definition) " customtype varname;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(variable_definition_with_initialization) @@ -381,7 +413,7 @@ BOOST_AUTO_TEST_CASE(variable_definition_with_initialization) " customtype varname;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(variable_definition_in_function_parameter) @@ -391,7 +423,7 @@ BOOST_AUTO_TEST_CASE(variable_definition_in_function_parameter) function fun(var a) {} } )"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(variable_definition_in_mapping) @@ -403,7 +435,7 @@ BOOST_AUTO_TEST_CASE(variable_definition_in_mapping) } } )"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(variable_definition_in_function_return) @@ -415,7 +447,7 @@ BOOST_AUTO_TEST_CASE(variable_definition_in_function_return) } } )"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(operator_expression) @@ -425,7 +457,7 @@ BOOST_AUTO_TEST_CASE(operator_expression) " uint256 x = (1 + 4) || false && (1 - 12) + -9;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(complex_expression) @@ -435,7 +467,7 @@ BOOST_AUTO_TEST_CASE(complex_expression) " uint256 x = (1 + 4).member(++67)[a/=9] || true;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(exp_expression) @@ -446,7 +478,7 @@ BOOST_AUTO_TEST_CASE(exp_expression) uint256 x = 3 ** a; } })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(while_loop) @@ -456,7 +488,7 @@ BOOST_AUTO_TEST_CASE(while_loop) " while (true) { uint256 x = 1; break; continue; } x = 9;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(for_loop_vardef_initexpr) @@ -467,7 +499,7 @@ BOOST_AUTO_TEST_CASE(for_loop_vardef_initexpr) " { uint256 x = i; break; continue; }\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(for_loop_simple_initexpr) @@ -479,7 +511,7 @@ BOOST_AUTO_TEST_CASE(for_loop_simple_initexpr) " { uint256 x = i; break; continue; }\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(for_loop_simple_noexpr) @@ -491,7 +523,7 @@ BOOST_AUTO_TEST_CASE(for_loop_simple_noexpr) " { uint256 x = i; break; continue; }\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(for_loop_single_stmt_body) @@ -503,7 +535,7 @@ BOOST_AUTO_TEST_CASE(for_loop_single_stmt_body) " continue;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(if_statement) @@ -513,7 +545,7 @@ BOOST_AUTO_TEST_CASE(if_statement) " if (a >= 8) return 2; else { var b = 7; }\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(else_if_statement) @@ -523,7 +555,7 @@ BOOST_AUTO_TEST_CASE(else_if_statement) " if (a < 0) b = 0x67; else if (a == 0) b = 0x12; else b = 0x78;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(statement_starting_with_type_conversion) @@ -535,7 +567,7 @@ BOOST_AUTO_TEST_CASE(statement_starting_with_type_conversion) " uint64[](3);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(type_conversion_to_dynamic_array) @@ -545,7 +577,7 @@ BOOST_AUTO_TEST_CASE(type_conversion_to_dynamic_array) " var x = uint64[](3);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(import_directive) @@ -556,7 +588,7 @@ BOOST_AUTO_TEST_CASE(import_directive) " uint64(2);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(multiple_contracts) @@ -571,7 +603,7 @@ BOOST_AUTO_TEST_CASE(multiple_contracts) " uint64(2);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(multiple_contracts_and_imports) @@ -589,7 +621,7 @@ BOOST_AUTO_TEST_CASE(multiple_contracts_and_imports) " }\n" "}\n" "import \"ghi\";\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(contract_inheritance) @@ -604,7 +636,7 @@ BOOST_AUTO_TEST_CASE(contract_inheritance) " uint64(2);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(contract_multiple_inheritance) @@ -619,7 +651,7 @@ BOOST_AUTO_TEST_CASE(contract_multiple_inheritance) " uint64(2);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(contract_multiple_inheritance_with_arguments) @@ -634,7 +666,7 @@ BOOST_AUTO_TEST_CASE(contract_multiple_inheritance_with_arguments) " uint64(2);\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(placeholder_in_function_context) @@ -645,7 +677,7 @@ BOOST_AUTO_TEST_CASE(placeholder_in_function_context) " return _ + 1;" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(modifier) @@ -653,7 +685,7 @@ BOOST_AUTO_TEST_CASE(modifier) char const* text = "contract c {\n" " modifier mod { if (msg.sender == 0) _ }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(modifier_arguments) @@ -661,7 +693,7 @@ BOOST_AUTO_TEST_CASE(modifier_arguments) char const* text = "contract c {\n" " modifier mod(uint a) { if (msg.sender == a) _ }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(modifier_invocation) @@ -671,7 +703,7 @@ BOOST_AUTO_TEST_CASE(modifier_invocation) " modifier mod2 { if (msg.sender == 2) _ }\n" " function f() mod1(7) mod2 { }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(fallback_function) @@ -679,7 +711,7 @@ BOOST_AUTO_TEST_CASE(fallback_function) char const* text = "contract c {\n" " function() { }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(event) @@ -688,7 +720,7 @@ BOOST_AUTO_TEST_CASE(event) contract c { event e(); })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(event_arguments) @@ -697,7 +729,7 @@ BOOST_AUTO_TEST_CASE(event_arguments) contract c { event e(uint a, bytes32 s); })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(event_arguments_indexed) @@ -706,7 +738,7 @@ BOOST_AUTO_TEST_CASE(event_arguments_indexed) contract c { event e(uint a, bytes32 indexed s, bool indexed b); })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(visibility_specifiers) @@ -722,7 +754,7 @@ BOOST_AUTO_TEST_CASE(visibility_specifiers) function f_public() public {} function f_internal() internal {} })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(multiple_visibility_specifiers) @@ -731,7 +763,7 @@ BOOST_AUTO_TEST_CASE(multiple_visibility_specifiers) contract c { uint private internal a; })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(literal_constants_with_ether_subdenominations) @@ -750,7 +782,7 @@ BOOST_AUTO_TEST_CASE(literal_constants_with_ether_subdenominations) uint256 c; uint256 d; })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(literal_constants_with_ether_subdenominations_in_expressions) @@ -763,7 +795,7 @@ BOOST_AUTO_TEST_CASE(literal_constants_with_ether_subdenominations_in_expression } uint256 a; })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(enum_valid_declaration) @@ -777,7 +809,7 @@ BOOST_AUTO_TEST_CASE(enum_valid_declaration) } uint256 a; })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(empty_enum_declaration) @@ -786,7 +818,7 @@ BOOST_AUTO_TEST_CASE(empty_enum_declaration) contract c { enum foo { } })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(malformed_enum_declaration) @@ -795,7 +827,7 @@ BOOST_AUTO_TEST_CASE(malformed_enum_declaration) contract c { enum foo { WARNING,} })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(external_function) @@ -804,7 +836,7 @@ BOOST_AUTO_TEST_CASE(external_function) contract c { function x() external {} })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(external_variable) @@ -813,10 +845,10 @@ BOOST_AUTO_TEST_CASE(external_variable) contract c { uint external x; })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } -BOOST_AUTO_TEST_CASE(arrays_in_storage) +BOOST_AUTO_TEST_CASE(arrays_in_storagze) { char const* text = R"( contract c { @@ -825,7 +857,7 @@ BOOST_AUTO_TEST_CASE(arrays_in_storage) struct x { uint[2**20] b; y[0] c; } struct y { uint d; mapping(uint=>x)[] e; } })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(arrays_in_events) @@ -834,7 +866,7 @@ BOOST_AUTO_TEST_CASE(arrays_in_events) contract c { event e(uint[10] a, bytes7[8] indexed b, c[3] x); })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(arrays_in_expressions) @@ -843,7 +875,7 @@ BOOST_AUTO_TEST_CASE(arrays_in_expressions) contract c { function f() { c[10] a = 7; uint8[10 * 2] x; } })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(multi_arrays) @@ -852,7 +884,7 @@ BOOST_AUTO_TEST_CASE(multi_arrays) contract c { mapping(uint => mapping(uint => int8)[8][][9])[] x; })"; - ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed"); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(constant_is_keyword) @@ -861,7 +893,7 @@ BOOST_AUTO_TEST_CASE(constant_is_keyword) contract Foo { uint constant = 4; })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(var_array) @@ -870,7 +902,7 @@ BOOST_AUTO_TEST_CASE(var_array) contract Foo { function f() { var[] a; } })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(location_specifiers_for_params) @@ -880,7 +912,7 @@ BOOST_AUTO_TEST_CASE(location_specifiers_for_params) function f(uint[] storage constant x, uint[] memory y) { } } )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(location_specifiers_for_locals) @@ -893,7 +925,7 @@ BOOST_AUTO_TEST_CASE(location_specifiers_for_locals) } } )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(location_specifiers_for_state) @@ -902,7 +934,7 @@ BOOST_AUTO_TEST_CASE(location_specifiers_for_state) contract Foo { uint[] memory x; })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(location_specifiers_with_var) @@ -911,7 +943,7 @@ BOOST_AUTO_TEST_CASE(location_specifiers_with_var) contract Foo { function f() { var memory x; } })"; - BOOST_CHECK_THROW(parseText(text), ParserError); + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(empty_comment) @@ -921,7 +953,7 @@ BOOST_AUTO_TEST_CASE(empty_comment) contract test {} )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_CASE(library_simple) @@ -931,7 +963,21 @@ BOOST_AUTO_TEST_CASE(library_simple) function f() { } } )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); +} + + +BOOST_AUTO_TEST_CASE(local_const_variable) +{ + char const* text = R"( + contract Foo { + function localConst() returns (uint ret) + { + uint constant local = 4; + return local; + } + })"; + BOOST_CHECK(!successParse(text)); } BOOST_AUTO_TEST_CASE(multi_variable_declaration) diff --git a/test/libsolidity/solidityExecutionFramework.h b/test/libsolidity/solidityExecutionFramework.h index 3370044c..27dd4fb7 100644 --- a/test/libsolidity/solidityExecutionFramework.h +++ b/test/libsolidity/solidityExecutionFramework.h @@ -67,12 +67,26 @@ public: return m_output; } - template - void compileRequireThrow(std::string const& _sourceCode) + void compileRequireError(std::string const& _sourceCode, Error::Type _type) { m_compiler.reset(false, m_addStandardSources); m_compiler.addSource("", _sourceCode); - BOOST_REQUIRE_THROW(m_compiler.compile(m_optimize, m_optimizeRuns), Exceptiontype); + bool foundError = false; + try + { + m_compiler.compile(m_optimize, m_optimizeRuns); + BOOST_REQUIRE(Error::containsErrorOfType(m_compiler.errors(), _type)); + } + catch(Error const& _e) + { + BOOST_REQUIRE(_e.type() == _type); + foundError = true; + } + catch(Exception const& _exception) + { + BOOST_REQUIRE(false); + } + BOOST_REQUIRE(foundError); } bytes const& compileAndRun( -- cgit v1.2.3 From 7a7a7dcbb59e1126679e7e8f6eab16992fffb51c Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 11:10:55 +0200 Subject: fixes error after conflict resolving --- libsolidity/CompilerStack.cpp | 3 +-- libsolidity/ReferencesResolver.cpp | 2 +- libsolidity/TypeChecker.cpp | 2 +- libsolidity/Utils.h | 1 - 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libsolidity/CompilerStack.cpp b/libsolidity/CompilerStack.cpp index 3887999a..dd7f7dfc 100644 --- a/libsolidity/CompilerStack.cpp +++ b/libsolidity/CompilerStack.cpp @@ -140,7 +140,7 @@ bool CompilerStack::parse() { m_globalContext->setCurrentContract(*contract); resolver.updateDeclaration(*m_globalContext->currentThis()); - TypeChecker typeChecker; + TypeChecker typeChecker(m_errors); if (typeChecker.checkTypeRequirements(*contract)) { contract->setDevDocumentation(interfaceHandler.devDocumentation(*contract)); @@ -150,7 +150,6 @@ bool CompilerStack::parse() typesFine = false; m_contracts[contract->name()].contract = contract; - m_errors += typeChecker.errors(); } m_parseSuccessful = typesFine; return m_parseSuccessful; diff --git a/libsolidity/ReferencesResolver.cpp b/libsolidity/ReferencesResolver.cpp index 70bc6572..b1112dd9 100644 --- a/libsolidity/ReferencesResolver.cpp +++ b/libsolidity/ReferencesResolver.cpp @@ -60,7 +60,7 @@ bool ReferencesResolver::visit(UserDefinedTypeName const& _typeName) Error(Error::Type::DeclarationError) << errinfo_sourceLocation(_typeName.location()) << errinfo_comment("Identifier not found or not unique.") - + ); _typeName.annotation().referencedDeclaration = declaration; return true; } diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index cc7ad2f3..2e45f7b0 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -607,7 +607,7 @@ bool TypeChecker::visit(VariableDeclarationStatement const& _statement) { if (ref->dataStoredIn(DataLocation::Storage)) { - auto err = make_shared(); + auto err = make_shared(Error::Type::Warning); *err << errinfo_sourceLocation(varDecl.location()) << errinfo_comment("Uninitialized storage pointer. Did you mean ' memory " + varDecl.name() + "'?"); diff --git a/libsolidity/Utils.h b/libsolidity/Utils.h index 6c8e3b33..05c5fa6f 100644 --- a/libsolidity/Utils.h +++ b/libsolidity/Utils.h @@ -23,7 +23,6 @@ #pragma once #include -#include /// Assertion that throws an InternalCompilerError containing the given description if it is not met. #define solAssert(CONDITION, DESCRIPTION) \ -- cgit v1.2.3 From 675aed1edfcff1cf7cd68cc92582d987820e4729 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 11:50:25 +0200 Subject: fixed new tests --- libsolidity/Exceptions.cpp | 52 ++++++++++++++++++++++ libsolidity/Exceptions.h | 27 +---------- libsolidity/Utils.h | 9 ++++ solc/jsonCompiler.cpp | 5 ++- test/libsolidity/SolidityNameAndTypeResolution.cpp | 36 ++++++--------- test/libsolidity/SolidityParser.cpp | 2 +- 6 files changed, 81 insertions(+), 50 deletions(-) create mode 100644 libsolidity/Exceptions.cpp diff --git a/libsolidity/Exceptions.cpp b/libsolidity/Exceptions.cpp new file mode 100644 index 00000000..37d25697 --- /dev/null +++ b/libsolidity/Exceptions.cpp @@ -0,0 +1,52 @@ +/* + This file is part of cpp-ethereum. + + cpp-ethereum is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + cpp-ethereum is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with cpp-ethereum. If not, see . +*/ +/** + * @author Christian + * @date 2015 + * Solidity exception hierarchy. + */ + +#include +#include + +using namespace dev; +using namespace dev::solidity; + +Error::Error(Error::Type _type): m_type(_type) +{ + switch(m_type) + { + case Type::DeclarationError: + m_typeName = "Declaration Error"; + break; + case Type::DocstringParsingError: + m_typeName = "Docstring Parsing Error"; + break; + case Type::ParserError: + m_typeName = "Parser Error"; + break; + case Type::TypeError: + m_typeName = "Type Error"; + break; + case Type::Warning: + m_typeName = "Warning"; + break; + default: + solAssert(false, ""); + break; + } +} diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 92c009ef..9bc22994 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -26,7 +26,6 @@ #include #include #include -#include namespace dev { @@ -51,35 +50,11 @@ public: Warning }; - Error(Type _type) : m_type(_type) - { - switch(m_type) - { - case Type::DeclarationError: - m_typeName = "Declaration Error"; - break; - case Type::DocstringParsingError: - m_typeName = "Docstring Parsing Error"; - break; - case Type::ParserError: - m_typeName = "Parser Error"; - break; - case Type::TypeError: - m_typeName = "Type Error"; - break; - case Type::Warning: - m_typeName = "Warning"; - break; - default: - solAssert(false, ""); - break; - } - } + explicit Error(Type _type); Type type() const { return m_type; } std::string const& typeName() const { return m_typeName; } - /// helper functions static Error const* containsErrorOfType(ErrorList const& _list, Error::Type _type) { diff --git a/libsolidity/Utils.h b/libsolidity/Utils.h index 05c5fa6f..48bb1e47 100644 --- a/libsolidity/Utils.h +++ b/libsolidity/Utils.h @@ -23,6 +23,15 @@ #pragma once #include +#include + +namespace dev +{ +namespace solidity +{ +struct InternalCompilerError; +} +} /// Assertion that throws an InternalCompilerError containing the given description if it is not met. #define solAssert(CONDITION, DESCRIPTION) \ diff --git a/solc/jsonCompiler.cpp b/solc/jsonCompiler.cpp index 1cf539e5..0746fc88 100644 --- a/solc/jsonCompiler.cpp +++ b/solc/jsonCompiler.cpp @@ -127,11 +127,14 @@ string compile(string _input, bool _optimize) { bool succ = compiler.compile(_input, _optimize); for (auto const& error: compiler.errors()) + { + auto err = dynamic_pointer_cast(error); errors.append(formatError( *error, - (dynamic_pointer_cast(error)) ? "Warning" : "Error", + (err->type() == Error::Type::Warning) ? "Warning" : "Error", compiler )); + } success = succ; // keep success false on exception } catch (Error const& error) diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 905b5ce1..01a65cd9 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -57,12 +57,11 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) if(!sourceUnit) return make_pair(sourceUnit, nullptr); - NameAndTypeResolver resolver({}, errors); + std::shared_ptr globalContext = make_shared(); + NameAndTypeResolver resolver(globalContext->declarations(), errors); solAssert(Error::containsOnlyWarnings(errors), ""); resolver.registerDeclarations(*sourceUnit); - std::shared_ptr globalContext = make_shared(); - NameAndTypeResolver resolver(globalContext->declarations()); resolver.registerDeclarations(*sourceUnit); for (ASTPointer const& node: sourceUnit->nodes()) @@ -81,7 +80,7 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) TypeChecker typeChecker(errors); bool success = typeChecker.checkTypeRequirements(*contract); - BOOST_CHECK(success || !typeChecker.errors().empty()); + BOOST_CHECK(success || !errors.empty()); for (auto const& currentError: errors) { @@ -1119,7 +1118,7 @@ BOOST_AUTO_TEST_CASE(anonymous_event_too_many_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d, uint indexed e) anonymous; })"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(event_call) @@ -1282,13 +1281,8 @@ BOOST_AUTO_TEST_CASE(empty_name_return_parameter_with_named_one) BOOST_AUTO_TEST_CASE(disallow_declaration_of_void_type) { -<<<<<<< HEAD char const* sourceCode = "contract c { function f() { var (x) = f(); } }"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(sourceCode), TypeError); -======= - char const* sourceCode = "contract c { function f() { var x = f(); } }"; BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); ->>>>>>> 2cd6509... errors instead of exceptions } BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) @@ -2353,8 +2347,6 @@ BOOST_AUTO_TEST_CASE(non_initialized_references) } )"; - auto b = parseAndAnalyseReturnErrorType(text, true); - (void)b; BOOST_CHECK(parseAndAnalyseReturnErrorType(text, true) == Error::Type::Warning); } @@ -2366,7 +2358,7 @@ BOOST_AUTO_TEST_CASE(sha3_with_large_integer_constant) function f() { sha3(2**500); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(cyclic_binary_dependency) @@ -2376,7 +2368,7 @@ BOOST_AUTO_TEST_CASE(cyclic_binary_dependency) contract B { function f() { new C(); } } contract C { function f() { new A(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(cyclic_binary_dependency_via_inheritance) @@ -2386,7 +2378,7 @@ BOOST_AUTO_TEST_CASE(cyclic_binary_dependency_via_inheritance) contract B { function f() { new C(); } } contract C { function f() { new A(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_fail) @@ -2394,7 +2386,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_fail) char const* text = R"( contract C { function f() { var (x,y); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fine) @@ -2425,7 +2417,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_1) function f() { var (a, b, ) = one(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_2) { @@ -2435,7 +2427,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_2) function f() { var (a, , ) = one(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_3) @@ -2446,7 +2438,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_3) function f() { var (, , a) = one(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_4) @@ -2457,7 +2449,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_4) function f() { var (, a, b) = one(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_5) @@ -2468,7 +2460,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_5) function f() { var (,) = one(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_6) @@ -2479,7 +2471,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_6) function f() { var (a, b, c) = two(); } } )"; - SOLIDITY_CHECK_ERROR_TYPE(parseAndAnalyseReturnError(text), TypeError); + BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_SUITE_END() diff --git a/test/libsolidity/SolidityParser.cpp b/test/libsolidity/SolidityParser.cpp index 0bc4d4ee..3147c034 100644 --- a/test/libsolidity/SolidityParser.cpp +++ b/test/libsolidity/SolidityParser.cpp @@ -997,7 +997,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration) function g() returns (uint, uint, uint) {} } )"; - BOOST_CHECK_NO_THROW(parseText(text)); + BOOST_CHECK(successParse(text)); } BOOST_AUTO_TEST_SUITE_END() -- cgit v1.2.3 From 0d0fd31fbf41ea7c2fe3923a645a012026f314d4 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 12:16:10 +0200 Subject: fix --- test/libsolidity/SolidityNameAndTypeResolution.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 01a65cd9..24f19143 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -62,8 +62,6 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) solAssert(Error::containsOnlyWarnings(errors), ""); resolver.registerDeclarations(*sourceUnit); - resolver.registerDeclarations(*sourceUnit); - for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { -- cgit v1.2.3 From 771f20b595ec081c128e3b99ec3794eff11a58a5 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 14:36:23 +0200 Subject: mainly style fixes/renaming --- libsolidity/Exceptions.cpp | 4 +- libsolidity/Exceptions.h | 2 +- libsolidity/NameAndTypeResolver.cpp | 12 +- libsolidity/Parser.cpp | 4 +- libsolidity/TypeChecker.cpp | 4 +- test/libsolidity/SolidityNameAndTypeResolution.cpp | 172 +++++++++++---------- test/libsolidity/SolidityParser.cpp | 2 +- 7 files changed, 105 insertions(+), 95 deletions(-) diff --git a/libsolidity/Exceptions.cpp b/libsolidity/Exceptions.cpp index 37d25697..96bb2e37 100644 --- a/libsolidity/Exceptions.cpp +++ b/libsolidity/Exceptions.cpp @@ -15,7 +15,7 @@ along with cpp-ethereum. If not, see . */ /** - * @author Christian + * @author Liana * @date 2015 * Solidity exception hierarchy. */ @@ -26,7 +26,7 @@ using namespace dev; using namespace dev::solidity; -Error::Error(Error::Type _type): m_type(_type) +Error::Error(Type _type): m_type(_type) { switch(m_type) { diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 9bc22994..59d69a27 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -36,7 +36,7 @@ using ErrorList = std::vector>; struct CompilerError: virtual Exception {}; struct InternalCompilerError: virtual Exception {}; -struct fatalError: virtual Exception {}; //todo rename to FatalError +struct FatalError: virtual Exception {}; class Error: virtual public Exception { diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index 934be0e3..dc82531f 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -49,7 +49,7 @@ bool NameAndTypeResolver::registerDeclarations(SourceUnit& _sourceUnit) { DeclarationRegistrationHelper registrar(m_scopes, _sourceUnit, m_errors); } - catch (fatalError) + catch (FatalError) { return false; } @@ -122,7 +122,7 @@ bool NameAndTypeResolver::resolveNamesAndTypes(ContractDefinition& _contract) ); } } - catch (fatalError const& _e) + catch (FatalError const& _e) { return false; } @@ -136,7 +136,7 @@ bool NameAndTypeResolver::updateDeclaration(Declaration const& _declaration) m_scopes[nullptr].registerDeclaration(_declaration, false, true); solAssert(_declaration.scope() == nullptr, "Updated declaration outside global scope."); } - catch(fatalError _error) + catch(FatalError _error) { return false; } @@ -317,7 +317,7 @@ void NameAndTypeResolver::reportFatalDeclarationError( ) { reportDeclarationError(_sourceLoction, _description); - BOOST_THROW_EXCEPTION(fatalError()); + BOOST_THROW_EXCEPTION(FatalError()); } void NameAndTypeResolver::reportTypeError(Error _e) @@ -328,7 +328,7 @@ void NameAndTypeResolver::reportTypeError(Error _e) void NameAndTypeResolver::reportFatalTypeError(Error _e) { reportTypeError(_e); - BOOST_THROW_EXCEPTION(fatalError()); + BOOST_THROW_EXCEPTION(FatalError()); } @@ -527,7 +527,7 @@ void DeclarationRegistrationHelper::fatalDeclarationError( ) { declarationError(_sourceLoction, _description); - BOOST_THROW_EXCEPTION(fatalError()); + BOOST_THROW_EXCEPTION(FatalError()); } } diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index 491af369..58632b85 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -87,7 +87,7 @@ ASTPointer Parser::parse(shared_ptr const& _scanner) } return nodeFactory.createNode(nodes); } - catch(fatalError const& _error) + catch(FatalError const& _error) { return nullptr; } @@ -1179,7 +1179,7 @@ void Parser::parserError(string const& _description) void Parser::fatalParserError(string const& _description) { parserError(_description); - BOOST_THROW_EXCEPTION(fatalError()); + BOOST_THROW_EXCEPTION(FatalError()); } } diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index 2e45f7b0..9ceb8203 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -36,7 +36,7 @@ bool TypeChecker::checkTypeRequirements(const ContractDefinition& _contract) { visit(_contract); } - catch (fatalError const&) + catch (FatalError const&) { // We got a fatal error which required to stop further type checking, but we can // continue normally from here. @@ -1268,5 +1268,5 @@ void TypeChecker::typeError(ASTNode const& _node, string const& _description) void TypeChecker::fatalTypeError(ASTNode const& _node, string const& _description) { typeError(_node, _description); - BOOST_THROW_EXCEPTION(fatalError()); + BOOST_THROW_EXCEPTION(FatalError()); } diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 24f19143..909ec303 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -101,13 +101,23 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) return make_pair(sourceUnit, nullptr); } -ASTPointer parseAndAnalyse(string const& _source) +ASTPointer createSourceUnit(string const& _source) { auto sourceAndError = parseAnalyseAndReturnError(_source); BOOST_REQUIRE(!!sourceAndError.first); + BOOST_REQUIRE(!sourceAndError.second); return sourceAndError.first; } +bool successResolving(std::string const& _source) +{ + auto sourceAndError = parseAnalyseAndReturnError(_source); + + if (sourceAndError.second && *sourceAndError.second == Error::Type::TypeError) + return false; + return true; +} + Error::Type parseAndAnalyseReturnErrorType(std::string const& _source, bool _warning = false) { auto sourceAndError = parseAnalyseAndReturnError(_source, _warning); @@ -146,7 +156,7 @@ BOOST_AUTO_TEST_CASE(smoke_test) " uint256 stateVariable1;\n" " function fun(uint256 arg1) { uint256 y; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(double_stateVariable_declaration) @@ -181,7 +191,7 @@ BOOST_AUTO_TEST_CASE(name_shadowing) " uint256 variable;\n" " function f() { uint32 variable ; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(name_references) @@ -190,7 +200,7 @@ BOOST_AUTO_TEST_CASE(name_references) " uint256 variable;\n" " function f(uint256 arg) returns (uint out) { f(variable); test; out; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(undeclared_name) @@ -208,7 +218,7 @@ BOOST_AUTO_TEST_CASE(reference_to_later_declaration) " function g() { f(); }" " function f() { }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(struct_definition_directly_recursive) @@ -245,7 +255,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_not_really_recursive) struct s2 { s1 x; s1 y; } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(struct_definition_recursion_via_mapping) @@ -257,7 +267,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_recursion_via_mapping) " mapping(uint => MyStructName1) x;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(type_inference_smoke_test) @@ -265,7 +275,7 @@ BOOST_AUTO_TEST_CASE(type_inference_smoke_test) char const* text = "contract test {\n" " function f(uint256 arg1, uint32 arg2) returns (bool ret) { var x = arg1 + arg2 == 8; ret = x; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(type_checking_return) @@ -273,7 +283,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return) char const* text = "contract test {\n" " function f() returns (bool r) { return 1 >= 2; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(type_checking_return_wrong_number) @@ -298,7 +308,7 @@ BOOST_AUTO_TEST_CASE(type_checking_function_call) " function f() returns (bool r) { return g(12, true) == 3; }\n" " function g(uint256 a, bool b) returns (uint256 r) { }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(type_conversion_for_comparison) @@ -306,7 +316,7 @@ BOOST_AUTO_TEST_CASE(type_conversion_for_comparison) char const* text = "contract test {\n" " function f() { uint32(2) == int64(2); }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(type_conversion_for_comparison_invalid) @@ -322,7 +332,7 @@ BOOST_AUTO_TEST_CASE(type_inference_explicit_conversion) char const* text = "contract test {\n" " function f() returns (int256 r) { var x = int256(uint32(2)); return x; }" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(large_string_literal) @@ -330,7 +340,7 @@ BOOST_AUTO_TEST_CASE(large_string_literal) char const* text = "contract test {\n" " function f() { var x = \"123456789012345678901234567890123\"; }" "}\n"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(balance) @@ -340,7 +350,7 @@ BOOST_AUTO_TEST_CASE(balance) " uint256 x = address(0).balance;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(balance_invalid) @@ -380,7 +390,7 @@ BOOST_AUTO_TEST_CASE(assignment_to_struct) " data = a;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(returns_in_constructor) @@ -404,7 +414,7 @@ BOOST_AUTO_TEST_CASE(forward_function_reference) " if (First(2).fun() == true) return 1;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(comparison_bitop_precedence) @@ -414,7 +424,7 @@ BOOST_AUTO_TEST_CASE(comparison_bitop_precedence) " return 1 & 2 == 8 & 9 && 1 ^ 2 < 4 | 6;\n" " }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(function_no_implementation) @@ -423,7 +433,7 @@ BOOST_AUTO_TEST_CASE(function_no_implementation) char const* text = "contract test {\n" " function functionName(bytes32 input) returns (bytes32 out);\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* contract = dynamic_cast(nodes[0].get()); BOOST_CHECK(contract); @@ -438,7 +448,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract) contract base { function foo(); } contract derived is base { function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* base = dynamic_cast(nodes[0].get()); ContractDefinition* derived = dynamic_cast(nodes[1].get()); @@ -457,7 +467,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_with_overload) contract base { function foo(bool); } contract derived is base { function foo(uint) {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* base = dynamic_cast(nodes[0].get()); ContractDefinition* derived = dynamic_cast(nodes[1].get()); @@ -491,7 +501,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_optional) function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(text), "Parsing and name resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(text), "Parsing and name resolving failed"); } BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_not_provided) @@ -505,7 +515,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_not_provided) function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name resolving failed"); std::vector> nodes = sourceUnit->nodes(); BOOST_CHECK_EQUAL(nodes.size(), 3); ContractDefinition* derived = dynamic_cast(nodes[2].get()); @@ -532,7 +542,7 @@ BOOST_AUTO_TEST_CASE(function_canonical_signature) " ret = arg1 + arg2;\n" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -549,7 +559,7 @@ BOOST_AUTO_TEST_CASE(function_canonical_signature_type_aliases) " ret = 5;\n" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -572,7 +582,7 @@ BOOST_AUTO_TEST_CASE(function_external_types) ret = 5; } })"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -594,7 +604,7 @@ BOOST_AUTO_TEST_CASE(enum_external_type) ret = 5; } })"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -616,7 +626,7 @@ BOOST_AUTO_TEST_CASE(function_external_call_allowed_conversion) } function g (C c) external {} })"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(function_external_call_not_allowed_conversion) @@ -646,7 +656,7 @@ BOOST_AUTO_TEST_CASE(function_internal_allowed_conversion) g(a); } })"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(function_internal_not_allowed_conversion) @@ -685,7 +695,7 @@ BOOST_AUTO_TEST_CASE(inheritance_basic) function f() { baseMember = 7; } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(inheritance_diamond_basic) @@ -698,7 +708,7 @@ BOOST_AUTO_TEST_CASE(inheritance_diamond_basic) function g() { f(); rootFunction(); } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(cyclic_inheritance) @@ -716,7 +726,7 @@ BOOST_AUTO_TEST_CASE(legal_override_direct) contract B { function f() {} } contract C is B { function f(uint i) {} } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(legal_override_indirect) @@ -726,7 +736,7 @@ BOOST_AUTO_TEST_CASE(legal_override_indirect) contract B { function f() {} } contract C is A, B { } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(illegal_override_visibility) @@ -754,7 +764,7 @@ BOOST_AUTO_TEST_CASE(complex_inheritance) contract B { function f() {} function g() returns (uint8 r) {} } contract C is A, B { } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(constructor_visibility) @@ -764,7 +774,7 @@ BOOST_AUTO_TEST_CASE(constructor_visibility) contract A { function A() { } } contract B is A { function f() { A x = A(0); } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(overriding_constructor) @@ -774,7 +784,7 @@ BOOST_AUTO_TEST_CASE(overriding_constructor) contract A { function A() { } } contract B is A { function A() returns (uint8 r) {} } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(missing_base_constructor_arguments) @@ -783,7 +793,7 @@ BOOST_AUTO_TEST_CASE(missing_base_constructor_arguments) contract A { function A(uint a) { } } contract B is A { } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(base_constructor_arguments_override) @@ -792,7 +802,7 @@ BOOST_AUTO_TEST_CASE(base_constructor_arguments_override) contract A { function A(uint a) { } } contract B is A { } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(implicit_derived_to_base_conversion) @@ -803,7 +813,7 @@ BOOST_AUTO_TEST_CASE(implicit_derived_to_base_conversion) function f() { A a = B(1); } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(implicit_base_to_derived_conversion) @@ -826,7 +836,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation) modifier mod2(bytes7 a) { while (a == "1234567") _ } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(invalid_function_modifier_type) @@ -849,7 +859,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation_parameters) modifier mod2(bytes7 a) { while (a == "1234567") _ } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(function_modifier_invocation_local_variables) @@ -860,7 +870,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation_local_variables) modifier mod(uint a) { if (a > 0) _ } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(legal_modifier_override) @@ -869,7 +879,7 @@ BOOST_AUTO_TEST_CASE(legal_modifier_override) contract A { modifier mod(uint a) {} } contract B is A { modifier mod(uint a) {} } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(illegal_modifier_override) @@ -923,7 +933,7 @@ BOOST_AUTO_TEST_CASE(state_variable_accessors) ASTPointer source; ContractDefinition const* contract; - ETH_TEST_CHECK_NO_THROW(source = parseAndAnalyse(text), "Parsing and Resolving names failed"); + ETH_TEST_CHECK_NO_THROW(source = createSourceUnit(text), "Parsing and Resolving names failed"); BOOST_REQUIRE((contract = retrieveContract(source, 0)) != nullptr); FunctionTypePointer function = retrieveFunctionBySignature(contract, "foo()"); BOOST_REQUIRE(function && function->hasDeclaration()); @@ -973,7 +983,7 @@ BOOST_AUTO_TEST_CASE(private_state_variable) ASTPointer source; ContractDefinition const* contract; - ETH_TEST_CHECK_NO_THROW(source = parseAndAnalyse(text), "Parsing and Resolving names failed"); + ETH_TEST_CHECK_NO_THROW(source = createSourceUnit(text), "Parsing and Resolving names failed"); BOOST_CHECK((contract = retrieveContract(source, 0)) != nullptr); FunctionTypePointer function; function = retrieveFunctionBySignature(contract, "foo()"); @@ -991,7 +1001,7 @@ BOOST_AUTO_TEST_CASE(base_class_state_variable_accessor) "contract Child is Parent{\n" " function foo() returns (uint256) { return Parent.m_aMember; }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(base_class_state_variable_internal_member) @@ -1002,7 +1012,7 @@ BOOST_AUTO_TEST_CASE(base_class_state_variable_internal_member) "contract Child is Parent{\n" " function foo() returns (uint256) { return Parent.m_aMember; }\n" "}\n"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class1) @@ -1042,7 +1052,7 @@ BOOST_AUTO_TEST_CASE(fallback_function) function() { x = 2; } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(fallback_function_with_arguments) @@ -1079,7 +1089,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_inheritance) function() { x = 2; } } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(event) @@ -1089,7 +1099,7 @@ BOOST_AUTO_TEST_CASE(event) event e(uint indexed a, bytes3 indexed s, bool indexed b); function f() { e(2, "abc", true); } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(event_too_many_indexed) @@ -1107,7 +1117,7 @@ BOOST_AUTO_TEST_CASE(anonymous_event_four_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d) anonymous; })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(anonymous_event_too_many_indexed) @@ -1126,7 +1136,7 @@ BOOST_AUTO_TEST_CASE(event_call) event e(uint a, bytes3 indexed s, bool indexed b); function f() { e(2, "abc", true); } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(event_inheritance) @@ -1138,7 +1148,7 @@ BOOST_AUTO_TEST_CASE(event_inheritance) contract c is base { function f() { e(2, "abc", true); } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(multiple_events_argument_clash) @@ -1148,7 +1158,7 @@ BOOST_AUTO_TEST_CASE(multiple_events_argument_clash) event e1(uint a, uint e1, uint e2); event e2(uint a, uint e1, uint e2); })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(access_to_default_function_visibility) @@ -1160,7 +1170,7 @@ BOOST_AUTO_TEST_CASE(access_to_default_function_visibility) contract d { function g() { c(0).f(); } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(access_to_internal_function) @@ -1196,7 +1206,7 @@ BOOST_AUTO_TEST_CASE(access_to_internal_state_variable) contract d { function g() { c(0).a(); } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(error_count_in_named_args) @@ -1242,7 +1252,7 @@ BOOST_AUTO_TEST_CASE(empty_name_input_parameter) function f(uint){ } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(empty_name_return_parameter) @@ -1252,7 +1262,7 @@ BOOST_AUTO_TEST_CASE(empty_name_return_parameter) function f() returns(bool){ } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(empty_name_input_parameter_with_named_one) @@ -1263,7 +1273,7 @@ BOOST_AUTO_TEST_CASE(empty_name_input_parameter_with_named_one) return k; } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(empty_name_return_parameter_with_named_one) @@ -1293,7 +1303,7 @@ BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) } uint256 a; })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(sourceCodeFine), + ETH_TEST_CHECK_NO_THROW(createSourceUnit(sourceCodeFine), "Parsing and Resolving names failed"); char const* sourceCode = R"( contract c { @@ -1336,7 +1346,7 @@ BOOST_AUTO_TEST_CASE(enum_member_access) ActionChoices choices; } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(enum_invalid_member_access) @@ -1368,7 +1378,7 @@ BOOST_AUTO_TEST_CASE(enum_explicit_conversion_is_okay) uint64 b; } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(int_to_enum_explicit_conversion_is_okay) @@ -1385,7 +1395,7 @@ BOOST_AUTO_TEST_CASE(int_to_enum_explicit_conversion_is_okay) ActionChoices b; } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(enum_implicit_conversion_is_not_okay) @@ -1505,7 +1515,7 @@ BOOST_AUTO_TEST_CASE(test_for_bug_override_function_with_bytearray_type) function f(bytes _a) external returns (uint256 r) {r = 42;} } )"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(sourceCode), "Parsing and Name Resolving failed"); + ETH_TEST_CHECK_NO_THROW(createSourceUnit(sourceCode), "Parsing and Name Resolving failed"); } BOOST_AUTO_TEST_CASE(array_with_nonconstant_length) @@ -1547,7 +1557,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_conversion_possible) uint8[] b; function f() { a = b; } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_static_dynamic) @@ -1558,7 +1568,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_static_dynamic) uint8[80] b; function f() { a = b; } })"; - ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(text), "Parsing and Name Resolving Failed"); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_dynamic_static) @@ -1702,7 +1712,7 @@ BOOST_AUTO_TEST_CASE(test_byte_is_alias_of_byte1) bytes arr; function f() { byte a = arr[0];} })"; - ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(text), "Type resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(text), "Type resolving failed"); } BOOST_AUTO_TEST_CASE(assigning_value_to_const_variable) @@ -1767,7 +1777,7 @@ BOOST_AUTO_TEST_CASE(assignment_of_nonoverloaded_function) function g() returns(uint) { var x = f; return x(7); } } )"; - ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(sourceCode), "Type resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(sourceCode), "Type resolving failed"); } BOOST_AUTO_TEST_CASE(assignment_of_overloaded_function) @@ -1849,7 +1859,7 @@ BOOST_AUTO_TEST_CASE(string) function f(string x) external { s = x; } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(string_index) @@ -1891,7 +1901,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_signed_min) int8 public i = -128; } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound) @@ -1911,7 +1921,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound_max) int8 public j = 127; } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(negative_integers_to_unsigned) @@ -1993,7 +2003,7 @@ BOOST_AUTO_TEST_CASE(storage_location_local_variables) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(no_mappings_in_memory_array) @@ -2063,7 +2073,7 @@ BOOST_AUTO_TEST_CASE(assignment_mem_storage_variable_directly) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(function_argument_mem_to_storage) @@ -2091,7 +2101,7 @@ BOOST_AUTO_TEST_CASE(function_argument_storage_to_mem) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(mem_array_assignment_changes_base_type) @@ -2145,7 +2155,7 @@ BOOST_AUTO_TEST_CASE(struct_constructor) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(struct_constructor_nested) @@ -2160,7 +2170,7 @@ BOOST_AUTO_TEST_CASE(struct_constructor_nested) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(struct_named_constructor) @@ -2173,7 +2183,7 @@ BOOST_AUTO_TEST_CASE(struct_named_constructor) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); + BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); } BOOST_AUTO_TEST_CASE(literal_strings) @@ -2186,7 +2196,7 @@ BOOST_AUTO_TEST_CASE(literal_strings) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(invalid_integer_literal_fraction) @@ -2242,7 +2252,7 @@ BOOST_AUTO_TEST_CASE(string_bytes_conversion) function m() internal { string(b); } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(inheriting_from_library) @@ -2276,7 +2286,7 @@ BOOST_AUTO_TEST_CASE(valid_library) char const* text = R"( library Lib { uint constant x = 9; } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(call_to_library_function) @@ -2292,7 +2302,7 @@ BOOST_AUTO_TEST_CASE(call_to_library_function) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(creating_contract_within_the_contract) @@ -2404,7 +2414,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fine) } } )"; - BOOST_CHECK_NO_THROW(parseAndAnalyse(text)); + BOOST_CHECK(successResolving(text)); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_1) diff --git a/test/libsolidity/SolidityParser.cpp b/test/libsolidity/SolidityParser.cpp index 3147c034..2482acff 100644 --- a/test/libsolidity/SolidityParser.cpp +++ b/test/libsolidity/SolidityParser.cpp @@ -60,7 +60,7 @@ bool successParse(std::string const& _source) if(!sourceUnit) return false; } - catch (fatalError const& _exception) + catch (FatalError const& _exception) { if (Error::containsErrorOfType(errors, Error::Type::ParserError)) return false; -- cgit v1.2.3 From cd6262998ccf3c712bb2af1981eeb943ccaf8094 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 15:16:31 +0200 Subject: removed commit --- libsolidity/CompilerStack.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/libsolidity/CompilerStack.cpp b/libsolidity/CompilerStack.cpp index dd7f7dfc..cfd01310 100644 --- a/libsolidity/CompilerStack.cpp +++ b/libsolidity/CompilerStack.cpp @@ -97,7 +97,6 @@ void CompilerStack::setSource(string const& _sourceCode) bool CompilerStack::parse() { - // todo not sure about clear. can contain warnings m_errors.clear(); for (auto& sourcePair: m_sources) -- cgit v1.2.3 From 68e126dc7d85854aa1458934122a725e99eb36e0 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:08:02 +0200 Subject: style fixes mostly --- libsolidity/CompilerStack.cpp | 6 ++++- libsolidity/Exceptions.h | 4 ++-- libsolidity/NameAndTypeResolver.cpp | 45 ++++++++++++++++++++++++------------- libsolidity/NameAndTypeResolver.h | 5 +++++ 4 files changed, 42 insertions(+), 18 deletions(-) diff --git a/libsolidity/CompilerStack.cpp b/libsolidity/CompilerStack.cpp index cfd01310..1165d6f6 100644 --- a/libsolidity/CompilerStack.cpp +++ b/libsolidity/CompilerStack.cpp @@ -97,7 +97,9 @@ void CompilerStack::setSource(string const& _sourceCode) bool CompilerStack::parse() { + //reset m_errors.clear(); + m_parseSuccessful = false; for (auto& sourcePair: m_sources) { @@ -114,7 +116,9 @@ bool CompilerStack::parse() bool success = true; NameAndTypeResolver resolver(m_globalContext->declarations(), m_errors); for (Source const* source: m_sourceOrder) - success = success && resolver.registerDeclarations(*source->ast); + if (!resolver.registerDeclarations(*source->ast)) + return false; + for (Source const* source: m_sourceOrder) for (ASTPointer const& node: source->ast->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) diff --git a/libsolidity/Exceptions.h b/libsolidity/Exceptions.h index 59d69a27..cda6b97e 100644 --- a/libsolidity/Exceptions.h +++ b/libsolidity/Exceptions.h @@ -60,7 +60,7 @@ public: { for (auto e: _list) { - if(e->type() == _type) + if (e->type() == _type) return e.get(); } return nullptr; @@ -69,7 +69,7 @@ public: { for (auto e: _list) { - if(e->type() != Type::Warning) + if (e->type() != Type::Warning) return false; } return true; diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index dc82531f..fc83403f 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -296,17 +296,25 @@ vector<_T const*> NameAndTypeResolver::cThreeMerge(list>& _toMer void NameAndTypeResolver::reportDeclarationError( SourceLocation _sourceLoction, string const& _description, - SourceLocation _secondarySourceLocation = SourceLocation(), - string const& _secondaryDescription = "" + SourceLocation _secondarySourceLocation, + string const& _secondaryDescription ) { auto err = make_shared(Error::Type::DeclarationError); // todo remove Error? *err << - errinfo_sourceLocation(_sourceLoction) << - errinfo_comment(_description) << - errinfo_secondarySourceLocation( - SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) - ); + errinfo_sourceLocation(_sourceLoction) << + errinfo_comment(_description) << + errinfo_secondarySourceLocation( + SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) + ); + + m_errors.push_back(err); +} + +void NameAndTypeResolver::reportDeclarationError(SourceLocation _sourceLoction, string const& _description) +{ + auto err = make_shared(Error::Type::DeclarationError); // todo remove Error? + *err << errinfo_sourceLocation(_sourceLoction) << errinfo_comment(_description); m_errors.push_back(err); } @@ -331,7 +339,6 @@ void NameAndTypeResolver::reportFatalTypeError(Error _e) BOOST_THROW_EXCEPTION(FatalError()); } - DeclarationRegistrationHelper::DeclarationRegistrationHelper( map& _scopes, ASTNode& _astRoot, @@ -506,17 +513,25 @@ string DeclarationRegistrationHelper::currentCanonicalName() const void DeclarationRegistrationHelper::declarationError( SourceLocation _sourceLoction, string const& _description, - SourceLocation _secondarySourceLocation = SourceLocation(), - string const& _secondaryDescription = "" + SourceLocation _secondarySourceLocation, + string const& _secondaryDescription ) { auto err = make_shared(Error::Type::DeclarationError); *err << - errinfo_sourceLocation(_sourceLoction) << - errinfo_comment(_description) << - errinfo_secondarySourceLocation( - SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) - ); + errinfo_sourceLocation(_sourceLoction) << + errinfo_comment(_description) << + errinfo_secondarySourceLocation( + SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) + ); + + m_errors.push_back(err); +} + +void DeclarationRegistrationHelper::declarationError(SourceLocation _sourceLoction, string const& _description) +{ + auto err = make_shared(Error::Type::DeclarationError); + *err << errinfo_sourceLocation(_sourceLoction) << errinfo_comment(_description); m_errors.push_back(err); } diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index 9587fcfe..6a196b47 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -100,6 +100,8 @@ private: SourceLocation _secondarySourceLocation, std::string const& _secondaryDescription ); + // creates the Declaration error and adds it in the errors list + void reportDeclarationError(SourceLocation _sourceLoction, std::string const& _description); // creates the Declaration error and adds it in the errors list and throws FatalError void reportFatalDeclarationError(SourceLocation _sourceLoction, std::string _description); @@ -151,6 +153,9 @@ private: SourceLocation _secondarySourceLocation, std::string const& _secondaryDescription ); + + // creates the Declaration error and adds it in the errors list + void declarationError(SourceLocation _sourceLoction, std::string const& _description); // creates the Declaration error and adds it in the errors list and throws FatalError void fatalDeclarationError(SourceLocation _sourceLoction, std::string const& _description); -- cgit v1.2.3 From 3871e77946866cdef36147ddd2e6d322f63cea37 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:13:52 +0200 Subject: style fixes --- libsolidity/NameAndTypeResolver.cpp | 22 +++++++++++----------- libsolidity/NameAndTypeResolver.h | 10 +++++----- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index fc83403f..88cd1e2e 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -311,20 +311,20 @@ void NameAndTypeResolver::reportDeclarationError( m_errors.push_back(err); } -void NameAndTypeResolver::reportDeclarationError(SourceLocation _sourceLoction, string const& _description) +void NameAndTypeResolver::reportDeclarationError(SourceLocation _sourceLocation, string const& _description) { auto err = make_shared(Error::Type::DeclarationError); // todo remove Error? - *err << errinfo_sourceLocation(_sourceLoction) << errinfo_comment(_description); + *err << errinfo_sourceLocation(_sourceLocation) << errinfo_comment(_description); m_errors.push_back(err); } void NameAndTypeResolver::reportFatalDeclarationError( - SourceLocation _sourceLoction, - string _description + SourceLocation _sourceLocation, + string const& _description ) { - reportDeclarationError(_sourceLoction, _description); + reportDeclarationError(_sourceLocation, _description); BOOST_THROW_EXCEPTION(FatalError()); } @@ -511,7 +511,7 @@ string DeclarationRegistrationHelper::currentCanonicalName() const } void DeclarationRegistrationHelper::declarationError( - SourceLocation _sourceLoction, + SourceLocation _sourceLocation, string const& _description, SourceLocation _secondarySourceLocation, string const& _secondaryDescription @@ -519,7 +519,7 @@ void DeclarationRegistrationHelper::declarationError( { auto err = make_shared(Error::Type::DeclarationError); *err << - errinfo_sourceLocation(_sourceLoction) << + errinfo_sourceLocation(_sourceLocation) << errinfo_comment(_description) << errinfo_secondarySourceLocation( SecondarySourceLocation().append(_secondaryDescription, _secondarySourceLocation) @@ -528,20 +528,20 @@ void DeclarationRegistrationHelper::declarationError( m_errors.push_back(err); } -void DeclarationRegistrationHelper::declarationError(SourceLocation _sourceLoction, string const& _description) +void DeclarationRegistrationHelper::declarationError(SourceLocation _sourceLocation, string const& _description) { auto err = make_shared(Error::Type::DeclarationError); - *err << errinfo_sourceLocation(_sourceLoction) << errinfo_comment(_description); + *err << errinfo_sourceLocation(_sourceLocation) << errinfo_comment(_description); m_errors.push_back(err); } void DeclarationRegistrationHelper::fatalDeclarationError( - SourceLocation _sourceLoction, + SourceLocation _sourceLocation, string const& _description ) { - declarationError(_sourceLoction, _description); + declarationError(_sourceLocation, _description); BOOST_THROW_EXCEPTION(FatalError()); } diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index 6a196b47..fd939de8 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -101,9 +101,9 @@ private: std::string const& _secondaryDescription ); // creates the Declaration error and adds it in the errors list - void reportDeclarationError(SourceLocation _sourceLoction, std::string const& _description); + void reportDeclarationError(SourceLocation _sourceLocation, std::string const& _description); // creates the Declaration error and adds it in the errors list and throws FatalError - void reportFatalDeclarationError(SourceLocation _sourceLoction, std::string _description); + void reportFatalDeclarationError(SourceLocation _sourceLocation, std::string const& _description); // creates the Declaration error and adds it in the errors list void reportTypeError(Error _e); @@ -148,16 +148,16 @@ private: std::string currentCanonicalName() const; // creates the Declaration error and adds it in the errors list void declarationError( - SourceLocation _sourceLoction, + SourceLocation _sourceLocation, std::string const& _description, SourceLocation _secondarySourceLocation, std::string const& _secondaryDescription ); // creates the Declaration error and adds it in the errors list - void declarationError(SourceLocation _sourceLoction, std::string const& _description); + void declarationError(SourceLocation _sourceLocation, std::string const& _description); // creates the Declaration error and adds it in the errors list and throws FatalError - void fatalDeclarationError(SourceLocation _sourceLoction, std::string const& _description); + void fatalDeclarationError(SourceLocation _sourceLocation, std::string const& _description); std::map& m_scopes; Declaration const* m_currentScope; -- cgit v1.2.3 From 162d021c3faf0fdb671778870c9da8ad74256b2e Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:27:26 +0200 Subject: some more style fixes --- libsolidity/NameAndTypeResolver.h | 6 +++--- libsolidity/Parser.cpp | 3 ++- libsolidity/Parser.h | 3 +-- libsolidity/TypeChecker.cpp | 15 +-------------- libsolidity/TypeChecker.h | 2 +- test/libsolidity/SolidityParser.cpp | 8 ++++---- test/libsolidity/solidityExecutionFramework.h | 4 ++-- 7 files changed, 14 insertions(+), 27 deletions(-) diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index fd939de8..4fe8dd8c 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -44,14 +44,14 @@ class NameAndTypeResolver: private boost::noncopyable public: NameAndTypeResolver(std::vector const& _globals, ErrorList& _errors); /// Registers all declarations found in the source unit. - /// @returns false in case of type error. + /// @returns false in case of error. bool registerDeclarations(SourceUnit& _sourceUnit); /// Resolves all names and types referenced from the given contract. - /// @returns false in case of type error. + /// @returns false in case of error. bool resolveNamesAndTypes(ContractDefinition& _contract); /// Updates the given global declaration (used for "this"). Not to be used with declarations /// that create their own scope. - /// @returns false in case of type error. + /// @returns false in case of error. bool updateDeclaration(Declaration const& _declaration); /// Resolves the given @a _name inside the scope @a _scope. If @a _scope is omitted, diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index 58632b85..47d1fb2f 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -66,7 +66,8 @@ private: ASTPointer Parser::parse(shared_ptr const& _scanner) { - try{ + try + { m_scanner = _scanner; ASTNodeFactory nodeFactory(*this); vector> nodes; diff --git a/libsolidity/Parser.h b/libsolidity/Parser.h index 3fc3768e..ee5be51c 100644 --- a/libsolidity/Parser.h +++ b/libsolidity/Parser.h @@ -34,8 +34,7 @@ class Scanner; class Parser { public: - Parser(ErrorList& errors): - m_errors(errors){}; + Parser(ErrorList& errors): m_errors(errors){}; ASTPointer parse(std::shared_ptr const& _scanner); std::shared_ptr const& sourceName() const; diff --git a/libsolidity/TypeChecker.cpp b/libsolidity/TypeChecker.cpp index 9ceb8203..ca5b1eb7 100644 --- a/libsolidity/TypeChecker.cpp +++ b/libsolidity/TypeChecker.cpp @@ -43,19 +43,7 @@ bool TypeChecker::checkTypeRequirements(const ContractDefinition& _contract) if (m_errors.empty()) throw; // Something is weird here, rather throw again. } - -return Error::containsOnlyWarnings(m_errors); -// bool success = true; -// for (auto const& it: m_errors) -// { -// auto e = dynamic_cast(it.get()); -// if (e->type() != Error::Type::Warning) -// { -// success = false; -// break; -// } -// } -// return success; + return Error::containsOnlyWarnings(m_errors); } TypePointer const& TypeChecker::type(Expression const& _expression) const @@ -72,7 +60,6 @@ TypePointer const& TypeChecker::type(VariableDeclaration const& _variable) const bool TypeChecker::visit(ContractDefinition const& _contract) { - // We force our own visiting order here. ASTNode::listAccept(_contract.definedStructs(), *this); ASTNode::listAccept(_contract.baseContracts(), *this); diff --git a/libsolidity/TypeChecker.h b/libsolidity/TypeChecker.h index de095e3b..d9cb39ae 100644 --- a/libsolidity/TypeChecker.h +++ b/libsolidity/TypeChecker.h @@ -42,7 +42,7 @@ namespace solidity class TypeChecker: private ASTConstVisitor { public: - /// @_errors the reference to the list of errors and warnings to add them found during type checking. + /// @param _errors the reference to the list of errors and warnings to add them found during type checking. TypeChecker(ErrorList& _errors): m_errors(_errors) {} /// Performs type checking on the given contract and all of its sub-nodes. diff --git a/test/libsolidity/SolidityParser.cpp b/test/libsolidity/SolidityParser.cpp index 2482acff..35393811 100644 --- a/test/libsolidity/SolidityParser.cpp +++ b/test/libsolidity/SolidityParser.cpp @@ -42,7 +42,7 @@ namespace ASTPointer parseText(std::string const& _source, ErrorList& _errors) { ASTPointer sourceUnit = Parser(_errors).parse(std::make_shared(CharStream(_source))); - if(!sourceUnit) + if (!sourceUnit) return ASTPointer(); for (ASTPointer const& node: sourceUnit->nodes()) if (ASTPointer contract = dynamic_pointer_cast(node)) @@ -57,7 +57,7 @@ bool successParse(std::string const& _source) try { auto sourceUnit = parseText(_source, errors); - if(!sourceUnit) + if (!sourceUnit) return false; } catch (FatalError const& _exception) @@ -68,6 +68,7 @@ bool successParse(std::string const& _source) if (Error::containsErrorOfType(errors, Error::Type::ParserError)) return false; + BOOST_CHECK(Error::containsOnlyWarnings(errors)); return true; } @@ -168,7 +169,6 @@ BOOST_AUTO_TEST_CASE(two_exact_functions) // with support of overloaded functions, during parsing, // we can't determine whether they match exactly, however // it will throw DeclarationError in following stage. - // TODO add test to the SolidityNameAndTypeDeclaration BOOST_CHECK(successParse(text)); } @@ -848,7 +848,7 @@ BOOST_AUTO_TEST_CASE(external_variable) BOOST_CHECK(!successParse(text)); } -BOOST_AUTO_TEST_CASE(arrays_in_storagze) +BOOST_AUTO_TEST_CASE(arrays_in_storage) { char const* text = R"( contract c { diff --git a/test/libsolidity/solidityExecutionFramework.h b/test/libsolidity/solidityExecutionFramework.h index 27dd4fb7..82fede84 100644 --- a/test/libsolidity/solidityExecutionFramework.h +++ b/test/libsolidity/solidityExecutionFramework.h @@ -77,12 +77,12 @@ public: m_compiler.compile(m_optimize, m_optimizeRuns); BOOST_REQUIRE(Error::containsErrorOfType(m_compiler.errors(), _type)); } - catch(Error const& _e) + catch (Error const& _e) { BOOST_REQUIRE(_e.type() == _type); foundError = true; } - catch(Exception const& _exception) + catch (Exception const& _exception) { BOOST_REQUIRE(false); } -- cgit v1.2.3 From 292fb473bf125ed513e1a12a70d162ebd055e380 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:46:02 +0200 Subject: renaming in test framework --- test/libsolidity/SolidityNameAndTypeResolution.cpp | 390 ++++++++++----------- 1 file changed, 195 insertions(+), 195 deletions(-) diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 909ec303..2558ba97 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -101,7 +101,7 @@ parseAnalyseAndReturnError(string const& _source, bool _reportWarnings = false) return make_pair(sourceUnit, nullptr); } -ASTPointer createSourceUnit(string const& _source) +ASTPointer parseAndAnalyse(string const& _source) { auto sourceAndError = parseAnalyseAndReturnError(_source); BOOST_REQUIRE(!!sourceAndError.first); @@ -109,7 +109,7 @@ ASTPointer createSourceUnit(string const& _source) return sourceAndError.first; } -bool successResolving(std::string const& _source) +bool success(std::string const& _source) { auto sourceAndError = parseAnalyseAndReturnError(_source); @@ -118,7 +118,7 @@ bool successResolving(std::string const& _source) return true; } -Error::Type parseAndAnalyseReturnErrorType(std::string const& _source, bool _warning = false) +Error::Type expectError(std::string const& _source, bool _warning = false) { auto sourceAndError = parseAnalyseAndReturnError(_source, _warning); BOOST_REQUIRE(!!sourceAndError.second); @@ -156,7 +156,7 @@ BOOST_AUTO_TEST_CASE(smoke_test) " uint256 stateVariable1;\n" " function fun(uint256 arg1) { uint256 y; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(double_stateVariable_declaration) @@ -165,7 +165,7 @@ BOOST_AUTO_TEST_CASE(double_stateVariable_declaration) " uint256 variable;\n" " uint128 variable;\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(double_function_declaration) @@ -174,7 +174,7 @@ BOOST_AUTO_TEST_CASE(double_function_declaration) " function fun() { uint x; }\n" " function fun() { uint x; }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(double_variable_declaration) @@ -182,7 +182,7 @@ BOOST_AUTO_TEST_CASE(double_variable_declaration) char const* text = "contract test {\n" " function f() { uint256 x; if (true) { uint256 x; } }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(name_shadowing) @@ -191,7 +191,7 @@ BOOST_AUTO_TEST_CASE(name_shadowing) " uint256 variable;\n" " function f() { uint32 variable ; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(name_references) @@ -200,7 +200,7 @@ BOOST_AUTO_TEST_CASE(name_references) " uint256 variable;\n" " function f(uint256 arg) returns (uint out) { f(variable); test; out; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(undeclared_name) @@ -209,7 +209,7 @@ BOOST_AUTO_TEST_CASE(undeclared_name) " uint256 variable;\n" " function f(uint256 arg) { f(notfound); }" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(reference_to_later_declaration) @@ -218,7 +218,7 @@ BOOST_AUTO_TEST_CASE(reference_to_later_declaration) " function g() { f(); }" " function f() { }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(struct_definition_directly_recursive) @@ -229,7 +229,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_directly_recursive) " MyStructName x;\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_definition_indirectly_recursive) @@ -244,7 +244,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_indirectly_recursive) " MyStructName1 x;\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_definition_not_really_recursive) @@ -255,7 +255,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_not_really_recursive) struct s2 { s1 x; s1 y; } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(struct_definition_recursion_via_mapping) @@ -267,7 +267,7 @@ BOOST_AUTO_TEST_CASE(struct_definition_recursion_via_mapping) " mapping(uint => MyStructName1) x;\n" " }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(type_inference_smoke_test) @@ -275,7 +275,7 @@ BOOST_AUTO_TEST_CASE(type_inference_smoke_test) char const* text = "contract test {\n" " function f(uint256 arg1, uint32 arg2) returns (bool ret) { var x = arg1 + arg2 == 8; ret = x; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(type_checking_return) @@ -283,7 +283,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return) char const* text = "contract test {\n" " function f() returns (bool r) { return 1 >= 2; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(type_checking_return_wrong_number) @@ -291,7 +291,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return_wrong_number) char const* text = "contract test {\n" " function f() returns (bool r1, bool r2) { return 1 >= 2; }" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_checking_return_wrong_type) @@ -299,7 +299,7 @@ BOOST_AUTO_TEST_CASE(type_checking_return_wrong_type) char const* text = "contract test {\n" " function f() returns (uint256 r) { return 1 >= 2; }" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_checking_function_call) @@ -308,7 +308,7 @@ BOOST_AUTO_TEST_CASE(type_checking_function_call) " function f() returns (bool r) { return g(12, true) == 3; }\n" " function g(uint256 a, bool b) returns (uint256 r) { }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(type_conversion_for_comparison) @@ -316,7 +316,7 @@ BOOST_AUTO_TEST_CASE(type_conversion_for_comparison) char const* text = "contract test {\n" " function f() { uint32(2) == int64(2); }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(type_conversion_for_comparison_invalid) @@ -324,7 +324,7 @@ BOOST_AUTO_TEST_CASE(type_conversion_for_comparison_invalid) char const* text = "contract test {\n" " function f() { int32(2) == uint64(2); }" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(type_inference_explicit_conversion) @@ -332,7 +332,7 @@ BOOST_AUTO_TEST_CASE(type_inference_explicit_conversion) char const* text = "contract test {\n" " function f() returns (int256 r) { var x = int256(uint32(2)); return x; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(large_string_literal) @@ -340,7 +340,7 @@ BOOST_AUTO_TEST_CASE(large_string_literal) char const* text = "contract test {\n" " function f() { var x = \"123456789012345678901234567890123\"; }" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(balance) @@ -350,7 +350,7 @@ BOOST_AUTO_TEST_CASE(balance) " uint256 x = address(0).balance;\n" " }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(balance_invalid) @@ -360,7 +360,7 @@ BOOST_AUTO_TEST_CASE(balance_invalid) " address(0).balance = 7;\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_to_mapping) @@ -375,7 +375,7 @@ BOOST_AUTO_TEST_CASE(assignment_to_mapping) " data.map = a;\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_to_struct) @@ -390,7 +390,7 @@ BOOST_AUTO_TEST_CASE(assignment_to_struct) " data = a;\n" " }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(returns_in_constructor) @@ -399,7 +399,7 @@ BOOST_AUTO_TEST_CASE(returns_in_constructor) " function test() returns (uint a) {\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(forward_function_reference) @@ -414,7 +414,7 @@ BOOST_AUTO_TEST_CASE(forward_function_reference) " if (First(2).fun() == true) return 1;\n" " }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(comparison_bitop_precedence) @@ -424,7 +424,7 @@ BOOST_AUTO_TEST_CASE(comparison_bitop_precedence) " return 1 & 2 == 8 & 9 && 1 ^ 2 < 4 | 6;\n" " }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(function_no_implementation) @@ -433,7 +433,7 @@ BOOST_AUTO_TEST_CASE(function_no_implementation) char const* text = "contract test {\n" " function functionName(bytes32 input) returns (bytes32 out);\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* contract = dynamic_cast(nodes[0].get()); BOOST_CHECK(contract); @@ -448,7 +448,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract) contract base { function foo(); } contract derived is base { function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* base = dynamic_cast(nodes[0].get()); ContractDefinition* derived = dynamic_cast(nodes[1].get()); @@ -467,7 +467,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_with_overload) contract base { function foo(bool); } contract derived is base { function foo(uint) {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); std::vector> nodes = sourceUnit->nodes(); ContractDefinition* base = dynamic_cast(nodes[0].get()); ContractDefinition* derived = dynamic_cast(nodes[1].get()); @@ -487,7 +487,7 @@ BOOST_AUTO_TEST_CASE(create_abstract_contract) function foo() { b = new base();} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_optional) @@ -501,7 +501,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_optional) function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(text), "Parsing and name resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(text), "Parsing and name resolving failed"); } BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_not_provided) @@ -515,7 +515,7 @@ BOOST_AUTO_TEST_CASE(abstract_contract_constructor_args_not_provided) function foo() {} } )"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name resolving failed"); std::vector> nodes = sourceUnit->nodes(); BOOST_CHECK_EQUAL(nodes.size(), 3); ContractDefinition* derived = dynamic_cast(nodes[2].get()); @@ -531,7 +531,7 @@ BOOST_AUTO_TEST_CASE(redeclare_implemented_abstract_function_as_abstract) contract derived is base { function foo() {} } contract wrong is derived { function foo(); } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_canonical_signature) @@ -542,7 +542,7 @@ BOOST_AUTO_TEST_CASE(function_canonical_signature) " ret = arg1 + arg2;\n" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -559,7 +559,7 @@ BOOST_AUTO_TEST_CASE(function_canonical_signature_type_aliases) " ret = 5;\n" " }\n" "}\n"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -582,7 +582,7 @@ BOOST_AUTO_TEST_CASE(function_external_types) ret = 5; } })"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -604,7 +604,7 @@ BOOST_AUTO_TEST_CASE(enum_external_type) ret = 5; } })"; - ETH_TEST_REQUIRE_NO_THROW(sourceUnit = createSourceUnit(text), "Parsing and name Resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseAndAnalyse(text), "Parsing and name Resolving failed"); for (ASTPointer const& node: sourceUnit->nodes()) if (ContractDefinition* contract = dynamic_cast(node.get())) { @@ -626,7 +626,7 @@ BOOST_AUTO_TEST_CASE(function_external_call_allowed_conversion) } function g (C c) external {} })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(function_external_call_not_allowed_conversion) @@ -640,7 +640,7 @@ BOOST_AUTO_TEST_CASE(function_external_call_not_allowed_conversion) } function g (C c) external {} })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_internal_allowed_conversion) @@ -656,7 +656,7 @@ BOOST_AUTO_TEST_CASE(function_internal_allowed_conversion) g(a); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(function_internal_not_allowed_conversion) @@ -672,7 +672,7 @@ BOOST_AUTO_TEST_CASE(function_internal_not_allowed_conversion) g(a); } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(hash_collision_in_interface) @@ -683,7 +683,7 @@ BOOST_AUTO_TEST_CASE(hash_collision_in_interface) " function tgeo() {\n" " }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(inheritance_basic) @@ -695,7 +695,7 @@ BOOST_AUTO_TEST_CASE(inheritance_basic) function f() { baseMember = 7; } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(inheritance_diamond_basic) @@ -708,7 +708,7 @@ BOOST_AUTO_TEST_CASE(inheritance_diamond_basic) function g() { f(); rootFunction(); } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(cyclic_inheritance) @@ -717,7 +717,7 @@ BOOST_AUTO_TEST_CASE(cyclic_inheritance) contract A is B { } contract B is A { } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(legal_override_direct) @@ -726,7 +726,7 @@ BOOST_AUTO_TEST_CASE(legal_override_direct) contract B { function f() {} } contract C is B { function f(uint i) {} } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(legal_override_indirect) @@ -736,7 +736,7 @@ BOOST_AUTO_TEST_CASE(legal_override_indirect) contract B { function f() {} } contract C is A, B { } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(illegal_override_visibility) @@ -745,7 +745,7 @@ BOOST_AUTO_TEST_CASE(illegal_override_visibility) contract B { function f() internal {} } contract C is B { function f() public {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(illegal_override_constness) @@ -754,7 +754,7 @@ BOOST_AUTO_TEST_CASE(illegal_override_constness) contract B { function f() constant {} } contract C is B { function f() {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(complex_inheritance) @@ -764,7 +764,7 @@ BOOST_AUTO_TEST_CASE(complex_inheritance) contract B { function f() {} function g() returns (uint8 r) {} } contract C is A, B { } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(constructor_visibility) @@ -774,7 +774,7 @@ BOOST_AUTO_TEST_CASE(constructor_visibility) contract A { function A() { } } contract B is A { function f() { A x = A(0); } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(overriding_constructor) @@ -784,7 +784,7 @@ BOOST_AUTO_TEST_CASE(overriding_constructor) contract A { function A() { } } contract B is A { function A() returns (uint8 r) {} } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(missing_base_constructor_arguments) @@ -793,7 +793,7 @@ BOOST_AUTO_TEST_CASE(missing_base_constructor_arguments) contract A { function A(uint a) { } } contract B is A { } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(base_constructor_arguments_override) @@ -802,7 +802,7 @@ BOOST_AUTO_TEST_CASE(base_constructor_arguments_override) contract A { function A(uint a) { } } contract B is A { } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(implicit_derived_to_base_conversion) @@ -813,7 +813,7 @@ BOOST_AUTO_TEST_CASE(implicit_derived_to_base_conversion) function f() { A a = B(1); } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(implicit_base_to_derived_conversion) @@ -824,7 +824,7 @@ BOOST_AUTO_TEST_CASE(implicit_base_to_derived_conversion) function f() { B b = A(1); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_modifier_invocation) @@ -836,7 +836,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation) modifier mod2(bytes7 a) { while (a == "1234567") _ } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(invalid_function_modifier_type) @@ -847,7 +847,7 @@ BOOST_AUTO_TEST_CASE(invalid_function_modifier_type) modifier mod1(uint a) { if (a > 0) _ } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_modifier_invocation_parameters) @@ -859,7 +859,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation_parameters) modifier mod2(bytes7 a) { while (a == "1234567") _ } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(function_modifier_invocation_local_variables) @@ -870,7 +870,7 @@ BOOST_AUTO_TEST_CASE(function_modifier_invocation_local_variables) modifier mod(uint a) { if (a > 0) _ } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(legal_modifier_override) @@ -879,7 +879,7 @@ BOOST_AUTO_TEST_CASE(legal_modifier_override) contract A { modifier mod(uint a) {} } contract B is A { modifier mod(uint a) {} } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(illegal_modifier_override) @@ -888,7 +888,7 @@ BOOST_AUTO_TEST_CASE(illegal_modifier_override) contract A { modifier mod(uint a) {} } contract B is A { modifier mod(uint8 a) {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(modifier_overrides_function) @@ -897,7 +897,7 @@ BOOST_AUTO_TEST_CASE(modifier_overrides_function) contract A { modifier mod(uint a) {} } contract B is A { function mod(uint a) {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_overrides_modifier) @@ -906,7 +906,7 @@ BOOST_AUTO_TEST_CASE(function_overrides_modifier) contract A { function mod(uint a) {} } contract B is A { modifier mod(uint a) {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(modifier_returns_value) @@ -917,7 +917,7 @@ BOOST_AUTO_TEST_CASE(modifier_returns_value) modifier mod(uint a) { return 7; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(state_variable_accessors) @@ -933,7 +933,7 @@ BOOST_AUTO_TEST_CASE(state_variable_accessors) ASTPointer source; ContractDefinition const* contract; - ETH_TEST_CHECK_NO_THROW(source = createSourceUnit(text), "Parsing and Resolving names failed"); + ETH_TEST_CHECK_NO_THROW(source = parseAndAnalyse(text), "Parsing and Resolving names failed"); BOOST_REQUIRE((contract = retrieveContract(source, 0)) != nullptr); FunctionTypePointer function = retrieveFunctionBySignature(contract, "foo()"); BOOST_REQUIRE(function && function->hasDeclaration()); @@ -968,7 +968,7 @@ BOOST_AUTO_TEST_CASE(function_clash_with_state_variable_accessor) "uint256 foo;\n" " function foo() {}\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_state_variable) @@ -983,7 +983,7 @@ BOOST_AUTO_TEST_CASE(private_state_variable) ASTPointer source; ContractDefinition const* contract; - ETH_TEST_CHECK_NO_THROW(source = createSourceUnit(text), "Parsing and Resolving names failed"); + ETH_TEST_CHECK_NO_THROW(source = parseAndAnalyse(text), "Parsing and Resolving names failed"); BOOST_CHECK((contract = retrieveContract(source, 0)) != nullptr); FunctionTypePointer function; function = retrieveFunctionBySignature(contract, "foo()"); @@ -1001,7 +1001,7 @@ BOOST_AUTO_TEST_CASE(base_class_state_variable_accessor) "contract Child is Parent{\n" " function foo() returns (uint256) { return Parent.m_aMember; }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(base_class_state_variable_internal_member) @@ -1012,7 +1012,7 @@ BOOST_AUTO_TEST_CASE(base_class_state_variable_internal_member) "contract Child is Parent{\n" " function foo() returns (uint256) { return Parent.m_aMember; }\n" "}\n"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class1) @@ -1026,7 +1026,7 @@ BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class1) "contract Child is Parent2{\n" " function foo() returns (uint256) { return Parent2.m_aMember1; }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class2) @@ -1041,7 +1041,7 @@ BOOST_AUTO_TEST_CASE(state_variable_member_of_wrong_class2) " function foo() returns (uint256) { return Child.m_aMember2; }\n" " uint256 public m_aMember3;\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(fallback_function) @@ -1052,7 +1052,7 @@ BOOST_AUTO_TEST_CASE(fallback_function) function() { x = 2; } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(fallback_function_with_arguments) @@ -1063,7 +1063,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_with_arguments) function(uint a) { x = 2; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(fallback_function_twice) @@ -1075,7 +1075,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_twice) function() { x = 3; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(fallback_function_inheritance) @@ -1089,7 +1089,7 @@ BOOST_AUTO_TEST_CASE(fallback_function_inheritance) function() { x = 2; } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(event) @@ -1099,7 +1099,7 @@ BOOST_AUTO_TEST_CASE(event) event e(uint indexed a, bytes3 indexed s, bool indexed b); function f() { e(2, "abc", true); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(event_too_many_indexed) @@ -1108,7 +1108,7 @@ BOOST_AUTO_TEST_CASE(event_too_many_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d); })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(anonymous_event_four_indexed) @@ -1117,7 +1117,7 @@ BOOST_AUTO_TEST_CASE(anonymous_event_four_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d) anonymous; })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(anonymous_event_too_many_indexed) @@ -1126,7 +1126,7 @@ BOOST_AUTO_TEST_CASE(anonymous_event_too_many_indexed) contract c { event e(uint indexed a, bytes3 indexed b, bool indexed c, uint indexed d, uint indexed e) anonymous; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(event_call) @@ -1136,7 +1136,7 @@ BOOST_AUTO_TEST_CASE(event_call) event e(uint a, bytes3 indexed s, bool indexed b); function f() { e(2, "abc", true); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(event_inheritance) @@ -1148,7 +1148,7 @@ BOOST_AUTO_TEST_CASE(event_inheritance) contract c is base { function f() { e(2, "abc", true); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(multiple_events_argument_clash) @@ -1158,7 +1158,7 @@ BOOST_AUTO_TEST_CASE(multiple_events_argument_clash) event e1(uint a, uint e1, uint e2); event e2(uint a, uint e1, uint e2); })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(access_to_default_function_visibility) @@ -1170,7 +1170,7 @@ BOOST_AUTO_TEST_CASE(access_to_default_function_visibility) contract d { function g() { c(0).f(); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(access_to_internal_function) @@ -1182,7 +1182,7 @@ BOOST_AUTO_TEST_CASE(access_to_internal_function) contract d { function g() { c(0).f(); } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(access_to_default_state_variable_visibility) @@ -1194,7 +1194,7 @@ BOOST_AUTO_TEST_CASE(access_to_default_state_variable_visibility) contract d { function g() { c(0).a(); } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(access_to_internal_state_variable) @@ -1206,7 +1206,7 @@ BOOST_AUTO_TEST_CASE(access_to_internal_state_variable) contract d { function g() { c(0).a(); } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(error_count_in_named_args) @@ -1215,7 +1215,7 @@ BOOST_AUTO_TEST_CASE(error_count_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1}); }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(empty_in_named_args) @@ -1224,7 +1224,7 @@ BOOST_AUTO_TEST_CASE(empty_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({}); }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(duplicate_parameter_names_in_named_args) @@ -1233,7 +1233,7 @@ BOOST_AUTO_TEST_CASE(duplicate_parameter_names_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1, a: 2}); }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(invalid_parameter_names_in_named_args) @@ -1242,7 +1242,7 @@ BOOST_AUTO_TEST_CASE(invalid_parameter_names_in_named_args) " function a(uint a, uint b) returns (uint r) { r = a + b; }\n" " function b() returns (uint r) { r = a({a: 1, c: 2}); }\n" "}\n"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(empty_name_input_parameter) @@ -1252,7 +1252,7 @@ BOOST_AUTO_TEST_CASE(empty_name_input_parameter) function f(uint){ } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(empty_name_return_parameter) @@ -1262,7 +1262,7 @@ BOOST_AUTO_TEST_CASE(empty_name_return_parameter) function f() returns(bool){ } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(empty_name_input_parameter_with_named_one) @@ -1273,7 +1273,7 @@ BOOST_AUTO_TEST_CASE(empty_name_input_parameter_with_named_one) return k; } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(empty_name_return_parameter_with_named_one) @@ -1284,13 +1284,13 @@ BOOST_AUTO_TEST_CASE(empty_name_return_parameter_with_named_one) return 5; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(disallow_declaration_of_void_type) { char const* sourceCode = "contract c { function f() { var (x) = f(); } }"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) @@ -1303,7 +1303,7 @@ BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) } uint256 a; })"; - ETH_TEST_CHECK_NO_THROW(createSourceUnit(sourceCodeFine), + ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(sourceCodeFine), "Parsing and Resolving names failed"); char const* sourceCode = R"( contract c { @@ -1313,7 +1313,7 @@ BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) } uint256 a; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(exp_operator_negative_exponent) @@ -1322,7 +1322,7 @@ BOOST_AUTO_TEST_CASE(exp_operator_negative_exponent) contract test { function f() returns(uint d) { return 2 ** -3; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(exp_operator_exponent_too_big) @@ -1331,7 +1331,7 @@ BOOST_AUTO_TEST_CASE(exp_operator_exponent_too_big) contract test { function f() returns(uint d) { return 2 ** 10000000000; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_member_access) @@ -1346,7 +1346,7 @@ BOOST_AUTO_TEST_CASE(enum_member_access) ActionChoices choices; } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(enum_invalid_member_access) @@ -1361,7 +1361,7 @@ BOOST_AUTO_TEST_CASE(enum_invalid_member_access) ActionChoices choices; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_explicit_conversion_is_okay) @@ -1378,7 +1378,7 @@ BOOST_AUTO_TEST_CASE(enum_explicit_conversion_is_okay) uint64 b; } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(int_to_enum_explicit_conversion_is_okay) @@ -1395,7 +1395,7 @@ BOOST_AUTO_TEST_CASE(int_to_enum_explicit_conversion_is_okay) ActionChoices b; } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(enum_implicit_conversion_is_not_okay) @@ -1412,7 +1412,7 @@ BOOST_AUTO_TEST_CASE(enum_implicit_conversion_is_not_okay) uint64 b; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(enum_duplicate_values) @@ -1422,7 +1422,7 @@ BOOST_AUTO_TEST_CASE(enum_duplicate_values) enum ActionChoices { GoLeft, GoRight, GoLeft, Sit } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(text) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_visibility) @@ -1435,7 +1435,7 @@ BOOST_AUTO_TEST_CASE(private_visibility) function g() { f(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(private_visibility_via_explicit_base_access) @@ -1448,7 +1448,7 @@ BOOST_AUTO_TEST_CASE(private_visibility_via_explicit_base_access) function g() { base.f(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_visibility) @@ -1459,7 +1459,7 @@ BOOST_AUTO_TEST_CASE(external_visibility) function g() { f(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(external_base_visibility) @@ -1472,7 +1472,7 @@ BOOST_AUTO_TEST_CASE(external_base_visibility) function g() { base.f(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_assign) @@ -1482,7 +1482,7 @@ BOOST_AUTO_TEST_CASE(external_argument_assign) function f(uint a) external { a = 1; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_increment) @@ -1492,7 +1492,7 @@ BOOST_AUTO_TEST_CASE(external_argument_increment) function f(uint a) external { a++; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_argument_delete) @@ -1502,7 +1502,7 @@ BOOST_AUTO_TEST_CASE(external_argument_delete) function f(uint a) external { delete a; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(test_for_bug_override_function_with_bytearray_type) @@ -1515,7 +1515,7 @@ BOOST_AUTO_TEST_CASE(test_for_bug_override_function_with_bytearray_type) function f(bytes _a) external returns (uint256 r) {r = 42;} } )"; - ETH_TEST_CHECK_NO_THROW(createSourceUnit(sourceCode), "Parsing and Name Resolving failed"); + ETH_TEST_CHECK_NO_THROW(parseAndAnalyse(sourceCode), "Parsing and Name Resolving failed"); } BOOST_AUTO_TEST_CASE(array_with_nonconstant_length) @@ -1524,7 +1524,7 @@ BOOST_AUTO_TEST_CASE(array_with_nonconstant_length) contract c { function f(uint a) { uint8[a] x; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types1) @@ -1535,7 +1535,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types1) uint[] b; function f() { b = a; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types2) @@ -1546,7 +1546,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types2) uint8[] b; function f() { b = a; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_conversion_possible) @@ -1557,7 +1557,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_conversion_possible) uint8[] b; function f() { a = b; } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_static_dynamic) @@ -1568,7 +1568,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_static_dynamic) uint8[80] b; function f() { a = b; } })"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(array_copy_with_different_types_dynamic_static) @@ -1579,7 +1579,7 @@ BOOST_AUTO_TEST_CASE(array_copy_with_different_types_dynamic_static) uint[80] b; function f() { b = a; } })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_int) @@ -1588,7 +1588,7 @@ BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_int) contract c { uint8 a = 1000; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_string) @@ -1597,7 +1597,7 @@ BOOST_AUTO_TEST_CASE(storage_variable_initialization_with_incorrect_type_string) contract c { uint a = "abc"; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(test_fromElementaryTypeName) @@ -1712,7 +1712,7 @@ BOOST_AUTO_TEST_CASE(test_byte_is_alias_of_byte1) bytes arr; function f() { byte a = arr[0];} })"; - ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(text), "Type resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(text), "Type resolving failed"); } BOOST_AUTO_TEST_CASE(assigning_value_to_const_variable) @@ -1722,7 +1722,7 @@ BOOST_AUTO_TEST_CASE(assigning_value_to_const_variable) function changeIt() { x = 9; } uint constant x = 56; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(complex_const_variable) @@ -1732,7 +1732,7 @@ BOOST_AUTO_TEST_CASE(complex_const_variable) contract Foo { mapping(uint => bool) constant mapVar; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(uninitialized_const_variable) @@ -1741,7 +1741,7 @@ BOOST_AUTO_TEST_CASE(uninitialized_const_variable) contract Foo { uint constant y; })"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overloaded_function_cannot_resolve) @@ -1753,7 +1753,7 @@ BOOST_AUTO_TEST_CASE(overloaded_function_cannot_resolve) function g() returns(uint) { return f(3, 5); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(ambiguous_overloaded_function) @@ -1766,7 +1766,7 @@ BOOST_AUTO_TEST_CASE(ambiguous_overloaded_function) function g() returns(uint) { return f(1); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_of_nonoverloaded_function) @@ -1777,7 +1777,7 @@ BOOST_AUTO_TEST_CASE(assignment_of_nonoverloaded_function) function g() returns(uint) { var x = f; return x(7); } } )"; - ETH_TEST_REQUIRE_NO_THROW(createSourceUnit(sourceCode), "Type resolving failed"); + ETH_TEST_REQUIRE_NO_THROW(parseAndAnalyse(sourceCode), "Type resolving failed"); } BOOST_AUTO_TEST_CASE(assignment_of_overloaded_function) @@ -1789,7 +1789,7 @@ BOOST_AUTO_TEST_CASE(assignment_of_overloaded_function) function g() returns(uint) { var x = f; return x(7); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(external_types_clash) @@ -1803,7 +1803,7 @@ BOOST_AUTO_TEST_CASE(external_types_clash) function f(uint8 a) { } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(override_changes_return_types) @@ -1816,7 +1816,7 @@ BOOST_AUTO_TEST_CASE(override_changes_return_types) function f(uint a) returns (uint8) { } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multiple_constructors) @@ -1827,7 +1827,7 @@ BOOST_AUTO_TEST_CASE(multiple_constructors) function test() {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(equal_overload) @@ -1838,7 +1838,7 @@ BOOST_AUTO_TEST_CASE(equal_overload) function test(uint a) external {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::DeclarationError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::DeclarationError); } BOOST_AUTO_TEST_CASE(uninitialized_var) @@ -1848,7 +1848,7 @@ BOOST_AUTO_TEST_CASE(uninitialized_var) function f() returns (uint) { var x; return 2; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string) @@ -1859,7 +1859,7 @@ BOOST_AUTO_TEST_CASE(string) function f(string x) external { s = x; } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(string_index) @@ -1870,7 +1870,7 @@ BOOST_AUTO_TEST_CASE(string_index) function f() { var a = s[2]; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string_length) @@ -1881,7 +1881,7 @@ BOOST_AUTO_TEST_CASE(string_length) function f() { var a = s.length; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(negative_integers_to_signed_out_of_bound) @@ -1891,7 +1891,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_signed_out_of_bound) int8 public i = -129; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(negative_integers_to_signed_min) @@ -1901,7 +1901,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_signed_min) int8 public i = -128; } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound) @@ -1911,7 +1911,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound) int8 public j = 128; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound_max) @@ -1921,7 +1921,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_signed_out_of_bound_max) int8 public j = 127; } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(negative_integers_to_unsigned) @@ -1931,7 +1931,7 @@ BOOST_AUTO_TEST_CASE(negative_integers_to_unsigned) uint8 public x = -1; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(positive_integers_to_unsigned_out_of_bound) @@ -1941,7 +1941,7 @@ BOOST_AUTO_TEST_CASE(positive_integers_to_unsigned_out_of_bound) uint8 public x = 700; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(integer_boolean_operators) @@ -1949,15 +1949,15 @@ BOOST_AUTO_TEST_CASE(integer_boolean_operators) char const* sourceCode1 = R"( contract test { function() { uint x = 1; uint y = 2; x || y; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode1) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode1) == Error::Type::TypeError); char const* sourceCode2 = R"( contract test { function() { uint x = 1; uint y = 2; x && y; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode2) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode2) == Error::Type::TypeError); char const* sourceCode3 = R"( contract test { function() { uint x = 1; !x; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode3) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode3) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(reference_compare_operators) @@ -1965,11 +1965,11 @@ BOOST_AUTO_TEST_CASE(reference_compare_operators) char const* sourceCode1 = R"( contract test { bytes a; bytes b; function() { a == b; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode1) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode1) == Error::Type::TypeError); char const* sourceCode2 = R"( contract test { struct s {uint a;} s x; s y; function() { x == y; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode2) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode2) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overwrite_memory_location_external) @@ -1979,7 +1979,7 @@ BOOST_AUTO_TEST_CASE(overwrite_memory_location_external) function f(uint[] memory a) external {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(overwrite_storage_location_external) @@ -1989,7 +1989,7 @@ BOOST_AUTO_TEST_CASE(overwrite_storage_location_external) function f(uint[] storage a) external {} } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_location_local_variables) @@ -2003,7 +2003,7 @@ BOOST_AUTO_TEST_CASE(storage_location_local_variables) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(no_mappings_in_memory_array) @@ -2015,7 +2015,7 @@ BOOST_AUTO_TEST_CASE(no_mappings_in_memory_array) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_mem_to_local_storage_variable) @@ -2029,7 +2029,7 @@ BOOST_AUTO_TEST_CASE(assignment_mem_to_local_storage_variable) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(storage_assign_to_different_local_variable) @@ -2046,7 +2046,7 @@ BOOST_AUTO_TEST_CASE(storage_assign_to_different_local_variable) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(no_delete_on_storage_pointers) @@ -2060,7 +2060,7 @@ BOOST_AUTO_TEST_CASE(no_delete_on_storage_pointers) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(assignment_mem_storage_variable_directly) @@ -2073,7 +2073,7 @@ BOOST_AUTO_TEST_CASE(assignment_mem_storage_variable_directly) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(function_argument_mem_to_storage) @@ -2087,7 +2087,7 @@ BOOST_AUTO_TEST_CASE(function_argument_mem_to_storage) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(function_argument_storage_to_mem) @@ -2101,7 +2101,7 @@ BOOST_AUTO_TEST_CASE(function_argument_storage_to_mem) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(mem_array_assignment_changes_base_type) @@ -2116,7 +2116,7 @@ BOOST_AUTO_TEST_CASE(mem_array_assignment_changes_base_type) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(dynamic_return_types_not_possible) @@ -2129,7 +2129,7 @@ BOOST_AUTO_TEST_CASE(dynamic_return_types_not_possible) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(memory_arrays_not_resizeable) @@ -2142,7 +2142,7 @@ BOOST_AUTO_TEST_CASE(memory_arrays_not_resizeable) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(struct_constructor) @@ -2155,7 +2155,7 @@ BOOST_AUTO_TEST_CASE(struct_constructor) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(struct_constructor_nested) @@ -2170,7 +2170,7 @@ BOOST_AUTO_TEST_CASE(struct_constructor_nested) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(struct_named_constructor) @@ -2183,7 +2183,7 @@ BOOST_AUTO_TEST_CASE(struct_named_constructor) } } )"; - BOOST_CHECK_NO_THROW(createSourceUnit(sourceCode)); + BOOST_CHECK_NO_THROW(parseAndAnalyse(sourceCode)); } BOOST_AUTO_TEST_CASE(literal_strings) @@ -2196,7 +2196,7 @@ BOOST_AUTO_TEST_CASE(literal_strings) } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(invalid_integer_literal_fraction) @@ -2208,7 +2208,7 @@ BOOST_AUTO_TEST_CASE(invalid_integer_literal_fraction) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(invalid_integer_literal_exp) @@ -2220,7 +2220,7 @@ BOOST_AUTO_TEST_CASE(invalid_integer_literal_exp) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(memory_structs_with_mappings) @@ -2235,7 +2235,7 @@ BOOST_AUTO_TEST_CASE(memory_structs_with_mappings) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(string_bytes_conversion) @@ -2252,7 +2252,7 @@ BOOST_AUTO_TEST_CASE(string_bytes_conversion) function m() internal { string(b); } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(inheriting_from_library) @@ -2261,7 +2261,7 @@ BOOST_AUTO_TEST_CASE(inheriting_from_library) library Lib {} contract Test is Lib {} )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(inheriting_library) @@ -2270,7 +2270,7 @@ BOOST_AUTO_TEST_CASE(inheriting_library) contract Test {} library Lib is Test {} )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(library_having_variables) @@ -2278,7 +2278,7 @@ BOOST_AUTO_TEST_CASE(library_having_variables) char const* text = R"( library Lib { uint x; } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(valid_library) @@ -2286,7 +2286,7 @@ BOOST_AUTO_TEST_CASE(valid_library) char const* text = R"( library Lib { uint constant x = 9; } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(call_to_library_function) @@ -2302,7 +2302,7 @@ BOOST_AUTO_TEST_CASE(call_to_library_function) } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(creating_contract_within_the_contract) @@ -2312,7 +2312,7 @@ BOOST_AUTO_TEST_CASE(creating_contract_within_the_contract) function f() { var x = new Test(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(sourceCode) == Error::Type::TypeError); + BOOST_CHECK(expectError(sourceCode) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(array_out_of_bound_access) @@ -2326,7 +2326,7 @@ BOOST_AUTO_TEST_CASE(array_out_of_bound_access) } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(literal_string_to_storage_pointer) @@ -2336,7 +2336,7 @@ BOOST_AUTO_TEST_CASE(literal_string_to_storage_pointer) function f() { string x = "abc"; } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(non_initialized_references) @@ -2355,7 +2355,7 @@ BOOST_AUTO_TEST_CASE(non_initialized_references) } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text, true) == Error::Type::Warning); + BOOST_CHECK(expectError(text, true) == Error::Type::Warning); } BOOST_AUTO_TEST_CASE(sha3_with_large_integer_constant) @@ -2366,7 +2366,7 @@ BOOST_AUTO_TEST_CASE(sha3_with_large_integer_constant) function f() { sha3(2**500); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(cyclic_binary_dependency) @@ -2376,7 +2376,7 @@ BOOST_AUTO_TEST_CASE(cyclic_binary_dependency) contract B { function f() { new C(); } } contract C { function f() { new A(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(cyclic_binary_dependency_via_inheritance) @@ -2386,7 +2386,7 @@ BOOST_AUTO_TEST_CASE(cyclic_binary_dependency_via_inheritance) contract B { function f() { new C(); } } contract C { function f() { new A(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_fail) @@ -2394,7 +2394,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_fail) char const* text = R"( contract C { function f() { var (x,y); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fine) @@ -2414,7 +2414,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fine) } } )"; - BOOST_CHECK(successResolving(text)); + BOOST_CHECK(success(text)); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_1) @@ -2425,7 +2425,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_1) function f() { var (a, b, ) = one(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_2) { @@ -2435,7 +2435,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_2) function f() { var (a, , ) = one(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_3) @@ -2446,7 +2446,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_3) function f() { var (, , a) = one(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_4) @@ -2457,7 +2457,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_4) function f() { var (, a, b) = one(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_5) @@ -2468,7 +2468,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_5) function f() { var (,) = one(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_6) @@ -2479,7 +2479,7 @@ BOOST_AUTO_TEST_CASE(multi_variable_declaration_wildcards_fail_6) function f() { var (a, b, c) = two(); } } )"; - BOOST_CHECK(parseAndAnalyseReturnErrorType(text) == Error::Type::TypeError); + BOOST_CHECK(expectError(text) == Error::Type::TypeError); } BOOST_AUTO_TEST_SUITE_END() -- cgit v1.2.3 From 656e749b1e231d09b30507d3b8153a413bff66eb Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:51:01 +0200 Subject: added const --- libsolidity/NameAndTypeResolver.cpp | 4 ++-- libsolidity/NameAndTypeResolver.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index 88cd1e2e..1491068e 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -328,12 +328,12 @@ void NameAndTypeResolver::reportFatalDeclarationError( BOOST_THROW_EXCEPTION(FatalError()); } -void NameAndTypeResolver::reportTypeError(Error _e) +void NameAndTypeResolver::reportTypeError(Error const& _e) { m_errors.push_back(make_shared(_e)); } -void NameAndTypeResolver::reportFatalTypeError(Error _e) +void NameAndTypeResolver::reportFatalTypeError(Error const& _e) { reportTypeError(_e); BOOST_THROW_EXCEPTION(FatalError()); diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index 4fe8dd8c..6f3a4c87 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -106,9 +106,9 @@ private: void reportFatalDeclarationError(SourceLocation _sourceLocation, std::string const& _description); // creates the Declaration error and adds it in the errors list - void reportTypeError(Error _e); + void reportTypeError(Error const& _e); // creates the Declaration error and adds it in the errors list and throws FatalError - void reportFatalTypeError(Error _e); + void reportFatalTypeError(const Error& _e); DeclarationContainer* m_currentScope = nullptr; ErrorList& m_errors; -- cgit v1.2.3 From 2348a4ef34ec965aaaec549a5d01409573ca3738 Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:56:12 +0200 Subject: indent --- libsolidity/Parser.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index 47d1fb2f..ab2d0094 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -1171,8 +1171,8 @@ void Parser::parserError(string const& _description) { auto err = make_shared(Error::Type::ParserError); *err << - errinfo_sourceLocation(SourceLocation(position(), position(), sourceName())) << - errinfo_comment(_description); + errinfo_sourceLocation(SourceLocation(position(), position(), sourceName())) << + errinfo_comment(_description); m_errors.push_back(err); } -- cgit v1.2.3 From b2e787b803ffc4a3f13b8578f7029543bd665aed Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 15 Oct 2015 16:59:38 +0200 Subject: missing const --- libsolidity/NameAndTypeResolver.cpp | 2 +- libsolidity/NameAndTypeResolver.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libsolidity/NameAndTypeResolver.cpp b/libsolidity/NameAndTypeResolver.cpp index 1491068e..abf0788a 100644 --- a/libsolidity/NameAndTypeResolver.cpp +++ b/libsolidity/NameAndTypeResolver.cpp @@ -136,7 +136,7 @@ bool NameAndTypeResolver::updateDeclaration(Declaration const& _declaration) m_scopes[nullptr].registerDeclaration(_declaration, false, true); solAssert(_declaration.scope() == nullptr, "Updated declaration outside global scope."); } - catch(FatalError _error) + catch(FatalError const& _error) { return false; } diff --git a/libsolidity/NameAndTypeResolver.h b/libsolidity/NameAndTypeResolver.h index 6f3a4c87..7169f302 100644 --- a/libsolidity/NameAndTypeResolver.h +++ b/libsolidity/NameAndTypeResolver.h @@ -108,7 +108,7 @@ private: // creates the Declaration error and adds it in the errors list void reportTypeError(Error const& _e); // creates the Declaration error and adds it in the errors list and throws FatalError - void reportFatalTypeError(const Error& _e); + void reportFatalTypeError(Error const& _e); DeclarationContainer* m_currentScope = nullptr; ErrorList& m_errors; -- cgit v1.2.3