From 4134834ff3adedcf31d73edf5d25bfdc57994289 Mon Sep 17 00:00:00 2001 From: chriseth Date: Thu, 1 Sep 2016 19:31:17 +0200 Subject: Guard encoding crashes with assertions. --- Changelog.md | 1 + libsolidity/codegen/CompilerUtils.cpp | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/Changelog.md b/Changelog.md index 25890890..4bc750f0 100644 --- a/Changelog.md +++ b/Changelog.md @@ -39,6 +39,7 @@ Bugfixes: * JSON AST: nodes were added at wrong parent * Why3 translator: crash fix for exponentiation * Type Checker: Fallback function cannot return data anymore. + * Code Generator: Fix crash when sha3() was used on unsupported types. Lots of changes to the documentation mainly by voluntary external contributors. diff --git a/libsolidity/codegen/CompilerUtils.cpp b/libsolidity/codegen/CompilerUtils.cpp index d7d17b8e..c02a8126 100644 --- a/libsolidity/codegen/CompilerUtils.cpp +++ b/libsolidity/codegen/CompilerUtils.cpp @@ -160,7 +160,15 @@ void CompilerUtils::encodeToMemory( TypePointers targetTypes = _targetTypes.empty() ? _givenTypes : _targetTypes; solAssert(targetTypes.size() == _givenTypes.size(), ""); for (TypePointer& t: targetTypes) + { + solAssert( + t->mobileType() && + t->mobileType()->interfaceType(_encodeAsLibraryTypes) && + t->mobileType()->interfaceType(_encodeAsLibraryTypes)->encodingType(), + "Encoding type " + t->toString() + " not yet implemented." + ); t = t->mobileType()->interfaceType(_encodeAsLibraryTypes)->encodingType(); + } // Stack during operation: // ... ... -- cgit v1.2.3