diff options
| author | Alex Beregszaszi <alex@rtfs.hu> | 2018-08-08 18:27:37 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-08 18:27:37 +0800 |
| commit | 64e3c9913f6ecfde8f2fe0121c93e92080916b95 (patch) | |
| tree | 758b8c8cc5e4ff4f12d0f7cbd824982e4adad8ce /test | |
| parent | 4dc3335cda18bae7c683227a9795a7cc1de95fd2 (diff) | |
| parent | b11e39e25ee14b2d56db86ea48e3229a7a6cad52 (diff) | |
| download | dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar.gz dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar.bz2 dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar.lz dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar.xz dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.tar.zst dexon-solidity-64e3c9913f6ecfde8f2fe0121c93e92080916b95.zip | |
Merge pull request #4736 from ethereum/removeFillRight
Remove remaining instances of ``fillRight``.
Diffstat (limited to 'test')
3 files changed, 11 insertions, 20 deletions
diff --git a/test/libsolidity/syntaxTests/tupleAssignments/double_storage_crash.sol b/test/libsolidity/syntaxTests/tupleAssignments/double_storage_crash.sol new file mode 100644 index 00000000..3cff3a9a --- /dev/null +++ b/test/libsolidity/syntaxTests/tupleAssignments/double_storage_crash.sol @@ -0,0 +1,11 @@ +// This used to crash in certain compiler versions. +contract CrashContract { + struct S { uint a; } + S x; + function f() public { + (x, x) = 1(x, x); + } +} +// ---- +// TypeError: (170-177): Type is not callable +// TypeError: (170-177): Type tuple() is not implicitly convertible to expected type tuple(struct CrashContract.S storage ref,struct CrashContract.S storage ref). diff --git a/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_left.sol b/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_left.sol deleted file mode 100644 index 902d8b98..00000000 --- a/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_left.sol +++ /dev/null @@ -1,10 +0,0 @@ -contract C { - struct S { uint a; uint b; } - S x; S y; - function f() public { - (,x, y) = (1, 2, y, x); - } -} -// ---- -// TypeError: (89-101): Type tuple(int_const 1,int_const 2,struct C.S storage ref,struct C.S storage ref) is not implicitly convertible to expected type tuple(,struct C.S storage ref,struct C.S storage ref). -// Warning: (79-101): This assignment performs two copies to storage. Since storage copies do not first copy to a temporary location, one of them might be overwritten before the second is executed and thus may have unexpected effects. It is safer to perform the copies separately or assign to storage pointers first. diff --git a/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_right.sol b/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_right.sol deleted file mode 100644 index 51556aab..00000000 --- a/test/libsolidity/syntaxTests/tupleAssignments/err_multiple_storage_storage_copies_fill_right.sol +++ /dev/null @@ -1,10 +0,0 @@ -contract C { - struct S { uint a; uint b; } - S x; S y; - function f() public { - (x, y, ) = (y, x, 1, 2); - } -} -// ---- -// TypeError: (90-102): Type tuple(struct C.S storage ref,struct C.S storage ref,int_const 1,int_const 2) is not implicitly convertible to expected type tuple(struct C.S storage ref,struct C.S storage ref,). -// Warning: (79-102): This assignment performs two copies to storage. Since storage copies do not first copy to a temporary location, one of them might be overwritten before the second is executed and thus may have unexpected effects. It is safer to perform the copies separately or assign to storage pointers first. |