aboutsummaryrefslogtreecommitdiffstats
path: root/test/libsolidity
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2017-09-21 00:00:40 +0800
committerGitHub <noreply@github.com>2017-09-21 00:00:40 +0800
commit8af298ade31ed1337ec20bf50cdb963bbd50c0db (patch)
tree172da56472b55194199bc310fe36ab6f1be9cd22 /test/libsolidity
parent2adeb26d4396d94b322aeeef98bfb679a7cbce27 (diff)
parented1fd49ab07de1ddad9f3bc2864e17fe21ed993d (diff)
downloaddexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar.gz
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar.bz2
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar.lz
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar.xz
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.tar.zst
dexon-solidity-8af298ade31ed1337ec20bf50cdb963bbd50c0db.zip
Merge pull request #2902 from ethereum/warn-obsolete
Warn about obsolete sha3/suicide calls
Diffstat (limited to 'test/libsolidity')
-rw-r--r--test/libsolidity/SolidityNameAndTypeResolution.cpp29
1 files changed, 27 insertions, 2 deletions
diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp
index 2ca3a562..39c47f9c 100644
--- a/test/libsolidity/SolidityNameAndTypeResolution.cpp
+++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp
@@ -4679,7 +4679,7 @@ BOOST_AUTO_TEST_CASE(warn_about_callcode)
}
}
)";
- CHECK_WARNING(text, "\"callcode\" has been deprecated in favour");
+ CHECK_WARNING(text, "\"callcode\" has been deprecated in favour of \"delegatecall\"");
}
BOOST_AUTO_TEST_CASE(no_warn_about_callcode_as_function)
@@ -6877,7 +6877,7 @@ BOOST_AUTO_TEST_CASE(tight_packing_literals)
}
}
)";
- CHECK_WARNING(text, "The type of \"int_const 1\" was inferred as uint8.");
+// CHECK_WARNING(text, "The type of \"int_const 1\" was inferred as uint8.");
text = R"(
contract C {
function f() pure public returns (bytes32) {
@@ -6928,6 +6928,31 @@ BOOST_AUTO_TEST_CASE(non_external_fallback)
CHECK_ERROR(text, TypeError, "Fallback function must be defined as \"external\".");
}
+BOOST_AUTO_TEST_CASE(warn_about_sha3)
+{
+ char const* text = R"(
+ contract test {
+ function f() pure public {
+ var x = sha3(uint8(1));
+ x;
+ }
+ }
+ )";
+ CHECK_WARNING(text, "\"sha3\" has been deprecated in favour of \"keccak256\"");
+}
+
+BOOST_AUTO_TEST_CASE(warn_about_suicide)
+{
+ char const* text = R"(
+ contract test {
+ function f() public {
+ suicide(1);
+ }
+ }
+ )";
+ CHECK_WARNING(text, "\"suicide\" has been deprecated in favour of \"selfdestruct\"");
+}
+
BOOST_AUTO_TEST_SUITE_END()
}