diff options
author | chriseth <chris@ethereum.org> | 2018-09-06 17:05:35 +0800 |
---|---|---|
committer | chriseth <chris@ethereum.org> | 2018-09-06 22:42:59 +0800 |
commit | 0b7b8162cab67d58915d4561a52d70e7208233c1 (patch) | |
tree | 7d5a9c0447d0c6654219b85c2375adae6751e002 /test/libsolidity | |
parent | 977ac9c390d034232afdec195ffa069b6a1df21b (diff) | |
download | dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar.gz dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar.bz2 dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar.lz dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar.xz dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.tar.zst dexon-solidity-0b7b8162cab67d58915d4561a52d70e7208233c1.zip |
This fixes several bugs with regards to line breaks and comments:
- any unicode line break (line feed, vertical tab, form feed, carriage
return, NEL, LS and PS) is considered to terminate a single-line
comment. The line break itself is considered to be the next token
after the comment, leading to a parser error if it is not an
ascii character (i.e. for NEL, LS and PS).
- unterminated multiline comments are considered illegal tokens
- '/** /' is considered an unterminated multiline comment
(previously, whitespace was allowed before the last '/'
Diffstat (limited to 'test/libsolidity')
-rw-r--r-- | test/libsolidity/SolidityScanner.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/test/libsolidity/SolidityScanner.cpp b/test/libsolidity/SolidityScanner.cpp index f2e756bb..6b7f559a 100644 --- a/test/libsolidity/SolidityScanner.cpp +++ b/test/libsolidity/SolidityScanner.cpp @@ -500,6 +500,14 @@ BOOST_AUTO_TEST_CASE(invalid_hex_literal_nonhex_string) BOOST_CHECK_EQUAL(scanner.next(), Token::Illegal); } +BOOST_AUTO_TEST_CASE(invalid_multiline_comment_close) +{ + // This used to parse as "comment", "identifier" + Scanner scanner(CharStream("/** / x")); + BOOST_CHECK_EQUAL(scanner.currentToken(), Token::Illegal); + BOOST_CHECK_EQUAL(scanner.next(), Token::EOS); +} + BOOST_AUTO_TEST_SUITE_END() |