aboutsummaryrefslogtreecommitdiffstats
path: root/libsolidity
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2018-06-29 06:06:51 +0800
committerAlex Beregszaszi <alex@rtfs.hu>2018-08-01 19:28:27 +0800
commit7e5406dd8953cb819c397221fa55e6fa390108ee (patch)
treecf16b432bf0cc89f05a61b0d0fe6d2ba1e99af7f /libsolidity
parentef269bf40d3c6fc044c27654473353c556402b77 (diff)
downloaddexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar.gz
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar.bz2
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar.lz
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar.xz
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.tar.zst
dexon-solidity-7e5406dd8953cb819c397221fa55e6fa390108ee.zip
Disallow calling base constructors without arguments.
Diffstat (limited to 'libsolidity')
-rw-r--r--libsolidity/analysis/TypeChecker.cpp18
1 files changed, 4 insertions, 14 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
index d2fb9281..9e10b9b2 100644
--- a/libsolidity/analysis/TypeChecker.cpp
+++ b/libsolidity/analysis/TypeChecker.cpp
@@ -279,8 +279,6 @@ void TypeChecker::checkContractAbstractFunctions(ContractDefinition const& _cont
void TypeChecker::checkContractBaseConstructorArguments(ContractDefinition const& _contract)
{
- bool const v050 = _contract.sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050);
-
vector<ContractDefinition const*> const& bases = _contract.annotation().linearizedBaseContracts;
// Determine the arguments that are used for the base constructors.
@@ -296,18 +294,10 @@ void TypeChecker::checkContractBaseConstructorArguments(ContractDefinition const
annotateBaseConstructorArguments(_contract, baseContract->constructor(), modifier.get());
}
else
- {
- if (v050)
- m_errorReporter.declarationError(
- modifier->location(),
- "Modifier-style base constructor call without arguments."
- );
- else
- m_errorReporter.warning(
- modifier->location(),
- "Modifier-style base constructor call without arguments."
- );
- }
+ m_errorReporter.declarationError(
+ modifier->location(),
+ "Modifier-style base constructor call without arguments."
+ );
}
for (ASTPointer<InheritanceSpecifier> const& base: contract->baseContracts())