diff options
| author | chriseth <chris@ethereum.org> | 2017-04-22 01:13:46 +0800 |
|---|---|---|
| committer | chriseth <chris@ethereum.org> | 2017-04-25 22:49:04 +0800 |
| commit | 478f2997ea8b233882d33e693a0e8df176a0c222 (patch) | |
| tree | 2e18e560a737d85048d08884482426f439235eea /libsolidity/codegen | |
| parent | 5f4b68e211a10af513d53cd2b9586191e174423d (diff) | |
| download | dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar.gz dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar.bz2 dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar.lz dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar.xz dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.tar.zst dexon-solidity-478f2997ea8b233882d33e693a0e8df176a0c222.zip | |
Storage access from inline assembly.
Diffstat (limited to 'libsolidity/codegen')
| -rw-r--r-- | libsolidity/codegen/ContractCompiler.cpp | 45 |
1 files changed, 35 insertions, 10 deletions
diff --git a/libsolidity/codegen/ContractCompiler.cpp b/libsolidity/codegen/ContractCompiler.cpp index 5257b1f7..7e0be4cb 100644 --- a/libsolidity/codegen/ContractCompiler.cpp +++ b/libsolidity/codegen/ContractCompiler.cpp @@ -542,6 +542,7 @@ bool ContractCompiler::visit(InlineAssembly const& _inlineAssembly) solAssert(!!decl->type(), "Type of declaration required but not yet determined."); if (FunctionDefinition const* functionDef = dynamic_cast<FunctionDefinition const*>(decl)) { + solAssert(!ref->second.isOffset && !ref->second.isSlot, ""); functionDef = &m_context.resolveVirtualFunction(*functionDef); _assembly.append(m_context.functionEntryLabel(*functionDef).pushTag()); // If there is a runtime context, we have to merge both labels into the same @@ -557,19 +558,42 @@ bool ContractCompiler::visit(InlineAssembly const& _inlineAssembly) else if (auto variable = dynamic_cast<VariableDeclaration const*>(decl)) { solAssert(!variable->isConstant(), ""); - solAssert(m_context.isLocalVariable(variable), ""); - int stackDiff = _assembly.deposit() - m_context.baseStackOffsetOfVariable(*variable); - if (stackDiff < 1 || stackDiff > 16) - BOOST_THROW_EXCEPTION( - CompilerError() << - errinfo_sourceLocation(_inlineAssembly.location()) << - errinfo_comment("Stack too deep, try removing local variables.") - ); - solAssert(variable->type()->sizeOnStack() == 1, ""); - _assembly.append(dupInstruction(stackDiff)); + if (m_context.isStateVariable(decl)) + { + auto const& location = m_context.storageLocationOfVariable(*decl); + if (ref->second.isSlot) + m_context << location.first; + else if (ref->second.isOffset) + m_context << u256(location.second); + else + solAssert(false, ""); + } + else if (m_context.isLocalVariable(decl)) + { + int stackDiff = _assembly.deposit() - m_context.baseStackOffsetOfVariable(*variable); + if (ref->second.isSlot || ref->second.isOffset) + { + solAssert(variable->type()->sizeOnStack() == 2, ""); + if (ref->second.isOffset) + stackDiff--; + } + else + solAssert(variable->type()->sizeOnStack() == 1, ""); + if (stackDiff < 1 || stackDiff > 16) + BOOST_THROW_EXCEPTION( + CompilerError() << + errinfo_sourceLocation(_inlineAssembly.location()) << + errinfo_comment("Stack too deep, try removing local variables.") + ); + solAssert(variable->type()->sizeOnStack() == 1, ""); + _assembly.append(dupInstruction(stackDiff)); + } + else + solAssert(false, ""); } else if (auto contract = dynamic_cast<ContractDefinition const*>(decl)) { + solAssert(!ref->second.isOffset && !ref->second.isSlot, ""); solAssert(contract->isLibrary(), ""); _assembly.appendLibraryAddress(contract->fullyQualifiedName()); } @@ -580,6 +604,7 @@ bool ContractCompiler::visit(InlineAssembly const& _inlineAssembly) else { // lvalue context + solAssert(!ref->second.isOffset && !ref->second.isSlot, ""); auto variable = dynamic_cast<VariableDeclaration const*>(decl); solAssert( !!variable && m_context.isLocalVariable(variable), |