aboutsummaryrefslogtreecommitdiffstats
path: root/libsolidity/analysis
diff options
context:
space:
mode:
authorFederico Bond <federicobond@gmail.com>2017-07-09 07:27:28 +0800
committerAlex Beregszaszi <alex@rtfs.hu>2017-10-03 22:30:16 +0800
commit2b8235269221cacbcf9beb793d969c451b1927a3 (patch)
tree7966106164c51f392f497057028160d6193e6409 /libsolidity/analysis
parent5c284589202c261c06dadfe7a598cc23752e8e48 (diff)
downloaddexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar.gz
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar.bz2
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar.lz
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar.xz
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.tar.zst
dexon-solidity-2b8235269221cacbcf9beb793d969c451b1927a3.zip
Disallow non-pure constant state variables in 0.5.0
Diffstat (limited to 'libsolidity/analysis')
-rw-r--r--libsolidity/analysis/TypeChecker.cpp19
1 files changed, 14 insertions, 5 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
index d45e9e89..b2a88059 100644
--- a/libsolidity/analysis/TypeChecker.cpp
+++ b/libsolidity/analysis/TypeChecker.cpp
@@ -645,14 +645,23 @@ bool TypeChecker::visit(VariableDeclaration const& _variable)
if (!allowed)
m_errorReporter.typeError(_variable.location(), "Constants of non-value type not yet implemented.");
}
+
if (!_variable.value())
m_errorReporter.typeError(_variable.location(), "Uninitialized \"constant\" variable.");
else if (!_variable.value()->annotation().isPure)
- m_errorReporter.warning(
- _variable.value()->location(),
- "Initial value for constant variable has to be compile-time constant. "
- "This will fail to compile with the next breaking version change."
- );
+ {
+ if (_variable.sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050))
+ m_errorReporter.typeError(
+ _variable.value()->location(),
+ "Initial value for constant variable has to be compile-time constant."
+ );
+ else
+ m_errorReporter.warning(
+ _variable.value()->location(),
+ "Initial value for constant variable has to be compile-time constant. "
+ "This will fail to compile with the next breaking version change."
+ );
+ }
}
if (!_variable.isStateVariable())
{