diff options
| author | Alex Beregszaszi <alex@rtfs.hu> | 2017-08-04 20:35:06 +0800 |
|---|---|---|
| committer | Alex Beregszaszi <alex@rtfs.hu> | 2017-08-08 18:58:00 +0800 |
| commit | 1ada48f61e020a32c0c1f41394ded9a83d5ba57e (patch) | |
| tree | cfa812e75c27bd565f922e02b1b819fe8044e962 /libsolidity/analysis | |
| parent | bea37e5682d83b11988e51a16848319a59c39dd3 (diff) | |
| download | dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar.gz dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar.bz2 dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar.lz dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar.xz dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.tar.zst dexon-solidity-1ada48f61e020a32c0c1f41394ded9a83d5ba57e.zip | |
Raise error when using unimplemented internal library functions.
Diffstat (limited to 'libsolidity/analysis')
| -rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index a9f5b931..fbdac1c7 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -1403,6 +1403,21 @@ bool TypeChecker::visit(FunctionCall const& _functionCall) else _functionCall.annotation().type = make_shared<TupleType>(functionType->returnParameterTypes()); + // Internal library functions must be implemented, because of inlining rules. + if ( + functionType->kind() == FunctionType::Kind::Internal && + functionType->hasDeclaration() && + dynamic_cast<FunctionDefinition const*>(&functionType->declaration()) + ) + { + FunctionDefinition const* function = dynamic_cast<FunctionDefinition const*>(&functionType->declaration()); + bool isLibraryFunction = + dynamic_cast<ContractDefinition const*>(function->scope()) && + dynamic_cast<ContractDefinition const*>(function->scope())->isLibrary(); + if (!function->isImplemented() && isLibraryFunction) + m_errorReporter.typeError(_functionCall.location(), "Inlined library function is lacking implementation."); + } + TypePointers parameterTypes = functionType->parameterTypes(); if (!functionType->takesArbitraryParameters() && parameterTypes.size() != arguments.size()) { |