aboutsummaryrefslogtreecommitdiffstats
path: root/libsolidity/analysis/TypeChecker.cpp
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2018-04-19 02:40:46 +0800
committerAlex Beregszaszi <alex@rtfs.hu>2018-04-19 05:56:45 +0800
commita94945dfe40c879b6c3762620987a235582ccecf (patch)
treecd1308012cd19a0bded85f412291e34e7e1e4578 /libsolidity/analysis/TypeChecker.cpp
parent17beac1e07fba46f14d458ee600502c1da723f4f (diff)
downloaddexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar.gz
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar.bz2
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar.lz
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar.xz
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.tar.zst
dexon-solidity-a94945dfe40c879b6c3762620987a235582ccecf.zip
Improve error message for failed member lookup.
Diffstat (limited to 'libsolidity/analysis/TypeChecker.cpp')
-rw-r--r--libsolidity/analysis/TypeChecker.cpp27
1 files changed, 16 insertions, 11 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
index 87d69d97..72d29762 100644
--- a/libsolidity/analysis/TypeChecker.cpp
+++ b/libsolidity/analysis/TypeChecker.cpp
@@ -1904,7 +1904,8 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
// Retrieve the types of the arguments if this is used to call a function.
auto const& argumentTypes = _memberAccess.annotation().argumentTypes;
MemberList::MemberMap possibleMembers = exprType->members(m_scope).membersByName(memberName);
- if (possibleMembers.size() > 1 && argumentTypes)
+ size_t const initialMemberCount = possibleMembers.size();
+ if (initialMemberCount > 1 && argumentTypes)
{
// do overload resolution
for (auto it = possibleMembers.begin(); it != possibleMembers.end();)
@@ -1918,17 +1919,21 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
}
if (possibleMembers.size() == 0)
{
- auto storageType = ReferenceType::copyForLocationIfReference(
- DataLocation::Storage,
- exprType
- );
- if (!storageType->members(m_scope).membersByName(memberName).empty())
- m_errorReporter.fatalTypeError(
- _memberAccess.location(),
- "Member \"" + memberName + "\" is not available in " +
- exprType->toString() +
- " outside of storage."
+ if (initialMemberCount == 0)
+ {
+ // Try to see if the member was removed because it is only available for storage types.
+ auto storageType = ReferenceType::copyForLocationIfReference(
+ DataLocation::Storage,
+ exprType
);
+ if (!storageType->members(m_scope).membersByName(memberName).empty())
+ m_errorReporter.fatalTypeError(
+ _memberAccess.location(),
+ "Member \"" + memberName + "\" is not available in " +
+ exprType->toString() +
+ " outside of storage."
+ );
+ }
m_errorReporter.fatalTypeError(
_memberAccess.location(),
"Member \"" + memberName + "\" not found or not visible "