aboutsummaryrefslogtreecommitdiffstats
path: root/libevmasm/PeepholeOptimiser.cpp
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2017-10-14 00:59:04 +0800
committerchriseth <chris@ethereum.org>2017-10-14 01:00:56 +0800
commit7c94e5462abb327016520b896178de41bea473c2 (patch)
treea3c44ae1b221c6bf1a288e43b4956d511cfe874a /libevmasm/PeepholeOptimiser.cpp
parentd9bb4b44a4409db607ee74739f9a5ce1bd557067 (diff)
downloaddexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar.gz
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar.bz2
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar.lz
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar.xz
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.tar.zst
dexon-solidity-7c94e5462abb327016520b896178de41bea473c2.zip
Assume peephole optimizer was successful if number of pops increased.
Diffstat (limited to 'libevmasm/PeepholeOptimiser.cpp')
-rw-r--r--libevmasm/PeepholeOptimiser.cpp11
1 files changed, 9 insertions, 2 deletions
diff --git a/libevmasm/PeepholeOptimiser.cpp b/libevmasm/PeepholeOptimiser.cpp
index 31fdd317..168d1109 100644
--- a/libevmasm/PeepholeOptimiser.cpp
+++ b/libevmasm/PeepholeOptimiser.cpp
@@ -249,6 +249,11 @@ void applyMethods(OptimiserState& _state, Method, OtherMethods... _other)
applyMethods(_state, _other...);
}
+size_t numberOfPops(AssemblyItems const& _items)
+{
+ return std::count(_items.begin(), _items.end(), Instruction::POP);
+}
+
}
bool PeepholeOptimiser::optimise()
@@ -257,8 +262,10 @@ bool PeepholeOptimiser::optimise()
while (state.i < m_items.size())
applyMethods(state, PushPop(), OpPop(), DoublePush(), DoubleSwap(), JumpToNext(), UnreachableCode(), TagConjunctions(), Identity());
if (m_optimisedItems.size() < m_items.size() || (
- m_optimisedItems.size() == m_items.size() &&
- eth::bytesRequired(m_optimisedItems, 3) < eth::bytesRequired(m_items, 3)
+ m_optimisedItems.size() == m_items.size() && (
+ eth::bytesRequired(m_optimisedItems, 3) < eth::bytesRequired(m_items, 3) ||
+ numberOfPops(m_optimisedItems) > numberOfPops(m_items)
+ )
))
{
m_items = std::move(m_optimisedItems);