diff options
| author | chriseth <chris@ethereum.org> | 2018-09-04 22:31:25 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-09-04 22:31:25 +0800 |
| commit | cc7daf7b476f498c4dcde7bdb342974097ffe9bf (patch) | |
| tree | 707656e46a626f93bb24d45710ebda7ab31a013f /docs/security-considerations.rst | |
| parent | d88e5039ccc768f810f7882aa1f9ae338bc27dd3 (diff) | |
| parent | e3097b30dace9bbd88a5a74e6507baad0bc12cc4 (diff) | |
| download | dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar.gz dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar.bz2 dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar.lz dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar.xz dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.tar.zst dexon-solidity-cc7daf7b476f498c4dcde7bdb342974097ffe9bf.zip | |
Merge pull request #4829 from ethereum/callBytesReturn
Add return data to bare calls.
Diffstat (limited to 'docs/security-considerations.rst')
| -rw-r--r-- | docs/security-considerations.rst | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/docs/security-considerations.rst b/docs/security-considerations.rst index 066a31ea..3bcd9566 100644 --- a/docs/security-considerations.rst +++ b/docs/security-considerations.rst @@ -86,7 +86,8 @@ as it uses ``call`` which forwards all remaining gas by default: mapping(address => uint) shares; /// Withdraw your share. function withdraw() public { - if (msg.sender.call.value(shares[msg.sender])("")) + (bool success,) = msg.sender.call.value(shares[msg.sender])(""); + if (success) shares[msg.sender] = 0; } } |