aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Kirchner <daniel@ekpyron.org>2018-08-16 07:09:40 +0800
committerDaniel Kirchner <daniel@ekpyron.org>2018-09-04 19:31:10 +0800
commitcf69433f2312afc2b76b00dd202f114d9f546309 (patch)
tree46d09e216b10dbdbf270e55d4f428ea515c0120a
parent0011f8aef9ef949fc971fceed2e319adb6a58ec1 (diff)
downloaddexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar.gz
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar.bz2
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar.lz
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar.xz
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.tar.zst
dexon-solidity-cf69433f2312afc2b76b00dd202f114d9f546309.zip
Update documentation.
-rw-r--r--docs/contracts.rst6
-rw-r--r--docs/security-considerations.rst3
2 files changed, 6 insertions, 3 deletions
diff --git a/docs/contracts.rst b/docs/contracts.rst
index 669a374f..8fd1c89e 100644
--- a/docs/contracts.rst
+++ b/docs/contracts.rst
@@ -406,7 +406,8 @@ inheritable properties of contracts and may be overridden by derived contracts.
/// The `return 7` statement assigns 7 to the return value but still
/// executes the statement `locked = false` in the modifier.
function f() public noReentrancy returns (uint) {
- require(msg.sender.call(""));
+ (bool success,) = msg.sender.call("");
+ require(success);
return 7;
}
}
@@ -645,7 +646,8 @@ Like any function, the fallback function can execute complex operations as long
contract Caller {
function callTest(Test test) public returns (bool) {
- require(address(test).call(abi.encodeWithSignature("nonExistingFunction()")));
+ (bool success,) = address(test).call(abi.encodeWithSignature("nonExistingFunction()"));
+ require(success);
// results in test.x becoming == 1.
// If someone sends ether to that contract,
diff --git a/docs/security-considerations.rst b/docs/security-considerations.rst
index 066a31ea..3bcd9566 100644
--- a/docs/security-considerations.rst
+++ b/docs/security-considerations.rst
@@ -86,7 +86,8 @@ as it uses ``call`` which forwards all remaining gas by default:
mapping(address => uint) shares;
/// Withdraw your share.
function withdraw() public {
- if (msg.sender.call.value(shares[msg.sender])(""))
+ (bool success,) = msg.sender.call.value(shares[msg.sender])("");
+ if (success)
shares[msg.sender] = 0;
}
}