aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoão Vítor <joaovmferreira@gmail.com>2018-06-26 06:06:44 +0800
committerGitHub <noreply@github.com>2018-06-26 06:06:44 +0800
commit7ffdad4ae36042d81d0d8738e6f915648bc8fb44 (patch)
tree71468d153cabe4248894143c922d210db27e45b6
parent6ec61e283c598be5ee4bb9124366f2631912ff00 (diff)
downloaddexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar.gz
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar.bz2
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar.lz
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar.xz
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.tar.zst
dexon-solidity-7ffdad4ae36042d81d0d8738e6f915648bc8fb44.zip
add explanation about the splitSignature function
-rw-r--r--docs/solidity-by-example.rst6
1 files changed, 5 insertions, 1 deletions
diff --git a/docs/solidity-by-example.rst b/docs/solidity-by-example.rst
index e55b11b1..5f09446b 100644
--- a/docs/solidity-by-example.rst
+++ b/docs/solidity-by-example.rst
@@ -1056,7 +1056,8 @@ The full contract
/// does, you can skip it.
/// the same functions we wrote in the 'creating and verifying signatures' chapter,
- /// you can go there to find the full explanations
+ /// you can go there to find the full explanations.
+ /// please read the notes below this contract.
function splitSignature(bytes sig)
internal
@@ -1102,6 +1103,9 @@ The full contract
}
+Note: The function *splitSignature* uses the code from the `gist <https://gist.github.com/axic/5b33912c6f61ae6fd96d6c4a47afde6d>`_. In
+a real implementation should be used a more tested library, such as the
+openzepplin's fork of the original code, `library <https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/ECRecovery.sol>`_.