diff options
| author | chriseth <chris@ethereum.org> | 2018-04-18 20:28:53 +0800 |
|---|---|---|
| committer | chriseth <chris@ethereum.org> | 2018-04-19 03:23:09 +0800 |
| commit | 489586430202d17fb60d973503ab27670474143d (patch) | |
| tree | ad708894de37ac9df7c6d7f8547ded8c990dc662 | |
| parent | cd17c37fe6df143558a8aaadcec2495ff50f90df (diff) | |
| download | dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar.gz dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar.bz2 dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar.lz dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar.xz dexon-solidity-489586430202d17fb60d973503ab27670474143d.tar.zst dexon-solidity-489586430202d17fb60d973503ab27670474143d.zip | |
Warn about functions named "constructor".
| -rw-r--r-- | Changelog.md | 3 | ||||
| -rw-r--r-- | libsolidity/analysis/SyntaxChecker.cpp | 7 | ||||
| -rw-r--r-- | test/libsolidity/syntaxTests/constructor/function_named_constructor.sol | 5 |
3 files changed, 13 insertions, 2 deletions
diff --git a/Changelog.md b/Changelog.md index 230c1174..8812bace 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,8 +1,9 @@ ### 0.4.23 (unreleased) Features: - * SMTChecker: Integration with CVC4 SMT solver * Build system: Support Ubuntu Bionic. + * SMTChecker: Integration with CVC4 SMT solver + * Syntax Checker: Warn about functions named "constructor". Bugfixes: * Type Checker: Do not complain about new-style constructor and fallback function to have the same name. diff --git a/libsolidity/analysis/SyntaxChecker.cpp b/libsolidity/analysis/SyntaxChecker.cpp index f648e5b4..396058f4 100644 --- a/libsolidity/analysis/SyntaxChecker.cpp +++ b/libsolidity/analysis/SyntaxChecker.cpp @@ -237,8 +237,13 @@ bool SyntaxChecker::visit(FunctionDefinition const& _function) if (v050) m_errorReporter.syntaxError(_function.location(), "Functions without implementation cannot have modifiers."); else - m_errorReporter.warning( _function.location(), "Modifiers of functions without implementation are ignored." ); + m_errorReporter.warning(_function.location(), "Modifiers of functions without implementation are ignored." ); } + if (_function.name() == "constructor") + m_errorReporter.warning(_function.location(), + "This function is named \"constructor\" but is not the constructor of the contract. " + "If you intend this to be a constructor, use \"constructor(...) { ... }\" without the \"function\" keyword to define it." + ); return true; } diff --git a/test/libsolidity/syntaxTests/constructor/function_named_constructor.sol b/test/libsolidity/syntaxTests/constructor/function_named_constructor.sol new file mode 100644 index 00000000..29784033 --- /dev/null +++ b/test/libsolidity/syntaxTests/constructor/function_named_constructor.sol @@ -0,0 +1,5 @@ +contract C { + function constructor() public; +} +// ---- +// Warning: (17-47): This function is named "constructor" but is not the constructor of the contract. If you intend this to be a constructor, use "constructor(...) { ... }" without the "function" keyword to define it. |