aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLefteris Karapetsas <lefteris@refu.co>2015-03-21 00:50:26 +0800
committerLefteris Karapetsas <lefteris@refu.co>2015-03-25 21:26:05 +0800
commitfc0b32f68394518894314682f95a7b45fc1a6ef0 (patch)
tree58effb32bf8ada1ec0d1340a3ed9a6d906858e69
parent0934d0e943765c7c87cf1b3da43aa876f4f1e469 (diff)
downloaddexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar.gz
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar.bz2
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar.lz
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar.xz
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.tar.zst
dexon-solidity-fc0b32f68394518894314682f95a7b45fc1a6ef0.zip
Parsing of not fully implemented functions
- Adding the possibility of omitting a function body by simply ending a function definition with a semicolon - Such a function is marked as not fully implemented and any contract that contains such a function is considered a not fully implemented contract
-rw-r--r--SolidityNameAndTypeResolution.cpp15
-rw-r--r--SolidityParser.cpp8
2 files changed, 23 insertions, 0 deletions
diff --git a/SolidityNameAndTypeResolution.cpp b/SolidityNameAndTypeResolution.cpp
index 591cf053..3c088358 100644
--- a/SolidityNameAndTypeResolution.cpp
+++ b/SolidityNameAndTypeResolution.cpp
@@ -346,6 +346,21 @@ BOOST_AUTO_TEST_CASE(comparison_bitop_precedence)
ETH_TEST_CHECK_NO_THROW(parseTextAndResolveNames(text), "Parsing and Name Resolving Failed");
}
+BOOST_AUTO_TEST_CASE(function_no_implementation)
+{
+ ASTPointer<SourceUnit> sourceUnit;
+ char const* text = "contract test {\n"
+ " function functionName(bytes32 input) returns (bytes32 out);\n"
+ "}\n";
+ ETH_TEST_REQUIRE_NO_THROW(sourceUnit = parseTextAndResolveNames(text), "Parsing and name Resolving failed");
+ ContractDefinition* contract;
+ for (ASTPointer<ASTNode> const& node: sourceUnit->getNodes())
+ contract = dynamic_cast<ContractDefinition*>(node.get());
+ BOOST_CHECK(contract);
+ BOOST_CHECK(!contract->isFullyImplemented());
+ BOOST_CHECK(!contract->getDefinedFunctions()[0]->isFullyImplemented());
+}
+
BOOST_AUTO_TEST_CASE(function_canonical_signature)
{
ASTPointer<SourceUnit> sourceUnit;
diff --git a/SolidityParser.cpp b/SolidityParser.cpp
index 392d9ac4..7640f91a 100644
--- a/SolidityParser.cpp
+++ b/SolidityParser.cpp
@@ -108,6 +108,14 @@ BOOST_AUTO_TEST_CASE(single_function_param)
ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed.");
}
+BOOST_AUTO_TEST_CASE(function_no_body)
+{
+ char const* text = "contract test {\n"
+ " function functionName(bytes32 input) returns (bytes32 out);\n"
+ "}\n";
+ ETH_TEST_CHECK_NO_THROW(parseText(text), "Parsing failed.");
+}
+
BOOST_AUTO_TEST_CASE(missing_parameter_name_in_named_args)
{
char const* text = "contract test {\n"