From fedded3ec1d3051589777a61aba14720432f1d51 Mon Sep 17 00:00:00 2001
From: Fabio Berger <me@fabioberger.com>
Date: Wed, 23 Aug 2017 17:27:54 +0200
Subject: Add public method `getTokenMetadataIfExistsAsync` to TokenRegistry
 wrapper, refactor `getTokensAsync` to use `getTokenMetadataIfExistsAsync`
 under the hood and added unit tests

---
 test/token_registry_wrapper_test.ts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

(limited to 'test/token_registry_wrapper_test.ts')

diff --git a/test/token_registry_wrapper_test.ts b/test/token_registry_wrapper_test.ts
index da436161c..a3e5adf6c 100644
--- a/test/token_registry_wrapper_test.ts
+++ b/test/token_registry_wrapper_test.ts
@@ -38,4 +38,20 @@ describe('TokenRegistryWrapper', () => {
             });
         });
     });
+    describe('#getTokenMetadataIfExistsAsync', () => {
+        it('should return the token added to the tokenRegistry during the migration', async () => {
+            const tokens = await zeroEx.tokenRegistry.getTokensAsync();
+            const aToken = tokens[0];
+
+            const token = await zeroEx.tokenRegistry.getTokenMetadataIfExistsAsync(aToken.address);
+            const schemaValidator = new SchemaValidator();
+            const validationResult = schemaValidator.validate(token, tokenSchema);
+            expect(validationResult.errors).to.have.lengthOf(0);
+        });
+        it('should return return undefined when passed a token address not in the tokenRegistry', async () => {
+            const unregisteredTokenAddress = '0x5409ED021D9299bf6814279A6A1411A7e866A631';
+            const tokenIfExists = await zeroEx.tokenRegistry.getTokenMetadataIfExistsAsync(unregisteredTokenAddress);
+            expect(tokenIfExists).to.be.undefined();
+        });
+    });
 });
-- 
cgit v1.2.3


From 2a7da4fc4f344c1359aac93f286bb878447e67c6 Mon Sep 17 00:00:00 2001
From: Fabio Berger <me@fabioberger.com>
Date: Wed, 23 Aug 2017 18:13:26 +0200
Subject: use non-checksummed address

---
 test/token_registry_wrapper_test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'test/token_registry_wrapper_test.ts')

diff --git a/test/token_registry_wrapper_test.ts b/test/token_registry_wrapper_test.ts
index a3e5adf6c..72d385b48 100644
--- a/test/token_registry_wrapper_test.ts
+++ b/test/token_registry_wrapper_test.ts
@@ -49,8 +49,8 @@ describe('TokenRegistryWrapper', () => {
             expect(validationResult.errors).to.have.lengthOf(0);
         });
         it('should return return undefined when passed a token address not in the tokenRegistry', async () => {
-            const unregisteredTokenAddress = '0x5409ED021D9299bf6814279A6A1411A7e866A631';
             const tokenIfExists = await zeroEx.tokenRegistry.getTokenMetadataIfExistsAsync(unregisteredTokenAddress);
+            const unregisteredTokenAddress = '0x5409ed021d9299bf6814279a6a1411a7e866a631';
             expect(tokenIfExists).to.be.undefined();
         });
     });
-- 
cgit v1.2.3


From 98be7867649337a18441e517790c748c722ee730 Mon Sep 17 00:00:00 2001
From: Fabio Berger <me@fabioberger.com>
Date: Wed, 23 Aug 2017 18:14:19 +0200
Subject: rename method for clarity since we return a Token and not
 tokenMetadata

---
 test/token_registry_wrapper_test.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'test/token_registry_wrapper_test.ts')

diff --git a/test/token_registry_wrapper_test.ts b/test/token_registry_wrapper_test.ts
index 72d385b48..6b5640c6c 100644
--- a/test/token_registry_wrapper_test.ts
+++ b/test/token_registry_wrapper_test.ts
@@ -38,19 +38,19 @@ describe('TokenRegistryWrapper', () => {
             });
         });
     });
-    describe('#getTokenMetadataIfExistsAsync', () => {
+    describe('#getTokenIfExistsAsync', () => {
         it('should return the token added to the tokenRegistry during the migration', async () => {
             const tokens = await zeroEx.tokenRegistry.getTokensAsync();
             const aToken = tokens[0];
 
-            const token = await zeroEx.tokenRegistry.getTokenMetadataIfExistsAsync(aToken.address);
+            const token = await zeroEx.tokenRegistry.getTokenIfExistsAsync(aToken.address);
             const schemaValidator = new SchemaValidator();
             const validationResult = schemaValidator.validate(token, tokenSchema);
             expect(validationResult.errors).to.have.lengthOf(0);
         });
         it('should return return undefined when passed a token address not in the tokenRegistry', async () => {
-            const tokenIfExists = await zeroEx.tokenRegistry.getTokenMetadataIfExistsAsync(unregisteredTokenAddress);
             const unregisteredTokenAddress = '0x5409ed021d9299bf6814279a6a1411a7e866a631';
+            const tokenIfExists = await zeroEx.tokenRegistry.getTokenIfExistsAsync(unregisteredTokenAddress);
             expect(tokenIfExists).to.be.undefined();
         });
     });
-- 
cgit v1.2.3