From 55c491f8ea8bb0ba8cb1b856b3c42dd05c31565d Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Thu, 25 May 2017 11:19:14 +0200 Subject: Add generateSalt and tests for it --- src/ts/0x.js.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'src') diff --git a/src/ts/0x.js.ts b/src/ts/0x.js.ts index acbdd01e2..14f9f2061 100644 --- a/src/ts/0x.js.ts +++ b/src/ts/0x.js.ts @@ -11,6 +11,8 @@ export interface ECSignature { s: string; } +const MAX_DIGITS_IN_UNSIGNED_256_INT = 78; + export class ZeroEx { /** * Verifies that the elliptic curve signature `signature` was generated @@ -34,4 +36,13 @@ export class ZeroEx { return false; } } + /** Generates pseudo-random 256 bits salt */ + public static generatePseudoRandomSalt(): BigNumber.BigNumber { + // BigNumber.random returns a pseudo-random number between 0 & 1 with a passed in number of decimal places. + // Source: https://mikemcl.github.io/bignumber.js/#random + const randomNumber = BigNumber.random(MAX_DIGITS_IN_UNSIGNED_256_INT); + const factor = new BigNumber(10).pow(MAX_DIGITS_IN_UNSIGNED_256_INT - 1); + const salt = randomNumber.times(factor).round(); + return salt; + } } -- cgit v1.2.3 From 8fe580ea526a048148df2b3545f903eae660ed58 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Thu, 25 May 2017 11:38:01 +0200 Subject: More descriptive comment --- src/ts/0x.js.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/ts/0x.js.ts b/src/ts/0x.js.ts index 14f9f2061..4b9680a18 100644 --- a/src/ts/0x.js.ts +++ b/src/ts/0x.js.ts @@ -36,7 +36,11 @@ export class ZeroEx { return false; } } - /** Generates pseudo-random 256 bits salt */ + /** + * Generates pseudo-random 256 bit salt. + * The salt is used to ensure that the 0x order generated has a unique orderHash that does + * not collide with any other outstanding orders. + */ public static generatePseudoRandomSalt(): BigNumber.BigNumber { // BigNumber.random returns a pseudo-random number between 0 & 1 with a passed in number of decimal places. // Source: https://mikemcl.github.io/bignumber.js/#random -- cgit v1.2.3