From dca572e74442534dc9f1bb853b2d8e9fe018639a Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 9 Jun 2017 11:17:32 +0200 Subject: Fix the bug of not awaiting an async function --- src/contract_wrappers/exchange_wrapper.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/contract_wrappers') diff --git a/src/contract_wrappers/exchange_wrapper.ts b/src/contract_wrappers/exchange_wrapper.ts index 73ec0886c..7fedf3183 100644 --- a/src/contract_wrappers/exchange_wrapper.ts +++ b/src/contract_wrappers/exchange_wrapper.ts @@ -282,10 +282,9 @@ export class ExchangeWrapper extends ContractWrapper { orderFillOrKillRequestsSchema, ); const exchangeInstance = await this.getExchangeContractAsync(); - _.each(orderFillOrKillRequests, request => { - this.validateFillOrKillOrderAndThrowIfInvalidAsync(request.signedOrder, - exchangeInstance.address, - request.fillTakerAmount); + _.each(orderFillOrKillRequests, async request => { + await this.validateFillOrKillOrderAndThrowIfInvalidAsync(request.signedOrder, exchangeInstance.address, + request.fillTakerAmount); }); const orderAddressesValuesAndTakerTokenFillAmounts = _.map(orderFillOrKillRequests, request => { -- cgit v1.2.3 From 9ffd36d57f2926629f8ca7e48ede87b2a6929ff9 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 9 Jun 2017 15:52:18 +0200 Subject: Use for of --- src/contract_wrappers/exchange_wrapper.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/contract_wrappers') diff --git a/src/contract_wrappers/exchange_wrapper.ts b/src/contract_wrappers/exchange_wrapper.ts index 7fedf3183..b1b21f873 100644 --- a/src/contract_wrappers/exchange_wrapper.ts +++ b/src/contract_wrappers/exchange_wrapper.ts @@ -282,10 +282,10 @@ export class ExchangeWrapper extends ContractWrapper { orderFillOrKillRequestsSchema, ); const exchangeInstance = await this.getExchangeContractAsync(); - _.each(orderFillOrKillRequests, async request => { + for (const request of orderFillOrKillRequests) { await this.validateFillOrKillOrderAndThrowIfInvalidAsync(request.signedOrder, exchangeInstance.address, request.fillTakerAmount); - }); + } const orderAddressesValuesAndTakerTokenFillAmounts = _.map(orderFillOrKillRequests, request => { return [ -- cgit v1.2.3