From 7b318b3cc20fa9185849db36429e307bbbf9d950 Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Fri, 13 Apr 2018 13:39:32 +1000 Subject: Update the Changelog with pr number --- packages/0x.js/CHANGELOG.json | 9 +++++++++ packages/dev-utils/CHANGELOG.json | 9 +++++++++ packages/dev-utils/src/web3_factory.ts | 2 +- 3 files changed, 19 insertions(+), 1 deletion(-) (limited to 'packages') diff --git a/packages/0x.js/CHANGELOG.json b/packages/0x.js/CHANGELOG.json index 9b5c52d00..a54550660 100644 --- a/packages/0x.js/CHANGELOG.json +++ b/packages/0x.js/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "0.36.1", + "changes": [ + { + "note": "Remove truffle-hdwallet from artifact tests", + "pr": 524 + } + ], + }, { "version": "0.36.0", "changes": [ diff --git a/packages/dev-utils/CHANGELOG.json b/packages/dev-utils/CHANGELOG.json index b5dd3732d..8faf71d6a 100644 --- a/packages/dev-utils/CHANGELOG.json +++ b/packages/dev-utils/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "0.3.6", + "changes": [ + { + "note": "Allow an rpcURL to be set in Web3Config (for testnet RPC endpoints)", + "pr": 524 + } + ] + }, { "timestamp": 1523462196, "version": "0.3.5", diff --git a/packages/dev-utils/src/web3_factory.ts b/packages/dev-utils/src/web3_factory.ts index 5519bec2b..68348d671 100644 --- a/packages/dev-utils/src/web3_factory.ts +++ b/packages/dev-utils/src/web3_factory.ts @@ -54,7 +54,7 @@ export const web3Factory = { }; const shouldUseInProcessGanache = !!config.shouldUseInProcessGanache; if (shouldUseInProcessGanache) { - if (_.isUndefined(config.rpcUrl)) { + if (!_.isUndefined(config.rpcUrl)) { throw new Error('Cannot use both GanacheSubrovider and RPCSubprovider'); } provider.addProvider( -- cgit v1.2.3