From 101e9be7b928493efe96c6a3c05641c68e30a02e Mon Sep 17 00:00:00 2001 From: Amir Bandeali Date: Fri, 25 May 2018 15:04:44 -0700 Subject: Change names of signature types --- .../current/protocol/Exchange/MixinSignatureValidator.sol | 8 ++++---- .../current/protocol/Exchange/mixins/MSignatureValidator.sol | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'packages') diff --git a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol index 4b0b1d02d..fc61112eb 100644 --- a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol +++ b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol @@ -132,7 +132,7 @@ contract MixinSignatureValidator is return isValid; // Signed using web3.eth_sign - } else if (signatureType == SignatureType.Ecrecover) { + } else if (signatureType == SignatureType.EthSign) { require( signature.length == 65, INVALID_SIGNATURE_LENGTH @@ -165,9 +165,9 @@ contract MixinSignatureValidator is isValid = signer == msg.sender; return isValid; - // Signature verified by signer contract. - // If used with an order, the maker of the order is the signer contract. - } else if (signatureType == SignatureType.Signer) { + // Signature verified by wallet contract. + // If used with an order, the maker of the order is the wallet contract. + } else if (signatureType == SignatureType.Wallet) { isValid = ISigner(signer).isValidSignature(hash, signature); return isValid; diff --git a/packages/contracts/src/contracts/current/protocol/Exchange/mixins/MSignatureValidator.sol b/packages/contracts/src/contracts/current/protocol/Exchange/mixins/MSignatureValidator.sol index dc08c6d27..7eed453ff 100644 --- a/packages/contracts/src/contracts/current/protocol/Exchange/mixins/MSignatureValidator.sol +++ b/packages/contracts/src/contracts/current/protocol/Exchange/mixins/MSignatureValidator.sol @@ -28,9 +28,9 @@ contract MSignatureValidator is Illegal, // 0x00, default value Invalid, // 0x01 EIP712, // 0x02 - Ecrecover, // 0x03 + EthSign, // 0x03 Caller, // 0x04 - Signer, // 0x05 + Wallet, // 0x05 Validator, // 0x06 PreSigned, // 0x07 Trezor // 0x08 -- cgit v1.2.3