From d057b77dc5585756f1df7fad03a415314bd9111b Mon Sep 17 00:00:00 2001 From: fragosti Date: Thu, 24 May 2018 10:42:48 -0700 Subject: Address PR feedback --- .../website/ts/components/onboarding/onboarding_flow.tsx | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'packages/website/ts/components/onboarding') diff --git a/packages/website/ts/components/onboarding/onboarding_flow.tsx b/packages/website/ts/components/onboarding/onboarding_flow.tsx index 350319c63..dd417856f 100644 --- a/packages/website/ts/components/onboarding/onboarding_flow.tsx +++ b/packages/website/ts/components/onboarding/onboarding_flow.tsx @@ -4,24 +4,19 @@ import Joyride, { Step, StyleOptions } from 'react-joyride'; import { zIndex } from 'ts/utils/style'; -interface OnboardingFlowProps { +export interface OnboardingFlowProps { steps: Step[]; stepIndex: number; isRunning: boolean; onClose: () => void; - onChange?: (options: any) => void; } -const style: StyleOptions = { +const joyrideStyleOptions: StyleOptions = { zIndex: zIndex.overlay, }; // Wrapper around Joyride with defaults and styles set export class OnboardingFlow extends React.Component { - public static defaultProps: Partial = { - onChange: _.noop, - }; - public render(): React.ReactNode { return ( { debug={true} steps={this.props.steps} stepIndex={this.props.stepIndex} - styles={{ options: style }} + styles={{ options: joyrideStyleOptions }} callback={this._handleChange.bind(this)} /> ); @@ -40,6 +35,5 @@ export class OnboardingFlow extends React.Component { case 'close': this.props.onClose(); } - this.props.onChange(options); } } -- cgit v1.2.3