From 82d59dbea80c351a5ac8de34debd182775eb870e Mon Sep 17 00:00:00 2001 From: Bryce Date: Fri, 22 Jun 2018 13:35:49 -0700 Subject: Address INVALID_ARGUMENT issue --- packages/typescript-typings/types/ethers/index.d.ts | 3 +++ 1 file changed, 3 insertions(+) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/types/ethers/index.d.ts b/packages/typescript-typings/types/ethers/index.d.ts index d40428a9b..c3ec82163 100644 --- a/packages/typescript-typings/types/ethers/index.d.ts +++ b/packages/typescript-typings/types/ethers/index.d.ts @@ -31,4 +31,7 @@ declare module 'ethers' { public static getDeployTransaction(bytecode: string, abi: any, ...args: any[]): Partial; constructor(address: string, abi: any, provider: any); } + const enum errors { + INVALID_ARGUMENT = 'INVALID_ARGUMENT', + } } -- cgit v1.2.3 From 69625946b173737932060bfa1b3a6f25d2c3acdf Mon Sep 17 00:00:00 2001 From: Bryce Date: Fri, 22 Jun 2018 16:56:19 -0700 Subject: Typings and comment --- packages/typescript-typings/CHANGELOG.json | 9 +++++++++ packages/typescript-typings/package.json | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/CHANGELOG.json b/packages/typescript-typings/CHANGELOG.json index 5b5d5c31d..a2081e3b9 100644 --- a/packages/typescript-typings/CHANGELOG.json +++ b/packages/typescript-typings/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "0.4.2", + "changes": [ + { + "note": "Additional error type for `ethers.js`", + "pr": 763 + } + ] + }, { "timestamp": 1529397769, "version": "0.4.1", diff --git a/packages/typescript-typings/package.json b/packages/typescript-typings/package.json index f10d35666..3ba7c10ba 100644 --- a/packages/typescript-typings/package.json +++ b/packages/typescript-typings/package.json @@ -1,6 +1,6 @@ { "name": "@0xproject/typescript-typings", - "version": "0.4.1", + "version": "0.4.2", "engines": { "node": ">=6.12" }, -- cgit v1.2.3 From e59c57106cd15d45efb6f4100529cf6e5dfe71a8 Mon Sep 17 00:00:00 2001 From: Bryce Date: Mon, 25 Jun 2018 09:44:56 -0700 Subject: Run prettier --- packages/typescript-typings/types/ethers/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/types/ethers/index.d.ts b/packages/typescript-typings/types/ethers/index.d.ts index c3ec82163..f869196e0 100644 --- a/packages/typescript-typings/types/ethers/index.d.ts +++ b/packages/typescript-typings/types/ethers/index.d.ts @@ -32,6 +32,6 @@ declare module 'ethers' { constructor(address: string, abi: any, provider: any); } const enum errors { - INVALID_ARGUMENT = 'INVALID_ARGUMENT', + INVALID_ARGUMENT = 'INVALID_ARGUMENT', } } -- cgit v1.2.3 From 84bd54ba4025a33f4e311ec66d81d58b45e54d6b Mon Sep 17 00:00:00 2001 From: Nikita Galkin Date: Sat, 23 Jun 2018 16:32:07 +0300 Subject: Improve 'web3-provider-engine' typings --- packages/typescript-typings/CHANGELOG.json | 9 +++++++++ .../typescript-typings/types/web3-provider-engine/index.d.ts | 10 +++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/CHANGELOG.json b/packages/typescript-typings/CHANGELOG.json index 5b5d5c31d..c76e0d4c0 100644 --- a/packages/typescript-typings/CHANGELOG.json +++ b/packages/typescript-typings/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "0.4.2", + "changes": [ + { + "note": "Improve 'web3-provider-engine' typings", + "pr": 768 + } + ] + }, { "timestamp": 1529397769, "version": "0.4.1", diff --git a/packages/typescript-typings/types/web3-provider-engine/index.d.ts b/packages/typescript-typings/types/web3-provider-engine/index.d.ts index 1733f2731..72ef434a7 100644 --- a/packages/typescript-typings/types/web3-provider-engine/index.d.ts +++ b/packages/typescript-typings/types/web3-provider-engine/index.d.ts @@ -1,6 +1,12 @@ declare module 'web3-provider-engine' { import { Provider, JSONRPCRequestPayload, JSONRPCResponsePayload } from 'ethereum-types'; + interface Web3ProviderEngineOptions { + pollingInterval?: number; + blockTracker?: any; + blockTrackerProvider?: any; + } class Web3ProviderEngine implements Provider { + constructor(options?: Web3ProviderEngineOptions); public on(event: string, handler: () => void): void; public send(payload: JSONRPCRequestPayload): void; public sendAsync( @@ -8,7 +14,9 @@ declare module 'web3-provider-engine' { callback: (error: null | Error, response: JSONRPCResponsePayload) => void, ): void; public addProvider(provider: any): void; - public start(): void; + // start block polling + public start(callback?: () => void): void; + // stop block polling public stop(): void; } export = Web3ProviderEngine; -- cgit v1.2.3 From 6c8b99850529cb1403a09327a0088c2d5b43cba7 Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Wed, 27 Jun 2018 11:28:41 +0200 Subject: Fix tslint --- packages/typescript-typings/CHANGELOG.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/CHANGELOG.json b/packages/typescript-typings/CHANGELOG.json index 9c78c538a..25ff73274 100644 --- a/packages/typescript-typings/CHANGELOG.json +++ b/packages/typescript-typings/CHANGELOG.json @@ -7,8 +7,8 @@ "pr": 768 }, { - "note": "Additional error type for `ethers.js`", - "pr": 763 + "note": "Additional error type for `ethers.js`", + "pr": 763 } ] }, -- cgit v1.2.3 From 51211a21ba64d81c50eb4e13146b1246c8da46e0 Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Wed, 27 Jun 2018 18:33:32 +0200 Subject: Improve `ganache-core`'s `GanacheOpts` type and require it instead of `any` --- packages/typescript-typings/types/ganache-core/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/types/ganache-core/index.d.ts b/packages/typescript-typings/types/ganache-core/index.d.ts index 84635038f..c07e6a78e 100644 --- a/packages/typescript-typings/types/ganache-core/index.d.ts +++ b/packages/typescript-typings/types/ganache-core/index.d.ts @@ -7,7 +7,9 @@ declare module 'ganache-core' { }; port?: number; network_id?: number; + networkId?: number; mnemonic?: string; + gasLimit?: number; } // tslint:disable-next-line:completed-docs export function provider(opts: GanacheOpts): Provider; -- cgit v1.2.3 From e58e35e098952259c0c3f59ea1132669aab7d36d Mon Sep 17 00:00:00 2001 From: Amir Bandeali Date: Fri, 29 Jun 2018 12:38:57 -0700 Subject: Move ledgerhq module declarations to typescript-typings --- packages/typescript-typings/CHANGELOG.json | 4 ++ .../typescript-typings/types/@ledgerhq/index.d.ts | 45 ++++++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 packages/typescript-typings/types/@ledgerhq/index.d.ts (limited to 'packages/typescript-typings') diff --git a/packages/typescript-typings/CHANGELOG.json b/packages/typescript-typings/CHANGELOG.json index 25ff73274..1f397e622 100644 --- a/packages/typescript-typings/CHANGELOG.json +++ b/packages/typescript-typings/CHANGELOG.json @@ -9,6 +9,10 @@ { "note": "Additional error type for `ethers.js`", "pr": 763 + }, + { + "note": "Add @ledgerhq typings", + "pr": 770 } ] }, diff --git a/packages/typescript-typings/types/@ledgerhq/index.d.ts b/packages/typescript-typings/types/@ledgerhq/index.d.ts new file mode 100644 index 000000000..724dacb76 --- /dev/null +++ b/packages/typescript-typings/types/@ledgerhq/index.d.ts @@ -0,0 +1,45 @@ +// Ledgerco declarations +interface ECSignatureString { + v: string; + r: string; + s: string; +} +interface ECSignature { + v: number; + r: string; + s: string; +} + +interface LedgerTransport { + close(): Promise; +} + +declare module '@ledgerhq/hw-app-eth' { + class Eth { + public transport: LedgerTransport; + constructor(transport: LedgerTransport); + public getAddress( + path: string, + boolDisplay?: boolean, + boolChaincode?: boolean, + ): Promise<{ publicKey: string; address: string; chainCode: string }>; + public signTransaction(path: string, rawTxHex: string): Promise; + public getAppConfiguration(): Promise<{ arbitraryDataEnabled: number; version: string }>; + public signPersonalMessage(path: string, messageHex: string): Promise; + } + export default Eth; +} + +declare module '@ledgerhq/hw-transport-u2f' { + export default class TransportU2F implements LedgerTransport { + public static create(): Promise; + public close(): Promise; + } +} + +declare module '@ledgerhq/hw-transport-node-hid' { + export default class TransportNodeHid implements LedgerTransport { + public static create(): Promise; + public close(): Promise; + } +} -- cgit v1.2.3