From 6e2e658162a5a128b722ba105f92fa5267c4bd62 Mon Sep 17 00:00:00 2001 From: Alex Browne Date: Wed, 8 Aug 2018 11:27:38 -0700 Subject: Update TypeScript to version 2.9.2 --- packages/types/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/types') diff --git a/packages/types/package.json b/packages/types/package.json index d2fefa136..e42c44630 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -30,7 +30,7 @@ "make-promises-safe": "^1.1.0", "shx": "^0.2.2", "tslint": "5.11.0", - "typescript": "2.7.1" + "typescript": "2.9.2" }, "dependencies": { "@types/node": "^8.0.53", -- cgit v1.2.3 From 45e9fbe8f93f68f3786629fff1861b1a66b90635 Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Tue, 31 Jul 2018 17:24:19 +0800 Subject: Introduce SignerProviderType This allows the developer to indicate the nuanced signer provider. Some have different implementations (trezor, ledger) and others have different implementations (metamask). Breaking the abstraction of eth_sign. EthSign assumes a spec compliant implementation and can be used as a default --- packages/types/src/index.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'packages/types') diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 7774b61b0..ba384dbb8 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -142,6 +142,16 @@ export enum SignatureType { NSignatureTypes, } +/** + * The Signer Provider Type. Some Signer implementations use different message prefixes or implement different + * eth_sign behaviour. Note EthSign is compatible with the Ledger device. + */ +export enum SignerProviderType { + EthSign = 'ETH_SIGN', + Metamask = 'METAMASK', + Trezor = 'TREZOR', +} + /** * Elliptic Curve signature */ -- cgit v1.2.3 From 5d4dd406f2946b43377049d7422c72b433bc64ab Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Fri, 3 Aug 2018 11:53:26 +0800 Subject: Update Changelogs. Rebased from development --- packages/types/CHANGELOG.json | 9 +++++++++ packages/types/src/index.ts | 5 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) (limited to 'packages/types') diff --git a/packages/types/CHANGELOG.json b/packages/types/CHANGELOG.json index 8520c5146..057d3451c 100644 --- a/packages/types/CHANGELOG.json +++ b/packages/types/CHANGELOG.json @@ -1,4 +1,13 @@ [ + { + "version": "pending", + "changes": [ + { + "pr": 914, + "note": "Added SignerProviderType" + } + ] + }, { "version": "1.0.1-rc.3", "changes": [ diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index ba384dbb8..58399de4c 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -143,11 +143,12 @@ export enum SignatureType { } /** - * The Signer Provider Type. Some Signer implementations use different message prefixes or implement different - * eth_sign behaviour. Note EthSign is compatible with the Ledger device. + * The Signer Provider Type. Some Signer provider implementations use different message prefixes or implement different + * eth_sign behaviour. */ export enum SignerProviderType { EthSign = 'ETH_SIGN', + Ledger = 'LEDGER', Metamask = 'METAMASK', Trezor = 'TREZOR', } -- cgit v1.2.3 From ca4905c3436931684d113ec66882836a4d0b265b Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Thu, 9 Aug 2018 12:24:52 +1000 Subject: Rename from SignerProviderType.EthSign to SignerType.Default --- packages/types/CHANGELOG.json | 2 +- packages/types/src/index.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'packages/types') diff --git a/packages/types/CHANGELOG.json b/packages/types/CHANGELOG.json index 057d3451c..4f60310e6 100644 --- a/packages/types/CHANGELOG.json +++ b/packages/types/CHANGELOG.json @@ -4,7 +4,7 @@ "changes": [ { "pr": 914, - "note": "Added SignerProviderType" + "note": "Added SignerType to handle different signing prefix scenarios" } ] }, diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 58399de4c..fa634420d 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -143,11 +143,11 @@ export enum SignatureType { } /** - * The Signer Provider Type. Some Signer provider implementations use different message prefixes or implement different - * eth_sign behaviour. + * The type of the Signer implementation. Some signer implementations use different message prefixes (e.g Trezor) or implement different + * eth_sign behaviour (e.g Metamask). Default assumes a spec compliant `eth_sign`. */ -export enum SignerProviderType { - EthSign = 'ETH_SIGN', +export enum SignerType { + Default = 'DEFAULT', Ledger = 'LEDGER', Metamask = 'METAMASK', Trezor = 'TREZOR', -- cgit v1.2.3 From a3517574936aa6a4911003dbff06302926b04cb4 Mon Sep 17 00:00:00 2001 From: Jacob Evans Date: Tue, 14 Aug 2018 08:32:16 +1000 Subject: Update version numbers. Add source for Metamask future fix. Consolidate switch statement to one return --- packages/types/CHANGELOG.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/types') diff --git a/packages/types/CHANGELOG.json b/packages/types/CHANGELOG.json index 4f60310e6..9d78d3dc0 100644 --- a/packages/types/CHANGELOG.json +++ b/packages/types/CHANGELOG.json @@ -1,6 +1,6 @@ [ { - "version": "pending", + "version": "1.0.1-rc.4", "changes": [ { "pr": 914, -- cgit v1.2.3 From 7c8a7a24209ae518d7a7d3c45829d75d224ce3a3 Mon Sep 17 00:00:00 2001 From: Alex Browne Date: Mon, 13 Aug 2018 18:34:37 -0700 Subject: Updated CHANGELOGS --- packages/types/CHANGELOG.json | 3 ++- packages/types/CHANGELOG.md | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) (limited to 'packages/types') diff --git a/packages/types/CHANGELOG.json b/packages/types/CHANGELOG.json index 9d78d3dc0..4b9019cd4 100644 --- a/packages/types/CHANGELOG.json +++ b/packages/types/CHANGELOG.json @@ -6,7 +6,8 @@ "pr": 914, "note": "Added SignerType to handle different signing prefix scenarios" } - ] + ], + "timestamp": 1534210131 }, { "version": "1.0.1-rc.3", diff --git a/packages/types/CHANGELOG.md b/packages/types/CHANGELOG.md index 98439a807..9be0c8bca 100644 --- a/packages/types/CHANGELOG.md +++ b/packages/types/CHANGELOG.md @@ -5,6 +5,10 @@ Edit the package's CHANGELOG.json file only. CHANGELOG +## v1.0.1-rc.4 - _August 13, 2018_ + + * Added SignerType to handle different signing prefix scenarios (#914) + ## v1.0.1-rc.3 - _July 26, 2018_ * Dependencies updated @@ -21,7 +25,7 @@ CHANGELOG * Dependencies updated -## v1.0.0-rc.1 - _July 20, 2018_ +## v1.0.0-rc.1 - _July 19, 2018_ * Updated types for V2 of 0x protocol * Add `ECSignatureBuffer` @@ -44,7 +48,7 @@ CHANGELOG * Make OpCode type an enum (#589) * Moved ExchangeContractErrs, DoneCallback, Token, OrderRelevantState, OrderStateValid, OrderStateInvalid, OrderState, OrderAddresses and OrderValues types from 0x.js (#579) -## v0.6.3 - _May 5, 2018_ +## v0.6.3 - _May 4, 2018_ * Dependencies updated -- cgit v1.2.3 From fadd292ecf367e42154856509d0ea0c20b23f2f1 Mon Sep 17 00:00:00 2001 From: Alex Browne Date: Mon, 13 Aug 2018 18:34:51 -0700 Subject: Publish - 0x.js@1.0.1-rc.3 - @0xproject/abi-gen@1.0.5 - @0xproject/assert@1.0.5 - @0xproject/base-contract@2.0.0-rc.1 - @0xproject/connect@1.0.5 - @0xproject/contract-wrappers@1.0.1-rc.3 - contracts@2.1.40 - @0xproject/dev-utils@1.0.4 - ethereum-types@1.0.4 - @0xproject/fill-scenarios@1.0.1-rc.3 - @0xproject/json-schemas@1.0.1-rc.4 - @0xproject/metacoin@0.0.15 - @0xproject/migrations@1.0.4 - @0xproject/monorepo-scripts@1.0.5 - @0xproject/order-utils@1.0.1-rc.3 - @0xproject/order-watcher@1.0.1-rc.3 - @0xproject/react-docs@1.0.5 - @0xproject/react-docs-example@0.0.20 - @0xproject/react-shared@1.0.6 - @0xproject/sol-compiler@1.0.5 - @0xproject/sol-cov@2.0.0 - @0xproject/sol-resolver@1.0.5 - @0xproject/sra-api@1.0.1-rc.4 - @0xproject/sra-report@1.0.5 - @0xproject/subproviders@1.0.5 - @0xproject/testnet-faucets@1.0.41 - @0xproject/tslint-config@1.0.5 - @0xproject/types@1.0.1-rc.4 - @0xproject/typescript-typings@1.0.4 - @0xproject/utils@1.0.5 - @0xproject/web3-wrapper@1.2.0 - @0xproject/website@0.0.44 --- packages/types/package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'packages/types') diff --git a/packages/types/package.json b/packages/types/package.json index e42c44630..c97984e10 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -1,6 +1,6 @@ { "name": "@0xproject/types", - "version": "1.0.1-rc.3", + "version": "1.0.1-rc.4", "engines": { "node": ">=6.12" }, @@ -24,8 +24,8 @@ }, "homepage": "https://github.com/0xProject/0x-monorepo/packages/types/README.md", "devDependencies": { - "@0xproject/monorepo-scripts": "^1.0.4", - "@0xproject/tslint-config": "^1.0.4", + "@0xproject/monorepo-scripts": "^1.0.5", + "@0xproject/tslint-config": "^1.0.5", "copyfiles": "^1.2.0", "make-promises-safe": "^1.1.0", "shx": "^0.2.2", @@ -35,7 +35,7 @@ "dependencies": { "@types/node": "^8.0.53", "bignumber.js": "~4.1.0", - "ethereum-types": "^1.0.3" + "ethereum-types": "^1.0.4" }, "publishConfig": { "access": "public" -- cgit v1.2.3