From b74957acdfc8d67d154bcb4698acd7575db7cc47 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 11 May 2018 17:38:51 +0200 Subject: Add missing type definitions --- packages/tslint-config/rules/underscorePrivateAndProtectedRule.ts | 4 ++-- packages/tslint-config/tslint.json | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/rules/underscorePrivateAndProtectedRule.ts b/packages/tslint-config/rules/underscorePrivateAndProtectedRule.ts index 2f05b0c18..8c039bea7 100644 --- a/packages/tslint-config/rules/underscorePrivateAndProtectedRule.ts +++ b/packages/tslint-config/rules/underscorePrivateAndProtectedRule.ts @@ -50,10 +50,10 @@ function isRelevantClassMember(node: ts.Node): node is RelevantClassMember { return false; } } -function nameStartsWithUnderscore(text: string) { +function nameStartsWithUnderscore(text: string): boolean { return text.charCodeAt(0) === UNDERSCORE.charCodeAt(0); } -function memberIsPrivate(node: ts.Declaration) { +function memberIsPrivate(node: ts.Declaration): boolean { return Lint.hasModifier(node.modifiers, ts.SyntaxKind.PrivateKeyword, ts.SyntaxKind.ProtectedKeyword); } function nameIsIdentifier(node: ts.Node): node is ts.Identifier { diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index aacfb6d59..1d717430d 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -18,6 +18,7 @@ ], "curly": true, "eofline": true, + "typedef": [true, "call-signature", "parameter", "property-declaration"], "encoding": true, "import-spacing": true, "indent": [true, "spaces", 4], -- cgit v1.2.3 From 478f6ed011185b66ac87323c6d9ad1f598060760 Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Mon, 14 May 2018 19:23:50 +0200 Subject: Move from using lerna multi-package commands to wsrun, update README's accordingly --- packages/tslint-config/README.md | 18 +++--------------- packages/tslint-config/package.json | 2 +- 2 files changed, 4 insertions(+), 16 deletions(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/README.md b/packages/tslint-config/README.md index d90b3cf73..d630ec84d 100644 --- a/packages/tslint-config/README.md +++ b/packages/tslint-config/README.md @@ -40,28 +40,16 @@ yarn install ### Build -If this is your **first** time building this package, you must first build **all** packages within the monorepo. This is because packages that depend on other packages located inside this monorepo are symlinked when run from **within** the monorepo. This allows you to make changes across multiple packages without first publishing dependent packages to NPM. To build all packages, run the following from the monorepo root directory: +To build this package and all other monorepo packages that it depends on, run the following from the monorepo root directory: ```bash -yarn lerna:rebuild +PKG=@0xproject/tslint-config yarn build ``` Or continuously rebuild on change: ```bash -yarn dev -``` - -You can also build this specific package by running the following from within its directory: - -```bash -yarn build -``` - -or continuously rebuild on change: - -```bash -yarn build:watch +PKG=@0xproject/tslint-config yarn watch ``` ### Clean diff --git a/packages/tslint-config/package.json b/packages/tslint-config/package.json index a5b34a35e..04e1ba2b6 100644 --- a/packages/tslint-config/package.json +++ b/packages/tslint-config/package.json @@ -4,7 +4,7 @@ "description": "Lint rules related to 0xProject for TSLint", "main": "tslint.json", "scripts": { - "build:watch": "tsc -w", + "watch": "tsc -w", "build": "tsc && copyfiles -u 2 './lib/monorepo_scripts/**/*' ./scripts", "clean": "shx rm -rf lib scripts", "lint": "tslint --project .", -- cgit v1.2.3 From f86cc0dc7a5d75792b8ef7a38cbf9bba04cb6ab4 Mon Sep 17 00:00:00 2001 From: Alex Browne Date: Wed, 9 May 2018 13:29:43 -0700 Subject: Document Node.js version requirement and add it to package.json --- packages/tslint-config/package.json | 3 +++ 1 file changed, 3 insertions(+) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/package.json b/packages/tslint-config/package.json index a5b34a35e..0f894cecc 100644 --- a/packages/tslint-config/package.json +++ b/packages/tslint-config/package.json @@ -1,6 +1,9 @@ { "name": "@0xproject/tslint-config", "version": "0.4.17", + "engines": { + "node" : ">=8.0.0" + }, "description": "Lint rules related to 0xProject for TSLint", "main": "tslint.json", "scripts": { -- cgit v1.2.3 From fdeab0475c956c48ab79bb5238ae60e732b14e11 Mon Sep 17 00:00:00 2001 From: Alex Browne Date: Thu, 10 May 2018 11:46:02 -0700 Subject: Change minimum Node version to 6.12 --- packages/tslint-config/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/package.json b/packages/tslint-config/package.json index 0f894cecc..2b3c66eb9 100644 --- a/packages/tslint-config/package.json +++ b/packages/tslint-config/package.json @@ -2,7 +2,7 @@ "name": "@0xproject/tslint-config", "version": "0.4.17", "engines": { - "node" : ">=8.0.0" + "node" : ">=6.12" }, "description": "Lint rules related to 0xProject for TSLint", "main": "tslint.json", -- cgit v1.2.3