From c36d85a46c946b5d52164642336f39c90b732376 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 15 Dec 2017 13:14:44 +0100 Subject: Dissallow unused vars/imports --- packages/tslint-config/tslint.json | 1 + 1 file changed, 1 insertion(+) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index d3ee51a63..91185bddb 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -51,6 +51,7 @@ "no-string-throw": true, "no-submodule-imports": false, "no-unnecessary-type-assertion": true, + "no-unused-variable": [true, {"ignore-pattern": "^_\\d*"}], "no-implicit-dependencies": [true, "dev"], "number-literal-format": true, "object-literal-sort-keys": false, -- cgit v1.2.3 From 126048bac9f52871b841d9898cabe7cfd265ebb6 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 15 Dec 2017 13:58:30 +0100 Subject: Fix connect unused vars --- packages/tslint-config/rules/walkers/async_suffix.ts | 1 + 1 file changed, 1 insertion(+) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/rules/walkers/async_suffix.ts b/packages/tslint-config/rules/walkers/async_suffix.ts index 0c89bd99f..7fa7a78b8 100644 --- a/packages/tslint-config/rules/walkers/async_suffix.ts +++ b/packages/tslint-config/rules/walkers/async_suffix.ts @@ -9,6 +9,7 @@ export class AsyncSuffixWalker extends Lint.RuleWalker { const methodName = methodNameNode.getText(); if (!_.isUndefined(node.type)) { if (node.type.kind === ts.SyntaxKind.TypeReference) { + // tslint:disable-next-line:no-unnecessary-type-assertion const returnTypeName = (node.type as ts.TypeReferenceNode).typeName.getText(); if (returnTypeName === 'Promise' && !methodName.endsWith('Async')) { const failure = this.createFailure( -- cgit v1.2.3 From c8e52882ca556ea06696a56e312f69284f99aa29 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Fri, 15 Dec 2017 18:26:45 +0100 Subject: Fix redundant spaces --- packages/tslint-config/package.json | 7 ++++--- packages/tslint-config/tslint.json | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/package.json b/packages/tslint-config/package.json index 3b320e774..888ff675a 100644 --- a/packages/tslint-config/package.json +++ b/packages/tslint-config/package.json @@ -4,9 +4,9 @@ "description": "Lint rules related to 0xProject for TSLint", "main": "tslint.json", "scripts": { - "build": "tsc", - "clean": "shx rm -rf lib", - "lint": "tslint --project . 'rules/**/*.ts'" + "build": "tsc", + "clean": "shx rm -rf lib", + "lint": "tslint --project . 'rules/**/*.ts'" }, "files": [ "tslint.js", @@ -37,6 +37,7 @@ "@types/lodash": "^4.14.86", "shx": "^0.2.2", "tslint": "5.8.0", + "tslint-eslint-rules": "^4.1.1", "typescript": "~2.6.1" }, "dependencies": { diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index 91185bddb..acb6876c3 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -1,7 +1,8 @@ { "extends": [ "tslint:latest", - "tslint-react" + "tslint-react", + "tslint-eslint-rules" ], "rules": { "adjacent-overload-signatures": true, @@ -54,6 +55,7 @@ "no-unused-variable": [true, {"ignore-pattern": "^_\\d*"}], "no-implicit-dependencies": [true, "dev"], "number-literal-format": true, + "object-curly-spacing": [true, "never"], "object-literal-sort-keys": false, "ordered-imports": [ true, -- cgit v1.2.3