From 9778695b4ad1fd999eb79b01c768a2f2b9938917 Mon Sep 17 00:00:00 2001 From: fragosti Date: Mon, 4 Jun 2018 19:48:21 -0700 Subject: Try enabling no-unused-variable... --- packages/tslint-config/rules/booleanNamingRule.ts | 3 ++- packages/tslint-config/rules/customNoMagicNumbersRule.ts | 2 ++ packages/tslint-config/tslint.json | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/rules/booleanNamingRule.ts b/packages/tslint-config/rules/booleanNamingRule.ts index a8e1dc390..6590f689b 100644 --- a/packages/tslint-config/rules/booleanNamingRule.ts +++ b/packages/tslint-config/rules/booleanNamingRule.ts @@ -3,7 +3,7 @@ import * as Lint from 'tslint'; import * as ts from 'typescript'; const VALID_BOOLEAN_PREFIXES = ['is', 'does', 'should', 'was', 'has', 'can', 'did', 'would', 'are']; - +// tslint:disable:no-unnecessary-type-assertion export class Rule extends Lint.Rules.TypedRule { public static FAILURE_STRING = `Boolean variable names should begin with: ${VALID_BOOLEAN_PREFIXES.join(', ')}`; @@ -66,3 +66,4 @@ function handleBooleanNaming( } } } +// tslint:enable:no-unnecessary-type-assertion diff --git a/packages/tslint-config/rules/customNoMagicNumbersRule.ts b/packages/tslint-config/rules/customNoMagicNumbersRule.ts index e358221eb..0a565b2e6 100644 --- a/packages/tslint-config/rules/customNoMagicNumbersRule.ts +++ b/packages/tslint-config/rules/customNoMagicNumbersRule.ts @@ -2,6 +2,7 @@ import * as Lint from 'tslint'; import { isPrefixUnaryExpression } from 'tsutils'; import * as ts from 'typescript'; +// tslint:disable:no-unnecessary-type-assertion /** * A modified version of the no-magic-numbers rule that allows for magic numbers * when instantiating a BigNumber instance. @@ -74,3 +75,4 @@ class CustomNoMagicNumbersWalker extends Lint.AbstractWalker> { } // tslint:enable:no-non-null-assertion } +// tslint:enable:no-unnecessary-type-assertion diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index 77a1f41cc..a7b630885 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -45,6 +45,7 @@ "no-parameter-reassignment": true, "no-redundant-jsdoc": true, "no-return-await": true, + "no-unused-variable": true, "no-string-throw": true, "no-submodule-imports": false, "no-unnecessary-type-assertion": true, -- cgit v1.2.3 From cc6338d0482abd2db253b8755109d4aec801e88d Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Tue, 5 Jun 2018 12:19:28 +0200 Subject: Add `switch-default` tslint rule and add missing default statement --- packages/tslint-config/tslint.json | 1 + 1 file changed, 1 insertion(+) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index 77a1f41cc..ec414fb71 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -7,6 +7,7 @@ "async-suffix": true, "boolean-naming": true, "no-switch-case-fall-through": true, + "switch-default": true, "await-promise": true, "custom-no-magic-numbers": [true, 0, 1, 2, 3, -1], "binary-expression-operand-order": true, -- cgit v1.2.3 From 25f62daf146895a1e0e0c966166f08f28467ae2e Mon Sep 17 00:00:00 2001 From: Fabio Berger Date: Tue, 5 Jun 2018 15:38:40 +0200 Subject: - Rename watch to watch_without_deps in sub-packages, so dev's don't confuse running watch from root dir, with sub-package dir - stop using special prebuild script name and run pre_build steps for `watch` and `build` commands - Remove `clean` step from `build`/`watch` --- packages/tslint-config/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/package.json b/packages/tslint-config/package.json index a64feb836..452ac48a4 100644 --- a/packages/tslint-config/package.json +++ b/packages/tslint-config/package.json @@ -7,7 +7,7 @@ "description": "Lint rules related to 0xProject for TSLint", "main": "tslint.json", "scripts": { - "watch": "tsc -w", + "watch_without_deps": "tsc -w", "build": "tsc && copyfiles -u 2 './lib/monorepo_scripts/**/*' ./scripts", "clean": "shx rm -rf lib scripts", "lint": "tslint --project .", -- cgit v1.2.3 From 59cb2132f27c0c28a1e6077aaac320e485786e65 Mon Sep 17 00:00:00 2001 From: fragosti Date: Tue, 5 Jun 2018 11:46:05 -0700 Subject: Linter now passes --- packages/tslint-config/tslint.json | 1 - 1 file changed, 1 deletion(-) (limited to 'packages/tslint-config') diff --git a/packages/tslint-config/tslint.json b/packages/tslint-config/tslint.json index a7b630885..a3fb356c2 100644 --- a/packages/tslint-config/tslint.json +++ b/packages/tslint-config/tslint.json @@ -28,7 +28,6 @@ "interface-name": false, "interface-over-type-literal": true, "linebreak-style": [true, "LF"], - "max-classes-per-file": false, "max-classes-per-file": [true, 1], "max-line-length": false, "max-file-line-count": [true, 500], -- cgit v1.2.3