From f3026e33fd439bbd550e1814b5f067c36290638b Mon Sep 17 00:00:00 2001
From: Jacob Evans <jacob@dekz.net>
Date: Tue, 6 Mar 2018 08:57:54 -0500
Subject: Force shouldGetChainCode to true in types

---
 packages/subproviders/src/types.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'packages/subproviders/src')

diff --git a/packages/subproviders/src/types.ts b/packages/subproviders/src/types.ts
index 11a178f69..f49ac6107 100644
--- a/packages/subproviders/src/types.ts
+++ b/packages/subproviders/src/types.ts
@@ -10,10 +10,12 @@ export interface LedgerCommunicationClient {
  * NodeJs and Browser communication are supported.
  */
 export interface LedgerEthereumClient {
+    // shouldGetChainCode is defined as `true` instead of `boolean` because other types rely on the assumption
+    // that we get back the chain code and we don't have dependent types to express it properly
     getAddress: (
         derivationPath: string,
-        askForDeviceConfirmation?: boolean,
-        shouldGetChainCode?: boolean,
+        askForDeviceConfirmation: boolean,
+        shouldGetChainCode: true,
     ) => Promise<LedgerGetAddressResult>;
     signTransaction: (derivationPath: string, rawTxHex: string) => Promise<ECSignatureString>;
     signPersonalMessage: (derivationPath: string, messageHex: string) => Promise<ECSignature>;
-- 
cgit v1.2.3