From 6f8a70834b72d678cd9d171d7bb0a3a2cfb4134d Mon Sep 17 00:00:00 2001
From: Fabio Berger <me@fabioberger.com>
Date: Wed, 7 Mar 2018 13:25:15 +0100
Subject: Add onSelectedVersion callback so it can be handled in any way the
 caller wishes

---
 .../react-shared/src/ts/components/nested_sidebar_menu.tsx    |  2 ++
 packages/react-shared/src/ts/components/version_drop_down.tsx | 11 ++---------
 2 files changed, 4 insertions(+), 9 deletions(-)

(limited to 'packages/react-shared/src/ts/components')

diff --git a/packages/react-shared/src/ts/components/nested_sidebar_menu.tsx b/packages/react-shared/src/ts/components/nested_sidebar_menu.tsx
index 6a3cf2615..f562b3113 100644
--- a/packages/react-shared/src/ts/components/nested_sidebar_menu.tsx
+++ b/packages/react-shared/src/ts/components/nested_sidebar_menu.tsx
@@ -18,6 +18,7 @@ export interface NestedSidebarMenuProps {
     onMenuItemClick?: () => void;
     selectedVersion?: string;
     versions?: string[];
+    onVersionSelected?: (semver: string) => void;
 }
 
 export interface NestedSidebarMenuState {}
@@ -69,6 +70,7 @@ export class NestedSidebarMenu extends React.Component<NestedSidebarMenuProps, N
                             <VersionDropDown
                                 selectedVersion={this.props.selectedVersion}
                                 versions={this.props.versions}
+                                onVersionSelected={this.props.onVersionSelected}
                             />
                         </div>
                     )}
diff --git a/packages/react-shared/src/ts/components/version_drop_down.tsx b/packages/react-shared/src/ts/components/version_drop_down.tsx
index 86fe43507..d9e49b205 100644
--- a/packages/react-shared/src/ts/components/version_drop_down.tsx
+++ b/packages/react-shared/src/ts/components/version_drop_down.tsx
@@ -8,6 +8,7 @@ import { utils } from '../utils/utils';
 export interface VersionDropDownProps {
     selectedVersion: string;
     versions: string[];
+    onVersionSelected: (semver: string) => void;
 }
 
 export interface VersionDropDownState {}
@@ -33,14 +34,6 @@ export class VersionDropDown extends React.Component<VersionDropDownProps, Versi
         return items;
     }
     private _updateSelectedVersion(e: any, index: number, semver: string) {
-        let path = window.location.pathname;
-        const lastChar = path[path.length - 1];
-        if (_.isFinite(_.parseInt(lastChar))) {
-            const pathSections = path.split('/');
-            pathSections.pop();
-            path = pathSections.join('/');
-        }
-        const baseUrl = utils.getCurrentBaseUrl();
-        window.location.href = `${baseUrl}${path}/${semver}${window.location.hash}`;
+        this.props.onVersionSelected(semver);
     }
 }
-- 
cgit v1.2.3