From 00f86ca0f7871639d2b0be496f6f8c5e0d8d7ffe Mon Sep 17 00:00:00 2001
From: Alex Browne <stephenalexbrowne@gmail.com>
Date: Tue, 4 Dec 2018 20:04:08 -0800
Subject: Address PR feedback

---
 packages/pipeline/src/entities/exchange_cancel_event.ts       | 2 --
 packages/pipeline/src/entities/exchange_cancel_up_to_event.ts | 2 --
 packages/pipeline/src/entities/exchange_fill_event.ts         | 2 --
 packages/pipeline/src/entities/relayer.ts                     | 3 ---
 packages/pipeline/src/entities/token_metadata.ts              | 9 +++++----
 5 files changed, 5 insertions(+), 13 deletions(-)

(limited to 'packages/pipeline/src/entities')

diff --git a/packages/pipeline/src/entities/exchange_cancel_event.ts b/packages/pipeline/src/entities/exchange_cancel_event.ts
index 2fcc17df6..38f99c903 100644
--- a/packages/pipeline/src/entities/exchange_cancel_event.ts
+++ b/packages/pipeline/src/entities/exchange_cancel_event.ts
@@ -48,6 +48,4 @@ export class ExchangeCancelEvent {
     public takerTokenAddress!: string;
     @Column({ nullable: true, type: String, name: 'taker_token_id' })
     public takerTokenId!: string | null;
-
-    // TODO(albrow): Include topics?
 }
diff --git a/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts b/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts
index 60ead324f..27580305e 100644
--- a/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts
+++ b/packages/pipeline/src/entities/exchange_cancel_up_to_event.ts
@@ -12,7 +12,6 @@ export class ExchangeCancelUpToEvent {
     @PrimaryColumn({ name: 'block_number', transformer: numberToBigIntTransformer })
     public blockNumber!: number;
 
-    // TODO(albrow): Include transaction hash
     @Column({ name: 'raw_data' })
     public rawData!: string;
 
@@ -24,5 +23,4 @@ export class ExchangeCancelUpToEvent {
     public senderAddress!: string;
     @Column({ name: 'order_epoch', type: 'numeric', transformer: bigNumberTransformer })
     public orderEpoch!: BigNumber;
-    // TODO(albrow): Include topics?
 }
diff --git a/packages/pipeline/src/entities/exchange_fill_event.ts b/packages/pipeline/src/entities/exchange_fill_event.ts
index bbf0abf58..9b7727615 100644
--- a/packages/pipeline/src/entities/exchange_fill_event.ts
+++ b/packages/pipeline/src/entities/exchange_fill_event.ts
@@ -57,6 +57,4 @@ export class ExchangeFillEvent {
     public takerTokenAddress!: string;
     @Column({ nullable: true, type: String, name: 'taker_token_id' })
     public takerTokenId!: string | null;
-
-    // TODO(albrow): Include topics?
 }
diff --git a/packages/pipeline/src/entities/relayer.ts b/packages/pipeline/src/entities/relayer.ts
index b3a856fd8..5af8578b4 100644
--- a/packages/pipeline/src/entities/relayer.ts
+++ b/packages/pipeline/src/entities/relayer.ts
@@ -14,9 +14,6 @@ export class Relayer {
     @Column({ name: 'app_url', type: 'varchar', nullable: true })
     public appUrl!: string | null;
 
-    // TODO(albrow): Add exchange contract or protocol version?
-    // TODO(albrow): Add network ids for addresses?
-
     @Column({ name: 'fee_recipient_addresses', type: 'varchar', array: true })
     public feeRecipientAddresses!: string[];
     @Column({ name: 'taker_addresses', type: 'varchar', array: true })
diff --git a/packages/pipeline/src/entities/token_metadata.ts b/packages/pipeline/src/entities/token_metadata.ts
index ca1e57937..911b53972 100644
--- a/packages/pipeline/src/entities/token_metadata.ts
+++ b/packages/pipeline/src/entities/token_metadata.ts
@@ -1,5 +1,8 @@
+import { BigNumber } from '@0x/utils';
 import { Column, Entity, PrimaryColumn } from 'typeorm';
 
+import { bigNumberTransformer } from '../utils/transformers';
+
 @Entity({ name: 'token_metadata', schema: 'raw' })
 export class TokenMetadata {
     @PrimaryColumn({ type: 'varchar', nullable: false })
@@ -8,10 +11,8 @@ export class TokenMetadata {
     @PrimaryColumn({ type: 'varchar', nullable: false })
     public authority!: string;
 
-    // TODO(albrow): Convert decimals field to type BigNumber/numeric because it
-    // comes from a 256-bit integer in a smart contract.
-    @Column({ type: 'integer', nullable: true })
-    public decimals!: number | null;
+    @Column({ type: 'numeric', transformer: bigNumberTransformer, nullable: true })
+    public decimals!: BigNumber | null;
 
     @Column({ type: 'varchar', nullable: true })
     public symbol!: string | null;
-- 
cgit v1.2.3