From 273d3445e46d45fc4fc1438148466e155bc380f3 Mon Sep 17 00:00:00 2001
From: Fabio Berger <me@fabioberger.com>
Date: Fri, 11 May 2018 16:04:03 +0200
Subject: Revert throw conditions since it messes with the expected test timing

---
 packages/fill-scenarios/src/index.ts | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

(limited to 'packages/fill-scenarios')

diff --git a/packages/fill-scenarios/src/index.ts b/packages/fill-scenarios/src/index.ts
index 8c7fa500e..9f1b68ef2 100644
--- a/packages/fill-scenarios/src/index.ts
+++ b/packages/fill-scenarios/src/index.ts
@@ -146,7 +146,7 @@ export class FillScenarios {
 
         const [orderAddresses, orderValues] = formatters.getOrderAddressesAndValues(signedOrder);
 
-        const txHash = await exchangeInstance.fillOrder.sendTransactionAsync(
+        await exchangeInstance.fillOrder.sendTransactionAsync(
             orderAddresses,
             orderValues,
             partialFillAmount,
@@ -156,10 +156,6 @@ export class FillScenarios {
             signedOrder.ecSignature.s,
             { from: takerAddress },
         );
-        const txReceipt = await this._web3Wrapper.awaitTransactionMinedAsync(txHash);
-        if (txReceipt.status !== 1) {
-            throw new Error(`FillOrder tx reverted. TxHash: ${txReceipt.transactionHash}`);
-        }
         return signedOrder;
     }
     private async _createAsymmetricFillableSignedOrderWithFeesAsync(
@@ -219,13 +215,9 @@ export class FillScenarios {
             this._web3Wrapper.getProvider(),
             this._web3Wrapper.getContractDefaults(),
         );
-        const txHash = await token.transfer.sendTransactionAsync(address, amount, {
+        await token.transfer.sendTransactionAsync(address, amount, {
             from: this._coinbase,
         });
-        const txReceipt = await this._web3Wrapper.awaitTransactionMinedAsync(txHash);
-        if (txReceipt.status !== 1) {
-            throw new Error(`Transfer tx reverted. TxHash: ${txReceipt.transactionHash}`);
-        }
     }
     private async _increaseAllowanceAsync(tokenAddress: string, address: string, amount: BigNumber): Promise<void> {
         const tokenInstance = new TokenContract(
@@ -243,12 +235,8 @@ export class FillScenarios {
         const oldMakerAllowance = await tokenInstance.allowance.callAsync(address, proxyAddress);
         const newMakerAllowance = oldMakerAllowance.plus(amount);
 
-        const txHash = await tokenInstance.approve.sendTransactionAsync(proxyAddress, newMakerAllowance, {
+        await tokenInstance.approve.sendTransactionAsync(proxyAddress, newMakerAllowance, {
             from: address,
         });
-        const txReceipt = await this._web3Wrapper.awaitTransactionMinedAsync(txHash);
-        if (txReceipt.status !== 1) {
-            throw new Error(`Approve tx reverted. TxHash: ${txReceipt.transactionHash}`);
-        }
     }
 }
-- 
cgit v1.2.3