aboutsummaryrefslogtreecommitdiffstats
path: root/packages/contracts
Commit message (Collapse)AuthorAgeFilesLines
* Add combinatorial tests for internal Exchange functions (#807)Alex Browne2018-07-2712-128/+756
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP add combinatorial tests for internal Exchange functions * Change combinitorial testing strategy based on feedback * Check value of filled[orderHash] in updateFilledState tests * Add combinatorial tests for addFillResults * Add combinatorial tests for getPartialAmount * Implement generic `testWithReferenceFuncAsync` * Implement generic `testCombinatoriallyWithReferenceFuncAsync` * Add combinatorial tests for isRoundingError * Add combinatorial tests for calculateFillResults * Add support for Geth in internal contract tests * Fix contract artifacts * Change DECIMAL_PLACES to 78 and add a note. * Document new functions in utils * Optimize tests by only reseting state when needed * Rename/move some files * Print parameter names on failure in testWithReferenceFuncAsync * Add to changelog for utils package * Appease various linters * Rename some more things related to FillOrderCombinatorialUtils * Remove .only from test/exchange/internal.ts * Remove old test for isRoundingError and getPartialAmount * Appease linters again * Remove old todos * Fix typos, add comments, rename some things * Re-add some LibMath tests * Update contract internal tests to use new SafeMath revert reasons * Apply PR feedback from Amir * Apply PR feedback from Remco * Re-add networks to ZRXToken artifact * Remove duplicate Whitelist in compiler.json
* Publishcontracts@2.1.39@0xproject/website@0.0.43@0xproject/testnet-faucets@1.0.40@0xproject/react-docs-example@0.0.19@0xproject/metacoin@0.0.14@0xproject/abi-gen@1.0.4Fabio Berger2018-07-261-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.2 - @0xproject/abi-gen@1.0.4 - @0xproject/assert@1.0.4 - @0xproject/base-contract@1.0.4 - @0xproject/connect@1.0.4 - @0xproject/contract-wrappers@1.0.1-rc.2 - contracts@2.1.39 - @0xproject/dev-utils@1.0.3 - @0xproject/fill-scenarios@1.0.1-rc.2 - @0xproject/json-schemas@1.0.1-rc.3 - @0xproject/metacoin@0.0.14 - @0xproject/migrations@1.0.3 - @0xproject/order-utils@1.0.1-rc.2 - @0xproject/order-watcher@1.0.1-rc.2 - @0xproject/react-docs@1.0.4 - @0xproject/react-docs-example@0.0.19 - @0xproject/react-shared@1.0.5 - @0xproject/sol-compiler@1.0.4 - @0xproject/sol-cov@1.0.3 - @0xproject/sol-resolver@1.0.4 - @0xproject/sra-report@1.0.4 - @0xproject/subproviders@1.0.4 - @0xproject/testnet-faucets@1.0.40 - @0xproject/types@1.0.1-rc.3 - @0xproject/utils@1.0.4 - @0xproject/web3-wrapper@1.1.2 - @0xproject/website@0.0.43
* Point to actual current versionFabio Berger2018-07-261-3/+3
|
* Publishcontracts@2.1.38@0xproject/website@0.0.42@0xproject/testnet-faucets@1.0.39@0xproject/sol-compiler@1.0.3@0xproject/react-docs-example@0.0.18@0xproject/monorepo-scripts@1.0.4@0xproject/metacoin@0.0.13@0xproject/abi-gen@1.0.3Fabio Berger2018-07-261-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.2 - @0xproject/abi-gen@1.0.3 - @0xproject/assert@1.0.3 - @0xproject/base-contract@1.0.3 - @0xproject/connect@1.0.3 - @0xproject/contract-wrappers@1.0.1-rc.2 - contracts@2.1.38 - @0xproject/dev-utils@1.0.3 - ethereum-types@1.0.3 - @0xproject/fill-scenarios@1.0.1-rc.2 - @0xproject/json-schemas@1.0.1-rc.2 - @0xproject/metacoin@0.0.13 - @0xproject/migrations@1.0.3 - @0xproject/monorepo-scripts@1.0.4 - @0xproject/order-utils@1.0.1-rc.2 - @0xproject/order-watcher@1.0.1-rc.2 - @0xproject/react-docs@1.0.3 - @0xproject/react-docs-example@0.0.18 - @0xproject/react-shared@1.0.4 - @0xproject/sol-compiler@1.0.3 - @0xproject/sol-cov@1.0.3 - @0xproject/sol-resolver@1.0.3 - @0xproject/sra-report@1.0.3 - @0xproject/subproviders@1.0.3 - @0xproject/testnet-faucets@1.0.39 - @0xproject/tslint-config@1.0.4 - @0xproject/types@1.0.1-rc.2 - @0xproject/typescript-typings@1.0.3 - @0xproject/utils@1.0.3 - @0xproject/web3-wrapper@1.1.1 - @0xproject/website@0.0.42
* Publishcontracts@2.1.37@0xproject/website@0.0.41@0xproject/testnet-faucets@1.0.38@0xproject/react-docs-example@0.0.17@0xproject/monorepo-scripts@1.0.3@0xproject/metacoin@0.0.12@0xproject/abi-gen@1.0.2Fabio Berger2018-07-261-22/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.1 - @0xproject/abi-gen@1.0.2 - @0xproject/assert@1.0.2 - @0xproject/base-contract@1.0.2 - @0xproject/connect@1.0.2 - @0xproject/contract-wrappers@1.0.1-rc.1 - contracts@2.1.37 - @0xproject/dev-utils@1.0.2 - ethereum-types@1.0.2 - @0xproject/fill-scenarios@1.0.1-rc.1 - @0xproject/json-schemas@1.0.1-rc.1 - @0xproject/metacoin@0.0.12 - @0xproject/migrations@1.0.2 - @0xproject/monorepo-scripts@1.0.3 - @0xproject/order-utils@1.0.1-rc.1 - @0xproject/order-watcher@1.0.1-rc.1 - @0xproject/react-docs@1.0.2 - @0xproject/react-docs-example@0.0.17 - @0xproject/react-shared@1.0.3 - @0xproject/sol-compiler@1.0.2 - @0xproject/sol-cov@1.0.2 - @0xproject/sol-resolver@1.0.2 - @0xproject/sra-report@1.0.2 - @0xproject/subproviders@1.0.2 - @0xproject/testnet-faucets@1.0.38 - @0xproject/tslint-config@1.0.3 - @0xproject/types@1.0.1-rc.1 - @0xproject/typescript-typings@1.0.2 - @0xproject/utils@1.0.2 - @0xproject/web3-wrapper@1.1.0 - @0xproject/website@0.0.41
* Revert to publishing ethereum-typesFabio Berger2018-07-261-1/+1
|
* Temporarily have all packages depend on an older, published version of ↵Fabio Berger2018-07-261-1/+1
| | | | ethereum-types since we cannot publish a new one
* Modify WETH9 event arg names to be identical to ERC20 standard suggested namesFabio Berger2018-07-261-4/+4
|
* merge v2-prototypeFabio Berger2018-07-252-2/+2
|\
| * Update orderEpoch commentsAmir Bandeali2018-07-252-2/+2
| |
* | Revert "Revert "Publish""Fabio Berger2018-07-241-16/+16
|/ | | | This reverts commit a66ccaa1da2af753038bf22a5e7e63bdc307bf2f.
* Remove ERC721 callback functionsAmir Bandeali2018-07-234-49/+3
|
* Use != instead of > in loops, add sanity checks to market fill functionsAmir Bandeali2018-07-233-19/+19
|
* Add more tests and fixesAmir Bandeali2018-07-237-411/+483
|
* Remove MConstants and MixinConstants for LibConstantsAmir Bandeali2018-07-238-57/+23
|
* Remove redundant external call by reimplementing fillOrderNoThrowAmir Bandeali2018-07-236-166/+355
|
* Remove orders length checkAmir Bandeali2018-07-232-11/+0
|
* Add assertValidFillResultsAmir Bandeali2018-07-231-61/+88
|
* Get actual gasPrice from transaction instead of setting defaultAmir Bandeali2018-07-231-35/+34
|
* Store orders length in varible before looping over ordersAmir Bandeali2018-07-232-14/+25
|
* Use transferFrom instead of safeTransferFromAmir Bandeali2018-07-232-6/+2
|
* Fix minimal testsAmir Bandeali2018-07-233-729/+747
|
* Fix rounding error issues, use different logic when makerAsset is ZRXAmir Bandeali2018-07-236-52/+95
|
* Rename marketSellEth => marketSellWethAmir Bandeali2018-07-232-3/+3
|
* Update percentage constantsAmir Bandeali2018-07-233-17/+18
|
* Update transferEthFeeAndRefund, add check to ERC721 transferAmir Bandeali2018-07-236-26/+54
|
* Refactor forwarding contract architecture, remove batch functionsAmir Bandeali2018-07-2320-1038/+572
|
* Add tests to verify ZRX_ASSET_DATAAmir Bandeali2018-07-235-1/+77
|
* Add comments for deploying with constant ZRX_ASSET_DATAAmir Bandeali2018-07-232-2/+15
|
* Move example contracts into new examples dirAmir Bandeali2018-07-2310-24/+33
|
* Merge pull request #877 from 0xProject/feature/contracts/removeERC721CallbackAmir Bandeali2018-07-235-188/+31
|\ | | | | Removed receiverData and `onReceive` callback from ERC721 proxy.
| * Fixed merge errorsGreg Hysen2018-07-181-2/+0
| |
| * Fixed merge errorGreg Hysen2018-07-181-11/+11
| |
| * Ran prettierGreg Hysen2018-07-181-11/+11
| |
| * Removed receiverData from ERC721 Proxy Id generationGreg Hysen2018-07-184-8/+6
| |
| * Removed receiverData and `onReceive` callback from ERC721 proxy.Greg Hysen2018-07-183-178/+25
| |
* | Fix version of ethereumjs-abi to 0.6.5 to fix decoding bugFabio Berger2018-07-221-1/+1
| |
* | fix decodeAssetData for addresses starting in 0Luke Autry2018-07-221-2/+2
| |
* | Hard code fillOrder selector into abiEncodeFillOrderAmir Bandeali2018-07-201-7/+4
| |
* | Returns byte array instead of memory range for encoding fillOrder calldataGreg Hysen2018-07-202-24/+26
| |
* | Created LibAbiEncoder with `fillOrderNoThrow`Greg Hysen2018-07-202-170/+235
| |
* | Change all package to depend on the new @0xproject/sol-cov@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/order-utils@1.0.0-rc.1Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/sol-compiler@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/dev-utils@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/subproviders@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/base-contract@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/web3-wrapper@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/abi-gen@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/utils@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/types@1.0.0-rc.1Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/tslint-config@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new @0xproject/typescript-typings@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | Change all package to depend on the new ethereum-types@1.0.0Leonid Logvinov2018-07-201-1/+1
| |
* | merge v2-prototypeFabio Berger2018-07-182-1/+2
|\ \
| * | Merge branch 'v2-prototype' into feature/order-watcher-v2Leonid Logvinov2018-07-1818-182/+201
| |\|
| * | MergeLeonid Logvinov2018-07-181-1/+1
| | |
| * | Merge branch 'v2-prototype' into feature/order-watcher-v2Leonid Logvinov2018-07-1829-186/+534
| |\ \
| * | | Upgrade tslint to use prefer-readonlyLeonid Logvinov2018-07-131-1/+1
| | | |
| * | | Update contract artifactsLeonid Logvinov2018-07-131-0/+1
| | | |
* | | | Update package versionsFabio Berger2018-07-181-10/+10
| |_|/ |/| |
* | | Merge pull request #884 from 0xProject/export-more-0x.jsFabio Berger2018-07-1818-182/+201
|\ \ \ | |_|/ |/| | Export missing V2 pieces from 0x.js
| * | Fix prettierFabio Berger2018-07-182-9/+3
| | |
| * | Fix linterFabio Berger2018-07-181-1/+1
| | |
| * | merge v2-prototypeFabio Berger2018-07-1815-138/+484
| |\ \
| * | | Rename decodeAssetDataId to decodeAssetProxyId for consistencyFabio Berger2018-07-184-11/+11
| | | |
| * | | Move encodeUint256 & decodeUint256 out of assetDataUtils since we don't want ↵Fabio Berger2018-07-184-6/+31
| | | | | | | | | | | | | | | | them exported
| * | | Rename assetProxyUtils to assetDataUtilsFabio Berger2018-07-1716-176/+176
| | |/ | |/|
* | | Merge pull request #883 from 0xProject/feature/tslint-improvementsLeonid Logvinov2018-07-1816-48/+50
|\ \ \ | |_|/ |/| | New tslint rules
| * | Fix tslint issuesLeonid Logvinov2018-07-1715-47/+49
| | |
| * | Upgrade tslint to the newest versionLeonid Logvinov2018-07-171-1/+1
| |/
* | Add tests for getOrderInfo and getOrdersInfoAmir Bandeali2018-07-183-5/+311
| |
* | Reorder checks in getOrderInfoAmir Bandeali2018-07-181-7/+9
| |
* | Add getOrdersInfo functionAmir Bandeali2018-07-182-0/+24
| |
* | Fix bugs having to do with block timestamps and order expirationTimesAlex Browne2018-07-1711-128/+142
|/
* Remove extra ERC20ProxyId from Forwarder constructorJacob Evans2018-07-112-3/+1
|
* Add Migrations for ForwarderJacob Evans2018-07-111-2/+2
|
* Add revert reasons and optimization to safeMathAmir Bandeali2018-07-111-3/+15
|
* Use 0.4.10 in AssetProxyOwner, add readBytes4 to contract and remove LibBytesAmir Bandeali2018-07-117-17/+76
|
* Update package versionsFabio Berger2018-07-101-11/+11
|
* Move functions out of Forwarder.solAmir Bandeali2018-07-0812-42/+35
|
* Add interfaces and mixinsAmir Bandeali2018-07-0816-61/+573
|
* Combine mixinsAmir Bandeali2018-07-086-284/+218
|
* Use interfaces instead of full contractsAmir Bandeali2018-07-084-7/+39
|
* Add lint-contracts to default lint commandAmir Bandeali2018-07-071-1/+1
|
* Remove TODOs that won't be addressedAmir Bandeali2018-07-074-10/+3
|
* Remove AbiV2 where unusedAmir Bandeali2018-07-0723-38/+27
|
* Only reset currentContextAddress if it was previously updatedAmir Bandeali2018-07-071-8/+11
|
* Change uint => uint256Amir Bandeali2018-07-071-8/+7
|
* Apply new linter rulesAmir Bandeali2018-07-0774-299/+351
|
* Update linter configAmir Bandeali2018-07-072-11/+14
|
* Fix importsLeonid Logvinov2018-07-061-2/+2
|
* Merge pull request #822 from 0xProject/v2-contract-wrappers-WIPLeonid Logvinov2018-07-0614-66/+68
|\ | | | | V2 contract wrappers
| * Make it possible to configure block polling interval in base contract wrapperLeonid Logvinov2018-07-0514-66/+68
| |
* | Types: Move Forwarder Revert Reason into types packageJacob Evans2018-07-061-13/+6
| |
* | Forwarder specify the revert reasonsJacob Evans2018-07-061-21/+31
| |
* | Forwarder fix linter errorJacob Evans2018-07-061-1/+1
| |
* | Update to new assertionsJacob Evans2018-07-061-18/+16
| |
* | Merge pull request #522 from 0xProject/feature/contracts/forwarderJacob Evans2018-07-0618-8/+2163
|\ \ | | | | | | Forwarding contract
| * | Forwarding contract (squashed commits)Jacob Evans2018-07-0618-8/+2163
| | |
* | | Contracts 2.0.0 were linted with solhintAlex Shafranovich2018-07-0660-1/+78
| | |
* | | Added Solhint package and 'lint-contracts' npm scriptAlex Shafranovich2018-07-062-1/+20
| |/ |/|
* | merge v2-prototypeFabio Berger2018-07-0417-186/+235
|\ \
| * | Move NodeType caching out of web3-wrapper and into our internal codeAlex Browne2018-07-041-2/+8
| | |
| * | Add TransactionReceiptStatus type to ethereum-typesAlex Browne2018-07-041-2/+2
| | |
| * | Improve robustness of revert reason assertionsAlex Browne2018-07-0317-185/+228
| | |
* | | Remove unused imported Web3.jsFabio Berger2018-07-041-2/+1
|/ /
* | Update incorrect versions of depsFabio Berger2018-07-021-1/+1
| |
* | Fix bug where 18 decimal tokens instead of 5 decimal tokens createdFabio Berger2018-07-021-1/+1
| |
* | Disable custom-no-magic-number for blockFabio Berger2018-07-021-0/+2
| |
* | Remove unused variableFabio Berger2018-07-021-1/+0
| |
* | Merge branch 'v2-prototype' into fix/five_decimal_scenarioFabio Berger2018-07-02130-936/+874
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (75 commits) Update relayer grid tiles to use Text Fix build Update file structure Update 2.0.0 artifacts Move ledgerhq module declarations to typescript-typings Export LedgerEthereumClient type in subproviders Update artifacts Add logging and updated artifacts Fix migrations Run prettier Add Kovan artifacts Use ledger subprovider Add Kovan migrations Remove state variable from Link component in Portal Make registerAssetProxy append only Update staging api link Change getTransactionReceipt to awaitTransactionMined Move /docs route to the end Remove extra call to scrollIntoView for wallet in onboarding Update expectRevertReasonOrAlwaysFailingTransactionAsync to check status codes ...
| * Fix buildAmir Bandeali2018-06-307-31/+31
| |
| * Update file structureAmir Bandeali2018-06-30125-199/+195
| |
| * Make registerAssetProxy append onlyAmir Bandeali2018-06-3011-201/+67
| |
| * Change getTransactionReceipt to awaitTransactionMinedAmir Bandeali2018-06-301-1/+1
| |
| * Update expectRevertReasonOrAlwaysFailingTransactionAsync to check status codesAlex Browne2018-06-302-27/+38
| |
| * Fix deployment to gethAmir Bandeali2018-06-302-7/+6
| |
| * Fix testsAmir Bandeali2018-06-306-79/+146
| |
| * Remove transferFrom, implement in fallback functionAmir Bandeali2018-06-306-290/+267
| |
| * Merge pull request #774 from 0xProject/style/contracts/abiEncodeAsmCommentsAmir Bandeali2018-06-302-0/+22
| |\ | | | | | | Added some comments for ASM hashing
| | * Updated hashing comments as-per PRGreg Hysen2018-06-291-9/+4
| | |
| | * Comments for ASM hashingGreg Hysen2018-06-262-0/+27
| | |
* | | Add commented out scenarios not run by defaultFabio Berger2018-07-021-16/+82
| | |
* | | Fix commentFabio Berger2018-07-021-2/+1
| | |
* | | Print out entire orderFill scenarioFabio Berger2018-07-021-7/+1
| | |
* | | Transfer ERC721 token instead of burning, so we can still set an allowance ↵Fabio Berger2018-07-021-1/+9
| | | | | | | | | | | | to it in tests
* | | Fix bug where using nullAddress for order instead of actual taker addressFabio Berger2018-07-021-11/+3
| | |
* | | Add maker and taker balance/allowance scenarios to generateFillOrderCombinationFabio Berger2018-07-021-8/+24
|/ /
* | Remove unused constantsFabio Berger2018-06-281-2/+0
| |
* | Reduce the userAddresses to the individual addresses actually used by tests, ↵Fabio Berger2018-06-287-19/+32
| | | | | | | | as well as only deploy the number of ERC20 tokens needed for each test suite
* | Add await time constantFabio Berger2018-06-281-0/+2
| |
* | Add missing awaitTransactionSuccessAsync callsFabio Berger2018-06-281-6/+10
| |
* | Merge branch 'v2-prototype' into feature/combinatorial-testingFabio Berger2018-06-2718-736/+363
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: Improve 'web3-provider-engine' typings Fix build Update artifacts Add more revert reasons to tests Make dispatchTransferFrom revert with reason from AssetProxy on failure Remove redundant files, hard code function selector in dispatchTransferFrom, and modify revert reason Updated offset of receiverData length to reflect new assetData encoding. ERC20 Custom storage layout Golf the authorization check ERC20 manual memory layout ERC20 inline return ERC721 inline return Golf ERC721 transferFrom Inline ERC20 tranferFrom selector constant Optimize ERC20 transferFrom Polish asset picker layout Update relayer grid fallback icon Change metamask install link based on browser Use ethereumjs-tx@1.3.5 instead of our fork # Conflicts: # packages/contracts/test/asset_proxy/proxies.ts # packages/contracts/test/exchange/core.ts # packages/migrations/artifacts/2.0.0/DummyERC721Token.json
| * | Fix buildAmir Bandeali2018-06-271-0/+3
| | |
| * | Add more revert reasons to testsAmir Bandeali2018-06-273-19/+43
| | |
| * | Make dispatchTransferFrom revert with reason from AssetProxy on failureAmir Bandeali2018-06-272-7/+6
| | |
| * | Remove redundant files, hard code function selector in dispatchTransferFrom, ↵Amir Bandeali2018-06-2717-896/+201
| | | | | | | | | | | | and modify revert reason
| * | Updated offset of receiverData length to reflect new assetData encoding.Greg Hysen2018-06-271-2/+2
| | |
| * | ERC20 Custom storage layoutRemco Bloemen2018-06-272-3/+5
| | |
| * | Golf the authorization checkRemco Bloemen2018-06-272-122/+132
| | |
| * | ERC20 manual memory layoutRemco Bloemen2018-06-271-11/+6
| | |
| * | ERC20 inline returnRemco Bloemen2018-06-271-6/+11
| | |
| * | ERC721 inline returnRemco Bloemen2018-06-271-8/+9
| | |
| * | Golf ERC721 transferFromRemco Bloemen2018-06-272-3/+166
| | |
| * | Inline ERC20 tranferFrom selector constantRemco Bloemen2018-06-271-4/+3
| | |
| * | Optimize ERC20 transferFromRemco Bloemen2018-06-271-2/+126
| | |
* | | Move combinatorial fillOrder tests into the `fill_ordere` test fileFabio Berger2018-06-272-48/+21
| | |
* | | Fix testsFabio Berger2018-06-271-3/+6
| | |
* | | Fix type issueFabio Berger2018-06-271-2/+2
| | |
* | | Merge branch 'refactor/check-revert-reasons' into feature/combinatorial-testingFabio Berger2018-06-2711-87/+91
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * refactor/check-revert-reasons: Temporarily switch revert reasons to `TransferFailed`. Should be `InvalidAmount` but because of an oversight in the assembly implementation of `dispatchTransferFrom`, it always throws `TransferFailed` Expect RevertReason be passed in, not string Rename RevertReasons to RevertReason since singular enum names are more common # Conflicts: # packages/contracts/test/asset_proxy/proxies.ts # packages/contracts/test/exchange/core.ts
| * | Temporarily switch revert reasons to `TransferFailed`. Should be ↵Fabio Berger2018-06-271-2/+2
| | | | | | | | | | | | `InvalidAmount` but because of an oversight in the assembly implementation of `dispatchTransferFrom`, it always throws `TransferFailed`
| * | Expect RevertReason be passed in, not stringFabio Berger2018-06-261-1/+5
| | |
| * | Rename RevertReasons to RevertReason since singular enum names are more commonFabio Berger2018-06-2610-95/+95
| | |
| * | Merge branch 'v2-prototype' into refactor/check-revert-reasonsFabio Berger2018-06-2633-266/+449
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (21 commits) Don't use variables for revert reasons Add comments to dispatchTransferFrom Document IAssetData Compute bytes4 proxyid constants Return inplace bytes in LibBytes.readBytesWithLength Add Greg's documentation to MixinErc721Transfer Add Greg's documentation to MixinErc20Transfer Gas golf the transfer success logic Optimize like in PR #767 Run prettier and fix linting errors Fix tests Update tests Fix AssetProxyUtils Update tests Fix ERC721Proxy TokenId Update AssetProxyUtils Add IAssetData WIP ABI encoded asset data Remove proxyId argument from dispatchTransferFrom ... # Conflicts: # packages/contracts/test/asset_proxy/proxies.ts
* | | | Update AbstractAssetWrapperFabio Berger2018-06-261-1/+1
| | | |
* | | | Rename to singularFabio Berger2018-06-261-9/+9
| | | |
* | | | Fix merge issuesFabio Berger2018-06-265-17/+21
| | | |
* | | | Merge branch 'v2-prototype' into feature/combinatorial-testingFabio Berger2018-06-2633-281/+460
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (21 commits) Don't use variables for revert reasons Add comments to dispatchTransferFrom Document IAssetData Compute bytes4 proxyid constants Return inplace bytes in LibBytes.readBytesWithLength Add Greg's documentation to MixinErc721Transfer Add Greg's documentation to MixinErc20Transfer Gas golf the transfer success logic Optimize like in PR #767 Run prettier and fix linting errors Fix tests Update tests Fix AssetProxyUtils Update tests Fix ERC721Proxy TokenId Update AssetProxyUtils Add IAssetData WIP ABI encoded asset data Remove proxyId argument from dispatchTransferFrom ... # Conflicts: # packages/contracts/test/asset_proxy/proxies.ts
| * | | Don't use variables for revert reasonsAmir Bandeali2018-06-2614-86/+86
| | | |
| * | | Add comments to dispatchTransferFromAmir Bandeali2018-06-261-30/+56
| | | |
| * | | Document IAssetDataRemco Bloemen2018-06-261-0/+3
| | | |
| * | | Compute bytes4 proxyid constantsRemco Bloemen2018-06-262-2/+2
| | | |
| * | | Return inplace bytes in LibBytes.readBytesWithLengthRemco Bloemen2018-06-261-9/+7
| | | |
| * | | Add Greg's documentation to MixinErc721TransferRemco Bloemen2018-06-261-33/+44
| | | |
| * | | Add Greg's documentation to MixinErc20TransferRemco Bloemen2018-06-261-13/+35
| | | |
| * | | Gas golf the transfer success logicRemco Bloemen2018-06-261-11/+10
| | | |
| * | | Optimize like in PR #767Remco Bloemen2018-06-263-34/+157
| | | |
| * | | Run prettier and fix linting errorsAmir Bandeali2018-06-261-18/+6
| | | |
| * | | Fix testsAmir Bandeali2018-06-265-21/+4
| | | |
| * | | Update testsRemco Bloemen2018-06-261-2/+2
| | | |
| * | | Update testsRemco Bloemen2018-06-262-33/+20
| | | |
| * | | Fix ERC721Proxy TokenIdRemco Bloemen2018-06-261-1/+1
| | | |
| * | | Add IAssetDataRemco Bloemen2018-06-262-1/+2
| | | |
| * | | WIPRemco Bloemen2018-06-263-2/+3
| | | |
| * | | ABI encoded asset dataRemco Bloemen2018-06-269-29/+51
| | | |
| * | | Remove proxyId argument from dispatchTransferFromRemco Bloemen2018-06-268-41/+20
| | | |
| * | | Document all the contract test options in READMEFabio Berger2018-06-251-3/+43
| | |/ | |/|
* | | Fix inconsistency between contract and reference implementation of order ↵Fabio Berger2018-06-261-0/+2
| | | | | | | | | | | | validation logic
* | | Prettier fixesFabio Berger2018-06-262-8/+2
| | |
* | | Fix tslint issuesFabio Berger2018-06-267-22/+4
| | |
* | | Check revert reasons in declarative and combinatorial testsFabio Berger2018-06-251-7/+8
| | |
* | | merge check-revert-reasonsFabio Berger2018-06-2511-66/+14
|\ \ \ | | |/ | |/|
| * | Move RevertReasons to @0xproject/types packageFabio Berger2018-06-2511-66/+14
| | |
| * | Add missing importFabio Berger2018-06-251-1/+4
| | |
* | | Add missing importFabio Berger2018-06-251-1/+4
| | |
* | | merge check-revert-reasonsFabio Berger2018-06-2515-129/+235
|\| |
| * | Merge branch 'v2-prototype' into refactor/check-revert-reasonsFabio Berger2018-06-2526-708/+965
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (48 commits) Fix typos in comments Add modifier and tests for removeAuthorizedAddressAtIndex Update and add tests Change removeAuthorizedAddress => removeAuthorizedAddressAtIndex Move isFunctionRemoveAuthorizedAddress to test Fix usage of `popLastByte` Fix LibBytes is a library Remove `areBytesEqual` Fix usage of `contentAddress()` Clean low bits in bytes4 Clean high bits in address Refactor LibBytes.readBytes4 for consistency Fix LibBytes.equals Add trailing garbage testcase for LibBytes.equals Rename bytes.equals Add slice and sliceDestructive Rename bytes.rawAddress and add bytes.contentAddress Rename read/writeBytesWithLength Using LibBytes for bytes Make LibBytes a library ... # Conflicts: # packages/contracts/src/contracts/current/utils/Ownable/Ownable.sol # packages/contracts/test/libraries/lib_bytes.ts
| * | Fix tslintFabio Berger2018-06-234-4/+4
| | |
| * | Fix prettierFabio Berger2018-06-235-15/+13
| | |
| * | Rename ContractLibErrors to RevertReasonsFabio Berger2018-06-2311-96/+96
| | |
| * | Remove revert reason 'Exchange' prefixFabio Berger2018-06-232-3/+3
| | |
| * | Move constants over to ContractLibError enum and update all testsFabio Berger2018-06-235-44/+42
| | |
| * | Standardize ERC20 error strings given conventionFabio Berger2018-06-231-3/+2
| | |
| * | Fix test now that contract reverts with messageFabio Berger2018-06-222-5/+4
| | |
| * | Merge branch 'v2-prototype' into refactor/check-revert-reasonsFabio Berger2018-06-223-27/+48
| |\ \ | | | | | | | | | | | | | | | | * v2-prototype: Check that assetProxy exists before attempting transfer
| * | | Add revert reason checks to wrapper testsFabio Berger2018-06-221-10/+19
| | | |
| * | | Fix testsFabio Berger2018-06-221-2/+2
| | | |
| * | | Change Whitelist error messages to conform to rest and added revert reason ↵Fabio Berger2018-06-223-21/+31
| | | | | | | | | | | | | | | | checks to transactions tests
| * | | Add revert reason checks to match_orders testsFabio Berger2018-06-221-7/+18
| | | |
| * | | Fix testsFabio Berger2018-06-221-2/+2
| | | |
| * | | Merge branch 'v2-prototype' into refactor/check-revert-reasonsFabio Berger2018-06-2239-382/+894
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (40 commits) Use make-promises-safe as a preloader instead of manually importing Updated compiler runs to be 1,000,000 Add event to setSignatureValidatorApproval, rename signer => signerAddress accross all contracts Add senderAddress to Fill and Cancel logs, add comments to events and types Fix Island component Add missing image assets for Chris and Mel Fix some bugs in sol-cov Remove unreachable PreSigned check Fix linting Buttons look hella disabled now Remove border radius, fix width issue for unlock step Add Chris and Mel to about page fix linter issues only call getLocationByOffset if source if defined Set settleOrder and settleMatchedOrders to private Prevent prettier issue Support mobile friendly onboarding flows Removed MixinSettlement. Moved `settleOrder` into `MixinExchangeCore` and `settleMatchedOrders` into `MixinMatchOrders` Migrations after rebasing Linter ...
| * | | | Check revert reason in dispatcher testsFabio Berger2018-06-222-5/+13
| | | | |
| * | | | remove unused importFabio Berger2018-06-221-1/+0
| | | | |
| * | | | Test revert reasons in proxy testsFabio Berger2018-06-211-11/+23
| | | | |
| * | | | remove onlyFabio Berger2018-06-211-1/+1
| | | | |
| * | | | Check revert reasons in Authorizable testsFabio Berger2018-06-212-6/+15
| | | | |
| * | | | Change revert reason in ownable to be similar to all other revert reasonsFabio Berger2018-06-211-1/+1
| | | | |
| * | | | remove .onlyFabio Berger2018-06-211-1/+1
| | | | |
| * | | | Update core tests to actually check revert messageFabio Berger2018-06-213-34/+97
| | | | |
* | | | | Merge branch 'v2-prototype' into feature/combinatorial-testingFabio Berger2018-06-2554-1100/+1890
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * v2-prototype: (97 commits) Fix typos in comments Add modifier and tests for removeAuthorizedAddressAtIndex Update and add tests Change removeAuthorizedAddress => removeAuthorizedAddressAtIndex Move isFunctionRemoveAuthorizedAddress to test Fix usage of `popLastByte` Fix LibBytes is a library Remove `areBytesEqual` Fix usage of `contentAddress()` Clean low bits in bytes4 Clean high bits in address Refactor LibBytes.readBytes4 for consistency Fix LibBytes.equals Add trailing garbage testcase for LibBytes.equals Rename bytes.equals Add slice and sliceDestructive Rename bytes.rawAddress and add bytes.contentAddress Rename read/writeBytesWithLength Using LibBytes for bytes Make LibBytes a library ... # Conflicts: # packages/contracts/src/utils/constants.ts # packages/contracts/test/exchange/core.ts
| * | | | Fix typos in commentsRemco Bloemen2018-06-231-2/+2
| | | | |
| * | | | Add modifier and tests for removeAuthorizedAddressAtIndexAmir Bandeali2018-06-233-2/+79
| | | | |
| * | | | Update and add testsAmir Bandeali2018-06-234-173/+274
| | | | |
| * | | | Change removeAuthorizedAddress => removeAuthorizedAddressAtIndexAmir Bandeali2018-06-232-13/+22
| | | | |
| * | | | Move isFunctionRemoveAuthorizedAddress to testRemco Bloemen2018-06-236-22/+70
| | | | |
| * | | | Fix usage of `popLastByte`Remco Bloemen2018-06-231-2/+2
| | | | |
| * | | | Fix LibBytes is a libraryRemco Bloemen2018-06-236-15/+12
| | | | |
| * | | | Remove `areBytesEqual`Remco Bloemen2018-06-231-35/+0
| | | | |
| * | | | Fix usage of `contentAddress()`Remco Bloemen2018-06-231-2/+2
| | | | |
| * | | | Clean low bits in bytes4Remco Bloemen2018-06-231-0/+3
| | | | |
| * | | | Clean high bits in addressRemco Bloemen2018-06-231-0/+4
| | | | |
| * | | | Refactor LibBytes.readBytes4 for consistencyRemco Bloemen2018-06-234-14/+25
| | | | |
| * | | | Fix LibBytes.equalsRemco Bloemen2018-06-231-21/+4
| | | | |
| * | | | Add trailing garbage testcase for LibBytes.equalsRemco Bloemen2018-06-232-0/+21
| | | | |
| * | | | Rename bytes.equalsRemco Bloemen2018-06-233-15/+50
| | | | |
| * | | | Add slice and sliceDestructiveRemco Bloemen2018-06-231-0/+46
| | | | |
| * | | | Rename bytes.rawAddress and add bytes.contentAddressRemco Bloemen2018-06-232-8/+25
| | | | |
| * | | | Rename read/writeBytesWithLengthRemco Bloemen2018-06-234-36/+36
| | | | |
| * | | | Using LibBytes for bytesRemco Bloemen2018-06-236-26/+38
| | | | |
| * | | | Make LibBytes a libraryRemco Bloemen2018-06-236-35/+30
| | | | |
| * | | | Merge LibMem and LibBytesRemco Bloemen2018-06-2311-399/+322
| | | | |
| * | | | Use provided mem in refernce memcpyRemco Bloemen2018-06-231-2/+2
| | | | |
| * | | | Merge pull request #749 from 0xProject/feature/contracts/transactionHashAsmAmir Bandeali2018-06-231-8/+18
| |\ \ \ \ | | |_|_|/ | |/| | | Converted `hashZeroExTransaction` to assembly. Saves 1k gas
| | * | | Apply mask to address to zero-out unused bytes.Greg Hysen2018-06-231-1/+1
| | | | |
| | * | | Converted `hashZeroExTransaction` to assembly. Saves 1k gasGreg Hysen2018-06-221-8/+18
| | | | |
| * | | | Merge pull request #748 from 0xProject/fix/contracts/nullAssetProxyFabio Berger2018-06-223-27/+48
| |\ \ \ \ | | |_|_|/ | |/| | | Check that assetProxy exists before attempting transfer
| | * | | Check that assetProxy exists before attempting transferAmir Bandeali2018-06-223-27/+48
| | | | |
| * | | | Merge pull request #752 from 0xProject/make-promises-safe-preloaderFabio Berger2018-06-2211-11/+1
| |\ \ \ \ | | | | | | | | | | | | Use make-promises-safe as a preloader instead of manually importing
| | * | | | Use make-promises-safe as a preloader instead of manually importingAlex Browne2018-06-2211-11/+1
| | | |/ / | | |/| |
| * | | | Merge pull request #751 from 0xProject/feature/contracts/compilerRunsAmir Bandeali2018-06-221-1/+1
| |\ \ \ \ | | |/ / / | |/| | | Updated compiler runs to be 1,000,000
| | * | | Updated compiler runs to be 1,000,000Greg Hysen2018-06-221-1/+1
| | | | |
| * | | | Add event to setSignatureValidatorApproval, rename signer => signerAddress ↵Amir Bandeali2018-06-2215-70/+144
| | | | | | | | | | | | | | | | | | | | accross all contracts
| * | | | Add senderAddress to Fill and Cancel logs, add comments to events and typesAmir Bandeali2018-06-225-44/+47
| | |/ / | |/| |
| * | | Remove unreachable PreSigned checkAustin Roberts2018-06-221-4/+0
| |/ / | | | | | | | | | This code was unreachable, as it had the exact same condition as line 206.
| * | Set settleOrder and settleMatchedOrders to privateGreg Hysen2018-06-214-25/+2
| | |
| * | Removed MixinSettlement. Moved `settleOrder` into `MixinExchangeCore` and ↵Greg Hysen2018-06-218-238/+205
| | | | | | | | | | | | `settleMatchedOrders` into `MixinMatchOrders`
| * | LinterGreg Hysen2018-06-211-2/+1
| | |
| * | Renamed constants in test wallet/validatorGreg Hysen2018-06-212-11/+11
| | |
| * | Few more minor #nit wording changesGreg Hysen2018-06-212-5/+5
| | |