Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | run prettier | fragosti | 2018-08-31 | 1 | -3/+1 |
| | |||||
* | Fix unused vars for react-shared and website | fragosti | 2018-08-31 | 1 | -1/+0 |
| | |||||
* | Making rounding consistent in calculateFillResults | Amir Bandeali | 2018-08-29 | 1 | -7/+10 |
| | |||||
* | safeGetPartialAmount (#1035) | Amir Bandeali | 2018-08-29 | 1 | -52/+129 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added Test "Should transfer correct amounts when left order is fully filled and values pass isRoundingErrorCeil but fail isRoundingErrorFloor" * Added RoundingError exception to reference function for getPartialAmount * Added RoundingError exception to reference function for getPartialAmount * Added isRoundingErrorCeil to getPartialAmountCeil reference funtion * Computed new values for "Should give right maker a better buy price when correct price is not integral" that does not have a rounding error * Almost all tests for match orders are passing after adding isRoundingErrorCeil check * WIP commit: Added rounding error checks to getPartialAmount * WIP commit: Added rounding error checks to getPartialAmount * Use safe versions of getPartialAmount * Update Exchange internals tests * Run linter * Found new values for "Should transfer correct amounts when right order fill amount deviates from amount derived by `Exchange.fillOrder`" * Fixed merge conflicts * Run all tests * Cleaned up some comments on match Orders tests * Fix tests for geth | ||||
* | fix(contracts): Use correct error message for division by zero | Alex Browne | 2018-08-28 | 1 | -3/+1 |
| | |||||
* | Fix linting errors | Amir Bandeali | 2018-08-25 | 1 | -2/+2 |
| | |||||
* | Append -Floor to getPartialAmount and isRoundingError | Remco Bloemen | 2018-08-25 | 1 | -10/+10 |
| | |||||
* | Add tests | Remco Bloemen | 2018-08-25 | 1 | -0/+43 |
| | |||||
* | Add DIVISION_BY_ZERO to getPartialAmount for consistency | Remco Bloemen | 2018-08-25 | 1 | -16/+15 |
| | |||||
* | Remove .only | Remco Bloemen | 2018-08-25 | 1 | -1/+1 |
| | |||||
* | Add tests for getPartialAmountCeil | Remco Bloemen | 2018-08-25 | 1 | -0/+40 |
| | |||||
* | Update tests | Remco Bloemen | 2018-08-25 | 1 | -11/+15 |
| | |||||
* | Add combinatorial tests for internal Exchange functions (#807) | Alex Browne | 2018-07-27 | 1 | -0/+305 |
* WIP add combinatorial tests for internal Exchange functions * Change combinitorial testing strategy based on feedback * Check value of filled[orderHash] in updateFilledState tests * Add combinatorial tests for addFillResults * Add combinatorial tests for getPartialAmount * Implement generic `testWithReferenceFuncAsync` * Implement generic `testCombinatoriallyWithReferenceFuncAsync` * Add combinatorial tests for isRoundingError * Add combinatorial tests for calculateFillResults * Add support for Geth in internal contract tests * Fix contract artifacts * Change DECIMAL_PLACES to 78 and add a note. * Document new functions in utils * Optimize tests by only reseting state when needed * Rename/move some files * Print parameter names on failure in testWithReferenceFuncAsync * Add to changelog for utils package * Appease various linters * Rename some more things related to FillOrderCombinatorialUtils * Remove .only from test/exchange/internal.ts * Remove old test for isRoundingError and getPartialAmount * Appease linters again * Remove old todos * Fix typos, add comments, rename some things * Re-add some LibMath tests * Update contract internal tests to use new SafeMath revert reasons * Apply PR feedback from Amir * Apply PR feedback from Remco * Re-add networks to ZRXToken artifact * Remove duplicate Whitelist in compiler.json |