Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Added comments to order matching | Greg Hysen | 2018-08-25 | 1 | -1/+13 |
| | |||||
* | Rephrased some of the math in MixinMatchOrders to improve readability | Greg Hysen | 2018-08-25 | 1 | -3/+3 |
| | |||||
* | Added temporary @todo to MixinMatchOrders | Greg Hysen | 2018-08-25 | 1 | -4/+4 |
| | |||||
* | Wording in MixinMatchOrders | Greg Hysen | 2018-08-25 | 1 | -2/+2 |
| | |||||
* | Removed a redundant comment from matchOrders | Greg Hysen | 2018-08-25 | 1 | -5/+1 |
| | |||||
* | Rounding for fees in match orders addressed, plus example | Greg Hysen | 2018-08-25 | 1 | -4/+4 |
| | |||||
* | Added fees to matchOrders (previously in calculateFillResults | Greg Hysen | 2018-08-25 | 1 | -0/+24 |
| | |||||
* | Removed calculateFillResults from matchOrders workflow. Eliminates ↵ | Greg Hysen | 2018-08-25 | 1 | -38/+29 |
| | | | | compounded rounding errors. | ||||
* | Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow ↵ | Amir Bandeali | 2018-08-25 | 3 | -12/+9 |
| | | | | variations | ||||
* | Add nonReentrant modifiers on functions that use getCurrentContextAddress ↵ | Amir Bandeali | 2018-08-25 | 4 | -15/+17 |
| | | | | only, add lockMutex modifier on functions that make external calls | ||||
* | Add internal fill functions, add reentrancy guard to public functions that ↵ | Amir Bandeali | 2018-08-25 | 5 | -40/+148 |
| | | | | make external calls | ||||
* | Remove redundant sload from getCurrentContextAddress | Amir Bandeali | 2018-08-25 | 1 | -1/+2 |
| | |||||
* | Merge pull request #1003 from 0xProject/feature/contracts/roundup | Amir Bandeali | 2018-08-25 | 4 | -22/+116 |
|\ | | | | | [contracts] Add getPartialAmountCeil and isRoundingErrorCeil | ||||
| * | Stylistic fixes | Remco Bloemen | 2018-08-25 | 1 | -5/+20 |
| | | |||||
| * | Append -Floor to getPartialAmount and isRoundingError | Remco Bloemen | 2018-08-25 | 4 | -12/+12 |
| | | |||||
| * | Disambiguate the operator precedence | Remco Bloemen | 2018-08-25 | 1 | -2/+2 |
| | | |||||
| * | Add docs | Remco Bloemen | 2018-08-25 | 1 | -2/+7 |
| | | |||||
| * | Fix incorect modulus | Remco Bloemen | 2018-08-25 | 1 | -4/+2 |
| | | |||||
| * | Add DIVISION_BY_ZERO to getPartialAmount for consistency | Remco Bloemen | 2018-08-25 | 1 | -4/+3 |
| | | |||||
| * | Improve getPartialAmountCeil docs | Remco Bloemen | 2018-08-25 | 1 | -3/+3 |
| | | |||||
| * | Add isRoundingErrorCeil | Remco Bloemen | 2018-08-25 | 1 | -0/+29 |
| | | |||||
| * | Add getPartialAmountCeil | Remco Bloemen | 2018-08-25 | 1 | -3/+32 |
| | | |||||
| * | Handle zero case | Remco Bloemen | 2018-08-25 | 1 | -3/+15 |
| | | |||||
| * | Fix isRoundingError | Remco Bloemen | 2018-08-25 | 1 | -10/+17 |
| | | |||||
* | | Skip self-transfers | Remco Bloemen | 2018-08-25 | 1 | -1/+1 |
| | | |||||
* | | Remove Trezor SignatureType | Amir Bandeali | 2018-08-25 | 2 | -30/+1 |
| | | |||||
* | | Remove SignatureType.Caller | Amir Bandeali | 2018-08-25 | 2 | -30/+15 |
| | | |||||
* | | Rethrow Wallet and Validator errors | Amir Bandeali | 2018-08-25 | 1 | -4/+28 |
| | | |||||
* | | Revert if undefined function called in AssetProxies | Amir Bandeali | 2018-08-25 | 2 | -0/+6 |
| | | |||||
* | | Remove pragma experimental v0.5.0 and use staticcall is assembly | Amir Bandeali | 2018-08-25 | 2 | -3/+112 |
| | | |||||
* | | Add pragma experimental v0.5.0 to SignatureValidator and add tests | Amir Bandeali | 2018-08-25 | 1 | -0/+1 |
|/ | |||||
* | Revert incrementing memory ptr in dispatchTransferFrom | Amir Bandeali | 2018-08-09 | 3 | -9/+3 |
| | |||||
* | Increment free memory pointer for internal Exchange functions that use asm | Amir Bandeali | 2018-08-09 | 2 | -11/+13 |
| | |||||
* | fix comments and styling for MixinSignatureValidator | Amir Bandeali | 2018-08-09 | 1 | -4/+9 |
| | |||||
* | Use asm for hashEIP712Message, increment free memory pointer after asm ↵ | Amir Bandeali | 2018-08-09 | 2 | -9/+28 |
| | | | | hashing functions | ||||
* | Fix comments, styling, and optimize hashOrder | Amir Bandeali | 2018-08-08 | 3 | -25/+33 |
| | |||||
* | Add combinatorial tests for internal Exchange functions (#807) | Alex Browne | 2018-07-27 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP add combinatorial tests for internal Exchange functions * Change combinitorial testing strategy based on feedback * Check value of filled[orderHash] in updateFilledState tests * Add combinatorial tests for addFillResults * Add combinatorial tests for getPartialAmount * Implement generic `testWithReferenceFuncAsync` * Implement generic `testCombinatoriallyWithReferenceFuncAsync` * Add combinatorial tests for isRoundingError * Add combinatorial tests for calculateFillResults * Add support for Geth in internal contract tests * Fix contract artifacts * Change DECIMAL_PLACES to 78 and add a note. * Document new functions in utils * Optimize tests by only reseting state when needed * Rename/move some files * Print parameter names on failure in testWithReferenceFuncAsync * Add to changelog for utils package * Appease various linters * Rename some more things related to FillOrderCombinatorialUtils * Remove .only from test/exchange/internal.ts * Remove old test for isRoundingError and getPartialAmount * Appease linters again * Remove old todos * Fix typos, add comments, rename some things * Re-add some LibMath tests * Update contract internal tests to use new SafeMath revert reasons * Apply PR feedback from Amir * Apply PR feedback from Remco * Re-add networks to ZRXToken artifact * Remove duplicate Whitelist in compiler.json | ||||
* | Update orderEpoch comments | Amir Bandeali | 2018-07-25 | 2 | -2/+2 |
| | |||||
* | Use != instead of > in loops, add sanity checks to market fill functions | Amir Bandeali | 2018-07-23 | 1 | -13/+13 |
| | |||||
* | Remove redundant external call by reimplementing fillOrderNoThrow | Amir Bandeali | 2018-07-23 | 1 | -1/+1 |
| | |||||
* | Store orders length in varible before looping over orders | Amir Bandeali | 2018-07-23 | 1 | -11/+19 |
| | |||||
* | Update percentage constants | Amir Bandeali | 2018-07-23 | 2 | -14/+15 |
| | |||||
* | Update transferEthFeeAndRefund, add check to ERC721 transfer | Amir Bandeali | 2018-07-23 | 1 | -2/+4 |
| | |||||
* | Add comments for deploying with constant ZRX_ASSET_DATA | Amir Bandeali | 2018-07-23 | 2 | -2/+15 |
| | |||||
* | Merge pull request #877 from 0xProject/feature/contracts/removeERC721Callback | Amir Bandeali | 2018-07-23 | 1 | -74/+22 |
|\ | | | | | Removed receiverData and `onReceive` callback from ERC721 proxy. | ||||
| * | Removed receiverData from ERC721 Proxy Id generation | Greg Hysen | 2018-07-18 | 1 | -1/+1 |
| | | |||||
| * | Removed receiverData and `onReceive` callback from ERC721 proxy. | Greg Hysen | 2018-07-18 | 1 | -73/+21 |
| | | |||||
* | | Hard code fillOrder selector into abiEncodeFillOrder | Amir Bandeali | 2018-07-20 | 1 | -7/+4 |
| | | |||||
* | | Returns byte array instead of memory range for encoding fillOrder calldata | Greg Hysen | 2018-07-20 | 2 | -24/+26 |
| | | |||||
* | | Created LibAbiEncoder with `fillOrderNoThrow` | Greg Hysen | 2018-07-20 | 2 | -170/+235 |
|/ | |||||
* | Reorder checks in getOrderInfo | Amir Bandeali | 2018-07-18 | 1 | -7/+9 |
| | |||||
* | Add getOrdersInfo function | Amir Bandeali | 2018-07-18 | 2 | -0/+24 |
| | |||||
* | Use 0.4.10 in AssetProxyOwner, add readBytes4 to contract and remove LibBytes | Amir Bandeali | 2018-07-11 | 1 | -4/+23 |
| | |||||
* | Remove TODOs that won't be addressed | Amir Bandeali | 2018-07-07 | 4 | -10/+3 |
| | |||||
* | Remove AbiV2 where unused | Amir Bandeali | 2018-07-07 | 9 | -21/+17 |
| | |||||
* | Only reset currentContextAddress if it was previously updated | Amir Bandeali | 2018-07-07 | 1 | -8/+11 |
| | |||||
* | Apply new linter rules | Amir Bandeali | 2018-07-07 | 36 | -90/+99 |
| | |||||
* | Merge pull request #522 from 0xProject/feature/contracts/forwarder | Jacob Evans | 2018-07-06 | 1 | -1/+1 |
|\ | | | | | Forwarding contract | ||||
| * | Forwarding contract (squashed commits) | Jacob Evans | 2018-07-06 | 1 | -1/+1 |
| | | |||||
* | | Contracts 2.0.0 were linted with solhint | Alex Shafranovich | 2018-07-06 | 34 | -1/+42 |
|/ | |||||
* | Update file structure | Amir Bandeali | 2018-06-30 | 36 | -0/+3908 |