Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | safeGetPartialAmount (#1035) | Amir Bandeali | 2018-08-29 | 1 | -8/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added Test "Should transfer correct amounts when left order is fully filled and values pass isRoundingErrorCeil but fail isRoundingErrorFloor" * Added RoundingError exception to reference function for getPartialAmount * Added RoundingError exception to reference function for getPartialAmount * Added isRoundingErrorCeil to getPartialAmountCeil reference funtion * Computed new values for "Should give right maker a better buy price when correct price is not integral" that does not have a rounding error * Almost all tests for match orders are passing after adding isRoundingErrorCeil check * WIP commit: Added rounding error checks to getPartialAmount * WIP commit: Added rounding error checks to getPartialAmount * Use safe versions of getPartialAmount * Update Exchange internals tests * Run linter * Found new values for "Should transfer correct amounts when right order fill amount deviates from amount derived by `Exchange.fillOrder`" * Fixed merge conflicts * Run all tests * Cleaned up some comments on match Orders tests * Fix tests for geth | ||||
* | Merge pull request #986 from 0xProject/feature/contracts/assertions | Amir Bandeali | 2018-08-25 | 1 | -6/+16 |
|\ | | | | | Add more assertions to assertValidFill | ||||
| * | Merge branch 'fix/contracts/robustMatching' of github.com:0xProject/0x.js ↵ | Remco Bloemen | 2018-08-25 | 1 | -2/+5 |
| |\ | | | | | | | | | | into fix/contracts/robustMatching | ||||
| * | | Fix mixin api | Remco Bloemen | 2018-08-25 | 1 | -7/+7 |
| | | | |||||
| * | | Split into assertFillable and assertValidFill | Remco Bloemen | 2018-08-25 | 1 | -5/+13 |
| | | | |||||
| * | | Update for new assertValidFill signature | Remco Bloemen | 2018-08-25 | 1 | -1/+3 |
| | | | |||||
* | | | Added comments to order matching | Greg Hysen | 2018-08-25 | 1 | -1/+13 |
| | | | |||||
* | | | Rephrased some of the math in MixinMatchOrders to improve readability | Greg Hysen | 2018-08-25 | 1 | -3/+3 |
| | | | |||||
* | | | Added temporary @todo to MixinMatchOrders | Greg Hysen | 2018-08-25 | 1 | -4/+4 |
| | | | |||||
* | | | Wording in MixinMatchOrders | Greg Hysen | 2018-08-25 | 1 | -2/+2 |
| | | | |||||
* | | | Removed a redundant comment from matchOrders | Greg Hysen | 2018-08-25 | 1 | -5/+1 |
| | | | |||||
* | | | Rounding for fees in match orders addressed, plus example | Greg Hysen | 2018-08-25 | 1 | -4/+4 |
| | | | |||||
* | | | Added fees to matchOrders (previously in calculateFillResults | Greg Hysen | 2018-08-25 | 1 | -0/+24 |
| | | | |||||
* | | | Removed calculateFillResults from matchOrders workflow. Eliminates ↵ | Greg Hysen | 2018-08-25 | 1 | -38/+29 |
| |/ |/| | | | | | compounded rounding errors. | ||||
* | | Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow ↵ | Amir Bandeali | 2018-08-25 | 1 | -1/+1 |
| | | | | | | | | variations | ||||
* | | Add nonReentrant modifiers on functions that use getCurrentContextAddress ↵ | Amir Bandeali | 2018-08-25 | 1 | -1/+1 |
| | | | | | | | | only, add lockMutex modifier on functions that make external calls | ||||
* | | Add internal fill functions, add reentrancy guard to public functions that ↵ | Amir Bandeali | 2018-08-25 | 1 | -0/+3 |
| | | | | | | | | make external calls | ||||
* | | Append -Floor to getPartialAmount and isRoundingError | Remco Bloemen | 2018-08-25 | 1 | -2/+2 |
|/ | |||||
* | Remove TODOs that won't be addressed | Amir Bandeali | 2018-07-07 | 1 | -3/+0 |
| | |||||
* | Apply new linter rules | Amir Bandeali | 2018-07-07 | 1 | -1/+1 |
| | |||||
* | Contracts 2.0.0 were linted with solhint | Alex Shafranovich | 2018-07-06 | 1 | -0/+1 |
| | |||||
* | Update file structure | Amir Bandeali | 2018-06-30 | 1 | -0/+301 |