Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | clarify iteration range | F. Eugene Aumson | 2018-08-17 | 1 | -1/+2 |
| | |||||
* | scrap comments in favor of self-documentation | F. Eugene Aumson | 2018-08-17 | 1 | -3/+2 |
| | |||||
* | declare contractData before adding to map | F. Eugene Aumson | 2018-08-17 | 1 | -2/+3 |
| | |||||
* | change `return Promise<void>` to `await...` | F. Eugene Aumson | 2018-08-17 | 1 | -1/+1 |
| | |||||
* | consolidate binPaths... ref's into fullSolcVersion | F. Eugene Aumson | 2018-08-17 | 1 | -2/+2 |
| | |||||
* | extract method _shouldCompile() | F. Eugene Aumson | 2018-08-16 | 1 | -13/+12 |
| | |||||
* | clarify recompilation tests | F. Eugene Aumson | 2018-08-16 | 1 | -6/+8 |
| | |||||
* | change .rejectedWith(error) to .rejected() | F. Eugene Aumson | 2018-08-16 | 1 | -1/+1 |
| | |||||
* | follow chai_setup pattern | F. Eugene Aumson | 2018-08-16 | 3 | -2/+16 |
| | |||||
* | renamed variable `compiled` to `compilerOutput` | F. Eugene Aumson | 2018-08-16 | 1 | -6/+6 |
| | |||||
* | use `for...of _.keys` instead of `for...in` | F. Eugene Aumson | 2018-08-16 | 1 | -5/+1 |
| | |||||
* | raise error for unknown compiler version | F. Eugene Aumson | 2018-08-16 | 1 | -0/+3 |
| | |||||
* | comments | F. Eugene Aumson | 2018-08-16 | 1 | -0/+3 |
| | |||||
* | remedy missing *IfExists identifier suffix | F. Eugene Aumson | 2018-08-16 | 1 | -6/+3 |
| | |||||
* | extract interfaces for re-used complex data types | F. Eugene Aumson | 2018-08-16 | 1 | -23/+28 |
| | |||||
* | move getSolcAsync to static private method | F. Eugene Aumson | 2018-08-16 | 1 | -23/+23 |
| | |||||
* | rename variable inputsByVersion to versionToInputs | F. Eugene Aumson | 2018-08-16 | 1 | -8/+8 |
| | |||||
* | move getSolcAsync to static private method | F. Eugene Aumson | 2018-08-16 | 1 | -25/+24 |
| | |||||
* | Update changelog | F. Eugene Aumson | 2018-08-15 | 1 | -0/+10 |
| | |||||
* | test compiler | F. Eugene Aumson | 2018-08-15 | 4 | -12/+82 |
| | |||||
* | simplify method interface | F. Eugene Aumson | 2018-08-15 | 1 | -8/+12 |
| | |||||
* | simplify method parameter | F. Eugene Aumson | 2018-08-15 | 1 | -6/+4 |
| | |||||
* | corrected whitespace (no functional changes) | F. Eugene Aumson | 2018-08-15 | 1 | -39/+41 |
| | |||||
* | compile contracts in batches | F. Eugene Aumson | 2018-08-15 | 1 | -31/+70 |
| | | | | one batch per compiler version needed. | ||||
* | extract method _verifyAndPersistCompilationAsync() | F. Eugene Aumson | 2018-08-15 | 1 | -1/+18 |
| | |||||
* | extract method _compile() | F. Eugene Aumson | 2018-08-15 | 1 | -24/+27 |
| | |||||
* | extract function getSolcAsync() | F. Eugene Aumson | 2018-08-15 | 1 | -18/+25 |
| | |||||
* | Merge pull request #964 from 0xProject/feature/sra-api/add-defaults | Francesco Agosti | 2018-08-14 | 3 | -6/+9 |
|\ | | | | | [sra-api] Add defaults for networkId and pagination | ||||
| * | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-08-14 | 89 | -415/+667 |
| |\ | |/ |/| | | | feature/sra-api/add-defaults | ||||
* | | Publish | Alex Browne | 2018-08-14 | 32 | -280/+269 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.3 - @0xproject/abi-gen@1.0.5 - @0xproject/assert@1.0.5 - @0xproject/base-contract@2.0.0-rc.1 - @0xproject/connect@1.0.5 - @0xproject/contract-wrappers@1.0.1-rc.3 - contracts@2.1.40 - @0xproject/dev-utils@1.0.4 - ethereum-types@1.0.4 - @0xproject/fill-scenarios@1.0.1-rc.3 - @0xproject/json-schemas@1.0.1-rc.4 - @0xproject/metacoin@0.0.15 - @0xproject/migrations@1.0.4 - @0xproject/monorepo-scripts@1.0.5 - @0xproject/order-utils@1.0.1-rc.3 - @0xproject/order-watcher@1.0.1-rc.3 - @0xproject/react-docs@1.0.5 - @0xproject/react-docs-example@0.0.20 - @0xproject/react-shared@1.0.6 - @0xproject/sol-compiler@1.0.5 - @0xproject/sol-cov@2.0.0 - @0xproject/sol-resolver@1.0.5 - @0xproject/sra-api@1.0.1-rc.4 - @0xproject/sra-report@1.0.5 - @0xproject/subproviders@1.0.5 - @0xproject/testnet-faucets@1.0.41 - @0xproject/tslint-config@1.0.5 - @0xproject/types@1.0.1-rc.4 - @0xproject/typescript-typings@1.0.4 - @0xproject/utils@1.0.5 - @0xproject/web3-wrapper@1.2.0 - @0xproject/website@0.0.44 | ||||
* | | Updated CHANGELOGS | Alex Browne | 2018-08-14 | 57 | -135/+398 |
| | | |||||
| * | Add defaults for networkId and pagination | fragosti | 2018-08-14 | 4 | -7/+10 |
|/ | |||||
* | fix(0x.js, order-utils): Fix CHANGELOG.json versions | Alex Browne | 2018-08-14 | 2 | -16/+6 |
| | |||||
* | Run publish/installation tests in CircleCI (#951) | Alex Browne | 2018-08-14 | 4 | -46/+134 |
| | | | | feat(monorepo-scripts): Run publish tests in CircleCI | ||||
* | Merge pull request #932 from 0xProject/fix-ganache-fork | Fabio Berger | 2018-08-14 | 5 | -12/+7 |
|\ | | | | | Fix ganache fork | ||||
| * | Move to dep | Fabio Berger | 2018-07-31 | 1 | -1/+1 |
| | | |||||
| * | Remove outdated parts of Dockerfile | Fabio Berger | 2018-07-31 | 1 | -5/+0 |
| | | |||||
| * | Fix github dep to point to branch | Fabio Berger | 2018-07-31 | 3 | -6/+6 |
| | | |||||
* | | Merge pull request #914 from 0xProject/feature/0x.js/ec-signature-string | Jacob Evans | 2018-08-14 | 13 | -140/+225 |
|\ \ | | | | | | | 0x.js Return signature as a hex encoded string | ||||
| * | | Update version numbers. | Jacob Evans | 2018-08-14 | 5 | -10/+12 |
| | | | | | | | | | | | | | | | Add source for Metamask future fix. Consolidate switch statement to one return | ||||
| * | | Rename from SignerProviderType.EthSign to SignerType.Default | Jacob Evans | 2018-08-11 | 9 | -115/+116 |
| | | | |||||
| * | | Update Changelogs. Rebased from development | Jacob Evans | 2018-08-09 | 5 | -11/+35 |
| | | | |||||
| * | | Update jsdoc | Jacob Evans | 2018-08-09 | 2 | -5/+5 |
| | | | |||||
| * | | Introduce SignerProviderType | Jacob Evans | 2018-08-09 | 11 | -118/+176 |
| | | | | | | | | | | | | This allows the developer to indicate the nuanced signer provider. Some have different implementations (trezor, ledger) and others have different implementations (metamask). Breaking the abstraction of eth_sign. EthSign assumes a spec compliant implementation and can be used as a default | ||||
* | | | Merge pull request #958 from 0xProject/feature/sra-api/camel-case-everything | Francesco Agosti | 2018-08-14 | 11 | -38/+58 |
|\ \ \ | | | | | | | | | [sra-api] Enforce camelCase for all parameters and other changes. | ||||
| * | | | Ignore api.json in prettier | fragosti | 2018-08-14 | 2 | -1044/+2 |
| | | | | |||||
| * | | | apply prettier | fragosti | 2018-08-14 | 2 | -4/+1047 |
| | | | | |||||
| * | | | Enforce camelCase for all parameters and change the way the site is deployed ↵ | fragosti | 2018-08-11 | 10 | -35/+54 |
| | | | | | | | | | | | | | | | | and hosted | ||||
* | | | | fix(sol-compiler, sol-resolver): Bug where sol-resolver tried to read a ↵ | Alex Browne | 2018-08-14 | 4 | -1/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | directory (#961) fix(sol-compiler, sol-resolver): Fix bug where sol-resolver tried to read a directory | ||||
* | | | | Merge pull request #955 from feuGeneA/patch-6 | Fabio Berger | 2018-08-14 | 1 | -5/+5 |
|\ \ \ \ | | | | | | | | | | | [PR template] a to-do list should be in the imperative mood | ||||
| * | | | | a to-do list should be in the imperative mood | F. Eugene Aumson | 2018-08-10 | 1 | -5/+5 |
| |/ / / | |||||
* | | | | Merge pull request #938 from 0xProject/sol-cov-fixes | Fabio Berger | 2018-08-14 | 10 | -22/+162 |
|\ \ \ \ | |/ / / |/| | | | Sol cov fixes | ||||
| * | | | Merge branch 'sol-cov-fixes' of github.com:0xProject/0x-monorepo into ↵ | Fabio Berger | 2018-08-14 | 86 | -203/+1673 |
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sol-cov-fixes * 'sol-cov-fixes' of github.com:0xProject/0x-monorepo: (49 commits) Add @return comments Import marshaller directly Update comment about ethers checksummed address behavior Add packages/coverage/.gitkeep file Update CI config and package.json to run @0xproject/utils tests on CI Update remaining CHANGELOG.json files Change amir picture Update CHANGELOG.json for contract-wrappers Update ethers typings for TypeScript 2.9.2 Update CHANGELOG.json for base-contract Move some ethers-related types to typescript-typings/ethers Apply prettier Add strictArgumentEncodingCheck to BaseContract and use it in contract templates fix(monorepo-scripts): Fix typo in git tag command feat(monorepo-scripts): Add confirmation prompt before publishing fix comments and styling for MixinSignatureValidator Update TypeScript to version 2.9.2 Use asm for hashEIP712Message, increment free memory pointer after asm hashing functions Fix comments, styling, and optimize hashOrder Remove assertion comments ... | ||||
| | * | | | Merge branch 'development' into sol-cov-fixes | Leonid Logvinov | 2018-08-09 | 84 | -201/+1663 |
| | |\| | | |||||
| | * | | | Add @return comments | Leonid Logvinov | 2018-08-09 | 1 | -0/+9 |
| | | | | | |||||
| | * | | | Import marshaller directly | Leonid Logvinov | 2018-08-09 | 1 | -2/+1 |
| | | | | | |||||
| * | | | | Remove test for unknown prop now that we are allowing additional props fro ↵ | Fabio Berger | 2018-08-14 | 1 | -4/+0 |
| |/ / / | | | | | | | | | | | | | txData | ||||
| * | | | Add comments | Leonid Logvinov | 2018-08-03 | 1 | -0/+39 |
| | | | | |||||
| * | | | Add PR numbers | Leonid Logvinov | 2018-08-03 | 4 | -10/+17 |
| | | | | |||||
| * | | | Add sol-cov CHANGELOG | Leonid Logvinov | 2018-08-03 | 1 | -0/+20 |
| | | | | |||||
| * | | | Read truffle compiler config from truffle.js and assert that the passed ↵ | Leonid Logvinov | 2018-08-03 | 1 | -7/+51 |
| | | | | | | | | | | | | | | | | solidity version matches the one in artifacts | ||||
| * | | | Use CallDataRPC in subprovider | Leonid Logvinov | 2018-08-03 | 1 | -7/+8 |
| | | | | |||||
| * | | | Add a TODO for failed transactions | Leonid Logvinov | 2018-08-03 | 1 | -0/+1 |
| | | | | |||||
| * | | | Export RPC data types from web3-wrapper | Leonid Logvinov | 2018-08-03 | 2 | -1/+14 |
| | | | | |||||
| * | | | Alow additional properties in txData json-schema | Leonid Logvinov | 2018-08-03 | 2 | -1/+8 |
| | | | | |||||
| * | | | Export marshaller from web3-wrapper | Leonid Logvinov | 2018-08-03 | 2 | -0/+9 |
| | | | | |||||
* | | | | Merge pull request #948 from 0xProject/feature/contracts/forwarderFoK | Amir Bandeali | 2018-08-10 | 10 | -163/+84 |
|\ \ \ \ | | | | | | | | | | | [contracts] Make marketBuy functions revert if entire amount not filled | ||||
| * | | | | Change withdrawERC20 => withdrawAsset, reuse transfer logic | Amir Bandeali | 2018-08-10 | 6 | -22/+40 |
| | | | | | |||||
| * | | | | Make marketBuy functions revert if entire amount not filled | Amir Bandeali | 2018-08-10 | 6 | -141/+44 |
| | | | | | |||||
* | | | | | Merge pull request #916 from 0xProject/feature/sra/add-sra-package | Francesco Agosti | 2018-08-10 | 81 | -992/+2742 |
|\ \ \ \ \ | | | | | | | | | | | | | Add the sra-api package (OpenAPI Spec) | ||||
| * | | | | | Fix order-watcher json-schemas | fragosti | 2018-08-10 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | Fix linting issues | fragosti | 2018-08-10 | 2 | -2/+1 |
| | | | | | | |||||
| * | | | | | fix contract-wrappers json-schemas | fragosti | 2018-08-10 | 15 | -271/+186 |
| | | | | | | |||||
| * | | | | | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-08-10 | 60 | -136/+601 |
| |\ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | feature/sra/add-sra-package | ||||
* | | | | | | Merge pull request #949 from 0xProject/fix/update-dependencies | Alex Browne | 2018-08-10 | 30 | -45/+45 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | fix: Update dependencies | ||||
| * | | | | | | fix: Update dependencies | Alex Browne | 2018-08-10 | 30 | -45/+45 |
| | |/ / / / | |/| | | | | |||||
* | | | | | | Update Clays linkedin | fragosti | 2018-08-10 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge https://github.com/0xProject/0x-monorepo into development | fragosti | 2018-08-10 | 27 | -45/+504 |
|\| | | | | | |||||
| * | | | | | Merge pull request #941 from 0xProject/feature/contracts/returnValuesTests | Amir Bandeali | 2018-08-10 | 7 | -34/+120 |
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | [contracts] Test fillOrder return values and abiEncodeFillOrder | ||||
| | * | | | | Revert incrementing memory ptr in dispatchTransferFrom | Amir Bandeali | 2018-08-09 | 3 | -9/+3 |
| | | | | | | |||||
| | * | | | | Test abiEncodeFillOrder as part of combinatorial follOrder tests | Amir Bandeali | 2018-08-09 | 4 | -16/+46 |
| | | | | | | |||||
| | * | | | | Increment free memory pointer for internal Exchange functions that use asm | Amir Bandeali | 2018-08-09 | 3 | -12/+34 |
| | | | | | | |||||
| | * | | | | Add return values to combinatorial fillOrder tests | Amir Bandeali | 2018-08-09 | 2 | -11/+51 |
| | | | | | | |||||
| * | | | | | Merge pull request #915 from 0xProject/feature/encode-decode-checks | Alex Browne | 2018-08-09 | 20 | -11/+384 |
| |\ \ \ \ \ | | | | | | | | | | | | | | | Add strictArgumentEncodingCheck to BaseContract and use it in contract templates | ||||
| | * | | | | | Update comment about ethers checksummed address behavior | Alex Browne | 2018-08-09 | 1 | -3/+3 |
| | | | | | | | |||||
| | * | | | | | Add packages/coverage/.gitkeep file | Alex Browne | 2018-08-09 | 1 | -0/+0 |
| | | | | | | | |||||
| | * | | | | | Update CI config and package.json to run @0xproject/utils tests on CI | Alex Browne | 2018-08-09 | 2 | -1/+6 |
| | | | | | | | |||||
| | * | | | | | Update remaining CHANGELOG.json files | Alex Browne | 2018-08-09 | 4 | -0/+22 |
| | | | | | | | |||||
| | * | | | | | Update CHANGELOG.json for contract-wrappers | Alex Browne | 2018-08-09 | 1 | -0/+4 |
| | | | | | | | |||||
| | * | | | | | Update ethers typings for TypeScript 2.9.2 | Alex Browne | 2018-08-09 | 1 | -2/+2 |
| | | | | | | | |||||
| | * | | | | | Update CHANGELOG.json for base-contract | Alex Browne | 2018-08-09 | 1 | -0/+9 |
| | | | | | | | |||||
| | * | | | | | Move some ethers-related types to typescript-typings/ethers | Alex Browne | 2018-08-09 | 3 | -13/+25 |
| | | | | | | | |||||
| | * | | | | | Apply prettier | Alex Browne | 2018-08-09 | 5 | -25/+36 |
| | | | | | | | |||||
| | * | | | | | Add strictArgumentEncodingCheck to BaseContract and use it in contract templates | Alex Browne | 2018-08-09 | 11 | -9/+319 |
| | | | | | | | |||||
* | | | | | | | Add clay to website | fragosti | 2018-08-10 | 2 | -0/+11 |
|/ / / / / / | |||||
* | | | | | | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-08-09 | 1 | -4/+9 |
|\ \ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | development | ||||
| * | | | | | Merge pull request #946 from 0xProject/fix/contracts/signatureValidatorComments | Amir Bandeali | 2018-08-09 | 1 | -4/+9 |
| |\ \ \ \ \ | | |/ / / / | |/| | | | | [contracts] Fix comments and styling for MixinSignatureValidator | ||||
| | * | | | | fix comments and styling for MixinSignatureValidator | Amir Bandeali | 2018-08-09 | 1 | -4/+9 |
| | | | | | | |||||
* | | | | | | Change amir picture | fragosti | 2018-08-09 | 3 | -1/+1 |
|/ / / / / | |||||
| | * | | | Apply prettier | fragosti | 2018-08-10 | 1 | -6/+14 |
| | | | | | |||||
| | * | | | Change scripts folder to build_scripts | fragosti | 2018-08-10 | 2 | -1/+7 |
| | | | | | |||||
| | * | | | Force case change in file | fragosti | 2018-08-10 | 1 | -0/+0 |
| | | | | | |||||
| | * | | | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-08-09 | 37 | -72/+124 |
| | |\ \ \ | |_|/ / / |/| | | | | | | | | | feature/sra/add-sra-package | ||||
* | | | | | Merge pull request #947 from 0xProject/feature/confirm-before-publish | Alex Browne | 2018-08-09 | 2 | -9/+15 |
|\ \ \ \ \ | | | | | | | | | | | | | Add confirmation prompt before publishing | ||||
| * | | | | | fix(monorepo-scripts): Fix typo in git tag command | Alex Browne | 2018-08-09 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | feat(monorepo-scripts): Add confirmation prompt before publishing | Alex Browne | 2018-08-09 | 2 | -75/+14 |
| | | | | | | |||||
* | | | | | | Merge pull request #945 from 0xProject/fix/typescript-2.9.2 | Alex Browne | 2018-08-09 | 32 | -101/+53 |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | Update TypeScript to version 2.9.2 | ||||
| * | | | | | Update TypeScript to version 2.9.2 | Alex Browne | 2018-08-09 | 32 | -101/+53 |
| |/ / / / | |||||
* | | | | | Merge pull request #925 from 0xProject/refactor/contracts/hashing | Amir Bandeali | 2018-08-09 | 3 | -29/+56 |
|\ \ \ \ \ | |/ / / / |/| | | | | [contracts] Fix comments, styling and small optimization for hashOrder | ||||
| * | | | | Use asm for hashEIP712Message, increment free memory pointer after asm ↵ | Amir Bandeali | 2018-08-09 | 2 | -9/+28 |
| | | | | | | | | | | | | | | | | | | | | hashing functions | ||||
| * | | | | Fix comments, styling, and optimize hashOrder | Amir Bandeali | 2018-08-08 | 3 | -25/+33 |
|/ / / / | |||||
| * | | | Remove md hints because the static site cannot handle them | fragosti | 2018-08-09 | 1 | -4/+4 |
| | | | | |||||
| * | | | Add section about json-schemas and sra report | fragosti | 2018-08-09 | 1 | -4/+30 |
| | | | | |||||
| * | | | Fix links in markdown | fragosti | 2018-08-09 | 1 | -8/+8 |
| | | | | |||||
| * | | | Add to changelog and fix OrderBook typo | fragosti | 2018-08-09 | 5 | -9/+19 |
| | | | | |||||
| * | | | Correct orderbook typo | fragosti | 2018-08-09 | 3 | -7/+7 |
| | | | | |||||
| * | | | Enforce that error code are ints not number | fragosti | 2018-08-09 | 1 | -2/+2 |
| | | | | |||||
| * | | | Remove tests directory, use swagger api, make json api compliant | fragosti | 2018-08-09 | 7 | -29/+201 |
| | | | | |||||
| * | | | Change remainingFillableAmount to metaData | fragosti | 2018-08-09 | 2 | -4/+6 |
| | | | | |||||
| * | | | Change some static side configs | fragosti | 2018-08-08 | 2 | -13/+15 |
| | | | | |||||
| * | | | Add POST order endpoint | fragosti | 2018-08-08 | 5 | -12/+56 |
| | | | | |||||
| * | | | Add GET fee_recipients | fragosti | 2018-08-08 | 5 | -0/+39 |
| | | | | |||||
| * | | | Add GET order_config | fragosti | 2018-08-08 | 5 | -0/+43 |
| | | | | |||||
| * | | | token_pairs -> asset_pairs | fragosti | 2018-08-08 | 1 | -4/+4 |
| | | | | |||||
| * | | | Add GET OrderBook endpoint | fragosti | 2018-08-08 | 3 | -0/+92 |
| | | | | |||||
| * | | | Add GET order endpoint spec | fragosti | 2018-08-08 | 3 | -1/+47 |
| | | | | |||||
| * | | | Add orders endpoint | fragosti | 2018-08-08 | 4 | -1/+175 |
| | | | | |||||
| * | | | Minor refactoring | fragosti | 2018-08-08 | 4 | -26/+7 |
| | | | | |||||
| * | | | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-08-08 | 73 | -1574/+2436 |
| |\ \ \ | |/ / / |/| | | | | | | | feature/sra/add-sra-package | ||||
* | | | | Merge pull request #937 from ↵ | Brandon Millman | 2018-08-07 | 9 | -2/+462 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | 0xProject/feature/contract-wrappers/forwarder-estimation-utils Add marketUtils object for assisting with market buy calculations | ||||
| * | | | | Remove assertion comments | Brandon Millman | 2018-08-07 | 1 | -4/+0 |
| | | | | | |||||
| * | | | | Remove 0x test case from hexSchema test | Brandon Millman | 2018-08-06 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Update CHANGELOGs | Brandon Millman | 2018-08-06 | 2 | -0/+13 |
| | | | | | |||||
| * | | | | Add some test cases that stress slippageBufferAmount param | Brandon Millman | 2018-08-06 | 1 | -6/+15 |
| | | | | | |||||
| * | | | | Add tests for findFeeOrdersThatCoverFeesForTargetOrders | Brandon Millman | 2018-08-06 | 4 | -20/+165 |
| | | | | | |||||
| * | | | | Change orderStates param name to remaingFillableMakerAssetAmounts | Brandon Millman | 2018-08-06 | 3 | -91/+69 |
| | | | | | |||||
| * | | | | Implement first round of tests for findOrdersThatCoverMakerAssetFillAmount | Brandon Millman | 2018-08-06 | 5 | -12/+222 |
| | | | | | |||||
| * | | | | Update hex schema to match 0x | Brandon Millman | 2018-08-06 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Move helper functions into order-utils | Brandon Millman | 2018-08-06 | 3 | -100/+111 |
| | | | | | |||||
| * | | | | Add findFeeOrdersThatCoverFeesForTargetOrders to ForwarderWrapper | Brandon Millman | 2018-08-06 | 1 | -5/+60 |
| | | | | | |||||
| * | | | | Add findOrdersThatCoverMakerAssetFillAmount static method on ForwarderWrapper | Brandon Millman | 2018-08-06 | 1 | -1/+44 |
|/ / / / | |||||
* | | | | Merge pull request #936 from ↵ | Brandon Millman | 2018-08-06 | 13 | -44/+241 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | 0xProject/feature/contract-wrappers/forwader-optimizations ForwarderWrapper order optimizations | ||||
| * | | | | Move CreateOrderOpts into shared types | Brandon Millman | 2018-08-06 | 3 | -12/+22 |
| | | | | | |||||
| * | | | | Update createFactory to accept one createOrderOpts param to encompass all ↵ | Brandon Millman | 2018-08-06 | 4 | -41/+59 |
| | | | | | | | | | | | | | | | | | | | | optional params | ||||
| * | | | | Prettier | Brandon Millman | 2018-08-04 | 1 | -1/+0 |
| | | | | | |||||
| * | | | | Fix CHANGELOGs | Brandon Millman | 2018-08-04 | 3 | -3/+12 |
| | | | | | |||||
| * | | | | Update orderFactory interface | Brandon Millman | 2018-08-04 | 4 | -33/+28 |
| | | | | | |||||
| * | | | | Rename to calldata utils | Brandon Millman | 2018-08-03 | 3 | -16/+16 |
| | | | | | |||||
| * | | | | Add missing PR numbers | Brandon Millman | 2018-08-03 | 2 | -2/+3 |
| | | | | | |||||
| * | | | | CHANGELOG | Brandon Millman | 2018-08-02 | 1 | -0/+4 |
| | | | | | |||||
| * | | | | Add tests | Brandon Millman | 2018-08-02 | 2 | -18/+85 |
| | | | | | |||||
| * | | | | Add createOrder with no signing to orderFactory | Brandon Millman | 2018-08-02 | 3 | -6/+45 |
| | | | | | |||||
| * | | | | Create marketBuyOrdersOptimizations | Brandon Millman | 2018-08-02 | 3 | -8/+63 |
|/ / / / | |||||
* | | | | Update contract-wrappers CHANGELOG.json | Brandon Millman | 2018-08-02 | 1 | -0/+9 |
| | | | | |||||
* | | | | Merge pull request #934 from 0xProject/feature/contract-wrappers/forwader | Brandon Millman | 2018-08-02 | 11 | -10/+448 |
|\ \ \ \ | |_|/ / |/| | | | Initial forwarder contract wrapper | ||||
| * | | | Clarify ethAmount is in wei | Brandon Millman | 2018-07-31 | 1 | -2/+2 |
| | | | | |||||
| * | | | Update forwarder_wrapper_test | Brandon Millman | 2018-07-31 | 1 | -0/+16 |
| | | | | |||||
| * | | | Add more assertions | Brandon Millman | 2018-07-31 | 3 | -6/+102 |
| | | | | |||||
| * | | | Write initial test for forwarder_wrapper | Brandon Millman | 2018-07-31 | 2 | -16/+73 |
| | | | | |||||
| * | | | Fix spelling error in exchange wrapper tests | Brandon Millman | 2018-07-31 | 1 | -1/+1 |
| | | | | |||||
| * | | | Add getOrdersInfo to exchange_wrapper | Brandon Millman | 2018-07-31 | 3 | -3/+32 |
| | | | | |||||
| * | | | Implement initial forwarder wrapper | Brandon Millman | 2018-07-31 | 8 | -2/+242 |
| | | | | |||||
* | | | | Add the CHANGELOG entry for #909 | Leonid Logvinov | 2018-07-31 | 1 | -0/+9 |
| | | | | |||||
* | | | | Merge pull request #909 from joincivil/ritave/resolver-check-dirs | Leonid Logvinov | 2018-07-31 | 2 | -1/+2 |
|\ \ \ \ | |/ / / |/| | | | Fixed the relative resolver not checking if the file can be read in the | ||||
| * | | | Merge branch 'development' into ritave/resolver-check-dirs | Leonid Logvinov | 2018-07-31 | 208 | -6745/+59805 |
| |\ \ \ | |/ / / |/| | | | |||||
* | | | | Merge pull request #931 from 0xProject/feature/website/meta-tags | Brandon Millman | 2018-07-31 | 8 | -73/+138 |
|\ \ \ \ | | | | | | | | | | | Add MetaTags component for easily adding customizable meta tags for a new page | ||||
| * | | | | Add back tags in html | Brandon Millman | 2018-07-31 | 1 | -1/+7 |
| | | | | | |||||
| * | | | | Fix jobs page overflow issue | Brandon Millman | 2018-07-30 | 3 | -4/+6 |
| | | | | | |||||
| * | | | | Create MetaTags component | Brandon Millman | 2018-07-30 | 7 | -76/+133 |
|/ / / / | |||||
* | | | | Merge pull request #910 from ↵ | Francesco Agosti | 2018-07-28 | 14 | -180/+346 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | 0xProject/feature/website/upgrade-allowance-toggles-to-locks-and-checks [website] Use new designs with tooltips for allowance toggles | ||||
| * \ \ \ | Merge branch 'development' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-07-28 | 195 | -6494/+59326 |
| |\ \ \ \ | |/ / / / |/| | | | | | | | | | feature/website/upgrade-allowance-toggles-to-locks-and-checks | ||||
* | | | | | Add note about needing Yarn 1.6 to README | Fabio Berger | 2018-07-27 | 1 | -3/+5 |
| | | | | | |||||
* | | | | | Add combinatorial tests for internal Exchange functions (#807) | Alex Browne | 2018-07-27 | 24 | -1269/+788 |
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * WIP add combinatorial tests for internal Exchange functions * Change combinitorial testing strategy based on feedback * Check value of filled[orderHash] in updateFilledState tests * Add combinatorial tests for addFillResults * Add combinatorial tests for getPartialAmount * Implement generic `testWithReferenceFuncAsync` * Implement generic `testCombinatoriallyWithReferenceFuncAsync` * Add combinatorial tests for isRoundingError * Add combinatorial tests for calculateFillResults * Add support for Geth in internal contract tests * Fix contract artifacts * Change DECIMAL_PLACES to 78 and add a note. * Document new functions in utils * Optimize tests by only reseting state when needed * Rename/move some files * Print parameter names on failure in testWithReferenceFuncAsync * Add to changelog for utils package * Appease various linters * Rename some more things related to FillOrderCombinatorialUtils * Remove .only from test/exchange/internal.ts * Remove old test for isRoundingError and getPartialAmount * Appease linters again * Remove old todos * Fix typos, add comments, rename some things * Re-add some LibMath tests * Update contract internal tests to use new SafeMath revert reasons * Apply PR feedback from Amir * Apply PR feedback from Remco * Re-add networks to ZRXToken artifact * Remove duplicate Whitelist in compiler.json | ||||
| * | | | Remove unused variable | fragosti | 2018-07-28 | 1 | -1/+0 |
| | | | | |||||
| * | | | Add loading state for initial load and other PR feedback | fragosti | 2018-07-28 | 2 | -10/+14 |
| | | | | |||||
| * | | | Make a non-jank Spinner component and use it | fragosti | 2018-07-25 | 4 | -3/+84 |
| | | | | |||||
| * | | | Merge branch 'v2-prototype' of https://github.com/0xProject/0x-monorepo into ↵ | fragosti | 2018-07-25 | 131 | -2380/+2820 |
| |\ \ \ | | | | | | | | | | | | | | | | feature/website/upgrade-allowance-toggles-to-locks-and-checks | ||||
| * | | | | Center allowance toggles in account page | fragosti | 2018-07-25 | 1 | -7/+9 |
| | | | | | |||||
| * | | | | Increase allowance toggle loading spinner size by 1 | fragosti | 2018-07-25 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Add unlocking and locking token copy | fragosti | 2018-07-25 | 1 | -2/+2 |
| | | | | | |||||
| * | | | | Hide tooltip after allowance toggle click | fragosti | 2018-07-25 | 1 | -1/+3 |
| | | | | | |||||
| * | | | | Make tooltip appear to the left of the toggle when onboarding in progress | fragosti | 2018-07-25 | 6 | -3/+20 |
| | | | | | |||||
| * | | | | Fix tooltip wrapping issue in onboardin | fragosti | 2018-07-25 | 2 | -8/+16 |
| | | | | | |||||
| * | | | | Fix wrap button alignment issue | fragosti | 2018-07-25 | 7 | -224/+40 |
| | | | | | |||||
| * | | | | WIP for allowance toggle redesign working | fragosti | 2018-07-21 | 4 | -16/+118 |
| | | | | | |||||
| * | | | | Show token name dynamically in tooltip | fragosti | 2018-07-21 | 4 | -13/+19 |
| | | | | | |||||
| * | | | | Implement tooltips | fragosti | 2018-07-21 | 2 | -8/+56 |
| | | | | | |||||
| * | | | | Add loading state | fragosti | 2018-07-21 | 3 | -3/+4 |
| | | | | | |||||
| * | | | | Have basic lock and check working in walelt | fragosti | 2018-07-20 | 4 | -13/+93 |
| | | | | | |||||
| | | * | | Added fix to CHANGELOG | Olaf Tomalka | 2018-07-27 | 1 | -0/+4 |
| | | | | | |||||
| | | * | | Fixed the relative resolver not checking if the file can be read in the | Olaf Tomalka | 2018-07-25 | 1 | -1/+1 |
| | |/ / | | | | | | | | | | | | | first place | ||||
| | | * | Add discharge config and deploy | fragosti | 2018-08-08 | 4 | -14/+180 |
| | | | | |||||
| | | * | Add static site build | fragosti | 2018-08-08 | 3 | -4/+3 |
| | | | | |||||
| | | * | Add markdown section | fragosti | 2018-08-08 | 3 | -3/+188 |
| | | | | |||||
| | | * | Refactor using some utility methods | fragosti | 2018-08-03 | 6 | -109/+135 |
| | | | | |||||
| | | * | Add errors and headers | fragosti | 2018-08-03 | 2 | -0/+50 |
| | | | | |||||
| | | * | Limit error codes with ranges | fragosti | 2018-08-03 | 1 | -2/+2 |
| | | | | |||||
| | | * | Create asset_pairs SRA endpoint (and establish conventions) | fragosti | 2018-08-03 | 4 | -172/+81 |
| | | | | |||||
| | | * | Enforce stronger naming convention for json schema ids | fragosti | 2018-08-03 | 25 | -107/+107 |
| | | | | |||||
| | | * | All schema tests padding | fragosti | 2018-08-02 | 1 | -6/+17 |
| | | | | |||||
| | | * | update orders channel subscribe schema | fragosti | 2018-08-02 | 2 | -76/+14 |
| | | | | |||||
| | | * | Update order book schema test | fragosti | 2018-08-02 | 1 | -18/+43 |
| | | | | |||||
| | | * | Add relayerApiOrdersResponseTest | fragosti | 2018-08-02 | 1 | -0/+33 |
| | | | | |||||
| | | * | Add tests for asset pair endpoint | fragosti | 2018-08-02 | 2 | -85/+111 |
| | | | | |||||
| | | * | Group all standard relayer api tests together | fragosti | 2018-08-01 | 1 | -405/+406 |
| | | | | |||||
| | | * | Add test for relayerApiOrderSchema | fragosti | 2018-08-01 | 4 | -3/+20 |
| | | | | |||||
| | | * | Add paginated collection test case | fragosti | 2018-08-01 | 3 | -5/+33 |
| | | | | |||||
| | | * | Get schema tests running (not crashiing) | fragosti | 2018-08-01 | 6 | -164/+125 |
| | | | | |||||
| | | * | Update schemas export | fragosti | 2018-07-31 | 1 | -23/+17 |
| | | | | |||||
| | | * | Update json-schemas for SRA v1 | fragosti | 2018-07-31 | 18 | -118/+160 |
| | | | | |||||
| | | * | Add scripts | fragosti | 2018-07-28 | 2 | -6/+4 |
| | | | | |||||
| | | * | Add to README | fragosti | 2018-07-27 | 1 | -1/+23 |
| | | | | |||||
| | | * | Create API development environment and json distribution | fragosti | 2018-07-27 | 3 | -25/+459 |
| | | | | |||||
| | | * | Rename to sra-api | fragosti | 2018-07-27 | 9 | -7/+8 |
| | | | | |||||
| | | * | Add typescript typings for Open API spec | fragosti | 2018-07-27 | 3 | -1/+19 |
| | | | | |||||
| | | * | Reset CHANGELOG | fragosti | 2018-07-27 | 2 | -187/+3 |
| | | | | |||||
| | | * | Add basic smoke test | fragosti | 2018-07-27 | 8 | -78/+201 |
| | | | | |||||
| | | * | Initial commit | fragosti | 2018-07-27 | 8 | -0/+315 |
| |_|/ |/| | | |||||
* | | | Publishcontracts@2.1.39@0xproject/website@0.0.43@0xproject/testnet-faucets@1.0.40@0xproject/react-docs-example@0.0.19@0xproject/metacoin@0.0.14@0xproject/abi-gen@1.0.4 | Fabio Berger | 2018-07-26 | 27 | -151/+151 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.2 - @0xproject/abi-gen@1.0.4 - @0xproject/assert@1.0.4 - @0xproject/base-contract@1.0.4 - @0xproject/connect@1.0.4 - @0xproject/contract-wrappers@1.0.1-rc.2 - contracts@2.1.39 - @0xproject/dev-utils@1.0.3 - @0xproject/fill-scenarios@1.0.1-rc.2 - @0xproject/json-schemas@1.0.1-rc.3 - @0xproject/metacoin@0.0.14 - @0xproject/migrations@1.0.3 - @0xproject/order-utils@1.0.1-rc.2 - @0xproject/order-watcher@1.0.1-rc.2 - @0xproject/react-docs@1.0.4 - @0xproject/react-docs-example@0.0.19 - @0xproject/react-shared@1.0.5 - @0xproject/sol-compiler@1.0.4 - @0xproject/sol-cov@1.0.3 - @0xproject/sol-resolver@1.0.4 - @0xproject/sra-report@1.0.4 - @0xproject/subproviders@1.0.4 - @0xproject/testnet-faucets@1.0.40 - @0xproject/types@1.0.1-rc.3 - @0xproject/utils@1.0.4 - @0xproject/web3-wrapper@1.1.2 - @0xproject/website@0.0.43 | ||||
* | | | Updated CHANGELOGS | Fabio Berger | 2018-07-26 | 36 | -10/+184 |
| | | | |||||
* | | | Update yarn.lock | Fabio Berger | 2018-07-26 | 1 | -0/+67 |
| | | | |||||
* | | | Point to actual current version | Fabio Berger | 2018-07-26 | 11 | -22/+22 |
| | | | |||||
* | | | Add changelog entries for other RCs that did publish | Fabio Berger | 2018-07-26 | 2 | -0/+16 |
| | | | |||||
* | | | Fix changelogs and package versions for ones that weren't published | Fabio Berger | 2018-07-26 | 16 | -21/+13 |
| | | | |||||
* | | | Fix circle.yml | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Publishcontracts@2.1.38@0xproject/website@0.0.42@0xproject/testnet-faucets@1.0.39@0xproject/sol-compiler@1.0.3@0xproject/react-docs-example@0.0.18@0xproject/monorepo-scripts@1.0.4@0xproject/metacoin@0.0.13@0xproject/abi-gen@1.0.3 | Fabio Berger | 2018-07-26 | 31 | -252/+252 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.2 - @0xproject/abi-gen@1.0.3 - @0xproject/assert@1.0.3 - @0xproject/base-contract@1.0.3 - @0xproject/connect@1.0.3 - @0xproject/contract-wrappers@1.0.1-rc.2 - contracts@2.1.38 - @0xproject/dev-utils@1.0.3 - ethereum-types@1.0.3 - @0xproject/fill-scenarios@1.0.1-rc.2 - @0xproject/json-schemas@1.0.1-rc.2 - @0xproject/metacoin@0.0.13 - @0xproject/migrations@1.0.3 - @0xproject/monorepo-scripts@1.0.4 - @0xproject/order-utils@1.0.1-rc.2 - @0xproject/order-watcher@1.0.1-rc.2 - @0xproject/react-docs@1.0.3 - @0xproject/react-docs-example@0.0.18 - @0xproject/react-shared@1.0.4 - @0xproject/sol-compiler@1.0.3 - @0xproject/sol-cov@1.0.3 - @0xproject/sol-resolver@1.0.3 - @0xproject/sra-report@1.0.3 - @0xproject/subproviders@1.0.3 - @0xproject/testnet-faucets@1.0.39 - @0xproject/tslint-config@1.0.4 - @0xproject/types@1.0.1-rc.2 - @0xproject/typescript-typings@1.0.3 - @0xproject/utils@1.0.3 - @0xproject/web3-wrapper@1.1.1 - @0xproject/website@0.0.42 | ||||
* | | | Updated CHANGELOGS | Fabio Berger | 2018-07-26 | 52 | -7/+289 |
| | | | |||||
* | | | Still test unrunnable packages for compilation issues | Fabio Berger | 2018-07-26 | 1 | -8/+8 |
| | | | |||||
* | | | Add changelog entries for next RC publish | Fabio Berger | 2018-07-26 | 7 | -0/+56 |
| | | | |||||
* | | | Expose lerna dep | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Split running packages that cannot be run in a node.js script | Fabio Berger | 2018-07-26 | 1 | -1/+9 |
| | | | |||||
* | | | Fix accidental import from test folder | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Re-enable deleted the dir after test runs | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Change test:installation so it also causes run-time errors to appear | Fabio Berger | 2018-07-26 | 1 | -3/+10 |
| | | | |||||
* | | | Fix lint issue | Fabio Berger | 2018-07-26 | 1 | -2/+1 |
| | | | |||||
* | | | Always append monorepo root path so script can be called from anywhere | Fabio Berger | 2018-07-26 | 1 | -3/+5 |
| | | | |||||
* | | | Delete any remenants of test-env dir before creating a new one | Fabio Berger | 2018-07-26 | 1 | -0/+1 |
| | | | |||||
* | | | Print version that will be tested | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Add ending slash | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Add support for testing installations post-publish as well | Fabio Berger | 2018-07-26 | 2 | -2/+5 |
| | | | |||||
* | | | Fix asset path | Fabio Berger | 2018-07-26 | 1 | -2/+2 |
| | | | |||||
* | | | Publishcontracts@2.1.37@0xproject/website@0.0.41@0xproject/testnet-faucets@1.0.38@0xproject/react-docs-example@0.0.17@0xproject/monorepo-scripts@1.0.3@0xproject/metacoin@0.0.12@0xproject/abi-gen@1.0.2 | Fabio Berger | 2018-07-26 | 31 | -261/+257 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - 0x.js@1.0.1-rc.1 - @0xproject/abi-gen@1.0.2 - @0xproject/assert@1.0.2 - @0xproject/base-contract@1.0.2 - @0xproject/connect@1.0.2 - @0xproject/contract-wrappers@1.0.1-rc.1 - contracts@2.1.37 - @0xproject/dev-utils@1.0.2 - ethereum-types@1.0.2 - @0xproject/fill-scenarios@1.0.1-rc.1 - @0xproject/json-schemas@1.0.1-rc.1 - @0xproject/metacoin@0.0.12 - @0xproject/migrations@1.0.2 - @0xproject/monorepo-scripts@1.0.3 - @0xproject/order-utils@1.0.1-rc.1 - @0xproject/order-watcher@1.0.1-rc.1 - @0xproject/react-docs@1.0.2 - @0xproject/react-docs-example@0.0.17 - @0xproject/react-shared@1.0.3 - @0xproject/sol-compiler@1.0.2 - @0xproject/sol-cov@1.0.2 - @0xproject/sol-resolver@1.0.2 - @0xproject/sra-report@1.0.2 - @0xproject/subproviders@1.0.2 - @0xproject/testnet-faucets@1.0.38 - @0xproject/tslint-config@1.0.3 - @0xproject/types@1.0.1-rc.1 - @0xproject/typescript-typings@1.0.2 - @0xproject/utils@1.0.2 - @0xproject/web3-wrapper@1.1.0 - @0xproject/website@0.0.41 | ||||
* | | | Updated CHANGELOGS | Fabio Berger | 2018-07-26 | 52 | -8/+299 |
| | | | |||||
* | | | Fix linter | Fabio Berger | 2018-07-26 | 2 | -3/+0 |
| | | | |||||
* | | | Revert to using execAsync | Fabio Berger | 2018-07-26 | 1 | -10/+2 |
| | | | |||||
* | | | update yarn.lock | Fabio Berger | 2018-07-26 | 1 | -7/+0 |
| | | | |||||
* | | | Revert to publishing ethereum-types | Fabio Berger | 2018-07-26 | 18 | -18/+17 |
| | | | |||||
* | | | Fix marshaller import | Fabio Berger | 2018-07-26 | 1 | -1/+1 |
| | | | |||||
* | | | Update yarn.lock | Fabio Berger | 2018-07-26 | 1 | -0/+7 |
| | | | |||||
* | | | Temporarily have all packages depend on an older, published version of ↵ | Fabio Berger | 2018-07-26 | 17 | -17/+17 |
| | | | | | | | | | | | | ethereum-types since we cannot publish a new one |