aboutsummaryrefslogtreecommitdiffstats
path: root/test/0x.js.ts
diff options
context:
space:
mode:
Diffstat (limited to 'test/0x.js.ts')
-rw-r--r--test/0x.js.ts71
1 files changed, 67 insertions, 4 deletions
diff --git a/test/0x.js.ts b/test/0x.js.ts
index 65475bf32..d59df8894 100644
--- a/test/0x.js.ts
+++ b/test/0x.js.ts
@@ -3,10 +3,73 @@ import {expect} from 'chai';
import 'mocha';
describe('ZeroEx library', () => {
- describe('#verifySignature', () => {
- it('should return undefined', () => {
- const zeroEx = new ZeroEx();
- expect(zeroEx.verifySignature()).to.be.undefined;
+ describe('#isValidSignature', () => {
+ // This test data was borrowed from the JSON RPC documentation
+ // Source: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign
+ const data = '0xdeadbeaf';
+ const signature = {
+ v: 27,
+ r: '0xa3f20717a250c2b0b729b7e5becbff67fdaef7e0699da4de7ca5895b02a170a1',
+ s: '0x2d887fd3b17bfdce3481f10bea41f45ba9f709d39ce8325427b57afcfc994cee',
+ };
+ const address = '0x9b2055d370f73ec7d8a03e965129118dc8f5bf83';
+ describe('should return false for malformed signature', () => {
+ it('malformed v', () => {
+ const malformedSignature = {
+ v: 34,
+ r: signature.r,
+ s: signature.s,
+ };
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ expect(isValid).to.be.false;
+ });
+ it('r lacks 0x prefix', () => {
+ const malformedR = signature.r.replace('0x', '');
+ const malformedSignature = {
+ v: signature.v,
+ r: malformedR,
+ s: signature.s,
+ };
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ expect(isValid).to.be.false;
+ });
+ it('r is too short', () => {
+ const malformedR = signature.r.substr(10);
+ const malformedSignature = {
+ v: signature.v,
+ r: malformedR,
+ s: signature.s,
+ };
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ expect(isValid).to.be.false;
+ });
+ it('s is not hex', () => {
+ const malformedS = signature.s.replace('0', 'z');
+ const malformedSignature = {
+ v: signature.v,
+ r: signature.r,
+ s: malformedS,
+ };
+ const isValid = ZeroEx.isValidSignature(data, malformedSignature, address);
+ expect(isValid).to.be.false;
+ });
+ });
+ it('should return false if the data doesn\'t pertain to the signature & address', () => {
+ const isValid = ZeroEx.isValidSignature('wrong data', signature, address);
+ expect(isValid).to.be.false;
+ });
+ it('should return false if the address doesn\'t pertain to the signature & data', () => {
+ const isValid = ZeroEx.isValidSignature(data, signature, '0xIamWrong');
+ expect(isValid).to.be.false;
+ });
+ it('should return false if the signature doesn\'t pertain to the data & address', () => {
+ const wrongSignature = Object.assign({}, signature, {v: 28});
+ const isValid = ZeroEx.isValidSignature(data, wrongSignature, address);
+ expect(isValid).to.be.false;
+ });
+ it('should return true if the signature does pertain to the data & address', () => {
+ const isValid = ZeroEx.isValidSignature(data, signature, address);
+ expect(isValid).to.be.true;
});
});
});