aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/0x.js.ts6
-rw-r--r--src/contract_wrappers/exchange_wrapper.ts3
-rw-r--r--src/web3_wrapper.ts5
3 files changed, 10 insertions, 4 deletions
diff --git a/src/0x.js.ts b/src/0x.js.ts
index 0e9d71586..967c81ed8 100644
--- a/src/0x.js.ts
+++ b/src/0x.js.ts
@@ -130,9 +130,9 @@ export class ZeroEx {
/**
* Get the default account set for sending transactions.
*/
- public async getTransactionSenderAccountAsync(): Promise<string> {
- const senderAccount = await this.web3Wrapper.getSenderAddressOrThrowAsync();
- return senderAccount;
+ public async getTransactionSenderAccountIfExistsAsync(): Promise<string|undefined> {
+ const senderAccountIfExists = await this.web3Wrapper.getSenderAddressIfExistsAsync();
+ return senderAccountIfExists;
}
/**
* Computes the orderHash given the order parameters and returns it as a hex encoded string.
diff --git a/src/contract_wrappers/exchange_wrapper.ts b/src/contract_wrappers/exchange_wrapper.ts
index 2894c5a9f..f32cb88a6 100644
--- a/src/contract_wrappers/exchange_wrapper.ts
+++ b/src/contract_wrappers/exchange_wrapper.ts
@@ -180,6 +180,9 @@ export class ExchangeWrapper extends ContractWrapper {
if (fillAmount.greaterThan(takerBalance)) {
throw new Error(FillOrderValidationErrs.NOT_ENOUGH_TAKER_BALANCE);
}
+ if (fillAmount.greaterThan(takerAllowance)) {
+ throw new Error(FillOrderValidationErrs.NOT_ENOUGH_TAKER_ALLOWANCE);
+ }
}
private throwErrorLogsAsErrors(logs: ContractEvent[]): void {
const errEvent = _.find(logs, {event: 'LogError'});
diff --git a/src/web3_wrapper.ts b/src/web3_wrapper.ts
index c1263222a..49bd8b67d 100644
--- a/src/web3_wrapper.ts
+++ b/src/web3_wrapper.ts
@@ -17,6 +17,9 @@ export class Web3Wrapper {
public isAddress(address: string): boolean {
return this.web3.isAddress(address);
}
+ public getDefaultAccount(): string {
+ return this.web3.eth.defaultAccount;
+ }
public setDefaultAccount(address: string): void {
this.web3.eth.defaultAccount = address;
}
@@ -66,7 +69,7 @@ export class Web3Wrapper {
const {timestamp} = await promisify(this.web3.eth.getBlock)(blockHash);
return timestamp;
}
- private async getSenderAddressIfExistsAsync(): Promise<string|undefined> {
+ public async getSenderAddressIfExistsAsync(): Promise<string|undefined> {
const defaultAccount = this.web3.eth.defaultAccount;
if (!_.isUndefined(defaultAccount)) {
return defaultAccount;