aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
Diffstat (limited to 'packages')
-rw-r--r--packages/forwarder-helper/src/forwarder_helper_impl.ts2
1 files changed, 2 insertions, 0 deletions
diff --git a/packages/forwarder-helper/src/forwarder_helper_impl.ts b/packages/forwarder-helper/src/forwarder_helper_impl.ts
index 39e84b477..43b2962da 100644
--- a/packages/forwarder-helper/src/forwarder_helper_impl.ts
+++ b/packages/forwarder-helper/src/forwarder_helper_impl.ts
@@ -56,6 +56,7 @@ export class ForwarderHelperImpl implements ForwarderHelper {
orders,
remainingFillableMakerAssetAmounts,
);
+ // TODO: provide a feeRate to the sorting function to more accurately sort based on the current market for ZRX tokens
const sortedOrderWithAmounts = sortingUtils.sortOrdersByFeeAdjustedRate(orderWithAmounts);
const unbundledSortedOrderWithAmounts = ForwarderHelperImpl._unbundleSignedOrderWithAmounts(
sortedOrderWithAmounts,
@@ -108,6 +109,7 @@ export class ForwarderHelperImpl implements ForwarderHelper {
throw new Error(ForwarderHelperError.InsufficientZrxLiquidity);
}
// TODO: calculate min and max eth usage
+ // TODO: optimize orders call data
return {
makerAssetFillAmount,
orders: resultOrders,