diff options
| -rw-r--r-- | packages/react-docs/package.json | 2 | ||||
| -rw-r--r-- | packages/react-shared/package.json | 2 | ||||
| -rw-r--r-- | packages/sol-cov/package.json | 2 | ||||
| -rw-r--r-- | packages/subproviders/package.json | 2 | ||||
| -rw-r--r-- | packages/types/CHANGELOG.json | 8 | ||||
| -rw-r--r-- | packages/types/src/index.ts | 6 | ||||
| -rw-r--r-- | packages/typescript-typings/package.json | 5 | ||||
| -rw-r--r-- | packages/typescript-typings/types/eth-lightwallet/index.d.ts | 8 | ||||
| -rw-r--r-- | packages/utils/README.md | 15 |
9 files changed, 37 insertions, 13 deletions
diff --git a/packages/react-docs/package.json b/packages/react-docs/package.json index c3853e6ba..820e2123b 100644 --- a/packages/react-docs/package.json +++ b/packages/react-docs/package.json @@ -41,7 +41,7 @@ "@types/lodash": "4.14.104", "@types/material-ui": "0.18.0", "@types/node": "^8.0.53", - "@types/react": "16.3.13", + "@types/react": "*", "@types/react-dom": "^16.0.3", "@types/react-scroll": "0.0.31", "basscss": "^8.0.3", diff --git a/packages/react-shared/package.json b/packages/react-shared/package.json index 008972da9..f406830f9 100644 --- a/packages/react-shared/package.json +++ b/packages/react-shared/package.json @@ -38,7 +38,7 @@ "@types/lodash": "4.14.104", "@types/material-ui": "0.18.0", "@types/node": "^8.0.53", - "@types/react": "16.3.13", + "@types/react": "*", "@types/react-dom": "^16.0.3", "@types/react-scroll": "0.0.31", "@types/is-mobile": "0.3.0", diff --git a/packages/sol-cov/package.json b/packages/sol-cov/package.json index 86808bfc1..9c23334a9 100644 --- a/packages/sol-cov/package.json +++ b/packages/sol-cov/package.json @@ -56,6 +56,7 @@ "@0xproject/utils": "^1.0.0", "@0xproject/web3-wrapper": "^1.0.0", "@0xproject/dev-utils": "^1.0.0", + "@types/solidity-parser-antlr": "^0.2.1", "ethereum-types": "^1.0.0", "ethereumjs-util": "^5.1.1", "glob": "^7.1.2", @@ -73,7 +74,6 @@ "@types/istanbul": "^0.4.30", "@types/loglevel": "^1.5.3", "@types/mkdirp": "^0.5.1", - "@types/solidity-parser-antlr": "^0.2.1", "@types/mocha": "^2.2.42", "@types/node": "^8.0.53", "@types/rimraf": "^2.0.2", diff --git a/packages/subproviders/package.json b/packages/subproviders/package.json index 1aa5514a7..4b6a87fcd 100644 --- a/packages/subproviders/package.json +++ b/packages/subproviders/package.json @@ -47,6 +47,7 @@ "@0xproject/utils": "^1.0.0", "@ledgerhq/hw-app-eth": "^4.3.0", "@ledgerhq/hw-transport-u2f": "^4.3.0", + "@types/hdkey": "^0.7.0", "ethereum-types": "^1.0.0", "bip39": "^2.5.0", "bn.js": "^4.11.8", @@ -66,7 +67,6 @@ "@0xproject/utils": "^1.0.0", "@types/bip39": "^2.4.0", "@types/bn.js": "^4.11.0", - "@types/hdkey": "^0.7.0", "@types/ethereumjs-tx": "^1.0.0", "@types/lodash": "4.14.104", "@types/mocha": "^2.2.42", diff --git a/packages/types/CHANGELOG.json b/packages/types/CHANGELOG.json index 1338fd9a8..002c281bf 100644 --- a/packages/types/CHANGELOG.json +++ b/packages/types/CHANGELOG.json @@ -1,5 +1,13 @@ [ { + "version": "1.0.0-rc.2", + "changes": [ + { + "note": "Remove `ECSignatureBuffer`" + } + ] + }, + { "timestamp": 1532357734, "version": "1.0.0", "changes": [ diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 555cd7dec..90291a172 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -48,12 +48,6 @@ export interface ECSignature { s: string; } -export interface ECSignatureBuffer { - v: number; - r: Buffer; - s: Buffer; -} - /** * Validator signature components */ diff --git a/packages/typescript-typings/package.json b/packages/typescript-typings/package.json index 8b7a640c9..ec64547e4 100644 --- a/packages/typescript-typings/package.json +++ b/packages/typescript-typings/package.json @@ -26,7 +26,10 @@ "homepage": "https://github.com/0xProject/0x-monorepo/packages/typescript-typings#readme", "dependencies": { "ethereum-types": "^1.0.0", - "bignumber.js": "~4.1.0" + "bignumber.js": "~4.1.0", + "@types/bn.js": "^4.11.0", + "@types/react": "16.3.13", + "popper.js": "1.14.3" }, "devDependencies": { "@0xproject/monorepo-scripts": "^1.0.0", diff --git a/packages/typescript-typings/types/eth-lightwallet/index.d.ts b/packages/typescript-typings/types/eth-lightwallet/index.d.ts index 58096e9f4..93daa5041 100644 --- a/packages/typescript-typings/types/eth-lightwallet/index.d.ts +++ b/packages/typescript-typings/types/eth-lightwallet/index.d.ts @@ -1,7 +1,11 @@ // eth-lightwallet declarations -declare module 'eth-lightwallet' { - import { ECSignatureBuffer } from '@0xproject/types'; +interface ECSignatureBuffer { + v: number; + r: Buffer; + s: Buffer; +} +declare module 'eth-lightwallet' { // tslint:disable-next-line:class-name export class signing { public static signTx( diff --git a/packages/utils/README.md b/packages/utils/README.md index c637c9af5..c9a2f5846 100644 --- a/packages/utils/README.md +++ b/packages/utils/README.md @@ -22,6 +22,21 @@ If your project is in [TypeScript](https://www.typescriptlang.org/), add the fol import { addressUtils, bigNumberConfigs, classUtils, intervalUtils, promisify } from '@0xproject/utils'; ``` +## Troubleshooting + +If you are still seeing TS type errors complaining about missing DOM types such as `Response`: + +``` +error TS2304: Cannot find name 'Response'. +``` + +Then you need to explicitly add the `dom` lib to your compiler options in `tsconfig.json`. The `dom` library is included by default, but customizing the `lib` option can cause it to be dropped. + +``` +"compilerOptions": { + "lib": [..., "dom"], +``` + ## Contributing We welcome improvements and fixes from the wider community! To report bugs within this package, please create an issue in this repository. |