diff options
-rw-r--r-- | src/0x.js.ts | 8 | ||||
-rw-r--r-- | test/0x.js_test.ts | 6 |
2 files changed, 7 insertions, 7 deletions
diff --git a/src/0x.js.ts b/src/0x.js.ts index 1ebafc604..de082146f 100644 --- a/src/0x.js.ts +++ b/src/0x.js.ts @@ -101,11 +101,11 @@ export class ZeroEx { const isValid = /^0x[0-9A-F]{64}$/i.test(orderHash); return isValid; } - /* + /** * A unit amount is defined as the amount of a token above the specified decimal places (integer part). * E.g: If a currency has 18 decimal places, 1e18 or one quintillion of the currency is equivalent * to 1 unit. - */ + */ public static toUnitAmount(amount: BigNumber.BigNumber, decimals: number): BigNumber.BigNumber { assert.isBigNumber('amount', amount); assert.isNumber('decimals', decimals); @@ -114,11 +114,11 @@ export class ZeroEx { const unit = amount.div(aUnit); return unit; } - /* + /** * A baseUnit is defined as the smallest denomination of a token. An amount expressed in baseUnits * is the amount expressed in the smallest denomination. * E.g: 1 unit of a token with 18 decimal places is expressed in baseUnits as 1000000000000000000 - */ + */ public static toBaseUnitAmount(amount: BigNumber.BigNumber, decimals: number): BigNumber.BigNumber { assert.isBigNumber('amount', amount); assert.isNumber('decimals', decimals); diff --git a/test/0x.js_test.ts b/test/0x.js_test.ts index 7106b6a7a..289c823af 100644 --- a/test/0x.js_test.ts +++ b/test/0x.js_test.ts @@ -12,7 +12,7 @@ const expect = chai.expect; describe('ZeroEx library', () => { describe('#getOrderHash', () => { - const ORDER_HASH = '0x103a5e97dab5dbeb8f385636f86a7d1e458a7ccbe1bd194727f0b2f85ab116c7'; + const expectedOrderHash = '0x103a5e97dab5dbeb8f385636f86a7d1e458a7ccbe1bd194727f0b2f85ab116c7'; it('defaults takerAddress to NULL address', () => { const orderHash = ZeroEx.getOrderHashHex( constants.NULL_ADDRESS, @@ -28,7 +28,7 @@ describe('ZeroEx library', () => { new BigNumber(0), new BigNumber(0), ); - expect(orderHash).to.be.equal(ORDER_HASH); + expect(orderHash).to.be.equal(expectedOrderHash); }); it('calculates the order hash', () => { const orderHash = ZeroEx.getOrderHashHex( @@ -45,7 +45,7 @@ describe('ZeroEx library', () => { new BigNumber(0), new BigNumber(0), ); - expect(orderHash).to.be.equal(ORDER_HASH); + expect(orderHash).to.be.equal(expectedOrderHash); }); }); describe('#isValidSignature', () => { |