aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorLeonid Logvinov <logvinov.leon@gmail.com>2017-06-06 22:57:13 +0800
committerLeonid Logvinov <logvinov.leon@gmail.com>2017-06-06 22:57:13 +0800
commitfa910bca0ebcc71e5fd7aa656972d77bec08c9e5 (patch)
treea61e05a0c580c32e222b5eca20b510945d99cf8a /test
parent5412e803159a1d944297ab1fe1a49896651cedd6 (diff)
downloaddexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar.gz
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar.bz2
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar.lz
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar.xz
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.tar.zst
dexon-sol-tools-fa910bca0ebcc71e5fd7aa656972d77bec08c9e5.zip
Add checks and tests for expired order and zero fill amount
Diffstat (limited to 'test')
-rw-r--r--test/exchange_wrapper_test.ts18
1 files changed, 17 insertions, 1 deletions
diff --git a/test/exchange_wrapper_test.ts b/test/exchange_wrapper_test.ts
index 48d10c1e4..b9400bf04 100644
--- a/test/exchange_wrapper_test.ts
+++ b/test/exchange_wrapper_test.ts
@@ -332,6 +332,7 @@ describe('ExchangeWrapper', () => {
const fillableAmount = new BigNumber(5);
let signedOrder: SignedOrder;
let orderHashHex: string;
+ const cancelAmount = new BigNumber(3);
before(async () => {
[coinbase, makerAddress, takerAddress] = userAddresses;
const [makerToken, takerToken] = tokenUtils.getNonProtocolTokens();
@@ -342,9 +343,24 @@ describe('ExchangeWrapper', () => {
);
orderHashHex = await zeroEx.getOrderHashHexAsync(signedOrder);
});
+ describe('failed cancels', () => {
+ it('should throw when cancel amount is zero', async () => {
+ const zeroCancelAmount = new BigNumber(0);
+ return expect(zeroEx.exchange.cancelOrderAsync(signedOrder, zeroCancelAmount))
+ .to.be.rejectedWith(ExchangeContractErrs.ORDER_CANCEL_AMOUNT_ZERO);
+ });
+ it('should throw when order is expired', async () => {
+ const expirationInPast = new BigNumber(42);
+ const expiredSignedOrder = await fillScenarios.createFillableSignedOrderAsync(
+ makerTokenAddress, takerTokenAddress, makerAddress, takerAddress, fillableAmount, expirationInPast,
+ );
+ orderHashHex = await zeroEx.getOrderHashHexAsync(expiredSignedOrder);
+ return expect(zeroEx.exchange.cancelOrderAsync(expiredSignedOrder, cancelAmount))
+ .to.be.rejectedWith(ExchangeContractErrs.ORDER_CANCEL_EXPIRED);
+ });
+ });
describe('successful cancels', () => {
it('should cancel an order', async () => {
- const cancelAmount = new BigNumber(5);
await zeroEx.exchange.cancelOrderAsync(signedOrder, cancelAmount);
const cancelledAmount = await zeroEx.exchange.getCanceledTakerAmountAsync(orderHashHex);
expect(cancelledAmount).to.be.bignumber.equal(cancelAmount);