diff options
author | Fabio Berger <me@fabioberger.com> | 2017-07-11 15:30:55 +0800 |
---|---|---|
committer | Fabio Berger <me@fabioberger.com> | 2017-07-11 15:30:55 +0800 |
commit | 56bedf724fb25f858b5aaefbb61562c4896defc1 (patch) | |
tree | 51a414c2280693b6ec36ec7109c3fd90d3c42082 /src/utils | |
parent | b98f3fc09485aaba56a2ce244dd2e27c59928cd8 (diff) | |
parent | 054843d599129e3dbb2eb36a402eff66064ed78f (diff) | |
download | dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar.gz dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar.bz2 dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar.lz dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar.xz dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.tar.zst dexon-sol-tools-56bedf724fb25f858b5aaefbb61562c4896defc1.zip |
Merge branch 'new-contracts'
* new-contracts: (29 commits)
Fix a typo
Fix a typo in comment
Rename shouldCheckTransfer to shouldThrowOnInsufficientBalanceOrAllowance
Simplify BigNumber hack
use yarn on CI
Upgrade to a new node version
Make CONTRACTS_COMMIT_HASH a string
Use never testrpc snapshot
Migrate the rest of the artifacts
Change arguments order at isRoundingError
Migrate events
Migrate constructor arguments
Migrate fillOrKillOrder
Migrate ZRX_TOKEN_AMOUNT
Migrate getUnavailableTakerTokenAmount
Migrate PROXY_CONTRACT
Migrate batchFillOrKillOrders
Migrate batchFillOrders
Migrate fillOrder
Migrate fillOrdersUpTo and remove min
...
Diffstat (limited to 'src/utils')
-rw-r--r-- | src/utils/event_utils.ts | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/utils/event_utils.ts b/src/utils/event_utils.ts index 07418cbc4..e8f30e1a8 100644 --- a/src/utils/event_utils.ts +++ b/src/utils/event_utils.ts @@ -1,5 +1,4 @@ import * as _ from 'lodash'; -import * as Web3 from 'web3'; import {EventCallback, ContractEventArg, ContractEvent, ContractEventObj, ContractEventEmitter} from '../types'; import * as BigNumber from 'bignumber.js'; import promisify = require('es6-promisify'); @@ -29,10 +28,8 @@ export const eventUtils = { const wrapIfBigNumber = (value: ContractEventArg): ContractEventArg => { // HACK: The old version of BigNumber used by Web3@0.19.0 does not support the `isBigNumber` // and checking for a BigNumber instance using `instanceof` does not work either. We therefore - // compare the constructor functions of the possible BigNumber instance and the BigNumber used by - // Web3. - const web3BigNumber = (Web3.prototype as any).BigNumber; - const isWeb3BigNumber = web3BigNumber.toString() === value.constructor.toString(); + // check if the value constructor is a bignumber constructor. + const isWeb3BigNumber = _.startsWith(value.constructor.toString(), 'function BigNumber('); return isWeb3BigNumber ? new BigNumber(value) : value; }; event.args = _.mapValues(event.args, wrapIfBigNumber); |