aboutsummaryrefslogtreecommitdiffstats
path: root/src/ts
diff options
context:
space:
mode:
authorLeonid Logvinov <logvinov.leon@gmail.com>2017-05-26 18:17:31 +0800
committerLeonid Logvinov <logvinov.leon@gmail.com>2017-05-26 18:17:31 +0800
commit3195741ebcfc95f4622aebcdc23fc5b8630efe39 (patch)
tree2d90199df90974be6a596eace3503281889c29f4 /src/ts
parent183e8a71389737dc1c535b3625c949307607b9b9 (diff)
downloaddexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.gz
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.bz2
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.lz
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.xz
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.zst
dexon-sol-tools-3195741ebcfc95f4622aebcdc23fc5b8630efe39.zip
Address feedback
Diffstat (limited to 'src/ts')
-rw-r--r--src/ts/0x.js.ts5
-rw-r--r--src/ts/globals.d.ts2
-rw-r--r--src/ts/types.ts3
3 files changed, 4 insertions, 6 deletions
diff --git a/src/ts/0x.js.ts b/src/ts/0x.js.ts
index 893d95de6..ba922d3db 100644
--- a/src/ts/0x.js.ts
+++ b/src/ts/0x.js.ts
@@ -132,8 +132,9 @@ export class ZeroEx {
/**
* Converts BigNumber instance to BN
- * We do it because ethABI accepts only BN's
- * We should be consistent about using BigNumbers in our codebase and not use BN anywhere else
+ * The only we convert to BN is to remain compatible with `ethABI. soliditySHA3 ` that
+ * expects values of Solidity type `uint` to be of type `BN`.
+ * We do not use BN anywhere else in the codebase.
*/
private static bigNumberToBN(value: BigNumber.BigNumber) {
return new BN(value.toString(), 10);
diff --git a/src/ts/globals.d.ts b/src/ts/globals.d.ts
index a50c635fb..99baf593f 100644
--- a/src/ts/globals.d.ts
+++ b/src/ts/globals.d.ts
@@ -26,5 +26,5 @@ declare module 'ethereumjs-util' {
}
declare module 'ethereumjs-abi' {
- const soliditySHA3: (argTypes: string[], args: any) => Buffer;
+ const soliditySHA3: (argTypes: string[], args: any[]) => Buffer;
}
diff --git a/src/ts/types.ts b/src/ts/types.ts
index c49ef2331..04902cca6 100644
--- a/src/ts/types.ts
+++ b/src/ts/types.ts
@@ -13,8 +13,5 @@ function strEnum(values: string[]): {[key: string]: string} {
export const SolidityTypes = strEnum([
'address',
'uint256',
- 'uint8',
- 'string',
- 'bool',
]);
export type SolidityTypes = keyof typeof SolidityTypes;