diff options
author | Brandon Millman <brandon@0xproject.com> | 2017-11-13 03:06:39 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-11-13 03:06:39 +0800 |
commit | 719c51f61a65e3e179ba2a78fa48105247ba2b41 (patch) | |
tree | 566c10ab457b45c5b1d535d78cece422ae24fdda /src/contract_wrappers/token_wrapper.ts | |
parent | 76b66872d8f797ee3b0efe0fa2ca914cf44ee46c (diff) | |
parent | dae5a063cf1568676485d4dc0a0d97f0e7aa5daa (diff) | |
download | dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar.gz dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar.bz2 dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar.lz dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar.xz dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.tar.zst dexon-sol-tools-719c51f61a65e3e179ba2a78fa48105247ba2b41.zip |
Merge pull request #209 from 0xProject/fixUnhandledPromiseBug
Fix unhandled promise rejection error on subscriptions
Diffstat (limited to 'src/contract_wrappers/token_wrapper.ts')
-rw-r--r-- | src/contract_wrappers/token_wrapper.ts | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/contract_wrappers/token_wrapper.ts b/src/contract_wrappers/token_wrapper.ts index 5d6d61cef..081113964 100644 --- a/src/contract_wrappers/token_wrapper.ts +++ b/src/contract_wrappers/token_wrapper.ts @@ -29,13 +29,11 @@ const ALLOWANCE_TO_ZERO_GAS_AMOUNT = 47275; export class TokenWrapper extends ContractWrapper { public UNLIMITED_ALLOWANCE_IN_BASE_UNITS = constants.UNLIMITED_ALLOWANCE_IN_BASE_UNITS; private _tokenContractsByAddress: {[address: string]: TokenContract}; - private _activeSubscriptions: string[]; private _tokenTransferProxyContractAddressFetcher: () => Promise<string>; constructor(web3Wrapper: Web3Wrapper, abiDecoder: AbiDecoder, tokenTransferProxyContractAddressFetcher: () => Promise<string>) { super(web3Wrapper, abiDecoder); this._tokenContractsByAddress = {}; - this._activeSubscriptions = []; this._tokenTransferProxyContractAddressFetcher = tokenTransferProxyContractAddressFetcher; } /** @@ -262,7 +260,6 @@ export class TokenWrapper extends ContractWrapper { const subscriptionToken = this._subscribe<ArgsType>( tokenAddress, eventName, indexFilterValues, artifacts.TokenArtifact.abi, callback, ); - this._activeSubscriptions.push(subscriptionToken); return subscriptionToken; } /** @@ -270,7 +267,6 @@ export class TokenWrapper extends ContractWrapper { * @param subscriptionToken Subscription token returned by `subscribe()` */ public unsubscribe(subscriptionToken: string): void { - _.pull(this._activeSubscriptions, subscriptionToken); this._unsubscribe(subscriptionToken); } /** @@ -294,13 +290,6 @@ export class TokenWrapper extends ContractWrapper { ); return logs; } - /** - * Cancels all existing subscriptions - */ - public unsubscribeAll(): void { - _.forEach(this._activeSubscriptions, this._unsubscribe.bind(this)); - this._activeSubscriptions = []; - } private _invalidateContractInstancesAsync(): void { this.unsubscribeAll(); this._tokenContractsByAddress = {}; |