aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-10-16 22:17:49 +0800
committerFabio Berger <me@fabioberger.com>2018-10-16 22:17:49 +0800
commit72f5719b3412da7840a7b85e4dce512ecbaece4d (patch)
tree055e1d305882dc8b2a490885f822087dbb908a7e /packages
parente62458705039f6a187ff23e4e4ee1737476eb431 (diff)
downloaddexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar.gz
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar.bz2
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar.lz
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar.xz
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.tar.zst
dexon-sol-tools-72f5719b3412da7840a7b85e4dce512ecbaece4d.zip
Added note about restriction on `testDirectory`
Diffstat (limited to 'packages')
-rw-r--r--packages/monorepo-scripts/src/test_installation.ts3
1 files changed, 3 insertions, 0 deletions
diff --git a/packages/monorepo-scripts/src/test_installation.ts b/packages/monorepo-scripts/src/test_installation.ts
index 9ef9e829b..a642498ac 100644
--- a/packages/monorepo-scripts/src/test_installation.ts
+++ b/packages/monorepo-scripts/src/test_installation.ts
@@ -104,6 +104,9 @@ async function testInstallPackageAsync(
const packageName = installablePackage.packageJson.name;
utils.log(`Testing ${packageName}@${lastChangelogVersion}`);
const packageDirName = path.join(...(packageName + '-test').split('/'));
+ // NOTE(fabio): The `testDirectory` needs to be somewhere **outside** the monorepo root directory.
+ // Otherwise, it will have access to the hoisted `node_modules` directory and the Typescript missing
+ // type errors will not be caught.
const testDirectory = path.join(monorepoRootPath, '..', '.installation-test', packageDirName);
await rimrafAsync(testDirectory);
await mkdirpAsync(testDirectory);