aboutsummaryrefslogtreecommitdiffstats
path: root/packages
diff options
context:
space:
mode:
authorFabio Berger <me@fabioberger.com>2018-07-02 16:49:41 +0800
committerFabio Berger <me@fabioberger.com>2018-07-02 16:49:41 +0800
commitcb6cace910b9639fc80b207b04dc8938831bae93 (patch)
treedf2a9311f65ba8141034a89b76ea841027352907 /packages
parent0326ddd79d2a97b5841f3e5dbfe6c3067e089bba (diff)
downloaddexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar.gz
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar.bz2
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar.lz
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar.xz
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.tar.zst
dexon-sol-tools-cb6cace910b9639fc80b207b04dc8938831bae93.zip
Fix bug where using nullAddress for order instead of actual taker address
Diffstat (limited to 'packages')
-rw-r--r--packages/contracts/src/utils/core_combinatorial_utils.ts14
1 files changed, 3 insertions, 11 deletions
diff --git a/packages/contracts/src/utils/core_combinatorial_utils.ts b/packages/contracts/src/utils/core_combinatorial_utils.ts
index aadf7a57c..3212eba04 100644
--- a/packages/contracts/src/utils/core_combinatorial_utils.ts
+++ b/packages/contracts/src/utils/core_combinatorial_utils.ts
@@ -783,25 +783,17 @@ export class CoreCombinatorialUtils {
case AllowanceAmountScenario.TooLow:
const tooLowAllowance = takerFee.minus(1);
- await this.assetWrapper.setProxyAllowanceAsync(
- signedOrder.takerAddress,
- this.zrxAssetData,
- tooLowAllowance,
- );
+ await this.assetWrapper.setProxyAllowanceAsync(this.takerAddress, this.zrxAssetData, tooLowAllowance);
break;
case AllowanceAmountScenario.Exact:
const exactAllowance = takerFee;
- await this.assetWrapper.setProxyAllowanceAsync(
- signedOrder.takerAddress,
- this.zrxAssetData,
- exactAllowance,
- );
+ await this.assetWrapper.setProxyAllowanceAsync(this.takerAddress, this.zrxAssetData, exactAllowance);
break;
case AllowanceAmountScenario.Unlimited:
await this.assetWrapper.setProxyAllowanceAsync(
- signedOrder.takerAddress,
+ this.takerAddress,
this.zrxAssetData,
constants.UNLIMITED_ALLOWANCE_IN_BASE_UNITS,
);