diff options
| author | Amir Bandeali <abandeali1@gmail.com> | 2018-09-03 01:39:22 +0800 |
|---|---|---|
| committer | Amir Bandeali <abandeali1@gmail.com> | 2018-09-04 22:57:47 +0800 |
| commit | e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a (patch) | |
| tree | 2dfdc19cd55109eab36a2d3a7e760bc886a2a2b3 /packages | |
| parent | f6b6619c08d5588ef5dfa653886f37c63018b477 (diff) | |
| download | dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar.gz dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar.bz2 dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar.lz dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar.xz dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.tar.zst dexon-sol-tools-e34b1f2f8b0aa32c95192c5c7fbbdecef2b3953a.zip | |
Remove TODOs that will not be addressed
Diffstat (limited to 'packages')
3 files changed, 2 insertions, 3 deletions
diff --git a/packages/contracts/src/2.0.0/extensions/Forwarder/MixinExchangeWrapper.sol b/packages/contracts/src/2.0.0/extensions/Forwarder/MixinExchangeWrapper.sol index 33326c2ab..fea9a53c2 100644 --- a/packages/contracts/src/2.0.0/extensions/Forwarder/MixinExchangeWrapper.sol +++ b/packages/contracts/src/2.0.0/extensions/Forwarder/MixinExchangeWrapper.sol @@ -60,7 +60,7 @@ contract MixinExchangeWrapper is // Call `fillOrder` and handle any exceptions gracefully assembly { let success := call( - gas, // forward all gas, TODO: look into gas consumption of assert/throw + gas, // forward all gas exchange, // call address of Exchange contract 0, // transfer 0 wei add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes) diff --git a/packages/contracts/src/2.0.0/protocol/Exchange/MixinWrapperFunctions.sol b/packages/contracts/src/2.0.0/protocol/Exchange/MixinWrapperFunctions.sol index fc3210d90..cddff0e5f 100644 --- a/packages/contracts/src/2.0.0/protocol/Exchange/MixinWrapperFunctions.sol +++ b/packages/contracts/src/2.0.0/protocol/Exchange/MixinWrapperFunctions.sol @@ -81,7 +81,7 @@ contract MixinWrapperFunctions is // Delegate to `fillOrder` and handle any exceptions gracefully assembly { let success := delegatecall( - gas, // forward all gas, TODO: look into gas consumption of assert/throw + gas, // forward all gas address, // call address of this contract add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes) mload(fillOrderCalldata), // length of input diff --git a/packages/contracts/src/2.0.0/protocol/Exchange/libs/LibMath.sol b/packages/contracts/src/2.0.0/protocol/Exchange/libs/LibMath.sol index d8fed176c..c0b85ea10 100644 --- a/packages/contracts/src/2.0.0/protocol/Exchange/libs/LibMath.sol +++ b/packages/contracts/src/2.0.0/protocol/Exchange/libs/LibMath.sol @@ -246,7 +246,6 @@ contract LibMath is numerator, denominator ); - // TODO: safeMod remainder = safeSub(denominator, remainder) % denominator; isError = safeMul(1000, remainder) >= safeMul(numerator, target); return isError; |